summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk/menu_gtk.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move chrome/browser/gtk/ to chrome/browser/ui/gtk/msw@chromium.org2011-01-141-840/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (moved *.cc using 'svn mv' to preserve history) (copied *.h using 'svn cp' to preserve history and stub out originals) Stubbed out original headers in chrome/browser/gtk/ Update header guards & copyright dates in chrome/browser/ui/gtk/ Update .gypi files Remove chrome/chrome_browser.gypi:4228 reference to nonexistant: ['include', '^browser/gtk/pk11_password_dialog.h'], Remove stray header guard in: chrome/browser/ui/gtk/bookmark_bar_instructions_gtk.cc Add #pragma once to the following files: chrome/browser/ui/gtk/instant_confirm_dialog_gtk.h chrome/browser/ui/gtk/infobar_arrow_model.h Ran the following to appease presubmit: 'svn pset svn:eol-style LF \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.cc \ chrome/browser/ui/gtk/gtk_custom_menu.cc \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/ui/gtk/gtk_custom_menu.h \ chrome/browser/ui/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/ui/gtk/chrome_gtk_frame.h \ chrome/browser/ui/gtk/chrome_gtk_frame.cc \ chrome/browser/ui/gtk/gtk_custom_menu_item.h \ chrome/browser/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/gtk/gtk_custom_menu.h \ chrome/browser/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/gtk/chrome_gtk_frame.h \ chrome/browser/gtk/gtk_custom_menu_item.h' BUG=69289 TEST=Compile&Trybots Review URL: http://codereview.chromium.org/6251001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71397 0039d316-1c4b-4281-b951-d872f2087c98
* Update menu icons for dynamic items when we update the label.atwilson@chromium.org2010-12-281-1/+11
| | | | | | | | | BUG=66508 TEST=enable background mode, see wrench menu badge toggle when extensions load Review URL: http://codereview.chromium.org/6014009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70228 0039d316-1c4b-4281-b951-d872f2087c98
* Change menus on OSX to update the icon dynamically.atwilson@chromium.org2010-12-151-2/+3
| | | | | | | | | | | | | | | | | Change MenuModel::IsLabelDynamicAt() to IsItemDynamicAt() to reflect its true purpose. Add SimpleMenuModel::GetIconForCommandId() to enable dynamic icons. Update OSX menu_controller code to update the icon for dynamic menu items when the menu is opened, to match the windows behavior. BUG=66508 TEST=MenuControllerTest.Dynamic Review URL: http://codereview.chromium.org/5697005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69234 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Stock menu icons update.sadrul@chromium.org2010-12-091-0/+21
| | | | | | | | | | | | | Show default stock icons for the bookmark bar context menus, and use gtk-save-as icon instead gtk-save for the 'Save .. As ...' items. Also, use IDC_ values instead of IDS_ values for the bookmark-bar context menus. BUG=65441 TEST=manual, see bug. Review URL: http://codereview.chromium.org/5659003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68690 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "Open frame in new xxx" context menu options.tfarina@chromium.org2010-12-031-1/+0
| | | | | | | | | BUG=33074 TEST=trybots Review URL: http://codereview.chromium.org/5523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68219 0039d316-1c4b-4281-b951-d872f2087c98
* Add ActivatedAtWithDisposition to MenuModel.estade@chromium.org2010-11-111-1/+11
| | | | | | | | | | | Also, use it in MenuGtk, and implement it in BackForwardMenuModel. BUG=38452 TEST=manual Review URL: http://codereview.chromium.org/4780001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65739 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-081-1/+1
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base/gtk_util.h by moving its methods tojhawkins@chromium.org2010-10-291-13/+10
| | | | | | | | | | | gfx/gtk_util.h BUG=none TEST=none Review URL: http://codereview.chromium.org/4150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Update how menu icons are assigned.estade@chromium.org2010-10-131-11/+22
| | | | | | | | | | | | | | | | | | Slightly change the architecture of how icons are assigned to menu items. Also, add stock icons for some additional menu items. And always show icons on overflow menus. BUG=59101 TEST=The major change here is architectural change, so there is little visible change in functionality. But if you right click on a link, it should now show an icon for the 'Open in new tab' menu. patch by sadrul@chromium.org original review: http://codereview.chromium.org/3714003/show Review URL: http://codereview.chromium.org/3816002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62461 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Allow showing icons in menus.erg@google.com2010-10-081-9/+158
| | | | | | | | | | | | | | | | This patch adds nice little icons in the menus (both for context and window menus). At this moment, only standard stock icons are used. It will be possible to add new stock icons of Chrome's own for the items that currently don't have any corresponding GTK+ stock icons. BUG=None TEST=Open the wrench menu, or context menu for the tab content/tab title etc., and you should see nice little icons on the left for many items. Review URL: http://codereview.chromium.org/3619010 Patch from Sadrul Chowdhury <sadrul@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61983 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: The wrench menu should remain open after clicking +/-.erg@google.com2010-09-201-50/+70
| | | | | | | | | | | | | This changes the model so there's a property about whether a button should dismiss the menu, modifies the GtkCustomMenu[Item] implementation to obey it, and modifies the BrowserToolbar to update the menu on zoom change. BUG=48240 TEST=matches windows behaviour Review URL: http://codereview.chromium.org/3391009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59963 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Cleanup MenuGtk to use signals thunk macros.erg@google.com2010-09-161-21/+17
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3426006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59708 0039d316-1c4b-4281-b951-d872f2087c98
* The "Update Chrome" menu item should appear in addition to the About menu.erg@google.com2010-08-311-5/+19
| | | | | | | | | | | It should not replace it. This patch modifications to the GTK and Cocoa ports to make the update chrome item appear when an update is available. On win/chromeos, the menu item is always there but disabled, since I'm having some problems figuring out the views custom menu implementation. BUG=46221 TEST=The upgrade item should now appear under instead of replacing the about command. Review URL: http://codereview.chromium.org/3143046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58040 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for status icon context menus for gtk.atwilson@chromium.org2010-08-241-0/+6
| | | | | | | | | | | Rename ResetContextIcon()->UpdatePlatformContextIcon(). BUG=37375 TEST=CreateIcon updated Review URL: http://codereview.chromium.org/3127028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57142 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 3)thestig@chromium.org2010-07-311-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3054029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54436 0039d316-1c4b-4281-b951-d872f2087c98
* The button menu items on GTK menus honor the enabled state of the command.sanjeevr@chromium.org2010-07-291-19/+20
| | | | | | | | | BUG=None TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise. Review URL: http://codereview.chromium.org/3032038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54162 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Grouped buttons should be equal sizes in new wrench menu.erg@chromium.org2010-07-091-2/+16
| | | | | | | | | | | | | This completes the linux implementation of the new wrench menu. Turning on by default. Will watch how this goes. BUG=45757 TEST=Look at the menu. The size of the "cut," "copy" and "paste" buttons should be equal. Review URL: http://codereview.chromium.org/2961001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51974 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix highlight and image colors in the new wrench menu.erg@chromium.org2010-07-081-12/+30
| | | | | | | | | | | | | | | | | | | | - The states weren't being set properly to replicate the menu item highlight effect. The button background needs to be STATE_SELECTED while the actual widget needs PRELIGHT. This removes a bunch of crud. - The fullscreen button needs to be tinted multiple times to the different label states. Now the fullscreen icon is the correct label color. Required adding infrastructure for GtkIconSets. BUG=45757 TEST=All labels and images in buttons should match the normal and prelight states of the labels in normal menu items. Make sure to try themes that have different normal and prelight states (DarkLooks) and themes that have the same color (Ambiance). Review URL: http://codereview.chromium.org/2864044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51805 0039d316-1c4b-4281-b951-d872f2087c98
* Moves gtk accelerator processing functions to base/gtk_util so I cansky@chromium.org2010-07-011-0/+1
| | | | | | | | | | | | | use them from views and gfx. Sorry for the new patch on this and not an update. Not sure what happened. BUG=none TEST=none Review URL: http://codereview.chromium.org/2809047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51409 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Cleanups to the new wrench menu.erg@chromium.org2010-06-301-10/+49
| | | | | | | | | | | | | | | - Make the rendering for multiple buttons pretty by unifying sequnces of buttons. - Add the zoom label control and make the wrench menu model listen for notifications about zoom percentage changing. - Fixes crash that would have gone away once this was taken out from behind a flag BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2799043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51266 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r50859 with chromeos fixes.erg@chromium.org2010-06-251-7/+84
| | | | | | | | | | | | | | | | GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. Review URL: http://codereview.chromium.org/2800015 BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50896 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50859 - GTK: First draft of the unified cut/copy/paste and ↵rafaelw@google.com2010-06-251-84/+7
| | | | | | | | | | | | | | | | | | +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2800015 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2836029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50865 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.erg@chromium.org2010-06-251-7/+84
| | | | | | | | | | | | | Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2800015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50859 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTREACHED() that I'm triggering when I righttony@chromium.org2010-05-211-1/+2
| | | | | | | | | | | click on a text field. BUG=None TEST=Right click on a text field with an IME installed. Review URL: http://codereview.chromium.org/2108023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47868 0039d316-1c4b-4281-b951-d872f2087c98
* Re-organize RenderViewContextMenu to the use cross-platform MenuModel class.estade@chromium.org2010-05-111-121/+8
| | | | | | | | | | | | | | | | | | Benefits: - less code - more straightforward code - more shared code unresolved issues: - RenderViewContextMenu{Gtk,Mac,Views} should not be a subclass of RenderViewContextMenu - On Linux, IMEs are added in the wrong place (not near the other editable stuff) BUG=31365 TEST=manual + trybots Review URL: http://codereview.chromium.org/2017001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46987 0039d316-1c4b-4281-b951-d872f2087c98
* Add icons to SimpleMenuModel.estade@chromium.org2010-05-051-13/+2
| | | | | | | | | | | | Also get rid of one of the MenuGtk constructors (now down to 2). Also, stamp out one more use of MenuGtk::Delegate as a controller class. BUG=31365 TEST=manual (in debug mode) + trybots Review URL: http://codereview.chromium.org/1915004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46434 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change menu delegate callback from CommandWasExecuted to ↵estade@chromium.org2010-04-061-3/+3
| | | | | | | | | | | | | CommandWillBeExecuted. Both the menu itself and the delegate were being destroyed in ExecuteCommand, double whammy! BUG=40477 TEST=disable browser action extension via context menu Review URL: http://codereview.chromium.org/1593012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43757 0039d316-1c4b-4281-b951-d872f2087c98
* GTK browser actions toolbar fiddling:estade@chromium.org2010-04-021-16/+21
| | | | | | | | | | | | - make the toolbar size restore properly when the toolbar is created before the model is loaded - allow the user to right click menu items in the overflow menu BUG=40068 (sorta) TEST=manual Review URL: http://codereview.chromium.org/1602003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43515 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-201-1/+2
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix menu display logic for people with top/down xinerama setups, part 2.thestig@chromium.org2010-03-191-11/+27
| | | | | | | | BUG=14184 TEST=see bug Review URL: http://codereview.chromium.org/1105006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42162 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: fix context menu positioning, take 2.estade@chromium.org2010-03-171-3/+7
| | | | | | | | | Find correct screen (based on current position of mouse pointer) and monitor. BUG=27800 Review URL: http://codereview.chromium.org/399101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41894 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix menu display logic for people with top/down xinerama setups.thestig@chromium.org2010-03-171-7/+9
| | | | | | | | BUG=14184 TEST=see bug Review URL: http://codereview.chromium.org/1026006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41855 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-171-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: tweak where widget-anchored menus appear.estade@chromium.org2010-03-091-2/+3
| | | | | | | | | BUG=15443 TEST=see bug. Page/app menus + download item menus + bookmark bar menus should be fixed. Review URL: http://codereview.chromium.org/672024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40978 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 4: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-2/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40960 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of bad dependency removal (chrome/common -> chrome/browser)phajdan.jr@chromium.org2010-03-021-1/+1
| | | | | | | | | | | This change introduces one more dependency on chrome/browser, but it seems simpler to move gtk_util first and then fix it. TEST=none BUG=none Review URL: http://codereview.chromium.org/661271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-101-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: support dynamic labels in GtkMenusestade@chromium.org2010-02-081-6/+29
| | | | | | | | | BUG=32115 TEST=show app menu, then toggle bookmark sync (on->off or off->on), show app menu again and confirm that the sync label has changed Review URL: http://codereview.chromium.org/573037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38380 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: uninstall signal handlers when MenuGtk goes down so that they don't get ↵estade@chromium.org2010-01-281-0/+2
| | | | | | | | | | | called after destruction. BUG=33335 TEST=none Review URL: http://codereview.chromium.org/549185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37371 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Implement input methods context menu.suzhe@chromium.org2010-01-241-24/+41
| | | | | | | | | BUG=31008 TEST=Right click in the content area, there will be an "Input Method" submenu. Review URL: http://codereview.chromium.org/549100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36977 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: respect menu model's radio button groupings.estade@chromium.org2010-01-201-8/+11
| | | | | | | | | | | (don't just group by proximity) BUG=32222 TEST=see bug Review URL: http://codereview.chromium.org/548074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36579 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: fix reference counting/destruction of GtkMenu* in MenuGtk. estade@chromium.org2010-01-191-0/+6
| | | | | | | | | | | | | regression caused by r35404 credit to Bryan Yeung for finding the bug BUG=31977, 31765, 32514, 31988 TEST=see bugs Review URL: http://codereview.chromium.org/552044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36559 0039d316-1c4b-4281-b951-d872f2087c98
* Escape the '&' character in the back/forward menu entries.estade@chromium.org2010-01-191-3/+3
| | | | | | | | | | | | BUG=17660 TEST=See 17660 for reproduction steps. patch by Aaron Kemp <kemp [at] chromium> original review: http://codereview.chromium.org/541053/show Review URL: http://codereview.chromium.org/542113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36530 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use page and app menu models.estade@chromium.org2010-01-071-35/+78
| | | | | | | | | | | | | | | - implement more MenuModel support for MenuGtk - copy some accelerators around TODO: centralize accelerator list (currently they are all listed twice) TODO: get rid of standard_menus.cc (it is still used by the popup favicon menu) BUG=NONE TEST=page and app menus still work, still display accelerators, accelerators still work Review URL: http://codereview.chromium.org/523105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35671 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make tab context menu use tab_menu_modelestade@chromium.org2010-01-051-15/+45
| | | | | | | | | | | flesh out some more menu model implementation for MenuGtk BUG=28977 TEST=menu still works as before Review URL: http://codereview.chromium.org/523049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35569 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix regression where MenuGtk::Delegate GetLabel() method was ↵estade@chromium.org2010-01-051-0/+3
| | | | | | | | | | | | | erroneously removed. got overzealous deleting code in r35389 BUG=31391 TEST=see bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35502 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Remove OwnedWidgetGtk wrapper for the GtkMenu* in MenuGtk.estade@chromium.org2009-12-311-21/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "execute the command later" workaround, which was in place to avoid OwnedWidget-DCHECKing when selecting menu items that might cause cascading object-destruction effects, caused problems with the Browser::SetBlockCommandExecution() workaround, the reasoning for which can be found in BrowserWindowGtk and is reproduced here: // This piece of code is based on the fact that calling // gtk_window_activate_key() method against |window_| may only trigger a // browser command execution, by matching either a global accelerator // defined in above |kAcceleratorMap| or the accelerator key of a menu // item defined in chrome/browser/gtk/standard_menus.cc. // // Here we need to retrieve the command id (if any) associated to the // keyboard event. Instead of looking up the command id in above // |kAcceleratorMap| table by ourselves, we block the command execution of // the |browser_| object then send the keyboard event to the |window_| by // calling gtk_window_activate_key() method, as if we are activating an // accelerator key. Then we can retrieve the command id from the // |browser_| object. // // Pros of this approach: // 1. We can handle accelerators defined not only in above // |kAcceleratorMap| table, but also those in standard_menus.cc. // 2. We don't need to care about keyboard layout problem, as // gtk_window_activate_key() method handles it for us. // // Cons: // 1. The logic is a little complicated. // 2. We should be careful not to introduce any accelerators that trigger // customized code instead of browser commands. The easiest and cleanest thing is just to remove the OwnedWidgetGtk. BUG=none TEST=interactive ui tests pass again Review URL: http://codereview.chromium.org/522028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35404 0039d316-1c4b-4281-b951-d872f2087c98
* Implement browser action context menu on linux.estade@chromium.org2009-12-311-6/+24
| | | | | | | | | BUG=30656 TEST=manual (right click on browser actions and test the actions) Review URL: http://codereview.chromium.org/521016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35400 0039d316-1c4b-4281-b951-d872f2087c98
* Make back forward menu model a MenuModel.estade@chromium.org2009-12-301-14/+21
| | | | | | | | | | | On Linux, implement just enough MenuModel support in GtkMenu. On Linux + windows, remove wrapper classes. On Mac, just change a few function calls around. BUG=none TEST=unit test + manually clicking around on it in debug mode Review URL: http://codereview.chromium.org/501168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35389 0039d316-1c4b-4281-b951-d872f2087c98
* Fix radio items in MenuGtk.satorux@chromium.org2009-12-161-0/+7
| | | | | | | | | | | | | | Suppose there are three radio items A, B, C, and A is now being checked. If you click C, commands associated with A and C are both executed. This is because A also receives the "activate" signal, before C receives it. BUG=30450 TEST=try; manually with gdb with the steps described in crbug.com/30450. Review URL: http://codereview.chromium.org/506010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34647 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 21:07:23 +0000