summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk/options
Commit message (Collapse)AuthorAgeFilesLines
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-022-0/+2
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* Linux cookies view: ui cleanups to match win.mattm@chromium.org2009-11-303-16/+87
| | | | | | | | | | | | | | | Show tree lines. Domains are collapsed by default and expanding them expands all their children Don't show the column header in the tree view anymore. BUG=27657 TEST=compare to win Review URL: http://codereview.chromium.org/444010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33373 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Adds back the ability to filter cookies by origin in the cookies ↵mattm@chromium.org2009-11-303-6/+273
| | | | | | | | | | | options view BUG=27657 TEST=unittest passes, manually testing typing "google" in the search field pulls up origins containing "google" in their name Review URL: http://codereview.chromium.org/437075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33359 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-0/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-302-2/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-0/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-251-3/+3
| | | | | | | | | | | | | | | | | | | (sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Create app modal dialogs in a different way to work around a KDE 3 ↵thestig@chromium.org2009-11-244-7/+12
| | | | | | | | | | window manager bug. While we're at it, change dialog's default size to match that of Chrome on Windows. BUG=28230 TEST=see bug Review URL: http://codereview.chromium.org/425016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32905 0039d316-1c4b-4281-b951-d872f2087c98
* Move Mac to using renderer spellchecker.estade@chromium.org2009-11-191-3/+3
| | | | | | | | BUG=25677 Review URL: http://codereview.chromium.org/395007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLs out of *.pak files and put them into code. This savestony@chromium.org2009-11-191-5/+14
| | | | | | | | | | 28k of pak file size, but will make the binary a tad bit larger. BUG=28174 Review URL: http://codereview.chromium.org/407007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32556 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-175-47/+47
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* Spellchecker: Always destruct url request context getter on io thread.estade@chromium.org2009-11-171-1/+9
| | | | | | | | | | To do this, we have to initiate downloads on the UI thread and don't hold onto a reference in the file thread. BUG=27667 Review URL: http://codereview.chromium.org/387055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32129 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Explicitly use underlines in cookies dialog to fix display in Karmic.erg@google.com2009-11-121-0/+2
| | | | | | | | BUG=25635 Review URL: http://codereview.chromium.org/385073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31831 0039d316-1c4b-4281-b951-d872f2087c98
* Add the sync options to the preferences dialog on Linux.zork@chromium.org2009-11-122-2/+202
| | | | | | | | | BUG=none TEST=With bookmark sync enabled, go to Wrench Menu->Sync my bookmarks. Ensure that the Bookmark Sync section is there and useable. Review URL: http://codereview.chromium.org/385026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31805 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cookies_table_model which has been succeeded by cookies_tree_model.mattm@chromium.org2009-11-121-1/+0
| | | | | | | | | BUG=26713 TEST=still compiles Review URL: http://codereview.chromium.org/387031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31756 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Convert Cookies options page from a list into a tree.mattm@chromium.org2009-11-113-533/+285
| | | | | | | | | | | Add gtk_tree::TreeAdapter class. BUG=26713 TEST=compare behavior to windows impl Review URL: http://codereview.chromium.org/371079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31732 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with inline autocomplete and URLs that change length ↵pkasting@chromium.org2009-11-073-7/+4
| | | | | | | | | | | | | | | | | | | | during fixup: * URLs with http auth info, which gets stripped * URLs with IDN hosts * URLs with escaped values that get unescaped In cases like these, we'd inline autocomplete from the wrong locations, highlight the wrong portions of the URL as matches, and sometimes DCHECK() in debug mode. The fix is to track how fixup affects the offsets into the URL we care about. Plumbing this required an enormous number of additions :( There is also a fix here to the URL Fixer Upper, which was obviously modified at some point in the past to use the Parsed components, but without updating the comments or some of the functionality to match. Since this isn't supposed to "fix up" things that aren't simple typos, I removed some code to "fix" bogus ports, which was causing bizarre effects when typing HTTP auth URLs ("http://foo:bar" would be fixed to "http://foo" and then matched for inline autocompletion, which was clearly wrong). This is tested incidentally by one of the new History URL Provider tests (which is how I discovered it). BUG=4010 TEST=Covered by unittests Review URL: http://codereview.chromium.org/372017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31352 0039d316-1c4b-4281-b951-d872f2087c98
* Rename gtk_tree::ModelAdapter to TableAdapter in preparation for adding ↵mattm@chromium.org2009-11-066-12/+12
| | | | | | | | | | | TreeAdapter. BUG=none TEST=none Review URL: http://codereview.chromium.org/374007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31293 0039d316-1c4b-4281-b951-d872f2087c98
* Seventh patch in making destructors of refcounted objects private.jam@chromium.org2009-11-061-0/+2
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/371006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-0/+3
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
* Move chromeos code to namespace chromeos.chocobo@google.com2009-10-301-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/341044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Activate window when "Get themes" button is clicked.derat@chromium.org2009-10-281-3/+3
| | | | | | | | | | | This is a direct copy of the Views fix from r29949. BUG=24866 TESTED=verified that minimized browser window gets restored under metacity Review URL: http://codereview.chromium.org/334048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30286 0039d316-1c4b-4281-b951-d872f2087c98
* Move initialization of ChromeURLRequestContexts to the IO thread.eroman@chromium.org2009-10-231-31/+34
| | | | | | | | | | | | | | | | | | | | | | | Before, these URLRequestContexts were lazily created from the UI thread. Unfortunately that model made it easy for consumers on the UI thread to poke at stuff which was being used from the IO thread, and introduce races. So instead of providing a URLRequestContext*, the Profile now vends a URLRequestContextGetter*. The consequence of this is: * Consumers on the UI thread can no longer get access to a URLRequestContext. * Consumers on the IO thread need to call URLRequestContextGetter::GetURLRequestContext() to get at the context. This uses the same style lazy-creation of URLRequestContexts, albeit from the IO thread. OK, so now the smelly part: There were a couple of consumers of URLRequestContext on the UI thread that can't easily be moved to the IO thread -- these are the consumers of the cookie store. Before they could happily mess with the cookie store from the UI thread, and this was fine since CookieStore is threadsafe. However under the new model, they have no way to get at the URLRequestContext from the UI thread, hence can't get a pointer to the cookie store. To support that use-cases, I bastardized the API some by adding a URLRequestContextGetter::GetCookieStore() method that lets UI thread consumers get a pointer to the cookie store, since we know this particular cross-thread usage is safe. BUG=http://crbug.com/22294 Review URL: http://codereview.chromium.org/258008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29880 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix crash in PopulateCookieDetails called by OnSelectionChanged callbackmattm@chromium.org2009-10-233-0/+43
| | | | | | | | | | | which can be called while the view and model are in inconsistent states. BUG=25535 TEST=open cookies manager, select all, remove all Review URL: http://codereview.chromium.org/334001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29860 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Use gtk_window_present_with_time since the doc's says it is better to usemattm@chromium.org2009-10-231-2/+2
| | | | | | | | | | | | it when it is a response to a user action. BUG=None TEST=compiled and tested. Review URL: http://codereview.chromium.org/299001 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29850 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Select the first row in cookies table when the Cookies window ismattm@chromium.org2009-10-213-1/+76
| | | | | | | | | | | | | | opened. Windows already does this. BUG=None TEST=compiled and tested on linux and covered by unit_tests. Review URL: http://codereview.chromium.org/270063 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29687 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some structures in webkit/glue to string16.darin@chromium.org2009-10-201-2/+2
| | | | | | | | | | R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/305002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: disable theme buttons in options dialog when we are already using that ↵estade@chromium.org2009-10-162-9/+53
| | | | | | | | | | | theme. BUG=18585 TEST=clicking Review URL: http://codereview.chromium.org/289007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29346 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-145-7/+8
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Select a row in Languages table when the user delete an item.mattm@chromium.org2009-10-132-5/+19
| | | | | | | | | | | | This is to work in the same way as in Windows version. BUG=None TEST=add some languages, remove them, should work fine. Review URL: http://codereview.chromium.org/270013 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28775 0039d316-1c4b-4281-b951-d872f2087c98
* Move more ICU-dependent stuff from base into base/i18n. Some test stuff alsobrettw@chromium.org2009-10-091-1/+1
| | | | | | | | | | | | depended on this, so to make the DEPS work out, I made a new base/test directory where I moved the testing-related files into a new directory base/test. TEST=none BUG=none Review URL: http://codereview.chromium.org/266038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
* Move classes depending on Skia out of base/gfx and into app/gfx. Renamebrettw@chromium.org2009-10-075-5/+5
| | | | | | | | | | native_theme to native_theme_win since its Windows-specific. BUG=none TEST=none Review URL: http://codereview.chromium.org/259047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28300 0039d316-1c4b-4281-b951-d872f2087c98
* Change flag "auto-spell-correct" to "experimental-spellchecker-features". I ↵sidchat@chromium.org2009-10-051-1/+1
| | | | | | | | | | will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use. BUG=none TEST=none Review URL: http://codereview.chromium.org/260006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28055 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using radio buttons for toggling the custom frame. Usetony@chromium.org2009-10-022-22/+54
| | | | | | | | | | title case for the context menu on the title bar. BUG=23412 Review URL: http://codereview.chromium.org/255059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27896 0039d316-1c4b-4281-b951-d872f2087c98
* Update some strings in the options dialog w.r.t. themes.tony@chromium.org2009-10-011-1/+1
| | | | | | | | | | | Changed the heading from Themes: to Appearance: and switch from 'Set to XXX theme' to 'Use XXX theme'. BUG=21504 Review URL: http://codereview.chromium.org/243059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27783 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up views on linux dialogs to use gtk ones.sky@chromium.org2009-09-291-2/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/254007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27484 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use "Set to Classic theme" instead of reset in the options dialog.erg@google.com2009-09-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/238003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27118 0039d316-1c4b-4281-b951-d872f2087c98
* Disables turning on custom frame in chrome os.sky@chromium.org2009-09-231-7/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/207055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26933 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the intializaton of the Download Manager when bringing uptony@chromium.org2009-09-181-3/+0
| | | | | | | | | | | | the options dialog. This was done a long long time ago because we used to register the download dir pref in the Download Manager constructor. Since that's no longer the case, we don't need to intialize the Download Manager. Review URL: http://codereview.chromium.org/208021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26583 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't show the GTK theme button on chromeos.erg@google.com2009-09-111-0/+2
| | | | | | Review URL: http://codereview.chromium.org/193088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26007 0039d316-1c4b-4281-b951-d872f2087c98
* Make the "get themes" button into a link instead.mdm@chromium.org2009-09-101-1/+2
| | | | | | | | | BUG=21414 TEST=none Review URL: http://codereview.chromium.org/203019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25913 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: expose "Use system title bar and borders" preference in options dialog.mdm@chromium.org2009-09-082-2/+38
| | | | | | | | | BUG=19483 TEST=none Review URL: http://codereview.chromium.org/193033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25643 0039d316-1c4b-4281-b951-d872f2087c98
* This CL changes the CookieStore obect to be a refcounted object to get a ↵ananta@chromium.org2009-09-051-3/+0
| | | | | | | | | | | | better handle on its lifetime as there are cases where this object is handed out to URLRequestContext instances which outlive the URLRequestContext object which created it. Partial fix for http://code.google.com/p/chromium/issues/detail?id=15289 Bug=15289 Review URL: http://codereview.chromium.org/197023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25558 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the default browser check to return "unknown" and reflect that in the UI.mdm@chromium.org2009-09-041-1/+5
| | | | | | | | | | On Linux this can happen for unsupported desktop environments. On Windows and Mac OS X this probably should not occur and likely indicates some sort of serious configuration error. This change avoids repeatedly bothering the user to set the default browser in cases where we're likely to fail at that, without incorrectly displaying that we are the default browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/200025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25553 0039d316-1c4b-4281-b951-d872f2087c98
* Convert std::wstring encoding names to std::string in a bunch of files.tony@chromium.org2009-09-041-3/+4
| | | | | | | | | | | | | | | BUG=8647 (http://crbug.com/8647) TEST=run unit_tests.exe and ui_tests.exe Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/179057/show Some linux related fixes by me. Review URL: http://codereview.chromium.org/192017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25529 0039d316-1c4b-4281-b951-d872f2087c98
* Set the initial sizes of several dialogs based on font information.mdm@chromium.org2009-09-022-21/+27
| | | | | | | | | BUG=19622 TEST=none Review URL: http://codereview.chromium.org/180031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25214 0039d316-1c4b-4281-b951-d872f2087c98
* Set the window type hint for the options dialog andtony@chromium.org2009-09-011-0/+2
| | | | | | | | | | | | | | task manager to GDK_WINDOW_TYPE_HINT_NORMAL. This allows the dialogs to go behind browser windows in metacity. I did it for these two dialogs mainly because they have links to web pages. The links should be able to open on top of the dialog. Review URL: http://codereview.chromium.org/179014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25057 0039d316-1c4b-4281-b951-d872f2087c98
* When running on chrome OS about:version now shows OS version.sky@chromium.org2009-09-011-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/179063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25045 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: get GNOME or KDE proxy settings.mdm@chromium.org2009-08-281-6/+6
| | | | | | | | | BUG=17363, 20407 TEST=none Review URL: http://codereview.chromium.org/174327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24831 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the settings tab to options on chrome os. The contents is just a placesky@chromium.org2009-08-271-0/+12
| | | | | | | | | | holder at this point. BUG=none TEST=none Review URL: http://codereview.chromium.org/174596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24642 0039d316-1c4b-4281-b951-d872f2087c98