summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk/tab_contents_drag_source.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move chrome/browser/gtk/ to chrome/browser/ui/gtk/msw@chromium.org2011-01-141-393/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (moved *.cc using 'svn mv' to preserve history) (copied *.h using 'svn cp' to preserve history and stub out originals) Stubbed out original headers in chrome/browser/gtk/ Update header guards & copyright dates in chrome/browser/ui/gtk/ Update .gypi files Remove chrome/chrome_browser.gypi:4228 reference to nonexistant: ['include', '^browser/gtk/pk11_password_dialog.h'], Remove stray header guard in: chrome/browser/ui/gtk/bookmark_bar_instructions_gtk.cc Add #pragma once to the following files: chrome/browser/ui/gtk/instant_confirm_dialog_gtk.h chrome/browser/ui/gtk/infobar_arrow_model.h Ran the following to appease presubmit: 'svn pset svn:eol-style LF \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.cc \ chrome/browser/ui/gtk/gtk_custom_menu.cc \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/ui/gtk/gtk_custom_menu.h \ chrome/browser/ui/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/ui/gtk/chrome_gtk_frame.h \ chrome/browser/ui/gtk/chrome_gtk_frame.cc \ chrome/browser/ui/gtk/gtk_custom_menu_item.h \ chrome/browser/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/gtk/gtk_custom_menu.h \ chrome/browser/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/gtk/chrome_gtk_frame.h \ chrome/browser/gtk/gtk_custom_menu_item.h' BUG=69289 TEST=Compile&Trybots Review URL: http://codereview.chromium.org/6251001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71397 0039d316-1c4b-4281-b951-d872f2087c98
* Fix situation where a new drag could start before previous one completes.tsepez@chromium.org2011-01-101-4/+15
| | | | | | | | | BUG=61094 TEST=manually select a region of text and repeatedly drag it into an inactive portion of the screen. Review URL: http://codereview.chromium.org/5981011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70906 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a minor resource leak.estade@chromium.org2010-11-051-4/+2
| | | | | | | | | | | | | | glib reference counting does not call gtk_widget_destroy. Can't use OwnedWidgetGtk because GtkInvisible and GtkWindow sink the floating reference in their initializers. So we manually call gtk_widget_destroy, following the pattern in TabGtk. BUG=61495 TEST=Run xrestop. Add a few tabs with ctrl-T. Number of X windows should increase by two. Remove the tabs with ctrl-W. Number of X windows should decrease accordingly. patch by Jonathan Backer <backer@chromium.org> original review: http://codereview.chromium.org/4341004/show Review URL: http://codereview.chromium.org/4498002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65163 0039d316-1c4b-4281-b951-d872f2087c98
* Remove src/app's dependency on the WebKit api.tony@chromium.org2010-10-211-2/+2
| | | | | | | | | | src/app shouldn't depend on webkit in anyway. DEPS allows this because it allows paths pulled in by deps = {} (stuff pulled in by gclient). Add a new rule to explicitly disallow this. Review URL: http://codereview.chromium.org/3998004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63434 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] disable drag image for non-compositing WMs.estade@chromium.org2010-09-101-1/+3
| | | | | | | | | BUG=55143 TEST=drag something in the render view Review URL: http://codereview.chromium.org/3351024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59158 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up download code:phajdan.jr@chromium.org2010-08-051-6/+6
| | | | | | | | | | | | | | | | | | - move filename generation parts and related code out of DownloadManager download_util is not the best place for it, but it's better than DownloadManager which we're trying to minimize - clean up posting tasks to different threads. There's no need to create separate methods for that, it was cluttering the file needlessly - other minor cleanups, like using static_cast instead of C-style cast TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3043048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55088 0039d316-1c4b-4281-b951-d872f2087c98
* Fix debug build GTK assert in TabContentsDragSource::OnDragBegin().dcheng@chromium.org2010-08-041-4/+7
| | | | | | | | | | | | | The assert is: Gtk: gtk_widget_set_colormap: assertion `!gtk_widget_get_realized (widget)' failed. BUG=none TEST=Navigate to google.com and drag the logo twice. Review URL: http://codereview.chromium.org/3086011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54851 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple of leaks in use of gdk_get_property.sky@chromium.org2010-05-251-0/+1
| | | | | | | | | BUG=44945 TEST=none Review URL: http://codereview.chromium.org/2089024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48161 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make more use of gtk_signal convenience macros/signal registrar.estade@chromium.org2010-04-281-29/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1708013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45850 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Support transparent web image drags.estade@chromium.org2010-04-231-7/+32
| | | | | | | | | | | | | This depends on a webkit side change before it has any effect. This only works on compositing WMs; non-compositing WMs will just not get a transparent image (it actually will appear slightly darkened). BUG=11457 TEST=manul Review URL: http://codereview.chromium.org/1756008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45503 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: slightly change how we display drag images.estade@chromium.org2010-04-081-10/+24
| | | | | | | | | | | | | We use a popup window for the drag because in many window managers it looks better. Ideally we would implement the alpha-channel fading that some other WebKit ports use, but gtk_drag_set_icon_* don't seem to support transparency (dragged tabs can be transparent because they use a different approach that avoids this problem, but is more complicated in other ways). BUG=none TEST=manual Review URL: http://codereview.chromium.org/1519019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43976 0039d316-1c4b-4281-b951-d872f2087c98
* GTK plumbing for dragend.dcheng@chromium.org2010-04-051-2/+3
| | | | | | | | | | | This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. BUG=39399 TEST=Manual testing using the attached test case on the bug. Review URL: http://codereview.chromium.org/1589015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43679 0039d316-1c4b-4281-b951-d872f2087c98
* Fix HTML5 effectAllowed and dragEffect on Chrome Linux.tony@chromium.org2010-03-231-1/+3
| | | | | | | | | | | This hooks up all the chrome side plumbing, but there are a couple webkit changes that need to happen for this to fully work. BUG=14654 Review URL: http://codereview.chromium.org/1084003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42306 0039d316-1c4b-4281-b951-d872f2087c98
* Retry r41799:estade@chromium.org2010-03-181-1/+13
| | | | | | | | | | | | | | | | | | | | Basic DragImage implementation. Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit. TODO later: - use the image on windows, mac - implement the other DragImageRef functions TEST=drag an image from the render view in GTK BUG=11457 Review URL: http://codereview.chromium.org/668125 The problem was an incorrect method signature in RenderView. Review URL: http://codereview.chromium.org/1037008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41953 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r41803 and r41799estade@chromium.org2010-03-171-13/+1
| | | | | | | | | | BUG=38414 TEST=none TBR=jam Review URL: http://codereview.chromium.org/1039006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41876 0039d316-1c4b-4281-b951-d872f2087c98
* fixing bustage... file was movedben@chromium.org2010-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41814 0039d316-1c4b-4281-b951-d872f2087c98
* Basic DragImage implementation.estade@chromium.org2010-03-171-1/+14
| | | | | | | | | | | | | | | Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit. TODO later: - use the image on windows, mac - implement the other DragImageRef functions TEST=drag an image from the render view in GTK BUG=11457 Review URL: http://codereview.chromium.org/668125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41799 0039d316-1c4b-4281-b951-d872f2087c98
* Final removal of the bad dependency of chrome/common on chrome/browserphajdan.jr@chromium.org2010-03-101-30/+30
| | | | | | | | | | | Also convert app/gtk_dnd_util.h from a class to a namespace for consistency with added app/gtk_util.h. TEST=none BUG=none Review URL: http://codereview.chromium.org/669268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41177 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 3: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-1/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40959 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of bad dependency removal (chrome/common -> chrome/browser)phajdan.jr@chromium.org2010-03-021-1/+1
| | | | | | | | | | | This change introduces one more dependency on chrome/browser, but it seems simpler to move gtk_util first and then fix it. TEST=none BUG=none Review URL: http://codereview.chromium.org/661271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser on Linux. This is based ↵jianli@chromium.org2010-02-191-1/+111
| | | | | | | | | | | on the discussion of drag-out feature on whatwg: http://list.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html BUG=none TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder. Review URL: http://codereview.chromium.org/600154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39405 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-091-0/+1
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't get stuck in render view drag.estade@chromium.org2010-01-211-5/+16
| | | | | | | | | | | Everyone once in a while gtk_drag_begin() returns NULL meaning the drag failed to start. Inform webkit of this. BUG=30580 TEST=see bug Review URL: http://codereview.chromium.org/548108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36812 0039d316-1c4b-4281-b951-d872f2087c98
* Allow link drags from the star, bookmarks bar, and bookmark bar menustony@chromium.org2010-01-201-16/+5
| | | | | | | | | | | to the Gnome desktop (nautilus). These should create shortcuts. Other drag operations should be the same as before. BUG=24210 Review URL: http://codereview.chromium.org/548067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36585 0039d316-1c4b-4281-b951-d872f2087c98
* Allow link drags from Chrome to create a shortcut on the desktop.tony@chromium.org2010-01-151-1/+15
| | | | | | | | | | | | | This required adding the netscape link+title format to the drag data (we were already doing this on windows) and adding GDK_ACTION_LINK to the GdkDragAction passed into gtk_drag_begin. BUG=27337 TEST=Drag a link to the desktop, it should create a shortcut (.desktop file). Review URL: http://codereview.chromium.org/542072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36321 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency cleanup in chrome/phajdan.jr@chromium.org2009-10-121-0/+1
| | | | | | | | | | | | - reduce header dependencies - remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h! TEST=none BUG=none Review URL: http://codereview.chromium.org/245011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code doing a no-op due to float -> int rounding.phajdan.jr@chromium.org2009-09-141-1/+3
| | | | | | | | | | | | | | | | Make implicit float -> int/long conversions explicit. (Implicit float -> int conversions can be found by compiling with -Wconversion in gcc [versions 4.1.1 and 4.2.4, and surely many others].) Landing the patch for Jacob Mandelson, original review: http://codereview.chromium.org/201091 BUG=none TEST=app_unittests & base_unittests Review URL: http://codereview.chromium.org/200122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26119 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the DragOperation through all the layers between the platform ↵snej@chromium.org2009-09-081-4/+8
| | | | | | | | | | | | | Drag-n-drop code and WebCore. This allows the HTML5 DataTransfer effectAllowed and dropEffect properties to be set correctly in JS handlers, as per the HTML5 spec. (The drag-dropeffect test isn't in WebKit yet -- it's part of a separate WebKit patch that's been in review for weeks.) R=darin,pink BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985 TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html Review URL: http://codereview.chromium.org/174364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25629 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make the toolbar star button a drag source.estade@chromium.org2009-09-011-18/+3
| | | | | | | | | | Also refactor URI list/named url packing code. BUG=19008 Review URL: http://codereview.chromium.org/175036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25067 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-3/+1
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-1/+3
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Moves GtkDndUtil into app.sky@chromium.org2009-08-181-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23627 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-171-1/+2
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors drag support from TabContentsViewGtk intosky@chromium.org2009-08-121-0/+216
TabContentsDragHandler so that it can be used by both Gtk and Views. BUG=none TEST=none Review URL: http://codereview.chromium.org/165302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23168 0039d316-1c4b-4281-b951-d872f2087c98