summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Remove Windows "Save As" dialogs from Save Page code.In this change:- ↵paulg@google.com2009-03-301-1/+3
| | | | | | | | convert SavePackage to use async SelectFileDialog- return the chosen filter index in the FileSelected callback- some clean up of save_package.ccBUG=8691 (http://crbug.com/8691) Review URL: http://codereview.chromium.org/45048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12799 0039d316-1c4b-4281-b951-d872f2087c98
* Break out the tab rendering logic into TabGtk and TabRendererGtk.jhawkins@chromium.org2009-03-309-645/+1321
| | | | | | Review URL: http://codereview.chromium.org/56030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12795 0039d316-1c4b-4281-b951-d872f2087c98
* Properly fix menu display when using dark system themes.evan@chromium.org2009-03-272-4/+4
| | | | | | | | | The drawing code in the tab strip was modifying the GC, which affected the GC used for drawing menus. Review URL: http://codereview.chromium.org/55022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12713 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk download shelf:estade@chromium.org2009-03-264-19/+84
| | | | | | | | | | | - show status text (when appropriate) - set text colors - limit the size of the download item view and elide text to fit - don't let download items spill over on the right (hide and show them as shelf grows and shrinks) Review URL: http://codereview.chromium.org/42672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12624 0039d316-1c4b-4281-b951-d872f2087c98
* Change NineBox to render into a GtkWidget. This offers a minor speedup and ↵jhawkins@chromium.org2009-03-268-142/+104
| | | | | | | | simplification of code because we get rid of the pixbuf middleman. Review URL: http://codereview.chromium.org/42620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12620 0039d316-1c4b-4281-b951-d872f2087c98
* Fix our browser window close path to be more like windows.tc@google.com2009-03-262-8/+38
| | | | | | | | | | | We try to run onbeforeunload handlers (and cause the renderer to hang) and we close all the tabs first which properly destroys the tabcontents and webcontents. Review URL: http://codereview.chromium.org/53083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12616 0039d316-1c4b-4281-b951-d872f2087c98
* More NOTIMPLEMENTEDs into bugs.evan@chromium.org2009-03-262-3/+9
| | | | | | Review URL: http://codereview.chromium.org/42668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12615 0039d316-1c4b-4281-b951-d872f2087c98
* Fix/punt on a bunch of NOTIMPLEMENTEDs.evan@chromium.org2009-03-261-1/+3
| | | | | | Review URL: http://codereview.chromium.org/53065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12604 0039d316-1c4b-4281-b951-d872f2087c98
* Linux download shelf:estade@chromium.org2009-03-264-7/+35
| | | | | | | | | - Show status text. - Pack new items on the left. Review URL: http://codereview.chromium.org/53084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12582 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up ctrl+tab and ctrl+shift+tab for switching tabs in linuxtc@google.com2009-03-262-11/+40
| | | | | | | | | | | | We can't just add accelerators for these because GDK_Tab and GDK_ISO_Left_Tab are not valid accelerator keys: http://www.google.com/codesearch/p?hl=en#ycarM8Ghiog/gtk+-2.4.0/gtk/gtkaccelgroup.c&q=gtk_accel_groups_activate&l=805 Instead, handle these keys in keypress and forward the event on to BrowserWindowGtk::OnAccelerator directly. We stash a pointer to BrowserWindowGtk on the GtkWindow. Review URL: http://codereview.chromium.org/42611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12581 0039d316-1c4b-4281-b951-d872f2087c98
* Linux UI theming:estade@chromium.org2009-03-251-1/+3
| | | | | | | | | - Improve appearance of menus by setting background to white (matching windows and fitting better with the overall appearance). - Disable user theming of native widgets: since our widgets are a hodge-podge of native and custom-drawn, there's no way we can support user theming. Eventually users will be able to choose a theme for chromium; until then make everything look like chrome. Review URL: http://codereview.chromium.org/49035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12516 0039d316-1c4b-4281-b951-d872f2087c98
* Use the correct g_free instead of free when freeing memory passed to us from ↵jhawkins@chromium.org2009-03-251-1/+1
| | | | | | | | gtk. Review URL: http://codereview.chromium.org/53072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12510 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix/punt on a bunch of NOTIMPLEMENTEDs."evan@chromium.org2009-03-251-3/+1
| | | | | | This reverts commit r12489. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12492 0039d316-1c4b-4281-b951-d872f2087c98
* Fix/punt on a bunch of NOTIMPLEMENTEDs.evan@chromium.org2009-03-251-1/+3
| | | | | | Review URL: http://codereview.chromium.org/53065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12489 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to paint tabs if there are no tabs to paint.tc@google.com2009-03-251-0/+3
| | | | | | | | | BUG=9214 Review URL: http://codereview.chromium.org/53033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12423 0039d316-1c4b-4281-b951-d872f2087c98
* Redone http://codereview.chromium.org/42571idanan@chromium.org2009-03-242-1/+7
| | | | | | | | | | | Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=maruel Review URL: http://codereview.chromium.org/53020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12403 0039d316-1c4b-4281-b951-d872f2087c98
* Make the find bar blue. Hooks up the prev/next buttons and thetc@google.com2009-03-242-12/+106
| | | | | | | | | close button. Review URL: http://codereview.chromium.org/50079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12378 0039d316-1c4b-4281-b951-d872f2087c98
* Add initial implementation of the Linux TabStrip.jhawkins@chromium.org2009-03-234-14/+670
| | | | | | | | | | | | | | | | | The following are implemented: * Keyboard shortcuts for next/prev/close tab. * Tab layout and rendering. The following need to be implemented: * Mouse input handling. * Animations. * TabGtk, TabRendererGtk. * Dragging. * Fix a NOTREACHED in navigation_controller.cc. Review URL: http://codereview.chromium.org/42457 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12316 0039d316-1c4b-4281-b951-d872f2087c98
* Deliver events and notifications to the RootView.erg@google.com2009-03-231-1/+8
| | | | | | | Review URL: http://codereview.chromium.org/42519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12305 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux input breakage: Don't wrap an important line in a DCHECK!estade@chromium.org2009-03-201-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12227 0039d316-1c4b-4281-b951-d872f2087c98
* Remove errant debugging line.estade@chromium.org2009-03-201-1/+0
| | | | | | Review URL: http://codereview.chromium.org/50073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12219 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate into a single shutdown path.tc@google.com2009-03-202-29/+32
| | | | | | | | | | | This consolidates the shutdown path. We used to have two paths depending of whether the user hit the X on the window manager or used wrench -> exit. Now both do the same thing: call BrowserWindowGtk::Close(). Review URL: http://codereview.chromium.org/42372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12214 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Restore normal event handling for key events that are not to be sent ↵estade@chromium.org2009-03-201-9/+18
| | | | | | | | | | to webkit. We want to pass all key events to webkit. But other widgets shouldn't get key events till after they've been checked against our accelerators. This fixes the problem that pressing ctrl-page{up,down} in the location bar moves the cursor rather than changing tabs. Review URL: http://codereview.chromium.org/50069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12209 0039d316-1c4b-4281-b951-d872f2087c98
* Linux UI hook ups:estade@chromium.org2009-03-202-0/+14
| | | | | | | | | - Fix new tab focus - attach f5 for refresh Review URL: http://codereview.chromium.org/42422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12206 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up ctrl-w for close tab on linux.estade@chromium.org2009-03-202-4/+31
| | | | | | | | | | Delay the handling of certain accelerators so we don't try to destroy a widget that GTK is reffing as a result of event handling. Patch based on another by Dean McNamee. Review URL: http://codereview.chromium.org/42421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12200 0039d316-1c4b-4281-b951-d872f2087c98
* Make GTK accelerator setup code more compact.estade@chromium.org2009-03-201-22/+19
| | | | | | Review URL: http://codereview.chromium.org/50042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12184 0039d316-1c4b-4281-b951-d872f2087c98
* Now have a TextButton rendering (sort of; doesn't respond to mouse events soerg@google.com2009-03-191-0/+4
| | | | | | | | | | | I don't know if it'll draw the border correctly). Now with fixes to compile under Windows. Review URL: http://codereview.chromium.org/42427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12172 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Now have a TextButton rendering." Broke Windows.erg@google.com2009-03-191-4/+0
| | | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/50035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12163 0039d316-1c4b-4281-b951-d872f2087c98
* Now have a TextButton rendering (sort of; doesn't respond to mouse events so ↵erg@google.com2009-03-191-0/+4
| | | | | | | | | I don't know if it'll draw the border correctly). Review URL: http://codereview.chromium.org/42414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12162 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FindInPage wstrings to string16.tc@google.com2009-03-192-7/+5
| | | | | | | Review URL: http://codereview.chromium.org/42408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12158 0039d316-1c4b-4281-b951-d872f2087c98
* Render into a ChromeCanvasPaint object in a RootView under Linux.erg@google.com2009-03-192-0/+17
| | | | | | | Review URL: http://codereview.chromium.org/45014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12097 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserWindow::Init().estade@chromium.org2009-03-182-48/+45
| | | | | | | | This belongs as a private method of BrowserView. Neither mac nor linux uses it. Review URL: http://codereview.chromium.org/42298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11982 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup GTK toolbar tooltips. Move from GtkTooltips to GtkTooltip API.deanm@chromium.org2009-03-172-17/+6
| | | | | | | | | | | | | Move away from the deprecated GtkTooltips API, instead using the preferred methods on GtkWidget. Add missing tooltips to the back and forward buttons. This also fixes a memory leak of the old tooltips object which is no longer needed. BUG=8868 Review URL: http://codereview.chromium.org/48068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11873 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that MenuGtks are destroyed before their accelerator group.deanm@chromium.org2009-03-173-30/+26
| | | | | | | | | | | | | When a MenuGtk is created, it is passed a GtkAccelGroup. Previously the GtkMenu widgets were destroyed after the browser window, which was the owner of the GtkAccelGroup. Make the toolbar own a reference to the GtkAccelGroup, and teardown all GtkMenus that reference it beforehand. Some MenuGtk cleanup while debugging the problem. BUG=8866 Review URL: http://codereview.chromium.org/48065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11872 0039d316-1c4b-4281-b951-d872f2087c98
* Linux accelerators cleanup:estade@chromium.org2009-03-164-42/+91
| | | | | | | | | | | | | | | | - Give renderer a chance to handle accelerators before browser does. - Handle browser accelerators that aren't attached to any particular UI element in BrowserWindowGtk rather than in BrowserToolbarGtk - Use Browser::ExecuteCommand() to handle accelerator activation - Switch a random void* to gfx::NativeWindow - Enable three browser commands on linux : Focus Location, Focus Search, Open file This fully enables ctrl-l, ctrl-k, and ctrl-o. This fixes copy-pasta in the omnibox. This fixes the problem Dean described with <http://www.quirksmode.org/js/keys.html>. bug=8659 Review URL: http://codereview.chromium.org/42190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11759 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of our GTK code that was previous manually handling references ↵deanm@chromium.org2009-03-167-40/+44
| | | | | | | | | (and often doing it incorrect / leaking) to use an OwnedWidgetGtk. Review URL: http://codereview.chromium.org/48007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11750 0039d316-1c4b-4281-b951-d872f2087c98
* Implement 2 more gtk dialogs: open file and open multiple files.estade@chromium.org2009-03-131-25/+138
| | | | | | | | | | | Test for single file dialog: - <html><body><input type=file></body></html> Test for multiple files dialog: - <html><body><input type=file multiple></body></html> Review URL: http://codereview.chromium.org/46024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11677 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1), 2nd attempt.finnur@chromium.org2009-03-132-0/+5
| | | | | | | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/46055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11672 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-131-0/+1
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11641.finnur@chromium.org2009-03-132-5/+0
| | | | | | | Reverting for now. Will try again later Review URL: http://codereview.chromium.org/46045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11646 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the look of the Linux omnibox.deanm@chromium.org2009-03-132-16/+39
| | | | | | | | | | | | | | | | - Paint a border around the input widget, which makes it fit better into the toolbar. A bordered widget is also very nice to have for debugging, so I abstracted a small helper for making a bordered bin. - Improve the results popup by painting with some Pango attributes. Sort of looks awful over NX, but I'm hoping it looks better on a real session. BUG=8236 Review URL: http://codereview.chromium.org/46035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11644 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing function to LocationBarViewGtk.finnur@chromium.org2009-03-132-0/+5
| | | | | | | | TBR=evanm Review URL: http://codereview.chromium.org/46038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11641 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some browser shutdown issues on Linux.deanm@chromium.org2009-03-132-8/+27
| | | | | | | | | | | | | The previous code ended up destroying the BrowserWindow (removing it from BrowserList) while BrowserList was in the middle of iterating. Push the deletion onto the message loop (using DeleteSoon) to emulate what I'm guessing happens on Windows (the message is queue instead of processed right away). This fixes a second bug involving re-entrancy issues with Close() and window_, we now make sure to set window_ to NULL before any events might fire. BUG=8712 Review URL: http://codereview.chromium.org/43135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11628 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk dialogs, first cut.estade@chromium.org2009-03-121-0/+182
| | | | | | | | Only the Save As file selection dialog is implemented for now. Review URL: http://codereview.chromium.org/42152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging.h from cc files that don't use it.thestig@chromium.org2009-03-122-2/+0
| | | | | | Review URL: http://codereview.chromium.org/42155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux build. we need to include basictypes.h to gettc@google.com2009-03-121-0/+1
| | | | | | | | | | | DISALLOW_COPY_AND_ASSIGN TBR=finnur Review URL: http://codereview.chromium.org/43140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11545 0039d316-1c4b-4281-b951-d872f2087c98
* Some work in refactoring FindBarWin/FindBarView sotc@google.com2009-03-124-28/+91
| | | | | | | | | | | we can share code across platforms. See http://code.google.com/p/chromium/wiki/FindBarRefactoring for more information about the design. Review URL: http://codereview.chromium.org/42057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98
* Add a GDK_COLOR_RGB macro for constructing GdkColors.deanm@chromium.org2009-03-121-2/+3
| | | | | | | | | This does the simple math of * 257 to map from a 1 byte component to the gint16 GdkColor values, and initializes the pixel field to 0. Review URL: http://codereview.chromium.org/43077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11526 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from scaffolding. Yay!pinkerton@chromium.org2009-03-111-3/+1
| | | | | | Review URL: http://codereview.chromium.org/43039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11435 0039d316-1c4b-4281-b951-d872f2087c98
* Add the show all downloads link to the download shelf on linux.estade@chromium.org2009-03-112-6/+85
| | | | | | Review URL: http://codereview.chromium.org/43053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11406 0039d316-1c4b-4281-b951-d872f2087c98