summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Gtk: theme certain close buttons:estade@chromium.org2009-12-023-0/+19
| | | | | | | | | | | | | | | | - download shelf - find bar - blocked popup container Notably, don't theme the infobar close button. In a follow up patch, I will fix the findbar and blocked popup container of Windows. BUG=29101 Review URL: http://codereview.chromium.org/454024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33600 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-022-0/+2
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't apply gtk theme to the info bubble for the extension popup.estade@chromium.org2009-12-025-5/+17
| | | | | | | | BUG=29096 Review URL: http://codereview.chromium.org/450043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33523 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Support plain text target as source for bookmark drags initiated from ↵estade@chromium.org2009-12-023-5/+15
| | | | | | | | | | | bookmark manager and bookmark bar. BUG=29029 TEST=drag a bookmark into an <input> field Review URL: http://codereview.chromium.org/449067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33522 0039d316-1c4b-4281-b951-d872f2087c98
* Windows/Linux: remove useless SetProfile() on tab selection.viettrungluu@chromium.org2009-12-021-1/+0
| | | | | | | | | | (We have a fixed profile per browser.) The Mac code never had this SetProfile(). BUG=none TEST=none Review URL: http://codereview.chromium.org/450038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33519 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add middle click and right click functionality to maximize button.estade@chromium.org2009-12-012-1/+36
| | | | | | | | | | | | If the user right clicks on the maximize button, it will horizontally maximize the window, and if the user middle clicks on the maximize button it will vertically maximize the window. At least on kde, the window manager supports more complicated behavior, e.g. right clicking on a window that is horizontally maximized will return it to its former size. It seems to keep track of multiple restored rects. However, we're not well equipped to replicate this behavior, so I just didn't add it. If the user wants it, they can disable the custom frame. BUG=28881 Review URL: http://codereview.chromium.org/455012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33389 0039d316-1c4b-4281-b951-d872f2087c98
* Linux cookies view: ui cleanups to match win.mattm@chromium.org2009-11-303-16/+87
| | | | | | | | | | | | | | | Show tree lines. Domains are collapsed by default and expanding them expands all their children Don't show the column header in the tree view anymore. BUG=27657 TEST=compare to win Review URL: http://codereview.chromium.org/444010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33373 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Adds back the ability to filter cookies by origin in the cookies ↵mattm@chromium.org2009-11-303-6/+273
| | | | | | | | | | | options view BUG=27657 TEST=unittest passes, manually testing typing "google" in the search field pulls up origins containing "google" in their name Review URL: http://codereview.chromium.org/437075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33359 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Dynamically adjust width of download item dangerous warning.estade@chromium.org2009-11-301-9/+13
| | | | | | | | BUG=28707 Review URL: http://codereview.chromium.org/456003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33355 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-308-0/+10
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-308-10/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the normal window's frame in maximized mode. See BUG for more detail. ↵oshima@chromium.org2009-11-301-11/+1
| | | | | | | | | | | Dan will investigate further when he has time. BUG=28580, 727 (chromeos) TEST=None Review URL: http://codereview.chromium.org/436039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33302 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-308-0/+10
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-253-11/+11
| | | | | | | | | | | | | | | | | | | (sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
* Fix page action spacing on Linux.mattm@chromium.org2009-11-241-4/+3
| | | | | | | | | | | Use the same constant for both Linux and Windows. BUG=28660 TEST=load extensions, compare spacing Review URL: http://codereview.chromium.org/440002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32977 0039d316-1c4b-4281-b951-d872f2087c98
* Update the sync menu item to change on Linux to reflect the current sync state.zork@chromium.org2009-11-242-0/+59
| | | | | | | | | BUG=28209 TEST=Enable sync and sign in. The "Sync my Bookmarks" label should now read "Bookmarks Synced..." Review URL: http://codereview.chromium.org/431032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32975 0039d316-1c4b-4281-b951-d872f2087c98
* Switch theme loading to use its own string.avi@google.com2009-11-241-2/+1
| | | | | | | | | BUG=http://crbug.com/24177 TEST=no visible change Review URL: http://codereview.chromium.org/361006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32934 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Create app modal dialogs in a different way to work around a KDE 3 ↵thestig@chromium.org2009-11-247-7/+15
| | | | | | | | | | window manager bug. While we're at it, change dialog's default size to match that of Chrome on Windows. BUG=28230 TEST=see bug Review URL: http://codereview.chromium.org/425016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32905 0039d316-1c4b-4281-b951-d872f2087c98
* page info dialog polish:estade@chromium.org2009-11-231-5/+5
| | | | | | | | | | | | | | GTK: - set default size of contents, rather than window as a whole---this gets line wrapping right. All: - change title string to Title Case instead of Sentence case - fix Connection text for mixed/unsafe content BUG=28507 Review URL: http://codereview.chromium.org/437026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32887 0039d316-1c4b-4281-b951-d872f2087c98
* Add platform abstraction for simple error box, and use it in a couple ↵estade@chromium.org2009-11-231-9/+0
| | | | | | | | | | | | extensions-related places. Also add a virtual destructor in some unrelated infobar. BUG=27691 Review URL: http://codereview.chromium.org/427002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32840 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Get rid of status bubble flicker.derat@chromium.org2009-11-222-2/+20
| | | | | | | | | | | | | | | | | | | | | The bubble was appearing in its default location when getting shown while the mouse was nearby; it would move to the correct location on the next motion event. I think that there's still a flicker in the wrong location when closing the download bar and then triggering the bubble, but the fix is non-obvious to me. It's possible that it's not noticeable on anything faster than the slow DSL line that I'm using to run Chrome remotely to test this. BUG=28494 TEST=repeated steps from bug and checked that download bar behavior doesn't appear to have regressed either Review URL: http://codereview.chromium.org/431007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32789 0039d316-1c4b-4281-b951-d872f2087c98
* posix: refactor duplicated path-handling codeevan@chromium.org2009-11-212-2/+2
| | | | | | | | | We had the same code in three headers, and an "if FREEBSD" in a _linux.cc file. Review URL: http://codereview.chromium.org/414063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32722 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced HungRendererDialog class with hung_renderer_dialog namespace.akalin@chromium.org2009-11-201-3/+6
| | | | | | | | | BUG= TEST=trybots Review URL: http://codereview.chromium.org/415006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32697 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't fail on startup with debug build.estade@chromium.org2009-11-201-2/+4
| | | | | | | | | | I thought the check would never fail, but I found out how to trigger it, so it turns out to be necessary after all. TBR=derat Review URL: http://codereview.chromium.org/421011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32658 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: don't occlude find bar with animating infobar.estade@chromium.org2009-11-201-2/+2
| | | | | | | | | BUG=none TEST=type g in location bar, press ctrl+f, wait for did you mean infobar. it should be below the findbar. Review URL: http://codereview.chromium.org/418005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32645 0039d316-1c4b-4281-b951-d872f2087c98
* Fix assert in sad_tab when requested width for message is < -1.kuan@chromium.org2009-11-201-2/+4
| | | | | | | | BUG=28270 TEST=verify per bug report. Review URL: http://codereview.chromium.org/414022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32595 0039d316-1c4b-4281-b951-d872f2087c98
* GTK bookmark manager polish.estade@chromium.org2009-11-201-6/+15
| | | | | | | | | | | | 1. on right tree view, deselect everything when user presses below lowest row. This is not native gtktreeview behavior, but it is used in windows and by nautilus via libegg, so it matches user expectations. 2. allow default left click handler to run on right tree view. This allows a left click below the lowest row to cause the tree view pane to take focus. 3. continue blocking empty drags. BUG=27869,27872 Review URL: http://codereview.chromium.org/417002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32585 0039d316-1c4b-4281-b951-d872f2087c98
* Set the label for a chrome link button when the text is set, not whentony@chromium.org2009-11-201-2/+14
| | | | | | | | | | | | the expose event fires. This avoids a relayout that happens when the label is set the first time the link is exposed. TEST=Put a breakpoint in gtk_chrome_link_button_expose and open the about dialog. You should hit the breakpoint twice, not four times. Review URL: http://codereview.chromium.org/411007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32579 0039d316-1c4b-4281-b951-d872f2087c98
* Undo my revert at r32524 due to a startup test regression.mpcomplete@chromium.org2009-11-201-1/+1
| | | | | | | | | | | | ExtensionHosts once again spawn extension processes asynchronously. However, if the process is already started, we now initialize the RenderView synchronously. This is so bug 28049 stays fixed. BUG=28049 Review URL: http://codereview.chromium.org/402101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32578 0039d316-1c4b-4281-b951-d872f2087c98
* Move Mac to using renderer spellchecker.estade@chromium.org2009-11-192-3/+5
| | | | | | | | BUG=25677 Review URL: http://codereview.chromium.org/395007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLs out of *.pak files and put them into code. This savestony@chromium.org2009-11-191-5/+14
| | | | | | | | | | 28k of pak file size, but will make the binary a tad bit larger. BUG=28174 Review URL: http://codereview.chromium.org/407007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32556 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Show page action popup bubbles.derat@chromium.org2009-11-191-9/+20
| | | | | | | | | | | | | | | | | Focus is a bit weird within these; I suspect that it's the same with the browser action bubbles. It looks like the same issue that the bookmark bubble had: the bubble grabs the pointer; when a widget within it (e.g. combobox) gets clicked it steals the grab; when it ungrabs it the grab is released instead of being transferred back to the bubble. Unsure of what the correct fix is for this. BUG=28061 TEST=installed two separate extensions with page action popups and clicked on their icons Review URL: http://codereview.chromium.org/412001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32547 0039d316-1c4b-4281-b951-d872f2087c98
* Revert old change that created an ExtensionHost's RenderView asynchronously.mpcomplete@chromium.org2009-11-191-1/+1
| | | | | | | | | | | | | With jam's recent change to spawn renderers from a background thread, ExtensionHost spawns processes asynchronously for free. Reverting this change also fixes a bug due to an extension popup closing before the next one can be created. BUG=28049 Review URL: http://codereview.chromium.org/399098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32524 0039d316-1c4b-4281-b951-d872f2087c98
* BookmarkManagerTest now passes without this hack.oshima@chromium.org2009-11-191-9/+0
| | | | | | | | | | | | I don't know exactly what's been changed thoguh. We're going to enable this in build/try bots soon so we can tell when this comes back. BUG=28046 TEST=browser_tests --gtest_filter=BookmarkManagerTest* should pass. Review URL: http://codereview.chromium.org/399104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32484 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add f11 for fullscreen menu item to wrench menu.estade@chromium.org2009-11-191-1/+2
| | | | | | | | BUG=28211 Review URL: http://codereview.chromium.org/399106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32476 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: correct coordinate calculation for floating bookmark bar background ↵estade@chromium.org2009-11-191-5/+5
| | | | | | | | | | | | | painting. I believe changes to the windowed-ness of the widgetry in the bookmark bar caused this. BUG=27769 TEST=works in both classic theme mode and gtk theme mode Review URL: http://codereview.chromium.org/399103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32463 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix popup menu positioning.estade@chromium.org2009-11-191-0/+8
| | | | | | | | | | Don't go off end of screen. push_in doesn't actually work as well as one might hope. BUG=27800 Review URL: http://codereview.chromium.org/408017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32449 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so you can't detach tabs on Chrome OS. It doesn't make sensesky@chromium.org2009-11-181-0/+11
| | | | | | | | | | | | | | given the current design and triggers a crash. I'm also effectively disabling DockInfo for ChromeOS as that triggers a crash. I don't believe we'll hit the code after my first change, but I'm going for completeness. BUG=none TEST=none Review URL: http://codereview.chromium.org/399083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32408 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for the bookmark sync error button on the bookmark bar to Linux.zork@chromium.org2009-11-182-1/+57
| | | | | | | | | BUG=none TEST=Change your password after logging into bookmark sync, then restart your browser. There should be a warning button on the bookmark bar now. Review URL: http://codereview.chromium.org/387054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32391 0039d316-1c4b-4281-b951-d872f2087c98
* Change the sync dialog to use the Html version on Linux.zork@chromium.org2009-11-182-184/+0
| | | | | | | | | BUG=none TEST=Run chrome with --enable-sync. While bookmark sync is disabled, click on Wrench Menu->Sync My Bookmarks Review URL: http://codereview.chromium.org/402059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32389 0039d316-1c4b-4281-b951-d872f2087c98
* This cl reimplements the entire "Aw Snap" page to use gtk widgets to layout ↵kuan@chromium.org2009-11-182-125/+156
| | | | | | | | | | and draw the icon, title, message and add new "Learn more" link; the old implementation used skia to do simple drawing, but couldn't be used for link, hence the rewrite. BUG=27211 TEST=Verify that "Aw Snap" page is displayed correctly, and new "Learn more" link shows up centralized beneath the message, and when window is resized bi-directionally, especially smaller to force wrapping of message. Review URL: http://codereview.chromium.org/385145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32365 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for ShowHtmlDialog() to Linux. This is modeled off the MacOS ↵zork@chromium.org2009-11-183-1/+296
| | | | | | | | | | | and Windows versions, except that it uses a gtk dialog and TabContentsContainerGtk to create the window. BUG=25260 TEST=Call ShowHTMLDialog() with a working dialog, such as the login dialog for Bookmark sync. Review URL: http://codereview.chromium.org/394011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32363 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix link button double free.estade@chromium.org2009-11-181-48/+28
| | | | | | | | | | | | | | | If set_normal_color was called while native_markup == normal_markup, then the string could be double freed. To fix this problem and prevent similar future mistakes, I made native_markup stdup normal_markup instead of just copying the pointer (the optimization wasn't worth the trickiness). Also, I cleaned up destruction logic. BUG=27855 TEST=tried every flavor of chrome link button: - classic theme - non classic theme - gtk theme - gtk theme system theme that has non-default link text color property Review URL: http://codereview.chromium.org/400009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32358 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for BookmarkManager Test Crash test.oshima@chromium.org2009-11-181-0/+10
| | | | | | | | | | | | | | | * Test was failing because the key events were sent even after the window has been destroyed. * Make sure browser window is closed before the end of test. Test fails in BookmarkBarView without this. I think this requires a fix on browser side. Filed a bug 28046. BUG=None Test=run browser_tests --gtest_filter=*Bookmark* Review URL: http://codereview.chromium.org/397034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32286 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanups for BrowserThemeProvider. Move the globaltony@chromium.org2009-11-171-0/+2
| | | | | | | | | | | | stl containers into helper functions to defer init and to ensure we only initialize once. Move some consts into the namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/399042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32214 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-178-65/+65
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* ViewIDTest.Basic fixoshima@chromium.org2009-11-171-2/+7
| | | | | | | | | | | FindBar has to be created before the test. BUG=26192 TEST=Run browser_tests Review URL: http://codereview.chromium.org/387060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32191 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at fixing white flash in switching between ntp and non-ntp.sky@chromium.org2009-11-171-17/+7
| | | | | | | | | | BUG=27898 TEST=make sure tab switching on chrome os doesn't result in any visual artifacts, especially when switching between ntp and non-ntp. Review URL: http://codereview.chromium.org/404005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32189 0039d316-1c4b-4281-b951-d872f2087c98
* Implement web app shortcuts natively per issue 25528xiyuan@chromium.org2009-11-172-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Implement a CreateApplicationShortcutView similar to the current Gears-based one; - Add a few profile prefs to persist user's last checked shortcut locations - Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications" in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls file_util code to creates shortcut on Windows; - Add Win7 taskbar pin/unpin support function to file_util; - Update TabContents to replace gears with new code; Note: - Gears dialog is modaless but this one is a modal dialog. - Gear's icon store is not migrated because gears icons could still be used by shortcuts created by gears and thus we could not delete them even after migration. And we are not using the local ico files in the dialog even if they exists. - New CreateApplicationShortcutView is included when TOOLKIT_VIEW is defined. However on platforms other than Windows, the actual CreateShortCut code is not implemented. Right now it calls ShellIntegration's CreateDesktopShort if OS_LINUX is defined and NOTREACHED() for other platforms. BUG=25528 TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7. Review URL: http://codereview.chromium.org/372012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32165 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes painting bug in switching between ntp and non-ntp pages. Withoutsky@chromium.org2009-11-171-0/+17
| | | | | | | | | | | | | | | this code the bookmark bar's widget gets sized to 1x1 for a layout/painting step and we get all sorts of painting artifacts. I don't understand why that happens, but forcing a layout fixes it. I've scoped this just to chrome os for now. BUG=27898 TEST=make sure tab switching on chrome os doesn't result in any visual artifacts, especially when switching between ntp and non-ntp. Review URL: http://codereview.chromium.org/397018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32152 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 12:36:01 +0000