summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Linux: Stack autocomplete popup window directly on top of the browser's ↵suzhe@chromium.org2009-10-151-20/+2
| | | | | | | | | | | toplevel window. BUG=19082 "Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM" TEST=Please refer to the bug report for how to test. Review URL: http://codereview.chromium.org/274046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29102 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r29095 (removes wrench integration foraa@chromium.org2009-10-151-2/+4
| | | | | | | | | | | | browser actions). Test failure was a fluke. I forgot that changing resources always makes the first bot run fail. TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29098 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r29095 (removes wrench integration foraa@chromium.org2009-10-151-4/+2
| | | | | | | | | browser actions). TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29097 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the implicit wrench menu items for browser actions.aa@chromium.org2009-10-151-2/+4
| | | | | | | | | | | Also, allow browser actions with no initial icons, and add some better tests. BUG=24379,24671 Review URL: http://codereview.chromium.org/276010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29095 0039d316-1c4b-4281-b951-d872f2087c98
* Update browser actions api to be like new design doc.aa@chromium.org2009-10-151-1/+7
| | | | | | | | | BUG=23879 TEST=Install sample gmail browser action sample. Review URL: http://codereview.chromium.org/264046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29068 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Prevent another Chrome instance when First Run UI is active.kuchhal@chromium.org2009-10-142-13/+21
| | | | | | | | | BUG=24485 TEST=On Ubuntu, delete 'First Run' file and launch Chrome to bring up First Run UI and then again launch Chrome which should not crash. Review URL: http://codereview.chromium.org/278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29007 0039d316-1c4b-4281-b951-d872f2087c98
* Make the multiple download request dialog an infobar.estade@chromium.org2009-10-142-149/+0
| | | | | | | | | | | | The icon is a placeholder until Glen makes a pretty one. BUG=24047 TEST=go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html allow, deny, closing infobar, and closing tab all work as expected Review URL: http://codereview.chromium.org/275011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29006 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-1413-17/+18
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* Port Browser Actions browsertest to linux.estade@chromium.org2009-10-142-0/+7
| | | | | | | | | BUG=23882 TEST=run it Review URL: http://codereview.chromium.org/274025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28941 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at fixing the bookmark bar instructional text color for GTK.pkasting@chromium.org2009-10-142-8/+23
| | | | | | | | BUG=23536 TEST=Open Chrome Linux w/a theme and no bookmarks, verify instructional text in bookmarks bar has correct color. Review URL: http://codereview.chromium.org/274034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28922 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-135-10/+8
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Update page action manifest parsing to match the new format.mpcomplete@chromium.org2009-10-131-1/+1
| | | | | | | | | | Preserves backwards compatability with the old manifest format. BUG=24635 Review URL: http://codereview.chromium.org/275007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28912 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Browser actions toolbar.estade@chromium.org2009-10-134-0/+280
| | | | | | | | | | | | | | We don't have html popups yet but clicking should work (e.g. print button works). TODO: port browser_action in proc browser test. TODO: badges BUG=23882 TEST=loaded gmail browser action extension, loaded print bookmark bar extension, loaded them both, unloaded, disabled, enabled, etc. Review URL: http://codereview.chromium.org/273025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28869 0039d316-1c4b-4281-b951-d872f2087c98
* Make the ThemeProvider methods const.pkasting@chromium.org2009-10-133-12/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28868 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up bookmark all tabs on linux.sky@chromium.org2009-10-137-37/+77
| | | | | | | | | | | | BUG=2935 TEST=Create two tabs, press control-shift-d. You should be presented with a dialog that lets you give a name to a folder. Change the name, press enter and make sure you get a bookmark folder populated with the urls of any open tabs. Review URL: http://codereview.chromium.org/268038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28788 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASCII strings for switch names.evan@chromium.org2009-10-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/270062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: avoid a hang brought on by an infinite size-allocate queue.estade@chromium.org2009-10-132-3/+17
| | | | | | | | | | | This is not the most satisfying fix imaginable. I'm not sure why we are getting size-allocate events where the visibility of the chevron has changed but our allocation is not yet updated. In principle I suppose it would be better not to call any function that might cause an allocation from within a size-allocate handler, but guaranteeing that is probably pretty hard. BUG=24470 TEST=repro steps no longer repro; also, verified that the early return line is actually being hit. Review URL: http://codereview.chromium.org/270078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28778 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Select a row in Languages table when the user delete an item.mattm@chromium.org2009-10-132-5/+19
| | | | | | | | | | | | This is to work in the same way as in Windows version. BUG=None TEST=add some languages, remove them, should work fine. Review URL: http://codereview.chromium.org/270013 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28775 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup for theme provider code, including:pkasting@chromium.org2009-10-133-16/+10
| | | | | | | | | | | | | | | | | | | | | * Use correct indentation/alignment in a number of places * Use early-return to avoid long code block indenting * Use for() instead of while() in cases where that's what the code is actually doing * Consistent naming for iterators ("foo_iter", "bar_iter" instead of sometimes that way and sometimes "found") * Use {} when needed, don't use when not * Do not use "else" after "return" * Shorten overly-verbose code * Pull some trivial functions into the header * Eliminate unused function * Use STLDeleteValues() helper where appropriate Some of this was originally in my patch that modified constness, but I've split it out to make that more sane. BUG=none TEST=none Review URL: http://codereview.chromium.org/272033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28771 0039d316-1c4b-4281-b951-d872f2087c98
* Converts some uses of native_view to native_window. This is necessitatedsky@chromium.org2009-10-127-16/+19
| | | | | | | | | | | | by wanting to parent bookmarkeditor to browserwindow, which returns a native_window. BUG=none TEST=none Review URL: http://codereview.chromium.org/270067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28728 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency cleanup in chrome/phajdan.jr@chromium.org2009-10-126-1/+6
| | | | | | | | | | | | - reduce header dependencies - remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h! TEST=none BUG=none Review URL: http://codereview.chromium.org/245011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-115-5/+5
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Move more ICU-dependent stuff from base into base/i18n. Some test stuff alsobrettw@chromium.org2009-10-091-1/+1
| | | | | | | | | | | | depended on this, so to make the DEPS work out, I made a new base/test directory where I moved the testing-related files into a new directory base/test. TEST=none BUG=none Review URL: http://codereview.chromium.org/266038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
* Just add a comment to explain some empty functions.tony@chromium.org2009-10-091-0/+6
| | | | | | Review URL: http://codereview.chromium.org/271028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28547 0039d316-1c4b-4281-b951-d872f2087c98
* Set size before realizing window in chrome os.davemoore@chromium.org2009-10-091-0/+4
| | | | | | | | Change to avoid race condition over size of popup windows in Chrome OS Review URL: http://codereview.chromium.org/261025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28504 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Prevent first-run bubble from getting clipped on high-DPI displays.derat@chromium.org2009-10-092-5/+11
| | | | | | | | | | | | | | | | | | Avoids setting the width of the contents vbox (so it can grow if the combined width of the two buttons exceeds the estimated width of the bubble's text) and fixes an issue where we were getting even-more-bogus estimates due to using an unrealized widget. Also adds a DCHECK() to catch future code that passes unrealized widgets to gtk_util::GetWidgetSizeFromResources() (I checked the existing calls to it and they all look fine). BUG=23367 TEST=tested first-run bubble on displays with various DPIs (75, 120, 200, etc.) Review URL: http://codereview.chromium.org/265023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28500 0039d316-1c4b-4281-b951-d872f2087c98
* * Add ctrl-shift-d to bookmark all tabs.pkasting@chromium.org2009-10-082-5/+5
| | | | | | | | | | | * Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything. * Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious. BUG=2935 TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs Review URL: http://codereview.chromium.org/266029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28480 0039d316-1c4b-4281-b951-d872f2087c98
* Add about:memory link to task manager.thakis@chromium.org2009-10-081-15/+1
| | | | | | | | | | | | | Since about:memory DCHECK()s atm, the link is not completely hooked up. In the xib, I've added a square button with height 14 and the new HyperlinkCell, contained in a GTMWidthBasedResizer or how it's called. I made sure the baseline of link on the left and button on the right is at the same height. BUG=17989,13156 TEST=Open MainMenu.xib, click "Enable" for view->dev->taskman. Build&run chrome. Task manager should contain link. Review URL: http://codereview.chromium.org/255018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28426 0039d316-1c4b-4281-b951-d872f2087c98
* Remove auto-open files from the download shelf on auto-open. This is the Gtk ↵thakis@chromium.org2009-10-081-0/+4
| | | | | | | | | | | version of r20787 / r28391. BUG=None, see http://codereview.chromium.org/268008 . TEST=download a theme, make sure that it doesn't stay in the download shelf. Review URL: http://codereview.chromium.org/262022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28417 0039d316-1c4b-4281-b951-d872f2087c98
* Renames browser/gtk/bookmark_context_menu tosky@chromium.org2009-10-089-646/+569
| | | | | | | | | | | | BoookmarkContextMenuGtk. I need to do this so that views/gtk can use both BookmarkContextMenu and BookmarkContextMenuGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/261013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28400 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove the concept of physical memory from the task manager.agl@chromium.org2009-10-071-19/+1
| | | | | | | | | | | | | | | Physical memory isn't a concept on Linux. We have private pages and proportional set size. This patch matches the task manager up with about:memory. 'Private memory' gets you the number of private pages and 'Shared memory' is the PSS (except on systems with old kernels that don't have PSS, where it'll be zero). http://codereview.chromium.org/242096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28337 0039d316-1c4b-4281-b951-d872f2087c98
* Loads local resources from current locale subtree if available, if not it ↵cira@chromium.org2009-10-072-2/+2
| | | | | | | | | | | | | | | | | falls back to extension subtree. We look for ext_root/foo/bar.js under ext_root/_locales/fr/foo/bar.js if current locale is fr. If there is no fr specific resource we load ext_root/foo/bar.js instead. Lots of small refactoring to replace FilePath with ExtensionResource. BUG=12131 TEST=See unittest for sample tree. Review URL: http://codereview.chromium.org/256022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28333 0039d316-1c4b-4281-b951-d872f2087c98
* Makes MainMenu a singleton and loaded 5 seconds after startup. This issky@chromium.org2009-10-071-0/+2
| | | | | | | | | | | | | done so that we can show the menu quickly. This is a hack. If the menu remains html we'll pull the html into Chrome and won't need this. This is just for a better prototype experience. BUG=24147 TEST=make sure the main menu still works. Review URL: http://codereview.chromium.org/271004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28321 0039d316-1c4b-4281-b951-d872f2087c98
* Move classes depending on Skia out of base/gfx and into app/gfx. Renamebrettw@chromium.org2009-10-0735-35/+35
| | | | | | | | | | native_theme to native_theme_win since its Windows-specific. BUG=none TEST=none Review URL: http://codereview.chromium.org/259047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28300 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the tab move animation when the custom frame is on. Previously,tony@chromium.org2009-10-071-2/+2
| | | | | | | | | | | | | | | | we were using the tab's y position which takes into account the custom frame padding. However, TabBounds is relative to the tabstrip origin so the we kept incrementing the y position by 15px at each step of the animation. Use the original tab bound y instead (matches code in the pin tab animation). TEST=open some tabs and use ctrl+shift+page{up,down} with the custom frame on. Review URL: http://codereview.chromium.org/269010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28298 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Improve info bubble placement.derat@chromium.org2009-10-075-78/+125
| | | | | | | | | | | | | | | | | | | | | Make InfoBubble's constructor take positions relative to the browser window's origin, rather than the absolute positions used by Views. Otherwise, we run into issues when the browser window is being moved while the bubble is created -- this is unlikely to happen for bookmark bubbles, but when the first run bubble is created, the browser window may or may not be in the final place that the window manager is going to put it. There was previously a 200 ms delay before opening the bubble, but that approach still fails sometimes when X is being forwarded over a network connection. This change makes us update the bubble's position as we receive ConfigureNotify events about its browser window. TEST=checked that first-run and bookmark bubbles are placed correctly in openbox, KDE, metacity, fluxbox, and ion3 Review URL: http://codereview.chromium.org/256068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28232 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix focus issues in bookmark bubble.derat@chromium.org2009-10-074-27/+70
| | | | | | | | | | | | | | | | I wasn't aware of it in my initial change that made us use override-redirect windows for InfoBubbleGtk, but clicking on the bookmark bubble's folder combobox steals InfoBubbleGtk's pointer and keyboard grabs, resulting in the other widgets in the window behaving as if they're inactive after the combobox's popup is closed. This somewhat hacky change makes us reinstall the bubble's grabs after the popup closes. TEST=clicked in and out of bookmark bubble's combobox and checked that text entry still behaves normally Review URL: http://codereview.chromium.org/260019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28218 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Draw bottom-aligned ntp themes on floating bookmark bar.estade@chromium.org2009-10-071-35/+28
| | | | | | | | | | | | | This is a simplified version of the windows code. There will be a follow-up patch to switch windows over to using this as well. I ran into some trouble calculating the correct size of the tab contents. Punting on that for now, filed http://crbug.com/23907 BUG=22836 TEST=Tested on klassen, candies, karim rashid, tiesto, ratchet and clank, and jeff coons themes. Review URL: http://codereview.chromium.org/255086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28215 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix minor slide animation bugs.estade@chromium.org2009-10-071-6/+6
| | | | | | | | | | | Following r27934, we might hit the code path for initial positioning *after* the AnimationProgressed positioning, causing the child widget not to show. BUG=23902 TEST=when you switch away from a tab that has an infobar, then switch back, you can see the infobar. Review URL: http://codereview.chromium.org/258038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28214 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make sure to delete any remaining dialogs when the SelectFileDialogImpl ↵estade@chromium.org2009-10-071-0/+11
| | | | | | | | | | | | | | | | | | | | | | object goes out of scope. The control flow was as follows: 1. user initiates a save page command 2. user initiates a second save page command 3. tab contents creates a SavePackage, shows dialog 4. tab contents gets second OnSavePage, deletes old SavePackage, which deletes its SelectFileDialogImpl 5. At this point two dialogs are visible. 6. User dismisses second dialog. 7. User dismisses first dialog, and calls us back with pointer to freed SelectFileDialogImpl. 8. Bad stuff. BUG=23817 TEST=I put a sleep in Browser::SavePage, then hit ctrl+s twice quickly. Only one dialog appeared. Review URL: http://codereview.chromium.org/243117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28213 0039d316-1c4b-4281-b951-d872f2087c98
* Add NULL-checks to render_view_host->view() to fix startup test crash.mpcomplete@chromium.org2009-10-071-1/+1
| | | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/258040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression with setting the toolstrip background.mpcomplete@chromium.org2009-10-062-1/+21
| | | | | | | | | BUG=23458 TEST=Load an extension with a toolstrip. The toolstrip's background should match the shelf's background for your theme. Review URL: http://codereview.chromium.org/243114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.erg@google.com2009-10-061-1/+1
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/246100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28077 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implements the special bookmark bar on NTP.erg@chromium.org2009-10-062-2/+2
| | | | | | | | | | | | | Based mostly on Ben's patch, but made it compile, work, and descoped moving the bookmark bar around the view heiarchy. XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view]. BUG=17625 Review URL: http://codereview.chromium.org/246034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Refactor some things so GTK doesn't touch the on disk image cache.erg@google.com2009-10-051-11/+17
| | | | | | | | | | Hopefully will solve crash. BUG=23588 Review URL: http://codereview.chromium.org/258020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28066 0039d316-1c4b-4281-b951-d872f2087c98
* Change flag "auto-spell-correct" to "experimental-spellchecker-features". I ↵sidchat@chromium.org2009-10-051-1/+1
| | | | | | | | | | will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use. BUG=none TEST=none Review URL: http://codereview.chromium.org/260006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28055 0039d316-1c4b-4281-b951-d872f2087c98
* Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage.pkasting@chromium.org2009-10-051-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/259050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28037 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTREACHED from the keyword editor dialog. To hit,tony@chromium.org2009-10-051-3/+2
| | | | | | | | open the keyword editor dialog and press enter. Review URL: http://codereview.chromium.org/259029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28028 0039d316-1c4b-4281-b951-d872f2087c98
* Task Manager: show right click context menu no matter where you click on the ↵estade@chromium.org2009-10-051-4/+0
| | | | | | | | | | task manager window. discoverability++ Review URL: http://codereview.chromium.org/203047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28005 0039d316-1c4b-4281-b951-d872f2087c98
* Linux build failure makes no sense. Try random fix.pkasting@chromium.org2009-10-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27950 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 13:24:54 +0000