summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Unbreak build.estade@chromium.org2009-04-221-1/+3
| | | | | | | | TBR=pinkerton Review URL: http://codereview.chromium.org/93037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14241 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid DCHECK in nine box during download shelf animation.estade@chromium.org2009-04-222-4/+9
| | | | | | | | | That DCHECK might be a little overzealous, but is probably useful for most situations, so I'm leaving it. TBR=tony Review URL: http://codereview.chromium.org/92036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14237 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a debugging change that was accidentally added to r14123.jhawkins@chromium.org2009-04-221-1/+0
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/88045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14222 0039d316-1c4b-4281-b951-d872f2087c98
* Add new item animation to download shelf.estade@chromium.org2009-04-226-15/+60
| | | | | | | | Also, fix duration and tween type for download shelf open animation. Review URL: http://codereview.chromium.org/88064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14220 0039d316-1c4b-4281-b951-d872f2087c98
* Merge BookmarkContextMenuGtk back into BookmarkContextMenu.erg@google.com2009-04-214-474/+5
| | | | | | Review URL: http://codereview.chromium.org/87038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14155 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak accelerators, and add ctrl+_ for zoom out.estade@chromium.org2009-04-211-1/+5
| | | | | | Review URL: http://codereview.chromium.org/87041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14133 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Properly escape download item label markup.estade@chromium.org2009-04-211-9/+10
| | | | | | | | BUG=10766 Review URL: http://codereview.chromium.org/88055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in the download shelf.estade@chromium.org2009-04-211-2/+5
| | | | | | | | | | Windows doesn't explicitly delete the DownloadItemView objects because the View destructor deletes child views automatically. BUG=10739 Review URL: http://codereview.chromium.org/88044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14131 0039d316-1c4b-4281-b951-d872f2087c98
* Fix #include (.h, not .cc).sgk@google.com2009-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/88050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14127 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up alt-d on linux.estade@chromium.org2009-04-211-2/+2
| | | | | | | | | | Also clean up some accelerators. BUG=10803 Review URL: http://codereview.chromium.org/90008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14123 0039d316-1c4b-4281-b951-d872f2087c98
* I missed this file in my last checkinestade@chromium.org2009-04-211-4/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14118 0039d316-1c4b-4281-b951-d872f2087c98
* Add open/close animations to infobar, download shelf.estade@chromium.org2009-04-216-48/+214
| | | | | | | | Animations are implemented by packing the native widget structure into a GtkFixed which resizes and moves its contents around based on AnimationDelegate callbacks. Review URL: http://codereview.chromium.org/88005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14116 0039d316-1c4b-4281-b951-d872f2087c98
* Handle a race between the remove tab animation resizing the closing tab and ↵jhawkins@chromium.org2009-04-211-1/+11
| | | | | | | | | the gtk mouse events. Fixes a crash where the hover index would become stale before a leave-notify event. BUG=10776 Review URL: http://codereview.chromium.org/88037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14115 0039d316-1c4b-4281-b951-d872f2087c98
* Rename web_contents_view* files to tab_contents_view* to reflect my previousbrettw@chromium.org2009-04-211-1/+1
| | | | | | | rename of the classes. Review URL: http://codereview.chromium.org/87009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14083 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to free any remaining tabs on tabstrip destruction. There are two ↵jhawkins@chromium.org2009-04-201-0/+10
| | | | | | | | cases where the remove tab animation is not used when closing tabs, and we were leaking these tabs in those cases. Review URL: http://codereview.chromium.org/87004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14066 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land my change to clean up TabContents/WebContents ownership. Thisbrettw@chromium.org2009-04-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | is the same except in tab_strip_model_unittest I fixed a leak by making a WebContents on the stack, I added a factory to the SiteInstance unittest to prevent another leak, and I re-added a NULL set to the external_tab_container. Fix the ownership model of TabContents and NavigationController. Previously the NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Previous review URL: http://codereview.chromium.org/69043 Review URL: http://codereview.chromium.org/67294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14053 0039d316-1c4b-4281-b951-d872f2087c98
* Better alignment of the omnibox edit entry.deanm@chromium.org2009-04-202-26/+87
| | | | | | | | | | | | | | - Let the GtkTextView size itself naturally. Have the AutocompleteEditViewGtk keep the GtkTextView vertically aligned (inside of a GtkAlignment). The non-used space of the alignment is "transparent" by virtue of the alignment not having a window, so the LocationBarView will paint the background. - Move the background color code to the location bar, and have the location custom paint the border and background color. Review URL: http://codereview.chromium.org/67263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14036 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14005.brettw@chromium.org2009-04-181-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ownership model of TabContents and NavigationController. Previously thebrettw@chromium.org2009-04-181-2/+2
| | | | | | | | | | | | | | | | | NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Review URL: http://codereview.chromium.org/69043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14005 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor NineBox to take 9 image ids instead of having to createtc@google.com2009-04-175-129/+103
| | | | | | | | | | | | | | the GdkPixbuf array and passing it into the constructor. This allows us to remove some resource_bundle.h includes. Clean up the style in gtk_chrome_button.cc. There was some C style and moved the globals to just static pointers. I verified with a debugger that we call gtk_chrome_button_class_init only once. Review URL: http://codereview.chromium.org/69025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13941 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to delete the tab when we remove it from the tab strip. Also ↵jhawkins@chromium.org2009-04-161-1/+5
| | | | | | | | removes a call to Layout that should be removed now that we have RemoveTabAnimation. Review URL: http://codereview.chromium.org/79029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13898 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the tab button logic into TabButtonGtk.jhawkins@chromium.org2009-04-168-300/+388
| | | | | | | * Modify the tabstrip input handling to match the new interface. Review URL: http://codereview.chromium.org/79025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13891 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit previous change with GYP files fixed.erg@google.com2009-04-1610-48/+570
| | | | | | | | | | | | | Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements. Also: - Fixes window dispositions (shift-click works on bookmark bar items). - Reorganizes gtk_utils Original Review URL: http://codereview.chromium.org/76002 Review URL: http://codereview.chromium.org/67223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13857 0039d316-1c4b-4281-b951-d872f2087c98
* Have ResourceBundle own GdkPixbufs.tc@google.com2009-04-169-92/+76
| | | | | | | | | | | | | | | | | This is the same as how ResourceBundle owns the SkBitmaps it loads. This should be faster than before because ResourceBundle will only load each bitmap once and cache the image. Also fix a memory leak in GdkPixbufFromSkBitmap. valgrind says we're not leaking here. BUG=9988 Review URL: http://codereview.chromium.org/67179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13847 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts the previous two commits. (r13812 and r13811).erg@google.com2009-04-1510-570/+48
| | | | | | Review URL: http://codereview.chromium.org/75023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13813 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BookmarkContextMenuGtk and hook it up to most bookmark bar elements.erg@google.com2009-04-1510-48/+570
| | | | | | | | | | Also: - Fixes window dispositions (shift-click works on bookmark bar items). - Reorganizes gtk_utils Review URL: http://codereview.chromium.org/76002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13811 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix yet another compile failurepkasting@chromium.org2009-04-151-7/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13770 0039d316-1c4b-4281-b951-d872f2087c98
* Change GTK Go button impl to match the changes I already made to the Windows ↵pkasting@chromium.org2009-04-152-43/+16
| | | | | | | | implementation. Review URL: http://codereview.chromium.org/67178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13767 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression I introduced where Stop/Go button would toggle state ↵pkasting@chromium.org2009-04-152-3/+3
| | | | | | | | | | | instantly instead of having protections against accidental user actions while the mouse was hovering the button. I elected to condense ChangeMode() and ScheduleChangeMode() into one function, which as a result became pretty simple. BUG=9843 Review URL: http://codereview.chromium.org/67156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13761 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify TabGtk::ContextMenuController by adding methods to dynamically ↵jhawkins@chromium.org2009-04-144-67/+63
| | | | | | | | build a MenuGtk and use them. Review URL: http://codereview.chromium.org/68013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13722 0039d316-1c4b-4281-b951-d872f2087c98
* Convert instances of WideToUTF8(l10n_util::GetString( totc@google.com2009-04-146-30/+28
| | | | | | | | | | | | l10n_util::GetStringUTF8 in the gtk code. This saves us some string conversions. BUG=9688 Review URL: http://codereview.chromium.org/73056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13719 0039d316-1c4b-4281-b951-d872f2087c98
* Implement context menu handling for the Linux tab strip.jhawkins@chromium.org2009-04-146-9/+152
| | | | | | Review URL: http://codereview.chromium.org/73053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13714 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extra zoom menu items.thestig@chromium.org2009-04-142-20/+19
| | | | | | Review URL: http://codereview.chromium.org/73023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13699 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Cocoa file picker.avi@google.com2009-04-141-4/+1
| | | | | | Review URL: http://codereview.chromium.org/73044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13695 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when the browser opens a popup window in Linux.jhawkins@chromium.org2009-04-141-0/+5
| | | | | | Review URL: http://codereview.chromium.org/73045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13679 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Ignore certain menu accelerators.estade@chromium.org2009-04-145-34/+47
| | | | | | Review URL: http://codereview.chromium.org/73003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13643 0039d316-1c4b-4281-b951-d872f2087c98
* Implement tooltips for the Go/Stop button in Linux.willchan@chromium.org2009-04-135-8/+48
| | | | | | | | BUG=9381 Review URL: http://codereview.chromium.org/67064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13618 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring; switch the |filter| parameter into something that is more ↵avi@chromium.org2009-04-121-14/+15
| | | | | | | | | | amenable to cross-platform implementation. BUG=9852 Review URL: http://codereview.chromium.org/63093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13573 0039d316-1c4b-4281-b951-d872f2087c98
* Enable zooming in on Linux.thestig@chromium.org2009-04-111-1/+9
| | | | | | Review URL: http://codereview.chromium.org/66068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13556 0039d316-1c4b-4281-b951-d872f2087c98
* Make linux link buttons pretty.estade@chromium.org2009-04-103-12/+64
| | | | | | | | | - set text to red while button is active - get rid of border spacing Review URL: http://codereview.chromium.org/66058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13545 0039d316-1c4b-4281-b951-d872f2087c98
* Use favicons in the bookmark bar under GTK.erg@google.com2009-04-102-11/+34
| | | | | | Review URL: http://codereview.chromium.org/66056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13543 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: implement link info bars (first cut).estade@chromium.org2009-04-101-12/+55
| | | | | | | | Also make GetIcon a function in InfoBarDelegate since all its inheritors have a function of that name, and putting it in InfoBarDelegate allows us to make InfoBar more generic. Review URL: http://codereview.chromium.org/66025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13526 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out MakeLinkButton into its own class.estade@chromium.org2009-04-104-60/+113
| | | | | | | This also gets rid of the event box, which means we can stick it in widgets that are custom painted. Review URL: http://codereview.chromium.org/66023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13525 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in NOTIMPLEMENTEDs in BookmarkBarGtk. Can now reorder bookmarks.erg@google.com2009-04-102-51/+198
| | | | | | Review URL: http://codereview.chromium.org/66022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc warnings when -Wall got re-enabled for Linux.willchan@chromium.org2009-04-104-13/+12
| | | | | | | | | | | | | | | browser/gtk/bookmark_bar_gtk.cc: In static member function 'static gboolean BookmarkBarGtk::OnToolbarDragLeave(GtkToolbar*, GdkDragContext*, guint, BookmarkBarGtk*)': browser/gtk/bookmark_bar_gtk.cc:372: warning: control reaches end of non-void function /usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h: In constructor 'TabRendererGtk::TabRendererGtk()': /usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h:241: warning: 'TabRendererGtk::loading_animation_' will be initialized after /usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h:238: warning: 'TabRendererGtk::CloseButtonState TabRendererGtk::close_button_state_' browser/gtk/tabs/tab_renderer_gtk.cc:139: warning: when initialized here browser/gtk/tabs/tab_strip_gtk.cc: In member function 'GdkRegion* NewTabButton::MakeRegionForButton() const': browser/gtk/tabs/tab_strip_gtk.cc:152: warning: unused variable 'h' Review URL: http://codereview.chromium.org/67038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13516 0039d316-1c4b-4281-b951-d872f2087c98
* Remove instances of the New Tab button images that are not being used anymore.jhawkins@chromium.org2009-04-102-8/+0
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/66027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13490 0039d316-1c4b-4281-b951-d872f2087c98
* Comment the unselected_width parameter to the newly-added LayoutNewTabButton ↵jhawkins@chromium.org2009-04-102-7/+9
| | | | | | | | | method. Also remove some c-style comments that slipped in. TBR=evan Review URL: http://codereview.chromium.org/66026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13489 0039d316-1c4b-4281-b951-d872f2087c98
* Add the New Tab button for Linux tabstrip.jhawkins@chromium.org2009-04-102-7/+248
| | | | | | Review URL: http://codereview.chromium.org/67025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13487 0039d316-1c4b-4281-b951-d872f2087c98
* Restore -Wall to Linux build and set up for -Werror.sgk@google.com2009-04-092-4/+1
| | | | | | | | | | | | | | | * Add -Wall to build/common.gypi (and -Werror, commented out for now). * Have build/external_code.gypi remove -Wall (and -Werror). * Remove chromium_code definition from build/all.gyp. * Remove chromium_code definitions from third_party/ *.gyp files. * Remove scons-specific -Werror removal in webkit.gyp. * Remove unused variables from: base/clipboard_linux.cc chrome/browser/gtk/download_shelf_gtk.cc chrome/browser/gtk/bookmark_bar_gtk.cc Review URL: http://codereview.chromium.org/66001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ctrl+tab/ctrl+shift+tab were not working if web contents did not have ↵tc@google.com2009-04-092-25/+43
| | | | | | | | | focus (e.g., location bar or find bar had focus). Refactor the special keypress handling so these accelerators work when gtk widgets have focus. Review URL: http://codereview.chromium.org/67011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13466 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 08:50:40 +0000