| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/113377
Patch from Matt Mueller <mattm@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
placed in third_party. All relevant skia changes (for all 3 platforms) have
been upstreamed.
Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp
(now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia
now requires C99 integer types, which MSVC doesn't support natively. I have put
typedefs in config/win/stdint.h.
Note that the new version of skia appears to render rects whose coordinates
are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There
were a couple obvious instances of this in the code which I fixed, but there may
be more.
There were ~35 layout test failures due to minor pixel differences which I
rebaselined on Windows and Linux, and 8 genuine failures related to masks and
stroked text, which I have put in text_expectations.txt and assigned to
myself. (There was another change which broke ~1700 tests on each platform,
but I put that change behind an #ifdef for now).
R=brettw
Review URL: http://codereview.chromium.org/65012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Refactors events so as a side effect, shift or control clicking a bookmark
menu item opens with the correct disposition.
- Moves away from use of MenuGtk, as this menu does just too much weird stuff
with events to use the general class.
Review URL: http://codereview.chromium.org/115270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Don't change focus in FindBarGtk::RestoreSavedFocus() unless the find bar has focus.
- Hide widgets in SlideAnimatorGtk when they aren't showing so they can't get focus.
- Add a check for null focus widget in TabContentsViewGtk::SaveFocus().
Review URL: http://codereview.chromium.org/115254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The keyboard accelerator still exists, but it's harmless (fires a
notimplemented).
BUG=11597
Review URL: http://codereview.chromium.org/115255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11191
TEST=Open Import Settings dialog from Chrome wrench menu on Linux and make sure it imports Firefox data as selected.
Review URL: http://codereview.chromium.org/115133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This makes the findbar look like the rest of the toolbar.
Review URL: http://codereview.chromium.org/113214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fixes a bug we've had for a long time drawing the wrench button. We would
over-tile the center portion, and draw the right images on top of it.
- Move away from x1 .. x2 parameters to more clear width and height.
- Makes the code significantly more straightforward and efficient.
Review URL: http://codereview.chromium.org/115181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Add ifdef for filepath init (there is probably a better way of doing this).
- Make Linux UI use active/inactive tabs instead of hover/OTR.
TBR=beng
Review URL: http://codereview.chromium.org/113180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
standard_layout to new locations in app/ and views/
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8604
Review URL: http://codereview.chromium.org/113166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Set focus to render view after finishing find.
- Make all custom buttons unfocusable. (matches windows chrome)
- Let the GtkWindow's default keyhandler run when the child widget fails to handle the key press event. Previously I optimized this out, but it turns out to be necessary because when a tab is pressed while focus is at the boundary of a child widget (e.g. the last button in an infobar) the focus has to traverse to the next child widget (e.g. the render view), and this is handled by the GtkWindow's key handler (and not the infobar's key handler).
BUG=8604,11560
Review URL: http://codereview.chromium.org/115113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11628
Review URL: http://codereview.chromium.org/113134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows view code and do the same thing.
BUG=11083
Review URL: http://codereview.chromium.org/115109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/112006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(As a side effect, this patch also fixes disabled items in the rest
of the bookmarks bar.)
Review URL: http://codereview.chromium.org/113119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handle the keypress.
Also, don't try to give the browser commands that are disabled.
----
(this description may need to be re-written)
BUG=11526
Review URL: http://codereview.chromium.org/113050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11472
Review URL: http://codereview.chromium.org/113109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10965
Review URL: http://codereview.chromium.org/115084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Allow the message to go multiline, and it will just clip if it can't fit.
Review URL: http://codereview.chromium.org/113099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a preparation for removing even more dependencies on views/
on Linux, but further parts are more complicated.
http://crbug.com/11066
Review URL: http://codereview.chromium.org/115078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11250
Review URL: http://codereview.chromium.org/114005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(It shouldn't be necessary to raise it when it's shown via SetDialogPosition().)
BUG=11515
Review URL: http://codereview.chromium.org/113055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Uses the NotificationRegistrar to notice TAB_CONTENTS_[DIS]CONNECTED events. When it disconnects, add a SadTabGtk to the TabContentsView. Delete it when the tab contents reconnects.
BUG=http://www.crbug.com/11081
TEST=Open http://about:crash. Verify that the sad tab renders properly. Navigate to another page to make sure the SadTabGtk is correctly replaced with a new RenderWidgetHostViewGtk.
Review URL: http://codereview.chromium.org/111003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that paths are remembered separately for save and open. This is *not* the same behavior as windows chrome/linux firefox, which remember the same path for both save and open. My justification is the following scenario:
1. User presses ctrl-o, and selects a file from the desktop.
2. One hour later, user presses ctrl-s to save a webpage.
3. User expects to be saving to his default download dir, but instead gets the desktop.
4. Huh?
Review URL: http://codereview.chromium.org/115007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/100198
Patch by Yusuke Sato.
Review URL: http://codereview.chromium.org/106007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Introduce a delegate to notify when the bubble is closed.
- Destroy the objects when the widgets are destroyed.
- Cleanup some style issues, add a bunch more comments.
Review URL: http://codereview.chromium.org/99276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
download icon.
INVALIDATE_FAVICON and INVALIDATE_TITLE become INVALIDATE_TAB. Also removed some dead code.
TEST=starting a download in a tab should show the download icon. Closing the dshelf should make the icon disappear.
Review URL: http://codereview.chromium.org/109050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- system bell for linux find bar when search not found
- move "not found" logic to find bar controller
Review URL: http://codereview.chromium.org/112002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
message_box_flags, os_exchange_data to src/app
http://crbug.com/11387
Review URL: http://codereview.chromium.org/115012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11476
Review URL: http://codereview.chromium.org/108037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/115010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/109043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11439
Review URL: http://codereview.chromium.org/108038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
removed.
BUG=11381
TEST=in opt mode: download something, go to downloads tab, clear all, go back to tab with downloaded item. The shelf should be gone.
Review URL: http://codereview.chromium.org/100366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/108035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
correct object. This change also adds an initial DraggedTabControllerGtk.
Review URL: http://codereview.chromium.org/99371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
when it's selected.
Review URL: http://codereview.chromium.org/109036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Since we set the background color, we can't go letting the theme choose the text color unless we want to potentially end up with white on yellow.
Review URL: http://codereview.chromium.org/108034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/109001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
beep if nothing was found on the page. The reason is
that it is gets called when you switch from one tab
to the other. I've added a function to FindBar that
the controller can call and each platform can
implement whatever sound they want to use.
BUG=10823
TEST=Open google.com, search for z0, it should beep
(no matches). Open new tab, switch back to the old
tab and it should not beep.
Review URL: http://codereview.chromium.org/99372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No changes to resource bundle yet, just the move to keep this CL as compact as possible.
Adds new vcproj and gyp file for app dir.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/100354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/106001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15262 0039d316-1c4b-4281-b951-d872f2087c98
|