summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Linux: Fix focus issues in bookmark bubble.derat@chromium.org2009-10-074-27/+70
| | | | | | | | | | | | | | | | I wasn't aware of it in my initial change that made us use override-redirect windows for InfoBubbleGtk, but clicking on the bookmark bubble's folder combobox steals InfoBubbleGtk's pointer and keyboard grabs, resulting in the other widgets in the window behaving as if they're inactive after the combobox's popup is closed. This somewhat hacky change makes us reinstall the bubble's grabs after the popup closes. TEST=clicked in and out of bookmark bubble's combobox and checked that text entry still behaves normally Review URL: http://codereview.chromium.org/260019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28218 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Draw bottom-aligned ntp themes on floating bookmark bar.estade@chromium.org2009-10-071-35/+28
| | | | | | | | | | | | | This is a simplified version of the windows code. There will be a follow-up patch to switch windows over to using this as well. I ran into some trouble calculating the correct size of the tab contents. Punting on that for now, filed http://crbug.com/23907 BUG=22836 TEST=Tested on klassen, candies, karim rashid, tiesto, ratchet and clank, and jeff coons themes. Review URL: http://codereview.chromium.org/255086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28215 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix minor slide animation bugs.estade@chromium.org2009-10-071-6/+6
| | | | | | | | | | | Following r27934, we might hit the code path for initial positioning *after* the AnimationProgressed positioning, causing the child widget not to show. BUG=23902 TEST=when you switch away from a tab that has an infobar, then switch back, you can see the infobar. Review URL: http://codereview.chromium.org/258038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28214 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make sure to delete any remaining dialogs when the SelectFileDialogImpl ↵estade@chromium.org2009-10-071-0/+11
| | | | | | | | | | | | | | | | | | | | | | object goes out of scope. The control flow was as follows: 1. user initiates a save page command 2. user initiates a second save page command 3. tab contents creates a SavePackage, shows dialog 4. tab contents gets second OnSavePage, deletes old SavePackage, which deletes its SelectFileDialogImpl 5. At this point two dialogs are visible. 6. User dismisses second dialog. 7. User dismisses first dialog, and calls us back with pointer to freed SelectFileDialogImpl. 8. Bad stuff. BUG=23817 TEST=I put a sleep in Browser::SavePage, then hit ctrl+s twice quickly. Only one dialog appeared. Review URL: http://codereview.chromium.org/243117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28213 0039d316-1c4b-4281-b951-d872f2087c98
* Add NULL-checks to render_view_host->view() to fix startup test crash.mpcomplete@chromium.org2009-10-071-1/+1
| | | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/258040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression with setting the toolstrip background.mpcomplete@chromium.org2009-10-062-1/+21
| | | | | | | | | BUG=23458 TEST=Load an extension with a toolstrip. The toolstrip's background should match the shelf's background for your theme. Review URL: http://codereview.chromium.org/243114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.erg@google.com2009-10-061-1/+1
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/246100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28077 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implements the special bookmark bar on NTP.erg@chromium.org2009-10-062-2/+2
| | | | | | | | | | | | | Based mostly on Ben's patch, but made it compile, work, and descoped moving the bookmark bar around the view heiarchy. XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view]. BUG=17625 Review URL: http://codereview.chromium.org/246034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Refactor some things so GTK doesn't touch the on disk image cache.erg@google.com2009-10-051-11/+17
| | | | | | | | | | Hopefully will solve crash. BUG=23588 Review URL: http://codereview.chromium.org/258020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28066 0039d316-1c4b-4281-b951-d872f2087c98
* Change flag "auto-spell-correct" to "experimental-spellchecker-features". I ↵sidchat@chromium.org2009-10-051-1/+1
| | | | | | | | | | will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use. BUG=none TEST=none Review URL: http://codereview.chromium.org/260006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28055 0039d316-1c4b-4281-b951-d872f2087c98
* Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage.pkasting@chromium.org2009-10-051-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/259050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28037 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTREACHED from the keyword editor dialog. To hit,tony@chromium.org2009-10-051-3/+2
| | | | | | | | open the keyword editor dialog and press enter. Review URL: http://codereview.chromium.org/259029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28028 0039d316-1c4b-4281-b951-d872f2087c98
* Task Manager: show right click context menu no matter where you click on the ↵estade@chromium.org2009-10-051-4/+0
| | | | | | | | | | task manager window. discoverability++ Review URL: http://codereview.chromium.org/203047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28005 0039d316-1c4b-4281-b951-d872f2087c98
* Linux build failure makes no sense. Try random fix.pkasting@chromium.org2009-10-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27950 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite chunks of the blocked popup container code:pkasting@chromium.org2009-10-031-18/+59
| | | | | | | | | | | | | | * Fix an off-by-one error in menu rendering if a renderer actually sent us kImpossibleNumberOfPopups. * Be clearer and stricter about item indexes and sanity checking. Hopefully, this or the previous item fix a crash we saw (no bug filed). * Add notice support (as much as exists for Windows) to GTK and Mac. * Make the implementations in the three platforms mirror each other a little more precisely. * Fix (expected, actual) mis-ordering in Mac unittest. BUG=none TEST=none Review URL: http://codereview.chromium.org/260005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27949 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: Update slide animation progress in a cleaner way.estade@chromium.org2009-10-032-22/+6
| | | | | | | | | BUG=none TEST=animations still work: infobar, findbar, download shelf Review URL: http://codereview.chromium.org/255071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27934 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-031-4/+5
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Set the default action of the import data dialog to "Import" andtony@chromium.org2009-10-021-0/+3
| | | | | | | | | | focus the button. BUG=19627 Review URL: http://codereview.chromium.org/259028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27916 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using radio buttons for toggling the custom frame. Usetony@chromium.org2009-10-023-23/+55
| | | | | | | | | | title case for the context menu on the title bar. BUG=23412 Review URL: http://codereview.chromium.org/255059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27896 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Restore the window that is hidden when the last tab is dragged out of ↵jhawkins@chromium.org2009-10-022-6/+21
| | | | | | | | | | the window. BUG=21002 TEST=Drag the last tab out of a window and press esc. The window should be restored. Review URL: http://codereview.chromium.org/257026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27853 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send tab switching/killing/creating keyboard accelerators to pages. ↵jam@chromium.org2009-10-022-13/+39
| | | | | | | | | | This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish. BUG=5496 TEST=added ui test Review URL: http://codereview.chromium.org/224023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27814 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Detach bookmark bar on NTP.estade@chromium.org2009-10-0110-71/+294
| | | | | | | | | | | | | | | | | | | TODO=get alignment right for NTP background when alignment != top TODO=fancy-pants animation (on windows this animation looks rather janky anyway so I'm not eager to work on this) TODO=tweak in gtk mode (border color=?) TEST=fiddle a lot, make sure there are no problems with find bar occlusion. TEST=install a bunch of different themes; everything looks right (up to TODOs) TEST=switch back and forth between gtk theme and chromium theme TEST=popup windows still work TEST=poked around in valgrind TEST=poked around with fullscreen BUG=18780 Review URL: http://codereview.chromium.org/243057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27801 0039d316-1c4b-4281-b951-d872f2087c98
* Update some strings in the options dialog w.r.t. themes.tony@chromium.org2009-10-011-1/+1
| | | | | | | | | | | Changed the heading from Themes: to Appearance: and switch from 'Set to XXX theme' to 'Use XXX theme'. BUG=21504 Review URL: http://codereview.chromium.org/243059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27783 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't hard code status bubble border.erg@google.com2009-10-011-8/+5
| | | | | | Review URL: http://codereview.chromium.org/255040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27744 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure download shelf items and download items don't share names.mhm@chromium.org2009-10-011-2/+2
| | | | | | | | | BUG=23046 TEST=Compiled and ran on Windows Review URL: http://codereview.chromium.org/242082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27696 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix memory leak from r27666.estade@chromium.org2009-09-304-3/+8
| | | | | | | | | | | Make MenuGtk take ownership of submenus. BUG=none TEST=valgrind doesn't complain Review URL: http://codereview.chromium.org/251053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27689 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement popup favicon menu.estade@chromium.org2009-09-306-69/+154
| | | | | | | | BUG=18181 Review URL: http://codereview.chromium.org/244029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27666 0039d316-1c4b-4281-b951-d872f2087c98
* Make the cache columns in the Task Manager sortable and only displayed once ↵pkasting@chromium.org2009-09-302-0/+37
| | | | | | | | | | per process on GTK and Mac, just like was already done on Windows. BUG=16221 TEST=Open Task Manager on GTK or Mac, add a WebCore Cache column, see that it only prints one line of output per process, and verify it's sortable. Review URL: http://codereview.chromium.org/251046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27657 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make InfoBubble use an override-redirect (popup) window.derat@chromium.org2009-09-306-98/+121
| | | | | | | | | | | | | This makes it work correctly in ion3 and other window managers that don't expect clients to try to move top-level windows themselves. This implementation grabs the pointer and keyboard. By doing this and using an override-redirect window, we should be able to avoid worrying about interactions with different window managers. The only downside (alluded to in the previous code) is that window manager keybindings don't make it through until the user dismisses the bubble by clicking outside of it or hitting Enter or Escape. I don't think this will be a problem; it's no different from what happens when you open a context menu in an app. BUG=20523 TEST=tested first-run and bookmark bubbles in Metacity, ion3, Fluxbox, KDE4, and the WM that I'm working on Review URL: http://codereview.chromium.org/198016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27578 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use a calculated border color in chrome theme mode instead of blue.erg@google.com2009-09-295-42/+26
| | | | | | Review URL: http://codereview.chromium.org/255012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27565 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix a bookmark dragging crasher by initing a member var.estade@chromium.org2009-09-291-0/+1
| | | | | | | | | | | Not sure when this regressed. Looking at the svn history I can't even find a revision where it would have worked. We probably made some other change that revealed this long-standing bug. BUG=23233 TEST=drag a bookmark out of a bookmark bar folder Review URL: http://codereview.chromium.org/255011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27550 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Raise window after click on titlebar or border.derat@chromium.org2009-09-291-0/+5
| | | | | | | | | BUG=23318 TEST=checked that it matches native window behavior in metacity and kwin Review URL: http://codereview.chromium.org/246029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27531 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up views on linux dialogs to use gtk ones.sky@chromium.org2009-09-294-4/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/254007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27484 0039d316-1c4b-4281-b951-d872f2087c98
* Directly add ExtensionShelfGtk to the widget hierarchy.tony@chromium.org2009-09-293-8/+6
| | | | | | | | | | | Just code cleanup. There's some more of this for the ExtensionShelfGtk::Toolstrip (adding removing the widgets from the hbox), but I kept that since the abstraction seems kind of useful. Review URL: http://codereview.chromium.org/242044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27438 0039d316-1c4b-4281-b951-d872f2087c98
* Retry r27137. Create renderers for ExtensionHosts one at a time to avoid ↵mpcomplete@chromium.org2009-09-281-1/+1
| | | | | | | | | | | | | | | blocking the UI. I added a process.Close() to the fast shutdown path for renderers. The problem was that we were trying to use an old terminated process handle. BUG=14040 TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading. Review URL: http://codereview.chromium.org/243007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27434 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable FindInPage automated ui test test.estade@chromium.org2009-09-281-2/+7
| | | | | | | | | BUG=none TEST=run it Review URL: http://codereview.chromium.org/243010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27423 0039d316-1c4b-4281-b951-d872f2087c98
* Use favicon for application shortcut icon.estade@chromium.org2009-09-282-7/+22
| | | | | | | | BUG=22528 Review URL: http://codereview.chromium.org/249023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27422 0039d316-1c4b-4281-b951-d872f2087c98
* Moving ContextualAction class to common/extensions and in the process ↵finnur@chromium.org2009-09-282-6/+6
| | | | | | | | | | | | | renaming it ExtensionAction. No code change. BUG=None TEST=Page actions and browser actions should work as before (no change) Review URL: http://codereview.chromium.org/242035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27406 0039d316-1c4b-4281-b951-d872f2087c98
* Pulls ActiveWindowWatcher into app so that we can use it insky@chromium.org2009-09-286-154/+68
| | | | | | | | | | | | | views. Converts from using notification server to observer as notification service is chrome only. Also changes the pointer type used by window_gtk to be a left arrow. BUG=none TEST=none Review URL: http://codereview.chromium.org/245016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27398 0039d316-1c4b-4281-b951-d872f2087c98
* Add columns to gtk task manager.thakis@chromium.org2009-09-281-1/+51
| | | | | | | | | BUG=16221 TEST=Open task man, right-click dialog, enable new columns (image size, script size, css size), surf around. Review URL: http://codereview.chromium.org/245018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27394 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS.erg@google.com2009-09-281-7/+19
| | | | | | | | | | GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors. BUG=23031 Review URL: http://codereview.chromium.org/248006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27368 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Browser Actions extensions.finnur@chromium.org2009-09-262-8/+10
| | | | | | | | | | | | | | | | Browser Actions are like Page Actions, except they appear next to the Omnibox and are always visible. For details see http://code.google.com/p/chromium/wiki/BrowserActions. Added a simple browser action sample that adds a Print button to the chrome toolbar (which brings up the Print dialog for the current page). Removed |type| from PageActions, which is currently ignored and was already removed from the docs. Each extension can only have 1 browser_action. Each browser action can specify more than one icon, but only the first is used. And no API has been added yet (besides the event definition). BUG=22099 TEST=Install the sample browser action, navigate to google.com, press the print button. A print dialog should come up. Review URL: http://codereview.chromium.org/243001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27319 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we get an extra resize event for background tabs.tony@chromium.org2009-09-251-0/+2
| | | | | | | | | | | | | | | | | | The TabContentsContainerGtk is a GtkFixed that contains a TabContentsViewGtk for each tab. We hide the background TCVG and only show the foreground TCVG. However, when the TCCG gets a resize event, we were still sending a set_size_request to all the background tabs. Since they were hidden, nothing happened except in the case described in issue 14114. It seems like this is a spurious resize by gtk, but not sending the resize request seems to work around it. BUG=14114 TEST=see bug Review URL: http://codereview.chromium.org/246012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27297 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add mutter to window frame whitelistevan@chromium.org2009-09-251-0/+1
| | | | | | | | | BUG=20381,23109 TEST=it compiles Review URL: http://codereview.chromium.org/235029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27285 0039d316-1c4b-4281-b951-d872f2087c98
* A change to make popups work correctly in the GTK build brokedavemoore@chromium.org2009-09-251-0/+6
| | | | | | | Chrome OS panels...this fixes them. Review URL: http://codereview.chromium.org/242011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27263 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: stop the window reconfigure debounce timer when a window is closed.mdm@chromium.org2009-09-251-0/+3
| | | | | | | | | BUG=23085 TEST=none Review URL: http://codereview.chromium.org/245010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27256 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add three simple unit tests to the bookmark bar.erg@google.com2009-09-256-14/+121
| | | | | | Review URL: http://codereview.chromium.org/249004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27251 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: work around browser windows that get stuck maximized by the WM.mdm@chromium.org2009-09-253-2/+17
| | | | | | | | | BUG=22807 TEST=none Review URL: http://codereview.chromium.org/218040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27247 0039d316-1c4b-4281-b951-d872f2087c98
* The shadow drawn by the browser window was being drawn over bydavemoore@chromium.org2009-09-251-6/+6
| | | | | | | the status area view. Review URL: http://codereview.chromium.org/249002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27243 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unnecessary vbox from the widget hierarchy.tony@chromium.org2009-09-252-35/+31
| | | | | | | | | | | | | | | | | | | | | Previously, it was: vbox (window_vbox) ..eventbox ..vbox (content_vbox_) ....eventbox ....eventbox ....eventbox ....eventbox I removed content_vbox_ and just put everything into the window vbox. There was no padding, so it's pretty straight forward. Some points for drawing the custom frame border were taken relative to content_vbox_, so those points are adjusted. Review URL: http://codereview.chromium.org/239007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27238 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 04:08:08 +0000