| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do as much as possible server side.
I suspect the main factors that made our previous implementation slow were blitting from client to server, several unnecessary copies of the entire image, and doing an in-memory rgba->bgra swap.
Now, even in debug mode with a 30" chrome window, the performance is very fast.
BUG=16257,15869
TEST=drag a tab out of the tabstrip, with and without compositing
Review URL: http://codereview.chromium.org/155321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
appears that some times Layout isn't invoked on initial size, so that
positioning the tab overview button only during Layout isn't enough.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't handle inline HTML in the item description (it just
dumps it as text) and the feed needs to be valid XML for it
to show any preview, but it is better than nothing. We can
easily change it to display the HTML but we want to (at some
point) try to use a separate origin so that we can render
the HTML code from untrusted sources safely.
Also fix a bug in the image tracker. It should not try
to communicate with the view if the view has gone away
(which was the whole point of the image tracker...)
BUG=None
TEST=Install the extension, browse to a page with a feed
and click onthe rss icon in the Omnibox. An interstitial
page should appear with a preview of the feed.
Review URL: http://codereview.chromium.org/155180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
canvas.
BUG=15869
TEST=Drag a tab out of the Linux tab strip. There should be a light-blue border around the dragged tab contents.
Review URL: http://codereview.chromium.org/155317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window manager says the window isn't active.
ActiveWindowWatcher listens for X events and notifies the browser
windows when the active window changes. We can't just use focus
events because popup menus cause browser windows to lose focus,
but it's still the "active" window.
Some window managers don't track active window, in which case we
don't get the x event and we just say that all windows are
active (our current behavior).
BUG=14649
Review URL: http://codereview.chromium.org/155303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some engines (clearlooks) query the bg color of a widget directly, so wrap the toolbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through.
http://crbug.com/13967
Review URL: http://codereview.chromium.org/155310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
looking for the top-left origin of the tab strip in screen coordinates, but we sent in the coordinates of this point relative to the entire window to gtk_util::ConvertWidgetPointToScreen.
BUG=15867
TEST=Open enough tabs so that they must be resized. Repeatedly press the mouse over a close button so that many tabs are closed. The tabs should not resize until the mouse leaves the tab strip.
Review URL: http://codereview.chromium.org/155308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=1316
Review URL: http://codereview.chromium.org/155053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crasher I ran into when testing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Run UI. Also enable it for Chromium builds.
Review URL: http://codereview.chromium.org/149348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window when this accelerator is activated.
BUG=11392
TEST=Open the task manager in Linux Chrome. Press ctrl-w. The task manager should close.
Review URL: http://codereview.chromium.org/149363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure chrome buttons have no child displacement (so the contents don't jiggle when you press them).
BUG=none
TEST=do a click on a folder, click away, make sure the button always looks as you'd expect
Review URL: http://codereview.chromium.org/149355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only use the KWin hack when the custom frame is enabled.
This is still a bit buggy in KWin (toggling from custom frame -> system
decorations doesn't always re-attach system decorations), but it seems
like the best I can do.
Review URL: http://codereview.chromium.org/155248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is only half of the bug fix. We also should match windows in that a drag held over a folder for more than a second or so shows the folder's contents and allows the user to continue the drag into the folder.
Also, it's kind of hard to use this new feature since the bookmark items float around when you are dragging out of the same bookmark bar you're dragging into, but the fix for that would be separate (and would require some design decisions).
BUG=14222
TEST=drag single or multiple bookmarks onto a bookmark bar folder
Review URL: http://codereview.chromium.org/149307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still are a bunch of more complicated behavior that doesn't work, like hitting
backspace to remove the keyword. The keyword hint and keyword display more or
less work, although things have gotten pretty complicated.
BUG=10965
TEST=Tab to search with a keyword.
Review URL: http://codereview.chromium.org/151209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=drag a bookmark into the webview or onto another program such as konqueror. The right thing should happen.
Review URL: http://codereview.chromium.org/149301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/13967
Review URL: http://codereview.chromium.org/155183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Allow keyboard and mouse navigation between the two while one is open.
BUG=none
TEST=the page and wrench menus feel like a native menubar
Review URL: http://codereview.chromium.org/155164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
frame around it.
BUG=16094
TEST=Open the task manager in Linux. Make sure the task manager treeview has a frame around it.
Review URL: http://codereview.chromium.org/149286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
removed when we maximize/go full screen.
BUG=15317
Review URL: http://codereview.chromium.org/155169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=Open popuptest.com in one tab and anything else in another. Switch between
GTK theme and normal. Theme of blocked popup container should change, even when
not the active tab.
http://crbug.com/13967
Review URL: http://codereview.chromium.org/149277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/13967
Review URL: http://codereview.chromium.org/149259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/13967
Review URL: http://codereview.chromium.org/155108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
manager treeview.
BUG=11392
TEST=Open the task manager and double click different processes. Those tabs should be activated.
Review URL: http://codereview.chromium.org/155098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Chrome still doesn't run.
Review URL: http://codereview.chromium.org/155026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15897
TEST=get Glen to look at it
Review URL: http://codereview.chromium.org/155040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15874
TEST=looks good
Review URL: http://codereview.chromium.org/155041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11392
TEST=none
Review URL: http://codereview.chromium.org/155027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15500
TEST=select an image in a file chooser
Review URL: http://codereview.chromium.org/151100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
height = 29 matches windows constant
padding between bookmark name and favico: I couldn't find a relevant constant in the windows code, so I experimentally matched the spacing between the two, for the same bookmark on linux and windows.
BUG=http://crbug.com/15882
TEST=look at bookmark bar
Review URL: http://codereview.chromium.org/155019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=edit the name of a folder; it should update in the left pane. Add a new bookmark URL; it should show up selected in the right pane. Also, see bug
BUG=http://crbug.com/15844
Review URL: http://codereview.chromium.org/149151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15859
TEST=see bug
Review URL: http://codereview.chromium.org/155008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 118358.
A lot of stuff works:
- Colors are picked out of the GTK theme.
- Buttons use the current GTK button theme.
- We use the user's icon theme.
A lot of stuff doesn't:
- We could do a better job of picking colors for the skylines.
- The omnibox hasn't been touched.
- UI that's not part of the toolbar hasn't been touched.
- We currently fail on themes like HighContrastInverse.
TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff.
TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images.
http://crbug.com/13967
Review URL: http://codereview.chromium.org/150176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/1455
Review URL: http://codereview.chromium.org/149156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15853
TEST=none
Review URL: http://codereview.chromium.org/155004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Columns are resizable.
* Resource icon displayed by resource name.
BUG=11392
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
abridged in the standard width.
BUG= http://crbug.com/1455
TEST= Mouse over a link which is abridged in the status bubble. Hover for 2 seconds. Link should expand to show as much as possible without extending out of the view in which it is contained.
Review URL: http://codereview.chromium.org/146043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=look at an infobar
BUG=none
Review URL: http://codereview.chromium.org/151162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested as follows:
Create a new window with two tabs. Type a bunch of 'a' characters into tab A's omnibox and a bunch of 'b's into tab B. Then,
1. Select tab A. Left-click in the omnibox and highlight a few characters in the middle. Left-click in the empty space to the right of the text to unhighlight it, then middle-click to make sure that the previously-highlighted text still gets pasted.
2. Repeat 1, but hit a key to remove the selection instead of clicking the mouse. The old highlighted text should still be available as the primary selection.
3. Highlight A's text as in 1. Select tab B and see that the omnibox is updated to B's string and highlighting is removed. Middle-click and confirm that the previously-highlighted text from A is pasted.
4. Select A and left-click in the middle of its string to position the cursor there. Click on tab B and then back on A to check that A's cursor position is restored.
5. Highlight text in A. Select tab B and then highlight text from a different window. Switch back to A and middle-click. The text from the different window, rather than A's previously-highlighted text, should be pasted.
BUG=9225
Review URL: http://codereview.chromium.org/151006
Patch from Dan Erat <derat@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19770 0039d316-1c4b-4281-b951-d872f2087c98
|