summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Begin work on extension shelf for Linux.phajdan.jr@chromium.org2009-07-174-1/+251
| | | | | | | | | | | For now it displays only a placeholder text, but knows when to display (it's connected to the ExtensionShelfModel). TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/159019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21014 0039d316-1c4b-4281-b951-d872f2087c98
* Do not block all task manager tree view mouse release events.estade@chromium.org2009-07-171-4/+2
| | | | | | | | | BUG=16974 TEST=you can resize rows of the task manager Review URL: http://codereview.chromium.org/155670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21006 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the Cancel button to Close in gtk Clear Browsing Data.mattm@chromium.org2009-07-171-1/+1
| | | | | | | | | BUG=16955 TEST=Open Clear Browsing Data dialog. The button should now say Close. Review URL: http://codereview.chromium.org/159023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20994 0039d316-1c4b-4281-b951-d872f2087c98
* Fix same crashy assumption that I fixed in r20967 later on in normal theme mode.erg@google.com2009-07-171-3/+6
| | | | | | Review URL: http://codereview.chromium.org/155709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20991 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the width of pinned tabs to be slightly bigger.sky@chromium.org2009-07-172-22/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20985 0039d316-1c4b-4281-b951-d872f2087c98
* This matches the behavior on Windows. Also this change lets user close ↵kuchhal@chromium.org2009-07-172-0/+15
| | | | | | | | | | | Chrome by clicking 'x' button even if a popup (for example - bookmark bubble) is open. BUG=NONE TEST=1. Click on bookmark star button to open bookmark bubble. Switch focus to some other Window, bubble should close automatically. 2. Click on bookmark star button to open bookmark bubble. Close chrome by clicking on Window close button ('x') and Chrome should close. Review URL: http://codereview.chromium.org/149757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20977 0039d316-1c4b-4281-b951-d872f2087c98
* Need to cleanup first run dialog on cancellation too.kuchhal@chromium.org2009-07-171-3/+4
| | | | | | | | Fixing what r20898 broke. Review URL: http://codereview.chromium.org/155676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20973 0039d316-1c4b-4281-b951-d872f2087c98
* Fix occasional crash at startup in gtk_chrome_button_expose.erg@google.com2009-07-171-2/+3
| | | | | | Review URL: http://codereview.chromium.org/155697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20967 0039d316-1c4b-4281-b951-d872f2087c98
* Set window icon on task manager.estade@chromium.org2009-07-171-0/+1
| | | | | | | | | | patch by <joel.stan@gmail.com> original review url: http://codereview.chromium.org/155677 Review URL: http://codereview.chromium.org/149797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20942 0039d316-1c4b-4281-b951-d872f2087c98
* forgot a file (or rather gcl was hiding it in another cl)estade@chromium.org2009-07-171-10/+3
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/149787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20929 0039d316-1c4b-4281-b951-d872f2087c98
* Set window icon on options dialog, bookmark manager.estade@chromium.org2009-07-173-3/+2
| | | | | | | | | BUG=16951 TEST=launch bookmark manager on gnome/metacity, observe that window has icon Review URL: http://codereview.chromium.org/155672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20928 0039d316-1c4b-4281-b951-d872f2087c98
* Allow dragging a link from the web contents to the bookmark bar to get a ↵estade@chromium.org2009-07-1710-75/+128
| | | | | | | | | | | | | named bookmark. Also, change the naming scheme of the DnD targets. BUG=16791 TEST=select a link in the web page and drag it to the bookmark bar. Review URL: http://codereview.chromium.org/155661 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux unit tests by checking for NULL that's impossible in real code, ↵erg@google.com2009-07-161-2/+2
| | | | | | | | | | but needed in unit tests. TBR=willchan Review URL: http://codereview.chromium.org/155663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20917 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Make the location bar area look native.erg@google.com2009-07-167-36/+214
| | | | | | | | | | | | | | | | | Replace the star and go buttons with a native looking thing, where we manually draw the theme's button image for the full omnibox area and then position the star/go buttons on top of that. Also adds stand in versions of star_noborder and starred_noborder until Glen can make real icons. http://crbug.com/16227 http://crbug.com/13967 http://crbug.com/16915 Review URL: http://codereview.chromium.org/149681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20914 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix bookmark manager crash on startup introduced by r20565estade@chromium.org2009-07-162-9/+11
| | | | | | | TBR=munjal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20899 0039d316-1c4b-4281-b951-d872f2087c98
* Show progress Window when importing profile from First Run dialog.kuchhal@chromium.org2009-07-162-5/+23
| | | | | | Review URL: http://codereview.chromium.org/149766 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20898 0039d316-1c4b-4281-b951-d872f2087c98
* Select correct default folder in bookmark editor gtk.estade@chromium.org2009-07-161-1/+1
| | | | | | | | | BUG=none TEST=right click in a dropdown from a folder on the bookmark bar, select add, you should see that the correct folder is seleted in the bookmark editor tree view. Add a bookmark, it should show up in the right place. Review URL: http://codereview.chromium.org/149725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20897 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Handle RTL layout when rendering the dragged tab.jhawkins@chromium.org2009-07-161-2/+5
| | | | | | | | BUG=none TEST=Drag a tab out of the browser in a RTL language. The tab should be rendered on the right side of the container. Review URL: http://codereview.chromium.org/155643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20890 0039d316-1c4b-4281-b951-d872f2087c98
* Work on RTL / BiDi Omnibox.deanm@chromium.org2009-07-165-15/+23
| | | | | | | | | Based on work from Evan Stade. Review URL: http://codereview.chromium.org/155567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20862 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Initial commit with docked devtools window support on Linux.pfeldman@chromium.org2009-07-164-13/+55
| | | | | | Review URL: http://codereview.chromium.org/149675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20861 0039d316-1c4b-4281-b951-d872f2087c98
* Implement gtk download options section.mattm@chromium.org2009-07-161-2/+165
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/155617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20848 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Tint throbbers like we tint all other buttons in the interface.erg@google.com2009-07-158-50/+105
| | | | | | | | | | | | | | Relanding with fixes for unit tests. Run through trybot this time... http://crbug.com/13967 Original Review URL: http://codereview.chromium.org/155588 TBR=estade Review URL: http://codereview.chromium.org/155601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20809 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel icon load requests when we are getting shutdown.estade@chromium.org2009-07-151-0/+1
| | | | | | | | | | | | | Hopefully this will fix the download test flakiness. I was able to reproduce the crash manually by just mass-clicking on the same download link many times (thanks to DotA for improving my APM). With this patch I am no longer able to repro. BUG=14746,14745,15244,15416 TEST=download tests stop flaking out Review URL: http://codereview.chromium.org/149712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20807 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK Themes: Tint throbbers like we tint all other buttons in the ↵erg@google.com2009-07-157-78/+41
| | | | | | | | | | | | interface." This reverts commit 3dfa509662e99282b5212490bfe19b32da357741 (r20799). TBR=estade Review URL: http://codereview.chromium.org/155598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20802 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Tint throbbers like we tint all other buttons in the interface.erg@google.com2009-07-157-41/+78
| | | | | | | | http://crbug.com/13967 Review URL: http://codereview.chromium.org/155588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20799 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: evan@chromium.orgmattm@chromium.org2009-07-151-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20798 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in "web content" section in "user data" options.mattm@chromium.org2009-07-153-5/+47
| | | | | | | | | BUG=11507 TEST=open options -> user data. Click the configure fonts button. Font configuration dialog should appear. Review URL: http://codereview.chromium.org/157002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20797 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ResolveMetricsReportingEnabled logic to OptionsUtil, make gtk ↵mattm@chromium.org2009-07-151-5/+54
| | | | | | | | | | | | | | | options use it. Only show the reporting checkbox in Google Chrome builds. Show the restart required message box when changing the reporting setting. BUG=11507 TEST=on Chromium build, option should not show up. On Google Chrome build in should show up, and enable both crash reporting and metrics settings. Review URL: http://codereview.chromium.org/149665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20796 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Remove two calls to Update that are unnecessary. When we layout the ↵jhawkins@chromium.org2009-07-151-2/+0
| | | | | | | | | | dragged tab, gtk will emit an expose-event signal for us if the widget changes size. BUG=none TEST=Drag a tab out of the browser. The tab should be sized and shown properly. Review URL: http://codereview.chromium.org/149703 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20791 0039d316-1c4b-4281-b951-d872f2087c98
* Add more browser tests for Task Manager.phajdan.jr@chromium.org2009-07-151-1/+2
| | | | | | | | | TEST=Covered by browser_tests. http://crbug.com/12127 Review URL: http://codereview.chromium.org/155433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20786 0039d316-1c4b-4281-b951-d872f2087c98
* Make more things clickable in the bookmark bar menus:estade@chromium.org2009-07-151-4/+16
| | | | | | | | | | | | | | - folder within a folder - "empty" menu item Note that it can be hard to click on a folder within a folder since hovering over the folder pops up a submenu that grabs focus, so you end up needing to right click twice. It's a little odd but the hackery required to fix it doesn't seem worth it. BUG=15886 TEST=right click on an empty menu item Review URL: http://codereview.chromium.org/155586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20785 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Handle RTL layout when positioning the tab strip drop arrow.jhawkins@chromium.org2009-07-151-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149695 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20778 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Inactive title bars should follow the bg insensitive color.erg@google.com2009-07-151-6/+13
| | | | | | | | | | This solves the inactive skyline color often being laughably bad. It does show that we may want to draw the line between the skyline and toolbar for best visual effect, though... Review URL: http://codereview.chromium.org/149693 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20774 0039d316-1c4b-4281-b951-d872f2087c98
* First run bubble polish:estade@chromium.org2009-07-156-12/+38
| | | | | | | | | | | | | | | - improve spacing and and sizing, both internally and externally (using windows as the guide) - make legible for dark themes - make show delay longer because it was too short on my machine (at least when using a Debug build). Also explicitly set bookmark bubble labels black. BUG=16782 TEST=none Review URL: http://codereview.chromium.org/149664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20762 0039d316-1c4b-4281-b951-d872f2087c98
* Set the prefs::kMetricsReportingEnabled value in the gtk first run dialog.mattm@chromium.org2009-07-151-1/+9
| | | | | | | | | BUG=11971 TEST=Build Google Chrome version, run with --user-data-dir pointing to empty directory, select to report crashes, open options user data page, check that the checkbox for reporting is actually checked. Review URL: http://codereview.chromium.org/149666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20752 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155428 for Thiago, which changessky@chromium.org2009-07-155-15/+8
| | | | | | | | | | | | | | from me to get the thing to work. Merging two versions of BookmarkNodeRemoved into one. BUG=None TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure everything works ok. Review URL: http://codereview.chromium.org/155572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
* Use tinted icons for menu buttons.tc@google.com2009-07-153-11/+33
| | | | | | | | | | Add a notification registrar for theme changes to the browser toolbar and update the images when the theme changes. Review URL: http://codereview.chromium.org/155473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20736 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r20667, which broke dropdown menus.estade@chromium.org2009-07-153-18/+6
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/155557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20717 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so that if you drag a tab to the left edge of the tab stripsky@chromium.org2009-07-152-10/+76
| | | | | | | | | | | | and hold the mouse for a little bit, the tab is pinned. BUG=16634 TEST=on linux with no tabs pinned drag until your close to the right edge of the tab and wait a second. The tab should be pinned. Review URL: http://codereview.chromium.org/155543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20711 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to set transparency on pixbufs that don't have any transparency ↵estade@chromium.org2009-07-151-2/+12
| | | | | | | | | | | | | | | channel. Also add DCHECK to make sure the assumption rowstride >= width * 4 is true. The reason this didn't cause any crashes or graphical corruption is because the non-transparent images don't have any white in them (luckily we are not making a browser for an ipod). BUG=16749 TEST=valgrind the browser, open find bar Review URL: http://codereview.chromium.org/155547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20701 0039d316-1c4b-4281-b951-d872f2087c98
* Make DownloadShelf a pure interface.estade@chromium.org2009-07-142-2/+6
| | | | | | | | | http://crbug.com/15474 TEST=none Review URL: http://codereview.chromium.org/149594 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20668 0039d316-1c4b-4281-b951-d872f2087c98
* Make GTK file dialog box modal for parent window, instead of for the entireestade@chromium.org2009-07-143-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | application. This works by adding the GtkWindow in BrowserWindowGtk to its own GtkWindowGroup and adding the SelectFile dialog to the same group. The following call to gtk_grab_add(...) makes the SelectFile dialog modal, but only to the windows within the same group. Similarly, the bookmark manager window is also added to its own unique GtkWindowGroup, so the import/export dialogs behave correctly. If I'm understanding things correctly, the GtkWindowGroup objects are reference counted once the have windows attached to them, and will delete themselves after all references to them are destroyed. I'm not sure how to verify this. Test: - Open two new chrome window: A and B - Open "Save file as..." dialog in window A - Verify that window A does not respond to keyboard or mouse events. - Verify that window B does responde to keyboard and mouse events. - Open "Save file as..." dialog in window B - Verify that window B does not respond to keyboard or mouse events. - Cancel dialog on window A. - Verify that window A starts responding to keyboard and mouse events. - Cancel dialog on window B. - Verify that window B starts responding to keyboard and mouse events. BUG=8727 patch by Mohit Muthanna <mmuthanna@google.com> original review URL: http://codereview.chromium.org/149548 Review URL: http://codereview.chromium.org/155518 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20667 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up restoring pinned tabs for session and tab restoresky@chromium.org2009-07-141-6/+4
| | | | | | | | | | | services. And turns on pinned tabs by default on linux. BUG=16634 TEST=Currently this linux only. Try tab pinning and make sure it works. Review URL: http://codereview.chromium.org/149621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20650 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Put the bookmark bar in a event box to prevent leaking.erg@google.com2009-07-142-18/+24
| | | | | | | | | | Some engines (clearlooks) query the bg color of a widget directly, so wrap the bookmarkbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through. http://crbug.com/16382 Review URL: http://codereview.chromium.org/155504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20643 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Initialize theme resources to make download shelf work.erg@google.com2009-07-141-0/+1
| | | | | | Review URL: http://codereview.chromium.org/149615 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20635 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add first run search bubble.kuchhal@chromium.org2009-07-146-25/+241
| | | | | | Review URL: http://codereview.chromium.org/149501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20625 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Focus docked DevTools window on breakpoint.pfeldman@chromium.org2009-07-142-0/+5
| | | | | | Review URL: http://codereview.chromium.org/155423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20614 0039d316-1c4b-4281-b951-d872f2087c98
* A blind fix for Issue 13443.hbono@chromium.org2009-07-141-0/+1
| | | | | | | | | | | | | | GTK may sends a GdkKeyEvent whose |keyval| is GDK_KP_Tab in pressing shift+tab keys on an X terminal running on Windows. This change just adds GDK_KP_Tab to HandleCustomAccelerator() to handle this event. (This is a blind fix since I don't have any environment that can reproduce this issue.) (*1) http://mail.gnome.org/archives/gtk-list/1999-September/msg00354.html BUG=13443 "Shift+Ctrl+Tab should cycle tabs backwards" TEST=none Review URL: http://codereview.chromium.org/149519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20611 0039d316-1c4b-4281-b951-d872f2087c98
* Add "learn more" link to privacy settings.mattm@chromium.org2009-07-141-1/+23
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/149581 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20584 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromium build.estade@chromium.org2009-07-131-2/+2
| | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/155466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20580 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 23:00:12 +0000