| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use hbox to pack location entry, security icons and EV cert info text.
Change ToolbarModel::GetInfoText not return SkColor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and display LTR for RTL locales.
r19162 | jhawkins@chromium.org | 2009-06-24 13:15:04 -0700 (Wed, 24 Jun 2009) | 5 lines
Add support for RTL languages in the gtk toolbar layout.
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The toolbar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/147102
r19179 | jhawkins@chromium.org | 2009-06-24 14:38:25 -0700 (Wed, 24 Jun 2009) | 5 lines
Add support for RTL languages in the gtk bookmark bar.
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
See http://i139.photobucket.com/albums/q315/failfast/revertrtl.png
Review URL: http://codereview.chromium.org/147130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=go incognito, toggle custom frame drawing
Review URL: http://codereview.chromium.org/146122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stuff going on here, I can't begin to unravel it on more than one platform at a time.
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Correct row index calculation in bookmark manager drag receive.
- Support multiple target dnd
also see http://crbug.com/15240
BUG=none
TEST=multi dragging in bookmark manager/bookmark bar. See cited bug for explanation of how to multi-drag.
Review URL: http://codereview.chromium.org/147107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GtkFixeds do allocate their children. They give them an allocation that matches
their size request. Hence when you directly allocate the child, it gets two
allocates right in a row (one from you, one from the fixed). This was causing
flicker in slide animator gtk (most noticeable when opening a new browser window
and seeing the restore infobar, but also confirmed with debugging statements). The original reason for needing to use
size_allocate() instead of set_size_request() (which had to do with browser
window resizing) is now obsolete, so revert these back to size_request()s.
BUG=none
TEST=less flicker when an infobar is opening; border at bottom of toolbar/bookmark bar still looks the same
Review URL: http://codereview.chromium.org/147100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The toolbar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/147102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
active browser. Not doing so was breaking code that opened a new window and
then immediatly opened aditional tabs in it.
http://crbug.com/14018
Review URL: http://codereview.chromium.org/147091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes the findbar entry look the same on all system themes (dark themes no longer distinct).
BUG=none
TEST=when you fail to find something the background of the match count label turns orange, and when you succeed in finding something the background is white.
Review URL: http://codereview.chromium.org/147053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
right click.
http://crbug.com/14196
http://crbug.com/14443
Review URL: http://codereview.chromium.org/147055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15100
TEST=do it
Review URL: http://codereview.chromium.org/146062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Open bookmark manager, drag bookmarks around.
Review URL: http://codereview.chromium.org/147059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
So the GTK version had only one status, setting the status to any URL the user hovered over. When the background tab is done with loading, it sends a SetStatus("") to the StatusBubble. This was what was tickling the bug.
So I'm copying the Windows implementation, which can have a URL and a status, with the URL's display overriding the status display. So when the background tab calls SetStatus(""), the URL should still be displayed.
http://crbug.com/14802
Review URL: http://codereview.chromium.org/147050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11507
TEST=open options, click "add" to startup url list, select row from list in add url dialog, click add. Also, try sorting columns, and make sure correct url gets added when selecting an url after sorting.
Review URL: http://codereview.chromium.org/145009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/144006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/13228
Review URL: http://codereview.chromium.org/147023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open the browser with --lang=he and make sure the tabs are ordered starting from the right. Also, the UI elements in the tabs should be reversed as well.
Review URL: http://codereview.chromium.org/147020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than being derived from it. This reduces the spaghetti somewhat. Also decouples the notion of a native view hierarchy from the location in TabContents::PageHasOSDD where the template URL fetcher is spawned. The Template URL Fetcher now simply retains a reference to the TabContents that created it. If the TabContents is destroyed before the fetch completes, we just discard the data retrieved without adding a keyword.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crome/browser/gtk/gtk_chrome_link_button.cc needs stdlib.h for free and malloc
on gcc-4.3
patch by Joel Stan <joel.stan@gmail.com>
original review: http://codereview.chromium.org/147002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
moves over the window.
BUG=none
TEST=Open two browser windows with multiple tabs. Make sure the windows overlap. Drag a tab from the top-level window into the frame of the other window. The lower window should be raised after a delay.
Review URL: http://codereview.chromium.org/146004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13838
TEST=Open two browser windows. Drag one of the tabs into the other tabstrip. The first browser window should disappear and the browser should not crash.
Review URL: http://codereview.chromium.org/145019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14113
TEST=the navigation hotkeys now work in fullscreen mode. Make sure the follownig all work:
{ GDK_Left, IDC_BACK, GDK_MOD1_MASK },
{ GDK_BackSpace, IDC_BACK, GdkModifierType(0) },
{ XF86XK_Back, IDC_BACK, GdkModifierType(0) },
{ GDK_Right, IDC_FORWARD, GDK_MOD1_MASK },
{ GDK_BackSpace, IDC_FORWARD, GDK_SHIFT_MASK },
{ XF86XK_Forward, IDC_FORWARD, GdkModifierType(0) },
{ GDK_r, IDC_RELOAD, GDK_CONTROL_MASK },
{ GDK_F5, IDC_RELOAD, GdkModifierType(0) },
{ GDK_F5, IDC_RELOAD, GDK_CONTROL_MASK },
{ XF86XK_Reload, IDC_RELOAD, GdkModifierType(0) },
{ XF86XK_Refresh, IDC_RELOAD, GdkModifierType(0) },
key: { button, action, modifier }, where MOD1 = alt
Review URL: http://codereview.chromium.org/145020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14518
TEST=middle click on an infobar link, it should open in a new tab
Review URL: http://codereview.chromium.org/145013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The BrowserWindow creates the task manager UI directly, which uses the TaskManager to populate itself.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is off. Only paint the custom frame png if the custom frame is
on.
This fixes a bug where the blue gradient wans't applied on the window-decoration version.
Review URL: http://codereview.chromium.org/145005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11441
TEST=Try the non-standard browser keys on a keyboard that has them. I.e. the back and forward button on a Thinkpad.
Review URL: http://codereview.chromium.org/140081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/144004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser window. This fixes a visual bug where the border looked
disconnected with the background. This matches what Windows does.
BUG=14884
Review URL: http://codereview.chromium.org/140078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since the "remove" item always causes selection to change, we don't have to worry about trying to call remove twice with the same context menu.
TEST=see bug. Also, no new crashes on linux.
BUG=14443
Review URL: http://codereview.chromium.org/132048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11512
Review URL: http://codereview.chromium.org/140076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also switched from 3px borders to 4px borders because that's what they are
on windows. On linux, the borders look bigger because our webcontent area
doesn't drop a shadow.
For this to work for resizing on top, I had to remove the event box from
the browser titlebar and move the mouse event handling to the window.
BUG=14645
Review URL: http://codereview.chromium.org/140026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TemplateURL
(when creating with one, the entry changed signal would do it.)
BUG=13326
Review URL: http://codereview.chromium.org/141025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gtk/list_store_favicon_loader,
so that it can be used by the url_picker_dialog_gtk as well.
BUG=11507
Review URL: http://codereview.chromium.org/141035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
relevant places.
BUG=13326
Review URL: http://codereview.chromium.org/141026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rearranged the windows and mac ports to use the cross platform interfaces. Updated windows fonts and languages to use those interfaces. As well, created stubs for mac platform.
BUG=13524 (http://crbug.com/13524)
TEST=Open a webpage with a textfield, right click and choose Spell checker options > Language Settings. Tested this on windows as well.
Review URL: http://codereview.chromium.org/140043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Following the same approach as the general tab page..
BUG=11507
TEST=The Personal stuff tab is fully functioning, the prefs save correctly.
Review URL: http://codereview.chromium.org/125105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't like that GTK only does app-modal rather than window modal, but otherwise you can just close the parent window and crash when you then click okay on the dialog.
BUG=11507
Review URL: http://codereview.chromium.org/141020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Implements a ConstrainedWindowGtk which positions itself in the center of its corresponding TabContentsViewGtk.
- Implements LoginPromptGtk. HTTP Auth now works under Linux.
- Renames ConstrainedWindowImpl to ConstrainedWindowWin
http://crbug.com/11512
Review URL: http://codereview.chromium.org/132047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
more input and calling parent class forall.
http://crbug.com/14485
Review URL: http://codereview.chromium.org/141004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
catch the case when the user closes the last tab in a tabstrip. In this case, we add ourselves as a message loop observer and never get a chance to remove ourselves before the tabstrip is destroyed.
BUG=14648
TEST=Open a new window and press the close button on the tab. The browser should not crash.
Review URL: http://codereview.chromium.org/140006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ImporterHost aware of the current parent window and use that
as parent for the warning dialog.
BUG=13481
TEST=Start Firefox, try to import profile in Chrome and make sure the warning dialog is modal.
Review URL: http://codereview.chromium.org/131080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
still need to do similar for link buttons and such.
BUG=14518
Review URL: http://codereview.chromium.org/131071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14438
TEST=see bug
Review URL: http://codereview.chromium.org/132049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=tc
Review URL: http://codereview.chromium.org/132055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18782 0039d316-1c4b-4281-b951-d872f2087c98
|