| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
gtk_util/gtk_tree_util.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the call is async, we need to manually tell Browser that
we're no longer in full screen mode.
BUG=18104
Review URL: http://codereview.chromium.org/159670
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=make your browser very narrow in debug mode, it doesn't crash
Review URL: http://codereview.chromium.org/159665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17632
Review URL: http://codereview.chromium.org/159664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18071
Review URL: http://codereview.chromium.org/160422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a few bugs of button sensitivity not updating when it should.
Add the unittest to the valgrind/unit_tests.gtest_linux.txt list since Gtk is
causing UninitCondition errors when run with no DISPLAY.
BUG=11507
BUG=15445
Review URL: http://codereview.chromium.org/160420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 91bd4c1a4703db44ea45852bf2f62822e1ded743, which caused valgrind errors.
TBR=erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix a few bugs of button sensitivity not updating when it should.
BUG=11507
Review URL: http://codereview.chromium.org/159625
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch from joel.stan@gmail.com: http://codereview.chromium.org/160377
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a crash where events were being sent to an unknown, unrealized widget.
BUG=18049
TEST=Quickly drag a tab down out of the tab strip. The browser should not crash.
Review URL: http://codereview.chromium.org/160379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11598
TEST=Visit an HTTPS page, click the lock icon, the page info should show.
Review URL: http://codereview.chromium.org/159521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17851
TEST=Open the task manager. Click on the 'Stats for nerds' link. Browser should navigate to about:memory.
Review URL: http://codereview.chromium.org/159616
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put the star and go/stop buttons inside the location bar drawing. Reverts my changes to
location_bar_view_gtk.cc in the previous patch. (Showed mocks of this to Ben and Glen.)
Also fixes rendering of the location bar background under Crux and other themes that
draw an entry_bg.
Review URL: http://codereview.chromium.org/159610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This matches native gtk behavior.
BUG=17869
TEST=Open multiple tabs. Scroll the tabs using the scroll wheel. The scroll should not wrap around.
Review URL: http://codereview.chromium.org/160362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15875
Review URL: http://codereview.chromium.org/160350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
download request manager.
We weren't reporting Cancel on page navigation, which meant the download request manager had a stale pointer that it later tried to dereference.
BUG=18021
Review URL: http://codereview.chromium.org/160361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To test, did the following under Metacity/GNOME:
- remove window_placement prefs from "Local State" file
- start chrome
- open bookmark manager with Ctrl-Shift-B
- resize window to be small and close it
- reopen bookmark manager and confirm that its window is the same
size as when closed
- maximize bookmark manager and close it
- reopen bookmark manager and confirm that it's still small
- minimize bookmark manager before closing it; confirm that the
size remains the same
- restart chrome and confirm that the window size is still saved
- repeat the above tests with the task manager (which is a bit
quicker, since it doesn't allow maximizing or minimizing)
BUG=15488
TEST=see above
Review URL: http://codereview.chromium.org/160330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8205
Review URL: http://codereview.chromium.org/159603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As with the rest of our shadow drawing, we don't overlap 1 pixel, we
just draw the area around.
BUG=15505
Review URL: http://codereview.chromium.org/160306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
matches up with Windows.
BUG=17915
Review URL: http://codereview.chromium.org/160281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/159186
Renaming GetNormalBounds to GetRestoredBounds from browser_window.h.
BUG=None
TEST=None
TBR=tfarina
Review URL: http://codereview.chromium.org/160337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8205
TEST=go to wrench->options->personal stuff->show saved passwords, it works
Review URL: http://codereview.chromium.org/159522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
multiple files. Do you want to allow this?" dialog on linux.
BUG=12757
TEST=Download several files from the same domain. After the first download, you should be prompted for every additional file you want to download from that domain (try for example http://amnoid.de/ddsview/download.html , click on the "download" link twice).
Review URL: http://codereview.chromium.org/159528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The combined star/location bar/go construct doesn't look native. In
GTK mode, make the star and go buttons act like toolbar buttons, and
draw a GTK text entry widget onto the toolbar. The omnibox popup
is just the size of the entry when in GTK theme mode.
There's still a lot of work to be done on this; I want to properly
draw focus rings, have the rest of the location box use theme colors, et cetera, but this is less broken then what's currently
there.
Review URL: http://codereview.chromium.org/159532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=17822
TEST=Use multiple monitors. Start Chrome, move the window to a non-primary
monitor, and exit Chrome. Disconnect or disable the monitor and start Chrome
again. Chrome should appear at the origin of a remaining monitor. Also try
chaning the resolution of the non-primary monitor. As far as the window fits
within the monitor, it should be shown as-is. If not, it is moved to the origin
and resized, if necessary.
Review URL: http://codereview.chromium.org/160246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems NXClient sends GDK_Tab not only when we press control+tab keys but also when we press control+shift+tab keys.
To emulate Firefox, this change checks if |modifier| is control+shift when |keyval| is either GDK_Tab, GDK_ISO_Left_Tab, or GDK_KP_Tab.
BUG=13443 "Shift+Ctrl+Tab should cycle tabs backwards"
TEST=Execute Chromium on an NX Client, press control+shift+tab keys, and verify tabs cycle backwards.
Review URL: http://codereview.chromium.org/155564
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17475
TEST=obvious
Review URL: http://codereview.chromium.org/159570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/160307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now when an extension is loaded, you will see its entry in the task manager.
However, on the shelf there is still only a placeholder label (I have to
work on setting proper size for the render widget).
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/159527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awong
Review URL: http://codereview.chromium.org/159550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- ctrl+e = ctrl+k
- alt + e and alt + f to open the page and wrench menus respectively (emulating menu bar _File and _Edit)
BUG=none
TEST=use the new hotkeys
Review URL: http://codereview.chromium.org/160292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
picker.
BUG=none
TEST=in a debug build, go to wrench->options->basics, select "open the following pages", click "add", select something from the list, and then deselect it by holding ctrl and clicking it again; chromium should not crash
Review URL: http://codereview.chromium.org/159540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When we use gtk_scrolled_window_add_with_viewport, it sets its own
shadow.
BUG=16913
Review URL: http://codereview.chromium.org/159535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Proxy settings are set using Gnome's network properties dialog, by running the
binary directly. The binary was renamed from gnome-system-preferences to
gnome-system-properties in Janurary 2009, so to ensure the dialog works on both
newer and older systems, this patch searches the users PATH for the binary to use.
Upstream rename: http://git.gnome.org/cgit/gnome-control-center/commit/?id=4f1b6aafba338a267b6c1b911ceb33358b2eca09
BUG=17756
TEST='Under the Hood' -> 'Change proxy settings' still works on Ubuntu Hardy as well as Ubuntu Jaunty.
Review URL: http://codereview.chromium.org/160146
Patch from Joel Stanley.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also disable it for the cookie behavior combobox, because it fights with the scrolled window.
The GtkFileChooserButton spews the following 2 errors (and possibly others) when you scroll on it quickly:
Gtk-WARNING **: idle activate multiple times without clearing the folder object first.
Gtk: gtk_tree_model_get_iter: assertion `path != NULL' failed
This causes us to crash in debug, and causes undesirable console output in release. I verified that this is their bug and not ours by reproing in a simple program that just has a window with a GtkFileChooserButton in it.
BUG=17805
Review URL: http://codereview.chromium.org/159459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename shell_integration.cc to shell_integration_win.cc, so
shell_integration.cc can be used for cross-platform stuff.
Move DefaultBrowserWorker from GeneralPageView to ShellIntegration.
BUG=17179
Review URL: http://codereview.chromium.org/160218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/159458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Correctly update drag status for drags over renderer. This makes things look quite a bit better.
- Rework the dnd utils so that we specify the drag targets in the order we prefer them (for destinations)
- Refactor code in bookmark bar so folder and toolbar drags share more code
- Allow bookmark bar to accept URI lists and plain text drags (for plain text we require the text to be a valid url)
BUG=17431
Review URL: http://codereview.chromium.org/159419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We put this in the browser window expose handler so the tabs in the
tab strip will draw over it.
BUG=15505
Review URL: http://codereview.chromium.org/160201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
source tab. This is necessary because we move the hidden source tab during a drag, and gtk does not update the allocation of hidden widgets.
BUG=16918,17712
TEST=Extensive tab dragging.
Review URL: http://codereview.chromium.org/159436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Same for hung renderer dialog.
BUG=13000
Review URL: http://codereview.chromium.org/160147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17631
Review URL: http://codereview.chromium.org/160131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17695
TEST=Open the browser in a RTL locale. Drag a link from the tab contents into the tabstrip. The drop arrow should be positioned correctly.
Review URL: http://codereview.chromium.org/159394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specifying "frame_color" and "inactive_frame_color" in the gtk_color_scheme.
Also attempts to do a better job matching the frame color. Most window
managers (defined as metacity default theme and xfwm's default theme)
take bg[SELECTED] tint it by 80%. We hand code that behaviour in, as it
will be wrong a smaller percentage of the time then our current
behaviour.
http://crbug.com/16271 (dark theme bug)
http://crbug.com/13967 (theme color metabug)
Review URL: http://codereview.chromium.org/160188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21704 0039d316-1c4b-4281-b951-d872f2087c98
|