summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk
Commit message (Collapse)AuthorAgeFilesLines
* GTK Themes: Fix spacing so page and app menus take up full height in GTK ↵erg@google.com2009-07-201-5/+7
| | | | | | | | theme mode. Review URL: http://codereview.chromium.org/159103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21120 0039d316-1c4b-4281-b951-d872f2087c98
* Fix misleading name and comment of Browser::GetCurrentPageTitle.phajdan.jr@chromium.org2009-07-201-1/+1
| | | | | | | | | | | GetWindowTitleForCurrentTab more accurately describes what this function really does. TEST=none http://crbug.com/16231 Review URL: http://codereview.chromium.org/155534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21114 0039d316-1c4b-4281-b951-d872f2087c98
* When we save the window bounds, make sure we are only storing thetc@google.com2009-07-202-10/+12
| | | | | | | | | | | | | | | | | non-maximized and non-fullscreen bounds. We still keep track of whether the window is maximized or not, but this allows restoring a maximized browser to go back to it's previous state. This also fixes a bug where we would confuse window managers by setting the initial window size to the full desktop would cause WMs to disable resize/move. BUG=16602 Review URL: http://codereview.chromium.org/155802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21113 0039d316-1c4b-4281-b951-d872f2087c98
* Change fullscreen mode to be determined by the window manager.tc@google.com2009-07-202-21/+30
| | | | | | | | | | | | | | | | | We used to have a bool that determined whether we were in full screen mode or not, but that's not always in sync with the WM so wait for the WM to tell us that we're in full screen mode. Also, change it so when we're in full screen mode, we don't save our window bounds because that causes us to restart in full screen mode which is all sorts of broken. BUG=16602 Review URL: http://codereview.chromium.org/159087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21103 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove unimplemented menu itemsevan@chromium.org2009-07-201-4/+12
| | | | | | Review URL: http://codereview.chromium.org/155786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21099 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Set the task manager scrolled window policy to GTK_POLICY_AUTOMATIC so ↵jhawkins@chromium.org2009-07-201-1/+1
| | | | | | | | | | that the task manager window is not resized when a page with a long title is viewed. BUG=17079 TEST=Open the task manager after navigating to a site with a long page title. The task manager window should not resize to fit the title. Review URL: http://codereview.chromium.org/159081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21096 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Store devtools split location on Linux.pfeldman@chromium.org2009-07-201-3/+19
| | | | | | Review URL: http://codereview.chromium.org/149748 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21070 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the the refactoring the page info to have a model.jcampan@chromium.org2009-07-192-0/+14
| | | | | | | | | BUG=None TEST=Make sure clicking the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well. TBR=ben Review URL: http://codereview.chromium.org/155753 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21065 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21032.jcampan@chromium.org2009-07-182-14/+0
| | | | | | | | | It breaks the release build on Windows. TBR=ben Review URL: http://codereview.chromium.org/155736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21035 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add proxy config (using gnome-network-preferences)"mattm@chromium.org2009-07-181-51/+1
| | | | | | | | This reverts commit d06bc0c855b1e81e36c7bfc9bef342eb358d99a5. TBR=estade git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21033 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring the page info to have a model.BUG=NoneTEST=Make sure clicking ↵jcampan@chromium.org2009-07-182-0/+14
| | | | | | | | the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well. Review URL: http://codereview.chromium.org/155336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21032 0039d316-1c4b-4281-b951-d872f2087c98
* Another bookmark manager crash fix after r20565.estade@chromium.org2009-07-171-1/+1
| | | | | | | | | | | | This thing really needs a ui test. BUG=none TEST=importer doesn't crash TBR=munjal Review URL: http://codereview.chromium.org/159041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21024 0039d316-1c4b-4281-b951-d872f2087c98
* Add proxy config (using gnome-network-preferences)mattm@chromium.org2009-07-171-1/+51
| | | | | | | | | BUG=11507 TEST=Open options, click change proxy, gnome-network-preferences should launch. If gnome isn't installed, LinuxProxyConfig wiki page should load. Review URL: http://codereview.chromium.org/149785 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21023 0039d316-1c4b-4281-b951-d872f2087c98
* Two tweaks to the linux tab strip code:sky@chromium.org2009-07-174-8/+24
| | | | | | | | | | | | . Adds a 3 pixel gap between pinned and non-pinned tabs. . Fixes bug when rapdily dragging pinned tabs that could result in unpinning all tabs to right of pinned tab being dragged. BUG=none TEST=none Review URL: http://codereview.chromium.org/155725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21022 0039d316-1c4b-4281-b951-d872f2087c98
* Begin work on extension shelf for Linux.phajdan.jr@chromium.org2009-07-174-1/+251
| | | | | | | | | | | For now it displays only a placeholder text, but knows when to display (it's connected to the ExtensionShelfModel). TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/159019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21014 0039d316-1c4b-4281-b951-d872f2087c98
* Do not block all task manager tree view mouse release events.estade@chromium.org2009-07-171-4/+2
| | | | | | | | | BUG=16974 TEST=you can resize rows of the task manager Review URL: http://codereview.chromium.org/155670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21006 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the Cancel button to Close in gtk Clear Browsing Data.mattm@chromium.org2009-07-171-1/+1
| | | | | | | | | BUG=16955 TEST=Open Clear Browsing Data dialog. The button should now say Close. Review URL: http://codereview.chromium.org/159023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20994 0039d316-1c4b-4281-b951-d872f2087c98
* Fix same crashy assumption that I fixed in r20967 later on in normal theme mode.erg@google.com2009-07-171-3/+6
| | | | | | Review URL: http://codereview.chromium.org/155709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20991 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the width of pinned tabs to be slightly bigger.sky@chromium.org2009-07-172-22/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20985 0039d316-1c4b-4281-b951-d872f2087c98
* This matches the behavior on Windows. Also this change lets user close ↵kuchhal@chromium.org2009-07-172-0/+15
| | | | | | | | | | | Chrome by clicking 'x' button even if a popup (for example - bookmark bubble) is open. BUG=NONE TEST=1. Click on bookmark star button to open bookmark bubble. Switch focus to some other Window, bubble should close automatically. 2. Click on bookmark star button to open bookmark bubble. Close chrome by clicking on Window close button ('x') and Chrome should close. Review URL: http://codereview.chromium.org/149757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20977 0039d316-1c4b-4281-b951-d872f2087c98
* Need to cleanup first run dialog on cancellation too.kuchhal@chromium.org2009-07-171-3/+4
| | | | | | | | Fixing what r20898 broke. Review URL: http://codereview.chromium.org/155676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20973 0039d316-1c4b-4281-b951-d872f2087c98
* Fix occasional crash at startup in gtk_chrome_button_expose.erg@google.com2009-07-171-2/+3
| | | | | | Review URL: http://codereview.chromium.org/155697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20967 0039d316-1c4b-4281-b951-d872f2087c98
* Set window icon on task manager.estade@chromium.org2009-07-171-0/+1
| | | | | | | | | | patch by <joel.stan@gmail.com> original review url: http://codereview.chromium.org/155677 Review URL: http://codereview.chromium.org/149797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20942 0039d316-1c4b-4281-b951-d872f2087c98
* forgot a file (or rather gcl was hiding it in another cl)estade@chromium.org2009-07-171-10/+3
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/149787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20929 0039d316-1c4b-4281-b951-d872f2087c98
* Set window icon on options dialog, bookmark manager.estade@chromium.org2009-07-173-3/+2
| | | | | | | | | BUG=16951 TEST=launch bookmark manager on gnome/metacity, observe that window has icon Review URL: http://codereview.chromium.org/155672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20928 0039d316-1c4b-4281-b951-d872f2087c98
* Allow dragging a link from the web contents to the bookmark bar to get a ↵estade@chromium.org2009-07-1710-75/+128
| | | | | | | | | | | | | named bookmark. Also, change the naming scheme of the DnD targets. BUG=16791 TEST=select a link in the web page and drag it to the bookmark bar. Review URL: http://codereview.chromium.org/155661 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux unit tests by checking for NULL that's impossible in real code, ↵erg@google.com2009-07-161-2/+2
| | | | | | | | | | but needed in unit tests. TBR=willchan Review URL: http://codereview.chromium.org/155663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20917 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Make the location bar area look native.erg@google.com2009-07-167-36/+214
| | | | | | | | | | | | | | | | | Replace the star and go buttons with a native looking thing, where we manually draw the theme's button image for the full omnibox area and then position the star/go buttons on top of that. Also adds stand in versions of star_noborder and starred_noborder until Glen can make real icons. http://crbug.com/16227 http://crbug.com/13967 http://crbug.com/16915 Review URL: http://codereview.chromium.org/149681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20914 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix bookmark manager crash on startup introduced by r20565estade@chromium.org2009-07-162-9/+11
| | | | | | | TBR=munjal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20899 0039d316-1c4b-4281-b951-d872f2087c98
* Show progress Window when importing profile from First Run dialog.kuchhal@chromium.org2009-07-162-5/+23
| | | | | | Review URL: http://codereview.chromium.org/149766 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20898 0039d316-1c4b-4281-b951-d872f2087c98
* Select correct default folder in bookmark editor gtk.estade@chromium.org2009-07-161-1/+1
| | | | | | | | | BUG=none TEST=right click in a dropdown from a folder on the bookmark bar, select add, you should see that the correct folder is seleted in the bookmark editor tree view. Add a bookmark, it should show up in the right place. Review URL: http://codereview.chromium.org/149725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20897 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Handle RTL layout when rendering the dragged tab.jhawkins@chromium.org2009-07-161-2/+5
| | | | | | | | BUG=none TEST=Drag a tab out of the browser in a RTL language. The tab should be rendered on the right side of the container. Review URL: http://codereview.chromium.org/155643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20890 0039d316-1c4b-4281-b951-d872f2087c98
* Work on RTL / BiDi Omnibox.deanm@chromium.org2009-07-165-15/+23
| | | | | | | | | Based on work from Evan Stade. Review URL: http://codereview.chromium.org/155567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20862 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Initial commit with docked devtools window support on Linux.pfeldman@chromium.org2009-07-164-13/+55
| | | | | | Review URL: http://codereview.chromium.org/149675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20861 0039d316-1c4b-4281-b951-d872f2087c98
* Implement gtk download options section.mattm@chromium.org2009-07-161-2/+165
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/155617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20848 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Tint throbbers like we tint all other buttons in the interface.erg@google.com2009-07-158-50/+105
| | | | | | | | | | | | | | Relanding with fixes for unit tests. Run through trybot this time... http://crbug.com/13967 Original Review URL: http://codereview.chromium.org/155588 TBR=estade Review URL: http://codereview.chromium.org/155601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20809 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel icon load requests when we are getting shutdown.estade@chromium.org2009-07-151-0/+1
| | | | | | | | | | | | | Hopefully this will fix the download test flakiness. I was able to reproduce the crash manually by just mass-clicking on the same download link many times (thanks to DotA for improving my APM). With this patch I am no longer able to repro. BUG=14746,14745,15244,15416 TEST=download tests stop flaking out Review URL: http://codereview.chromium.org/149712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20807 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK Themes: Tint throbbers like we tint all other buttons in the ↵erg@google.com2009-07-157-78/+41
| | | | | | | | | | | | interface." This reverts commit 3dfa509662e99282b5212490bfe19b32da357741 (r20799). TBR=estade Review URL: http://codereview.chromium.org/155598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20802 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Tint throbbers like we tint all other buttons in the interface.erg@google.com2009-07-157-41/+78
| | | | | | | | http://crbug.com/13967 Review URL: http://codereview.chromium.org/155588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20799 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: evan@chromium.orgmattm@chromium.org2009-07-151-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20798 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in "web content" section in "user data" options.mattm@chromium.org2009-07-153-5/+47
| | | | | | | | | BUG=11507 TEST=open options -> user data. Click the configure fonts button. Font configuration dialog should appear. Review URL: http://codereview.chromium.org/157002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20797 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ResolveMetricsReportingEnabled logic to OptionsUtil, make gtk ↵mattm@chromium.org2009-07-151-5/+54
| | | | | | | | | | | | | | | options use it. Only show the reporting checkbox in Google Chrome builds. Show the restart required message box when changing the reporting setting. BUG=11507 TEST=on Chromium build, option should not show up. On Google Chrome build in should show up, and enable both crash reporting and metrics settings. Review URL: http://codereview.chromium.org/149665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20796 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Remove two calls to Update that are unnecessary. When we layout the ↵jhawkins@chromium.org2009-07-151-2/+0
| | | | | | | | | | dragged tab, gtk will emit an expose-event signal for us if the widget changes size. BUG=none TEST=Drag a tab out of the browser. The tab should be sized and shown properly. Review URL: http://codereview.chromium.org/149703 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20791 0039d316-1c4b-4281-b951-d872f2087c98
* Add more browser tests for Task Manager.phajdan.jr@chromium.org2009-07-151-1/+2
| | | | | | | | | TEST=Covered by browser_tests. http://crbug.com/12127 Review URL: http://codereview.chromium.org/155433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20786 0039d316-1c4b-4281-b951-d872f2087c98
* Make more things clickable in the bookmark bar menus:estade@chromium.org2009-07-151-4/+16
| | | | | | | | | | | | | | - folder within a folder - "empty" menu item Note that it can be hard to click on a folder within a folder since hovering over the folder pops up a submenu that grabs focus, so you end up needing to right click twice. It's a little odd but the hackery required to fix it doesn't seem worth it. BUG=15886 TEST=right click on an empty menu item Review URL: http://codereview.chromium.org/155586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20785 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Handle RTL layout when positioning the tab strip drop arrow.jhawkins@chromium.org2009-07-151-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149695 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20778 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Inactive title bars should follow the bg insensitive color.erg@google.com2009-07-151-6/+13
| | | | | | | | | | This solves the inactive skyline color often being laughably bad. It does show that we may want to draw the line between the skyline and toolbar for best visual effect, though... Review URL: http://codereview.chromium.org/149693 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20774 0039d316-1c4b-4281-b951-d872f2087c98
* First run bubble polish:estade@chromium.org2009-07-156-12/+38
| | | | | | | | | | | | | | | - improve spacing and and sizing, both internally and externally (using windows as the guide) - make legible for dark themes - make show delay longer because it was too short on my machine (at least when using a Debug build). Also explicitly set bookmark bubble labels black. BUG=16782 TEST=none Review URL: http://codereview.chromium.org/149664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20762 0039d316-1c4b-4281-b951-d872f2087c98
* Set the prefs::kMetricsReportingEnabled value in the gtk first run dialog.mattm@chromium.org2009-07-151-1/+9
| | | | | | | | | BUG=11971 TEST=Build Google Chrome version, run with --user-data-dir pointing to empty directory, select to report crashes, open options user data page, check that the checkbox for reporting is actually checked. Review URL: http://codereview.chromium.org/149666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20752 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155428 for Thiago, which changessky@chromium.org2009-07-155-15/+8
| | | | | | | | | | | | | | from me to get the thing to work. Merging two versions of BookmarkNodeRemoved into one. BUG=None TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure everything works ok. Review URL: http://codereview.chromium.org/155572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 10:48:45 +0000