summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Minor tweaks to how pin tabs look:sky@chromium.org2009-09-013-3/+31
| | | | | | | | | | | | | . Increases the width by 8 pixels. . Animates the position of the favicon when the tab changes from pinned to unpinned. Without this the favicon jumps noticably. BUG=none TEST=none Review URL: http://codereview.chromium.org/183040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25118 0039d316-1c4b-4281-b951-d872f2087c98
* Squash the bookmark bar into the toolbar by 4 pixels.estade@chromium.org2009-09-016-64/+67
| | | | | | | | | | On windows they do this by having the two views overlap. We can't so instead move the bottom 4 pixels of padding from the toolbar widget into the bookmark bar widget. When the bookmark bar is closed/hidden, it still shows those 4 pixels. When it opens, it is able to make use of those 4 pixels. Since we get 4 extra pixels, we can make the overall height of the bookmark bar 4 pixels less. BUG=18570 Review URL: http://codereview.chromium.org/178029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25075 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make the toolbar star button a drag source.estade@chromium.org2009-09-015-21/+39
| | | | | | | | | | Also refactor URI list/named url packing code. BUG=19008 Review URL: http://codereview.chromium.org/175036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25067 0039d316-1c4b-4281-b951-d872f2087c98
* Porting textfield to toolkit_views Gtk.jcampan@chromium.org2009-09-012-8/+4
| | | | | | | | | | | BUG=None TEST=Run the view unit-tests. See original review: http://codereview.chromium.org/165512/show Review URL: http://codereview.chromium.org/180061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
* Set the window type hint for the options dialog andtony@chromium.org2009-09-012-0/+6
| | | | | | | | | | | | | | task manager to GDK_WINDOW_TYPE_HINT_NORMAL. This allows the dialogs to go behind browser windows in metacity. I did it for these two dialogs mainly because they have links to web pages. The links should be able to open on top of the dialog. Review URL: http://codereview.chromium.org/179014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25057 0039d316-1c4b-4281-b951-d872f2087c98
* When running on chrome OS about:version now shows OS version.sky@chromium.org2009-09-011-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/179063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25045 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the position of the throbber for pinned tabs. It was wrong before,tony@chromium.org2009-09-011-13/+5
| | | | | | | | | | | | but we repainted the whole pinned tab so it wasn't as obvious. With this change, the throbber is placed where the favicon will go. BUG=20626 Review URL: http://codereview.chromium.org/175038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25005 0039d316-1c4b-4281-b951-d872f2087c98
* Set the info bubble popups as _NET_WM_WINDOW_TYPE_UTILITY so theytony@chromium.org2009-09-011-0/+3
| | | | | | | | | don't show up in the task bar. Review URL: http://codereview.chromium.org/177046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25002 0039d316-1c4b-4281-b951-d872f2087c98
* Delete first run dialog on Linux when done.kuchhal@chromium.org2009-08-311-0/+1
| | | | | | | | BUG=18429 Review URL: http://codereview.chromium.org/182037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24966 0039d316-1c4b-4281-b951-d872f2087c98
* Paint the hover animation state when painting just the favicon.tony@chromium.org2009-08-311-0/+20
| | | | | | | | | BUG=20658 Review URL: http://codereview.chromium.org/173630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24960 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-314-0/+139
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24930 0039d316-1c4b-4281-b951-d872f2087c98
* Don't resize the renderer while opening the bookmark bar or an infobar.estade@chromium.org2009-08-319-19/+26
| | | | | | | | | | This is just a performance optimization. Previously this code was added for closing bookmark bars as a bit of visual polish.Doing the same thing for opening bookmark bars should reduce CPU usage but it won't look any different (for fast computers anyway). BUG=17133 Review URL: http://codereview.chromium.org/183011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24911 0039d316-1c4b-4281-b951-d872f2087c98
* Makes 'Pin tab' option in context menu a checkbox.sky@chromium.org2009-08-311-1/+1
| | | | | | | | | | BUG=20575 TEST=On linux pin a tab. Right click on the tab and make sure you see a check next to 'Pin Tab'. Review URL: http://codereview.chromium.org/175028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24905 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Use a GtkInvisible to track the tab dragging operation. Originally we ↵jhawkins@chromium.org2009-08-313-81/+114
| | | | | | | | | | were using the actual tab widget for this purpose, but this is unreliable becauase we hide and detach the tab widget, which disturbs the drag operation. BUG=19725,20513 TEST=Extensive tab dragging. Review URL: http://codereview.chromium.org/176034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24903 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make search engines dialog size based on locale settings.mdm@chromium.org2009-08-311-6/+11
| | | | | | | | | BUG=20453 TEST=none Review URL: http://codereview.chromium.org/180034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24890 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Get rid of the title-centering code in TabRendererGtk. DrawStringInt ↵jhawkins@chromium.org2009-08-311-8/+1
| | | | | | | | | | centers the text for us already. This change also removes a hack that modified the clipping rect unnecessarily. BUG=20401,20610 TEST=none Review URL: http://codereview.chromium.org/179037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24875 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment with dislodging the Extension Shelf and having it only appear on ↵finnur@chromium.org2009-08-302-0/+10
| | | | | | | | | | | the New Tab page. BUG=http://crbug.com/20415 TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity. Review URL: http://codereview.chromium.org/175017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24864 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Schedule a paint operation for the previously selected tab when ↵jhawkins@chromium.org2009-08-301-0/+4
| | | | | | | | | | selecting a new tab. BUG=20583 TEST=Open a browser with two tabs. Select the unselected tab. The now-unselected tab should be rendered as unselected. Review URL: http://codereview.chromium.org/182025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24863 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Initialize |background_offset_x_|. When rendering a dragged tab, we ↵jhawkins@chromium.org2009-08-301-0/+1
| | | | | | | | | | weren't hitting the codepath that initializes this variable, leading to a UMR that caused glitchy rendering. BUG=20157 TEST=Drag a tab. The rendering should not be glitchy. Review URL: http://codereview.chromium.org/176035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24862 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash where we were looking for the fav icon in the wrong service.estade@chromium.org2009-08-292-8/+8
| | | | | | | This caused the possible url dialog in the options menu to never load favicons, and instead DCHECK (crashing debug builds). Review URL: http://codereview.chromium.org/179034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24852 0039d316-1c4b-4281-b951-d872f2087c98
* Implement creating shortcuts in the applications menu.phajdan.jr@chromium.org2009-08-282-2/+15
| | | | | | | | | TEST=none http://crbug.com/17251 Review URL: http://codereview.chromium.org/179008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24836 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: get GNOME or KDE proxy settings.mdm@chromium.org2009-08-281-6/+6
| | | | | | | | | BUG=17363, 20407 TEST=none Review URL: http://codereview.chromium.org/174327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24831 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Refactoring and rounds the "Search site for:" hint.erg@google.com2009-08-288-198/+298
| | | | | | | | | | | | | Factor out common window rounding code from two places where it was used, generalize it, and use it to round the "Search site for:" hint in the location bar. Theoretically, people should be able to use this anywhere they need a window to have rounded corners. http://crbug.com/18310 Review URL: http://codereview.chromium.org/179026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24828 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Gtk confirm form resubmission dialog." Broke linux views build.mattm@chromium.org2009-08-284-139/+0
| | | | | | | | | | This reverts commit e6ab23c81e56c6b9fbb062bbb090a648e6ebef12. TBR=beng Review URL: http://codereview.chromium.org/183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24827 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-284-0/+139
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24826 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-281-4/+4
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-2817-61/+32
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-2817-32/+61
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the custom frame on app mode windows. This includes thetony@chromium.org2009-08-282-16/+23
| | | | | | | | | | | | | dev tools window. It makes app mode windows feel a lot more native. BUG=16474 Review URL: http://codereview.chromium.org/183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24778 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Clip the tab title to the content height and not the font height. The ↵jhawkins@chromium.org2009-08-281-2/+1
| | | | | | | | | | font height is a design measure and should not be used for a bounding box. BUG=20401 TEST=Open google.com in a tab. Tab title should be fully visible and not clipped. Review URL: http://codereview.chromium.org/179022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24765 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Remove unnecessary gtk_widget_queue_draws from the tabstrip code.jhawkins@chromium.org2009-08-281-6/+1
| | | | | | | | BUG=15872 TEST=none Review URL: http://codereview.chromium.org/182007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24744 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Refresh the entire location bar area on Update().erg@google.com2009-08-271-1/+7
| | | | | | | | http://crbug.com/20027 Review URL: http://codereview.chromium.org/182004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24698 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittest for Gtk search engine manager dialog.mattm@chromium.org2009-08-273-15/+283
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/180012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24692 0039d316-1c4b-4281-b951-d872f2087c98
* Ellipsize long entries in bookmark menus and the back/forward menus.estade@chromium.org2009-08-275-9/+58
| | | | | | | | | | | | | | | Also ellipsize long tooltips. Also make the bookmark bar tooltips more like window (Title on one line, then url on the next line). I've made the title bold, although that isn't the case on windows. Menus: Prefer popping downwards rather than upwards when there is more space down than up. BUG=18617 BUG=20120 Review URL: http://codereview.chromium.org/175004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24685 0039d316-1c4b-4281-b951-d872f2087c98
* Add a fast path for tab strip expose.tony@chromium.org2009-08-274-2/+116
| | | | | | | | | | | | | | | | | This optimizes the common case of just needing to update favicons. If the expose area consists of just favicons, only paint the favicons (i.e., don't bother with the complex tab edges that overlap). This doesn't help when tabs are resizing or moving, but does reduce CPU usage quite a bit. BUG=15872 Review URL: http://codereview.chromium.org/179003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24675 0039d316-1c4b-4281-b951-d872f2087c98
* Remove completed downloads from shelf when the shelf closes.thakis@chromium.org2009-08-273-5/+27
| | | | | | | | | | | | | | | | | BUG=15712 TEST=Download a few things, close shelf, download something else, note initial few things are no longer on the shelf. Special cases: * Dangerous downloads still awaiting affirmation should never be removed, no matter if they are completed or not. * Cancelled downloads should be removed. * In-progress downloads should not be removed. Review URL: http://codereview.chromium.org/173186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24663 0039d316-1c4b-4281-b951-d872f2087c98
* Add call to BrowserThemeProvider::GenerateBitmap removed in r24170.erg@google.com2009-08-271-1/+0
| | | | | | | | | | (Linux relies on the lazy generation provided by GenerateBitmap; having to call GenerateTabImages() regressed linux startup; theoretically it'd be nice if everything was done lazily...) Review URL: http://codereview.chromium.org/180004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24643 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the settings tab to options on chrome os. The contents is just a placesky@chromium.org2009-08-271-0/+12
| | | | | | | | | | holder at this point. BUG=none TEST=none Review URL: http://codereview.chromium.org/174596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24642 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Subtract the tabstrip x offset from the last tab x offset when ↵jhawkins@chromium.org2009-08-271-1/+1
| | | | | | | | | | calculating the available tab width. The tabstrip and its tabs are not necessarily based at (0,0). BUG=20329 TEST=Open many tabs until they resize smaller. Repeatedly close the left-most tab with the close button. The tabs should not resize at all until the mouse leaves the tabstrip. Review URL: http://codereview.chromium.org/173559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24630 0039d316-1c4b-4281-b951-d872f2087c98
* Draw background of Linux extension toolstrips.phajdan.jr@chromium.org2009-08-274-0/+30
| | | | | | | | | | | This makes Linux extension shelf quite pretty now IMHO. TEST=Just see it. http://crbug.com/16759 Review URL: http://codereview.chromium.org/174585 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24605 0039d316-1c4b-4281-b951-d872f2087c98
* Update of the extension install UI:aa@chromium.org2009-08-271-4/+3
| | | | | | | | | | | | | | | | | - Give the user more information about which hosts an extension can access. - Remove the red severe warning because it doesn't play well with themes and because it adds nothing when the other text is more specific. - Make the image a bit smaller. Also integrate this new idea with the silent/not-silent update flow. BUG=12129,12140,19582 Review URL: http://codereview.chromium.org/173463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24599 0039d316-1c4b-4281-b951-d872f2087c98
* Don't flip out in debug mode when launching the bookmark manager and the ↵estade@chromium.org2009-08-271-2/+0
| | | | | | | | model isn't yet loaded. Review URL: http://codereview.chromium.org/174593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24583 0039d316-1c4b-4281-b951-d872f2087c98
* assure model is loaded *before* showing the bookmark managerestade@chromium.org2009-08-271-4/+4
| | | | | | Review URL: http://codereview.chromium.org/173554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24581 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Set the default icon list so we don't have to set it on every window ↵estade@chromium.org2009-08-2710-10/+0
| | | | | | | | all the time. Review URL: http://codereview.chromium.org/174586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24576 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix the bounds of the clip region for tab title text.jhawkins@chromium.org2009-08-261-4/+4
| | | | | | | | BUG=19741 TEST=Open many tabs. The ellipses should not be rendered if the tab is not large enough. Review URL: http://codereview.chromium.org/174582 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24560 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Fix the find bar so the match count is inside the entry.erg@google.com2009-08-263-43/+104
| | | | | | | | | | In addition, only draw the dirty rectangle area when manually drawing a gtk entry. http://crbug.com/17962 Review URL: http://codereview.chromium.org/174577 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24558 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the bookmark model is loaded before running bookmark manager ↵estade@chromium.org2009-08-262-13/+63
| | | | | | | | | | tests. Fixes flaky browser test failures on the build bots. Also restructure the test to make adding future tests easier. Review URL: http://codereview.chromium.org/173527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24557 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't reposition the findbar when it's not visible.estade@chromium.org2009-08-262-8/+18
| | | | | | | | This gives us ~8ms of startup improvement that we lost previously from r22012. Review URL: http://codereview.chromium.org/173510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix startup regression in gtk theme mode.erg@google.com2009-08-262-1/+18
| | | | | | | | | Don't populate the image dictionary in gtk mode, in addition to not writing the images to disk. Review URL: http://codereview.chromium.org/173525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24541 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Linux Extensions Install Prompt""rafaelw@chromium.org2009-08-261-0/+147
| | | | | | | | | | | | | This relands http://codereview.chromium.org/174462 which was reverted. It now only includes the new panel for TOOLKIT_GTK (was OS_LINUX). TBR=sgk Review URL: http://codereview.chromium.org/173522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24540 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-09 00:09:30 +0000