| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
bookmark bar items for contrast.
BUG=40372
TEST=none
Review URL: http://codereview.chromium.org/4053004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38293
TEST=none
Review URL: http://codereview.chromium.org/4040004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3962004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
src/app shouldn't depend on webkit in anyway. DEPS allows this
because it allows paths pulled in by deps = {} (stuff pulled in
by gclient). Add a new rule to explicitly disallow this.
Review URL: http://codereview.chromium.org/3998004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that Ananta has graciously converted ChromeFrame to use the new SSL InfoBubble I can try again to delete the old SSL Page Info dialogs.
TBR=jcivelli
BUG=59030
TEST=None
Review URL: http://codereview.chromium.org/3927003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=1631,9315,9316,9447,10912,13053,13396,13397,13449
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3934001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3879002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds an onUpdated event that reports process metrics from the TaskManager,
and modifies the TaskManager to support multiple independent observers.
BUG=32302
TEST=ExtensionApiTest.Processes browsertest
TEST=process_monitor sample extension
Review URL: http://codereview.chromium.org/3801008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Only 424k off Linux debug .a files).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First Run. Make sure the minimum bubble is not showed if there is no default search.
This is a re-issue of CL 3565013 without the extraneous change to search_engine_list_model.mm, to be done in a forthcoming CL>
BUG=49306
TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats.
Review URL: http://codereview.chromium.org/3847006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
choose it at First Run. Make sure the minimum bubble is not showed if there is no default search.
BUG=49306
TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats.
Review URL: http://codereview.chromium.org/3565013
TBR=jeanluc@google.com
Review URL: http://codereview.chromium.org/3747009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
First Run. Make sure the minimum bubble is not showed if there is no default search.
BUG=49306
TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats.
Review URL: http://codereview.chromium.org/3565013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes modal html dialogs blend better (rather than having a white HTML background and a theme-colored border).
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3784006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes constrained html windows match HtmlDialogUI more closely. The main reason for wanting to do this is that TabContents{View} has a lot of functionality that we need, but miss out on if we use RenderViewHost directly. This isn't hooked up to anything yet, but can be tested using sync setup.
BUG=58022
TEST=manual
Review URL: http://codereview.chromium.org/3846002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48706
TEST=none
Review URL: http://codereview.chromium.org/3792007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from Win/Gtk. It has been replaced with the PageInfoBubble so it is not in use anymore.
BUG=59030
TEST=None
Review URL: http://codereview.chromium.org/3830001
TBR=finnur@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the PageInfoBubble so it is not in use anymore.
BUG=59030
TEST=None
Review URL: http://codereview.chromium.org/3830001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can't have a namespace called "linux" because it's ifdefed by GCC to be a
number. Same for "unix". "x11" was discarded because some future stuff in
here will not be related to x11.
This also renames base_paths_posix to base_paths_linux since this does not
apply to mac, and normally posix applies to mac (this confused me when I had to
edit it for the XDG stuff).
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3778007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't block with a throbber while doing a clear data operation. The views
version of this dialog disables the entire dialog and displays a throbber while
waiting for an operation to complete. We don't do that yet.
This is important because there's no way to display error codes the sync server
might throw; it's comparatively likely that deleting server side data may fail
compared to deleting local data. That's the next step.
BUG=57877
TEST=New dialog has same functionality as before; new functionality intermittently works (since we can't display errors yet).
Review URL: http://codereview.chromium.org/3574013
TBR=erg@google.com
Review URL: http://codereview.chromium.org/3841001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also rolls in some of raz@'s windows fixes.
BUG=57877
TEST=Dialog grays out before disappearing when trying to clear server side data (and handles server errors)
Review URL: http://codereview.chromium.org/3680003
TBR=erg@google.com
Review URL: http://codereview.chromium.org/3836002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behind switch
BUG=59095
TEST=See ui in options tab and clear other data tab
Review URL: http://codereview.chromium.org/3758004
TBR=raz@chromium.org
Review URL: http://codereview.chromium.org/3811008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58022
TEST=none
Review URL: http://codereview.chromium.org/3767005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59095
TEST=See ui in options tab and clear other data tab
Review URL: http://codereview.chromium.org/3758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed around BlockedPopupContainer so that it can handle any types
and made TabContents offer a mode to block all child content.
BUG=58927
TEST=enable instant, go to a site that would normally show a popup on
entering (or explicitly enable all popups). While typing in
the omnibox the popup shouldn't appear, but as soon as you
commit the instant result it should appear.
Review URL: http://codereview.chromium.org/3694005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26450
TEST=Load webpage with three JS alerts. Check "Prevent this page from creating
additional dialogs" on the second, and Cancel that alert. Ensure that the
third alert is not shown.
Review URL: http://codereview.chromium.org/3792001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds an onUpdated event that reports process metrics from the TaskManager,
and modifies the TaskManager to support multiple independent observers.
BUG=32302
TEST=ExtensionApiTest.Processes browsertest
TEST=process_monitor sample extension
Review URL: http://codereview.chromium.org/3597016
TBR=jrg@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I guess the uninitialized error only comes up in Release builds, so trybots/local compile didn't catch it.
BUG=none
TEST=compile
TBR=sadrul
Review URL: http://codereview.chromium.org/3805002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Slightly change the architecture of how icons are assigned to menu items. Also,
add stock icons for some additional menu items. And always show icons on
overflow menus.
BUG=59101
TEST=The major change here is architectural change, so there is little visible
change in functionality. But if you right click on a link, it should now show
an icon for the 'Open in new tab' menu.
patch by sadrul@chromium.org
original review: http://codereview.chromium.org/3714003/show
Review URL: http://codereview.chromium.org/3816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds an onUpdated event that reports process metrics from the TaskManager,
and modifies the TaskManager to support multiple independent observers.
BUG=32302
TEST=ExtensionApiTest.Processes browsertest
TEST=process_monitor sample extension
Review URL: http://codereview.chromium.org/3597016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=58981
TEST=Go to webpage that requires translation. Press Translate should not cause a crash.
Review URL: http://codereview.chromium.org/3771001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NEW_WINDOW. Many places were leaking a Browser and preventing Chrome
from shutting down.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3655006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename chrome_thread.cc to browser_thread.cc
- Rename chrome_thread_unittest.cc to browser_thread_unittest.cc
- Include browser_thread.h instead of chrome_thread.h where needed.
- Fix gyp files according.
BUG=56926
TEST=trybots and compiled locally
Review URL: http://codereview.chromium.org/3643005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Minor cleanup of CertificateManagerModel by removing some wrappers of CertDatabase readonly functions.
BUG=19991
TEST=manual
Review URL: http://codereview.chromium.org/3516023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added generalized support for accelerators to info_bubble_gtk by
adding a info_bubble_accelerators_gtk class and refactoring the
handling of accelerators in info_bubble_gtk. In addition, added the
ability to forward accelerators to the browser window. Specifically
added support for Ctrl-w, so that the bookmark bubble now will close
when that accelerator is used and the associated tab will close
also. The infrastructure that I have added will allow for the addition
of other accelerators as desired. What accelerators that should be
added from the browser set and what their behaviour should be is not
defined and thus should be handled in a different bug.
BUG=chromium:23930
TEST=Click the star on a website to bookmark it and hit C-w to close it and the tab. Esc still works to just close the bubble.
Review URL: http://codereview.chromium.org/3393009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also rolls in some of raz@'s windows fixes.
BUG=57877
TEST=Dialog grays out before disappearing when trying to clear server side data (and handles server errors)
Review URL: http://codereview.chromium.org/3680003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Include browser_thread.h instead of chrome_thread.h in more 70 files.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3734002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- explicitly invalidate the tab contents (makes appearance of drop shadow less delayed/janky)
- correct color of closing infobar arrow
- correct color of infobar arrow after the top infobar was closed and a lower one of a different color took its place
BUG=48996
TEST=manual (see above)
Review URL: http://codereview.chromium.org/3656001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is triggered by the secure infobars on the new tab page when toggling the floating bookmark bar. The reason it comes up is because it applies in the CairoShowRect() case, but not in the XShowRect() case.
BUG=none
TEST=manual; perf bots (after landing)
Review URL: http://codereview.chromium.org/3644001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
try to make the shadow follow the arrow's contour better with some fuzzy math.
BUG=48996
TEST=visual
Review URL: http://codereview.chromium.org/3674003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The click-to-play default setting says "Let me choose which plug-ins to run".
XIB changes: Change the middle radio button label in plug-in default settings from IDS_PLUGINS_LOAD_SANDBOXED_RADIO to IDS_PLUGINS_ASK_RADIO.
BUG=35316,56514,56270
TEST=ContentSettingsBubbleModelTest.*, mainly
Review URL: http://codereview.chromium.org/3608007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
methods. Adds empty implementations on Mac and Linux.
BUG=56385
TEST=No visible impact.
Review URL: http://codereview.chromium.org/3625004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The test was failing because we get a call to UpdatePageActions while we are in the process of creating PageActions, which leads to an infinite loop (create vector, add page action, update page actions, delete vector, create vector, ...).
BUG=58141
TEST=ExtensionApiTest.TestCrash57333
Review URL: http://codereview.chromium.org/3632001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename entries under geolocation, google, gtk, history and importer.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3646002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58480
TEST=manual
Review URL: http://codereview.chromium.org/3646001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were already doing this with other info bars, this one just
slipped through the cracks.
BUG=58371
TEST=Install a dark theme and navigate to http://html5demos.com/geo . The
text in the info bar should be readable.
Review URL: http://codereview.chromium.org/3629004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't support the multiple infobar case. It does however support the following:
- There is a drop shadow over the render view content, over the toolbar area, and an arrow to the location icon.
- animations while enabling/disabling the bookmark bar, on normal page or NTP
- different infobar colors
- switching between tabs with or without infobars
- animated appearance/disappearance (animation is alpha-fade)
Popup windows don't appear to support infobars (at least I can't get an infobar to open in a popup window), but this new code doesn't cause crashes there either.
BUG=48996
TEST=manual (see above)
Review URL: http://codereview.chromium.org/3621010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds nice little icons in the menus (both for context and window
menus). At this moment, only standard stock icons are used. It will be possible
to add new stock icons of Chrome's own for the items that currently don't have
any corresponding GTK+ stock icons.
BUG=None
TEST=Open the wrench menu, or context menu for the tab content/tab title etc.,
and you should see nice little icons on the left for many items.
Review URL: http://codereview.chromium.org/3619010
Patch from Sadrul Chowdhury <sadrul@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
reference counting and deleting an unused set of methods to simplify.
Should help with flakiness in ExtensionApiTest.Tabs and other tests.
BUG=58269
TEST=trybots; modified existing unit tests to exercise new paths.
Review URL: http://codereview.chromium.org/3525021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a pre-requisite for http://codereview.chromium.org/3529008/show
There are no functional changes, it's only refactoring existing code.
BUG=None
TEST=Go to an https:// page and check the certificate info.
Review URL: http://codereview.chromium.org/3565006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61944 0039d316-1c4b-4281-b951-d872f2087c98
|