summaryrefslogtreecommitdiffstats
path: root/chrome/browser/history
Commit message (Collapse)AuthorAgeFilesLines
* Create the DownloadItem earlier in the download process.ahendrickson@chromium.org2010-12-231-1/+1
| | | | | | | | | | | Since DownloadItem is now created before we analyze the file to determine its characteristics and final name/location, I have added a function SetFileCheckResults() to update DownloadItem after this process has been done. BUG=None TEST=None Review URL: http://codereview.chromium.org/5738007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70096 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h, part 2.thestig@chromium.org2010-12-173-3/+7
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69576 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h.thestig@chromium.org2010-12-171-1/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5875005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69507 0039d316-1c4b-4281-b951-d872f2087c98
* Make us save favicon in incognito mode if the url is bookmarked. Thissky@chromium.org2010-12-155-2/+33
| | | | | | | | | | | way the bookmark bar/manager have a favicon for the page. BUG=22670 TEST=see bug Review URL: http://codereview.chromium.org/5753007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69345 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h in other headers.thestig@chromium.org2010-12-151-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5783006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69321 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting second word iterator patch for tsepez. this was originally ↵cdn@chromium.org2010-12-152-8/+8
| | | | | | | | reviewed at http://codereview.chromium.org/5796003/ Review URL: http://codereview.chromium.org/5707011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69278 0039d316-1c4b-4281-b951-d872f2087c98
* Last few NewRunnableMethod scoped_refptr params to fix.willchan@chromium.org2010-12-151-1/+1
| | | | | | | | | BUG=28083 TEST=builds Review URL: http://codereview.chromium.org/5870001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69229 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded browser_thread.h usage.thestig@chromium.org2010-12-132-1/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5676004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69037 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ICU header dependencies outside of /i18n directory.cdn@chromium.org2010-12-101-0/+1
| | | | | | | | | | Committing for tsepez. Original code review is here http://codereview.chromium.org/5682002/ BUG=49747 TEST=WordIteratorTest.* Review URL: http://codereview.chromium.org/5718003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68867 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "virtual" keyword on method overrides that are missing it.erg@google.com2010-12-081-2/+2
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5648004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
* Move more code from headers to implementation.erg@google.com2010-12-072-2/+20
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bogus member variable initialization uncovered by Clang buildbot.pkasting@chromium.org2010-12-071-1/+1
| | | | | | | | BUG=9044 TEST=Clang builds git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68410 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the "dangerous download" algorithm as follows. Original patch by ↵pkasting@chromium.org2010-12-063-4/+9
| | | | | | | | | | | | | | | | | | | | Pierre-Antoine LaFayette (see http://codereview.chromium.org/1403001/ ), r=me,brettw,aa. Downloads are considered dangerous if: a) The file is dangerous just by sitting on the drive, without needing to be clicked on e.g. dll, xbap b) The file is executable and the download was not user initiated. c) They are an extension that is not from the gallery We have defined a user initiated download as 3 possible cases: a) A user enters a URL into the address bar that is a file b) A user left clicks on a URL that is a file c) A user right clicks and does "Save As" on a URL that is a file. BUG=9044 TEST=Open a page with a download link to a dangerous file that is not an extension, e.g. an .exe file, and left click on the link. The download should proceed without a prompt. Review URL: http://codereview.chromium.org/5603008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68406 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded browser_process.h includes.thestig@chromium.org2010-12-051-1/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5512009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68323 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove stub scoped_variant_win.h file.tfarina@chromium.org2010-12-041-4/+6
| | | | | | | | | | | Fix the callers and add base::win in the call sites. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5507001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68251 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the include footprint of pref_service.hmnissler@chromium.org2010-12-031-0/+2
| | | | | | | | | | | | | | | This removes the pref_value_store.h header from the pref_service.h include list and cleans up any users that were getting the MessageLoop and BrowserThread definitions indirectly through pref_service.h BUG=64893 TEST=compiles and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67997 Review URL: http://codereview.chromium.org/5461001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68157 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-024-5/+5
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67997 - Reduce the include footprint of pref_service.hmnissler@chromium.org2010-12-021-2/+0
| | | | | | | | | | | | | | | | This removes the pref_value_store.h header from the pref_service.h include list and cleans up any users that were getting the MessageLoop and BrowserThread definitions indirectly through pref_service.h BUG=64893 TEST=compiles and passes tests Review URL: http://codereview.chromium.org/5461001 TBR=mnissler@chromium.org Review URL: http://codereview.chromium.org/5575001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67998 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the include footprint of pref_service.hmnissler@chromium.org2010-12-021-0/+2
| | | | | | | | | | | | | This removes the pref_value_store.h header from the pref_service.h include list and cleans up any users that were getting the MessageLoop and BrowserThread definitions indirectly through pref_service.h BUG=64893 TEST=compiles and passes tests Review URL: http://codereview.chromium.org/5461001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67997 0039d316-1c4b-4281-b951-d872f2087c98
* Undisable tests that were disabled because of the leaked processes issue.phajdan.jr@chromium.org2010-11-301-8/+1
| | | | | | | | | | | TBR=thomasvl BUG=50060 TEST=none Review URL: http://codereview.chromium.org/5396003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67710 0039d316-1c4b-4281-b951-d872f2087c98
* Logging downloads.ahendrickson@chromium.org2010-11-242-1/+32
| | | | | | | | | BUG=None TEST=None. Review URL: http://codereview.chromium.org/4222004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67322 0039d316-1c4b-4281-b951-d872f2087c98
* Add pyauto hook for getting and manipulating the data underneath the NTP.kkania@chromium.org2010-11-192-18/+37
| | | | | | | | | BUG=49113 TEST=none Review URL: http://codereview.chromium.org/5088001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66709 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 1].jhawkins@chromium.org2010-11-161-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5043001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66198 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move StringSplitAlongWhitespace to string_split.htfarina@chromium.org2010-11-151-2/+3
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5004002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66181 0039d316-1c4b-4281-b951-d872f2087c98
* base: Get rid of 'using' declaration of StringAppendF.tfarina@chromium.org2010-11-151-2/+2
| | | | | | | | | | | Update the callers to append base:: in the calls to StringAppendF. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4974001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66116 0039d316-1c4b-4281-b951-d872f2087c98
* Crash fix: Don't use const-ref parameter for an async callback.jhawkins@chromium.org2010-11-111-1/+1
| | | | | | | | | BUG=62739 TEST=none Review URL: http://codereview.chromium.org/4708007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65836 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the RedirectTest.ClientEmptyReferer as flaky.ananta@chromium.org2010-11-111-1/+2
| | | | | | | | | Bug=62772 TBR=jcivelli Review URL: http://codereview.chromium.org/4722003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65762 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass parameters by reference.jhawkins@chromium.org2010-11-081-1/+2
| | | | | | | | | | | CID=2099,2573,2574,2575,2576,2633,2667, 2673,2674,5148,6514,7758,8059,8060,8071 BUG=none TEST=none Review URL: http://codereview.chromium.org/4527006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65437 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing unit_test crash on mac bots. The main egregioussky@chromium.org2010-11-082-8/+11
| | | | | | | | | | | | | | | | | error I noticed is that ProfileManagerTest was leaking two history services. I don't know how this would cause the crash though. I also added the thread_ checks to HistoryService as it's possible for the HistoryService to be used after Cleanup (processing notifications). And I removed the registration of the listener in History() as it doesn't appear to be needed, and if needed results in listening to too much. BUG=61982 TEST=none Review URL: http://codereview.chromium.org/4534001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65430 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in TopSitesBackend where it wasn't null checkingsky@chromium.org2010-11-041-1/+3
| | | | | | | | | | | the db. BUG=61919 TEST=none Review URL: http://codereview.chromium.org/4446004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65120 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in TopSitesDB where it could end up crashing if thumbnailsky@chromium.org2010-11-041-6/+6
| | | | | | | | | | | was empty. BUG=61917 TEST=none Review URL: http://codereview.chromium.org/4410004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65119 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the in memory db update keyword search terms.sky@chromium.org2010-11-046-24/+97
| | | | | | | | | BUG=61518 TEST=none Review URL: http://codereview.chromium.org/4449002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65065 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to improve memory consumption by TopSites. The biggest culpritsky@chromium.org2010-11-026-52/+126
| | | | | | | | | | | | | | | | | | | | seems to repeatedly querying history during this perf test. So, the biggest gain is made by scaling this back. Here are other tweaks I've made: . decrease the page size/cache size of the two DBs. Now that favicons doesn't store thumbnails the db doesn't need to be so big. . Set a cap to the max number of tmp thumnbails maintains. . Force jpg data vector to be only as big as it needs to be. . Tweak TopSitesCache so it doesn't end up duplicating so many GURLs. This is particularly helpful for long redirect lists. BUG=61487 TEST=none Review URL: http://codereview.chromium.org/4106014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64837 0039d316-1c4b-4281-b951-d872f2087c98
* Adds keyword_search_terms to in memory db so that we can synchronouslysky@chromium.org2010-11-016-9/+71
| | | | | | | | | | | get past searches. BUG=none TEST=none Review URL: http://codereview.chromium.org/4087013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64668 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing top sites refactor:sky@chromium.org2010-10-2720-1918/+2441
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactors TopSites so that it's hopefully easier to maintain and doesn't suffer the plethora of threading issues that exist with the current version. Here's the breakdown of what was refactored: . TopSitesCache: Contains the most visited urls and thumbnails. . TopSitesBackend: All mutations to topsites data end up calling into the backend on the UI thread. TopSitesBackend processes the method on the DB thread calling through to the TopSitesDatabase. . TopSites: uses two TopSitesCache. One that contains the raw history data, the other contains the processed data (pinned/blacklisted). The processed cache can be accessed on any thread. TopSites waits until history loads to know if it should migrate or use it's own db. I could probably make these execute in parallel, but for now this is how it works. This patch also makes it so the dom ui accesses the thumbnails on the IO thread. BUG=56382 TEST=Make sure all your thumbnails are correctly updated and you don't see problems. Review URL: http://codereview.chromium.org/4051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64072 0039d316-1c4b-4281-b951-d872f2087c98
* Make history notification's destructors all virtual, since the base class is.jochen@chromium.org2010-10-271-5/+5
| | | | | | | | | BUG=27936,59023 TEST=no new leaks, although I removed suppressions Review URL: http://codereview.chromium.org/4142007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64064 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix several pass-by-values.jhawkins@chromium.org2010-10-265-14/+16
| | | | | | | | | | CID=12543,12544,12758,12878,12879,12918,13252,13285,13301,13391 BUG=none TEST=none Review URL: http://codereview.chromium.org/4040003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63910 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63687 - Refactors TopSites so that it's hopefully easier to maintain andsky@chromium.org2010-10-2419-2236/+1816
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | doesn't suffer the plethora of threading issues that exist with the current version. Here's the breakdown of what was refactored: . TopSitesCache: Contains the most visited urls and thumbnails. . TopSitesBackend: All mutations to topsites data end up calling into the backend on the UI thread. TopSitesBackend processes the method on the DB thread calling through to the TopSitesDatabase. . TopSites: uses two TopSitesCache. One that contains the raw history data, the other contains the processed data (pinned/blacklisted). The processed cache can be accessed on any thread. TopSites waits until history loads to know if it should migrate or use it's own db. I could probably make these execute in parallel, but for now this is how it works. This patch also makes it so the dom ui accesses the thumbnails on the IO thread. BUG=56382 TEST=Make sure all your thumbnails are correctly updated and you don't see problems. Review URL: http://codereview.chromium.org/3440018 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/4048005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63695 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors TopSites so that it's hopefully easier to maintain andsky@chromium.org2010-10-2419-1816/+2236
| | | | | | | | | | | | | | | | | | | | | | | | | | | | doesn't suffer the plethora of threading issues that exist with the current version. Here's the breakdown of what was refactored: . TopSitesCache: Contains the most visited urls and thumbnails. . TopSitesBackend: All mutations to topsites data end up calling into the backend on the UI thread. TopSitesBackend processes the method on the DB thread calling through to the TopSitesDatabase. . TopSites: uses two TopSitesCache. One that contains the raw history data, the other contains the processed data (pinned/blacklisted). The processed cache can be accessed on any thread. TopSites waits until history loads to know if it should migrate or use it's own db. I could probably make these execute in parallel, but for now this is how it works. This patch also makes it so the dom ui accesses the thumbnails on the IO thread. BUG=56382 TEST=Make sure all your thumbnails are correctly updated and you don't see problems. Review URL: http://codereview.chromium.org/3440018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63687 0039d316-1c4b-4281-b951-d872f2087c98
* Update code that previously constructed strings from string iterators only ↵erikwright@chromium.org2010-10-221-2/+2
| | | | | | | | | | to use StringToInt. These usages now pass the iterators directly to the new StringToInt overloads. BUG=None TEST=All Review URL: http://codereview.chromium.org/3968001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63515 0039d316-1c4b-4281-b951-d872f2087c98
* Move inspector to "chrome-devtools" schemepodivilov@chromium.org2010-10-221-0/+1
| | | | | | | | Pages with "chrome" scheme have very narrow permissions (e.g. no access to localStorage). We want inspector page to have the same permissions as usual page. Review URL: http://codereview.chromium.org/3838005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63495 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - misc. chrome/browser/*/*.pkasting@chromium.org2010-10-212-3/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4009001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63420 0039d316-1c4b-4281-b951-d872f2087c98
* RedirectTest.ClientEmptyReferer works with a test_server on ephemeral ports.cbentzel@chromium.org2010-10-211-5/+25
| | | | | | | | | BUG=56814 TEST=ui_tests --gtest_filter="*ClientEmptyReferer*" Review URL: http://codereview.chromium.org/4026002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63382 0039d316-1c4b-4281-b951-d872f2087c98
* Change to use the new FORMAT_SkBitmap when encoding SkBitmap to jpeg.klobag@chromium.org2010-10-202-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3757008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63270 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more deinlining.erg@google.com2010-10-204-5/+57
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63261 0039d316-1c4b-4281-b951-d872f2087c98
* Remove scoped_bstr_win, fix all callers to use the new location.brettw@chromium.org2010-10-201-3/+6
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3748012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63216 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59851 since we now avoid the problem with the testing webserver.thomasvl@chromium.org2010-10-201-2/+1
| | | | | | | | BUG=55380 TEST=green tree Review URL: http://codereview.chromium.org/3871002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63210 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more ctor/virtual deinlining.erg@google.com2010-10-196-22/+33
| | | | | | | | | | | (Only 424k off Linux debug .a files). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3859003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-171-2/+2
| | | | | | | | | | | | removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 10:29:55 +0000