summaryrefslogtreecommitdiffstats
path: root/chrome/browser/history
Commit message (Collapse)AuthorAgeFilesLines
* Reupload of 12418glen@chromium.org2008-12-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of kPathSeparator on windows. Port some wstring function to take ↵estade@chromium.org2008-12-043-9/+10
| | | | | | | | FilePaths. Re-enable relevant posix unit tests. Review URL: http://codereview.chromium.org/12893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6387 0039d316-1c4b-4281-b951-d872f2087c98
* Make WordIterator and Snippet::MatchPositions use size_t instead of int for ↵pkasting@chromium.org2008-12-035-54/+50
| | | | | | | | offsets into strings. This avoids some casts. I also added a typedef for Snippet::MatchPosition which cleans up a bit of the calling code a little. Review URL: http://codereview.chromium.org/13064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6260 0039d316-1c4b-4281-b951-d872f2087c98
* * Cleanup: move base/platform_test.h -> testing/jeremy@chromium.org2008-12-021-1/+1
| | | | | | | | * Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild Review URL: http://codereview.chromium.org/13052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6227 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/ - part 1.deanm@chromium.org2008-11-252-5/+6
| | | | | | | Review URL: http://codereview.chromium.org/11402 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6007 0039d316-1c4b-4281-b951-d872f2087c98
* Rid most of the Browser object of HWND dependencies.ben@chromium.org2008-11-141-1/+5
| | | | | | Review URL: http://codereview.chromium.org/10929 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5492 0039d316-1c4b-4281-b951-d872f2087c98
* Port some unit tests in chrome/browser/agl@chromium.org2008-11-144-38/+25
| | | | | | | | | | | | | This first requires http://codereview.chromium.org/8618 . Only snippet_unittest is enabled for build. For rest of files it's only a platform cleanup. Review URL: http://codereview.chromium.org/8191 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5488 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/agl@chromium.org2008-11-144-41/+16
| | | | | | | | | | | | | | | #ifdef out windows-specific portion of chrome/common/l10n_util.h, which allows me to port some other files. I also extracted parts of chrome/views/tree_view.h to tree_model.h, so that ATL/WTL-specific parts stay in tree_view.h, but tree_model.h is platform-independent and can be included in files using it as base class. Review URL: http://codereview.chromium.org/8618 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix history_indexer.idl to stop from rebuilding it every time.maruel@chromium.org2008-11-121-0/+12
| | | | | | Review URL: http://codereview.chromium.org/10816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5235 0039d316-1c4b-4281-b951-d872f2087c98
* Fix initialization order to fix Mac & Linux.brettw@google.com2008-11-071-2/+2
| | | | | | Review URL: http://codereview.chromium.org/10209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5003 0039d316-1c4b-4281-b951-d872f2087c98
* Added a new interface IChromeHistoryIndexer which needs to be implemented bybrettw@google.com2008-11-0713-60/+434
| | | | | | | | | | | indexers which are interested in indexing Chrome's web history. These should register their CLSID in HKCU\Software\Google\Google Chrome\IndexerPlugins and this is be used by Chrome to publish its index. Added code to publish the index too. Checked in for Vijay Thadkal <veejay.t.s@gmail.com> (Google). Reitveld #9007. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5002 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace typo fix from CL 8722agl@chromium.org2008-11-051-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/9611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4839 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash when getting strings out of the database. column_text is a ↵brettw@google.com2008-11-052-3/+3
| | | | | | | | | little dangerous because it can return NULL. Most STL string stuff can't handle this. I changed the uses to column_string() which handles NULL properly and generates STL strings for us. BUG=3770 Review URL: http://codereview.chromium.org/9189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4811 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap forward declarations in their relevant namespaceagl@chromium.org2008-11-051-1/+3
| | | | | | | | | | Forward declarations can't simply use "class $namespace::$class;" syntax. Instead one needs to use "namespace $namespace { class $class; }" syntax. Review URL: http://codereview.chromium.org/8722 Patch from James Vega. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4723 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure titles and bodies of web pages that come into the history system verybrettw@google.com2008-10-305-32/+139
| | | | | | | | | late are indexed. Very slow pages (>20 seconds) would previously not get indexed. BUG=3835 Review URL: http://codereview.chromium.org/8899 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4201 0039d316-1c4b-4281-b951-d872f2087c98
* Add compatible version support since it was only halfway in place, and try ↵pkasting@chromium.org2008-10-305-41/+65
| | | | | | | | | | | | | and make our database versioning code and logging more similar across various consumers. The compatible version support isn't really used yet. It was going to be used for my cookie change until we decided that the old code was too busted to be forward-compatible. It seems worthwhile to put this in but maybe I am wrong. The logging similarity stuff is fairly useful. In a couple consumers in the old code, we DLOGed instead of LOGing, which meant that most people would get nothing in the log at all. I think it's a little weird that in a lot of these consumers, logging is all we do; for example, if you use a too-new cookie DB, you get output in the log, but no actual dialog box while the browser is running -- your cookies just silently don't get saved to disk. Seems bad, but I'm not prepared to try and do major surgery to address that (and add translated strings, etc.). At least now we'll actually get log messages in release builds instead of nothing at all. Because my last-access change touches this code, I'm considering asking that this change be merged back to the branch. Review URL: http://codereview.chromium.org/8712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4195 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial patch: add whitespace to some SQL statements to turn "INSERT INTO ↵pkasting@chromium.org2008-10-293-8/+8
| | | | | | | | | foo(bar,baz)VALUES(?,?)" into "INSERT INTO foo (bar, baz) VALUES (?,?)" (which is the way we have it in most of our code). This was annoying me while I tried to track down cases where we omitted the appropriate fieldnames from our SQL statements. Review URL: http://codereview.chromium.org/8855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4145 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-2735-87/+139
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Make ChromeThreadTest and TextDatabaseTest inherit from PlatformTest formark@chromium.org2008-10-171-1/+4
| | | | | | | autorelease pool management on the Mac. Review URL: http://codereview.chromium.org/7640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 3470, where the download tab would show the temporary name for ↵jcampan@chromium.org2008-10-171-2/+4
| | | | | | | | | | | | dangerous downloads (see download_tab_view.cc). Also fixes bug 3471, where if the same file is downloaded again while the first one is not finished, they would get the same name. For dangerous downloads, we now uniquify the path on download start (so the UI shows a file name most likely to be the final name), and on download complete (so if there 2 simultaneous downloads of the same file the last one does not overwrite the first). BUG=3470, 3471 TEST=see bugs Review URL: http://codereview.chromium.org/7395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3536 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-161-1/+1
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-107-1/+41
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
* Port some more of chrome/ to Linux.deanm@google.com2008-10-0211-36/+39
| | | | | | | | Original review: http://codereview.chromium.org/4247 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2793 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform wrappers for fopen, _wfopen_s, etc.mark@chromium.org2008-10-011-5/+5
| | | | | | | | | Patch by Paweł Hajdan jr <phajdan.jr@gmail.com>. http://codereview.chromium.org/6005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2760 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging of loading/saving bookmarks to help me diagnose why somesky@google.com2008-09-161-0/+1
| | | | | | | | | | | folks are having problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/2914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2290 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-132-2/+2
| | | | | | | | | browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BoomarkBarModel to BookmarkModel.sky@google.com2008-09-113-14/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2057 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmark related classes into bookmarks directory. There are nosky@google.com2008-09-093-4/+4
| | | | | | | | | | | | code changes here (other than converting to COPY_AND_BLAH_BLAH and updating include guards). BUG=none TEST=none Review URL: http://codereview.chromium.org/1868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1944 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the query parser to provide the position of the match in thesky@google.com2008-08-295-38/+98
| | | | | | | | | | | | title. I'm going to use this in the omnibox. There are a couple of other random spelling errors I came across that are included for your review pleasure. BUG=1256202 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1546 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Google Chrome specific strings from common resources file and use ↵rahulk@google.com2008-08-271-0/+2
| | | | | | | | | them from new resources file that is specific to only Google Chrome. BUG=1110882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1473 0039d316-1c4b-4281-b951-d872f2087c98
* Makes deleting history no longer delete starred urls. Thiseffectively ↵sky@google.com2008-08-2714-241/+603
| | | | | | reenables the code in ExpireHistoryBackend. I also madethe code consistent so that when we delete visits as the result ofhistory deletion we don't change the typed/visit count of theunderlying url.BUG=1214201 1256202TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1423 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes corresponding to my message_loop_type CL.darin@google.com2008-08-265-2/+13
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1363 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in HistoryProfileTest.TypicalProfileVersion.erikkay@google.com2008-08-251-8/+9
| | | | | | | | sqlite3_close returns SQLITE_BUSY if there are any outstanding statements. Since the SQLStatement object hadn't been destroyed, finalize hadn't been called, so the close failed and a lot of sqlite stuff leaked. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1321 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bogus typedef for HistoryService's empty callback. This turnedsky@google.com2008-08-241-1/+1
| | | | | | | | | | up as an UMR. I'm surprised this didn't produce a compiler error. BUG=1338601 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1291 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-2458-1630/+232
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmarks out of history into its own file (JSON).sky@google.com2008-08-2128-1665/+351
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Interesting points: . Migration was a bit atypical. Here is the approach I took: . If the URL db contains bookmarks it writes the bookmarks to a temporary file. . When the bookmark bar model is loaded it assumes bookmarks are stored in a file. If the bookmarks file doesn't exist it then attempts to load from history, after waiting for history to finish processing tasks. . I've broken having the omnibox query for starred only. This patch was already too ginormous for me to contemplate this too. I'll return to it after I land this. . Similarly the history page isn't searching for starred titles now. As we discussed with Glen, that is probably fine for now. . I've converted NOTIFY_STARRED_FAVICON_CHANGED to NOTIFY_FAVICON_CHANGED and it is notified ANY time a favicon changes. I'm mildly concerned about the extra notifications, but without having history know about starred it's the best I can do for now. . Autocomplete (specifically URLDatabase::AutocompleteForPrefix) previously sorted by starred. It can no longer do this. I don't think I can get this functionality back:( Luckily it only mattered if you had a starred and non-starred URL with the same type count that matched a query. Probably pretty rare. What's left: . Fix up HistoryContentsProvider to query for starred entries titles. . Clean up the delete all case. I basically just made it compile; it can be greatly simplified. . Rename BookmarkBarModel to BookmarksModel. BUG=1256202 TEST=this is a huge change to bookmarks. Thanfully it's pretty well covered by tests, none-the-less make sure you exercise bookmarks pretty heavily to make sure nothing is busted. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1153 0039d316-1c4b-4281-b951-d872f2087c98
* Use %ls instead of %s in wprintf format strings for wchar_t fields.mmentovai@google.com2008-08-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@846 0039d316-1c4b-4281-b951-d872f2087c98
* First, this removes the dependency of NavigationController on thebrettw@google.com2008-08-131-12/+0
| | | | | | | | | | | | | | | | | | | | | | SessionService. There were already some notifications that could be used to tell what's going on, and I filled out the rest. I moved some notifications from various places to the NavigationController. In ssl_blocking_page, I removed a notification because it also calls DidNavigateToEntry which does the notification (we got duplicate calls before). In browser.cc I removed the tab parented notification since this is already called by NavigationController::SetWindowID. I removed some obsolete notifications and associated structures, especially in history (like HOST_DELETED that was never issued). I renamed the window_map_ in the MetricsService becuase it was actually a map of controllers and Windows. This also reorders the navigation_types header file to try to bring some order to it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@807 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK in history_backend by ensuring we clear redirect tracking state ↵timsteele@google.com2008-08-011-1/+61
| | | | | | | | | | | | | whenever the RenderView is told that a provisional load has started for the main frame. The DCHECK(params->referrer == params->redirects[0]) was firing because: a) page A was loaded, triggered WillPerformClientRedirect b) after the provisional load started for the destination page of A's client redirect, but before this load was committed, the browser makes a Navigation request for page B. c) When page B's load is committed, the RenderView's completed_client_redirect_src_ was still set, resulting in a CLIENT_REDIRECT transition type and forwarding the src value through params->referrer -- but params->redirects was now completely unrelated. Kaboom. This fix should be general enough to handle cases (that are relatively likely in the wild) where WebKit legitimately cancels the redirect, instead of just the browser doing so. Note we can't depend on dispatchDidCancelClientRedirect because we get that callback on both completion and cancellation of a client redirect. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251 0039d316-1c4b-4281-b951-d872f2087c98
* Move more net classes into the net namespace. Also remove the net_util ↵darin@google.com2008-07-311-5/+5
| | | | | | | | namespace in favor of the net namespace. This is a purely mechanical change. There should be no logic changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192 0039d316-1c4b-4281-b951-d872f2087c98
* Removes a method never implemented in HistoryDB.sky@google.com2008-07-301-3/+0
| | | | | | | | | BUG=none TEST=none; this is just cleanup git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144 0039d316-1c4b-4281-b951-d872f2087c98
* Try to cut down on some unnecessary dependencies. Remove any unused ↵deanm@google.com2008-07-281-1/+0
| | | | | | includes of gurl.h in header files, and forward declare GURL where possible. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-2658-0/+19604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 01:53:56 +0000