| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And add a beacon to the histograms to allow identification of users in it.
isherman: for field trial and histogram stuff (all files)
sky: for OWNERs approval history stuff
BUG=
TEST=by hand, changed probabilities of field trial, looked at omnibox behavior and histogram behavior
Review URL: https://chromiumcodereview.appspot.com/10532149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
URLID, as it should.
BUG=None
TEST=No user visible change
Review URL: https://chromiumcodereview.appspot.com/10545113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will be needed in webkit/dom_storage/.
BUG=NONE
TEST=Existing tests.
Review URL: https://chromiumcodereview.appspot.com/10540003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove logically dead code. The value of "term_score" in the else block
is between 10 and 29, therefore, the condition "term_score <=30" cannot
be false.
CID=104184.
BUG=none
TEST=none
TBR=sky@chromium.org,mpearson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10535084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=104183
BUG=none
TEST=none
TBR=sky@chromium.org,mpearson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10540082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the "new scoring" function codepath in HistoryQuickProvider, don't count matches in the top level domain name (com, net, etc.).
BUG=
TEST=try the omnibox input "c"; results are much better now (not .com sites orderd by number of visits)
Review URL: https://chromiumcodereview.appspot.com/10534067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
History.
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10534062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
just performs the initial conversion. Separate CLs to take care of the removal of profile_->Get<Serivce> will follow.
BUG=97804,112525
TEST=no new, passes existing unittests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138867
Review URL: https://chromiumcodereview.appspot.com/10399087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
suggested page's score.
Since I can't ask georgey what the intent behind the old logic was anymore, I rewrote it so that it makes more sense to me. This should also help speed up the query, as well as remove the chance of an infinite loop in the case of cyclic redirect chains.
BUG=125447
TEST=
Review URL: https://chromiumcodereview.appspot.com/10517012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Created scored_history_match.h/cc and moved the ScoredHistoryMatch struct therein. Moved all scoring functions into that struct.
Created scored_history_match_unittest.cc and moved scoring tests therein.
BUG=None
TEST=All unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10541045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new algorithm relies on multiplicative boosts. The final score is a product of topicality score, URL popularity, and recency. The final score can
become very large.
The new scoring is enabled by a command line flag.
In another changelist I plan to add an about:flag for it.
BUG=
TEST=by hand
Review URL: https://chromiumcodereview.appspot.com/9428008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is computed for segment IDs, and not URL IDs.
BUG=none
TEST=Open chrome://suggestions-internals/, and verify that there is data in all
of the extended_info.* columns, for every row that has data in at least one of
those columns (extended_info.*).
Review URL: https://chromiumcodereview.appspot.com/10538006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, adds three columns: "total visits", "duration opened" and "seconds since last visit".
BUG=none
TEST=Open the chrome://suggestions-internals/ page, and verify that there is at least one entry in each of these columns: "total visits", "duration opened" and "seconds since last visit".
Review URL: https://chromiumcodereview.appspot.com/10444048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
way we can enforce that internal content headers don't leak to embedders.
BUG=98716
TBR=phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10500016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
can enforce that internal content headers don't leak to embedders. Move these headers into the content namespace in the process.
BUG=98716
TBR=phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10497009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Passed the existing tests
Review URL: https://chromiumcodereview.appspot.com/10440103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SearchProvider::NavigationToMatch authored by PKasting.
Consolidate URLPrefix code; add many unit test cases.
Trim |contents| and |fill_into_edit|'s http scheme if:
-the input does not contain "http:"
-and the input is not a leading substring of "http:".
TODO: Add file and chrome schemes as inlineable prefixes?
TBR=sky (chrome/browser/history OWNERS)
BUG=125871
TEST=Automated; manual with upcoming suggest experiments.
Review URL: https://chromiumcodereview.appspot.com/10396002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=owners
Review URL: https://chromiumcodereview.appspot.com/10386221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reports
Revert 138867 - Converting BookmarkModel and HistoryService to ProfileKeyedServices. This just performs the initial conversion. Separate CLs to take care of the removal of profile_->Get<Serivce> will follow.
BUG=97804,112525
TEST=no new, passes existing unittests
Review URL: https://chromiumcodereview.appspot.com/10399087
TBR=rlp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10444018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
just performs the initial conversion. Separate CLs to take care of the removal of profile_->Get<Serivce> will follow.
BUG=97804,112525
TEST=no new, passes existing unittests
Review URL: https://chromiumcodereview.appspot.com/10399087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
...instead of a Browser. This makes the function more general and will allow me to call it directly from some new unit tests that don't actually have a Browser, but do have a HistoryService.
BUG=NONE
TEST=Existing tests pass.
Review URL: https://chromiumcodereview.appspot.com/10332316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requested scale factor."
Relanding original CL 137734, http://codereview.chromium.org/10387010/.
TBR=aa,abodenha,ben,sail,tony
BUG=123611
TEST=All try bots pass and aura runs without errors.
Review URL: https://chromiumcodereview.appspot.com/10412004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117262
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10375021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scale factor.
Return the best match for a requested scale factor when fetching raw image data from ResourceBundle.
TBR=aa,abodenha
BUG=123611
TEST=ResourceBundle.LoadImageResourceBytes
Review URL: https://chromiumcodereview.appspot.com/10387010
TBR=flackr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Return the best match for a requested scale factor when fetching raw image data from ResourceBundle.
TBR=aa,abodenha
BUG=123611
TEST=ResourceBundle.LoadImageResourceBytes
Review URL: https://chromiumcodereview.appspot.com/10387010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10060003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137075
Review URL: https://chromiumcodereview.appspot.com/10378009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Review URL: https://chromiumcodereview.appspot.com/10378009
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10332163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Review URL: https://chromiumcodereview.appspot.com/10378009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Review URL: https://chromiumcodereview.appspot.com/10378009
TBR=pkotwicz@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136813
Review URL: https://chromiumcodereview.appspot.com/10383153
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Review URL: https://chromiumcodereview.appspot.com/10378009
TBR=pkotwicz@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136813
Review URL: https://chromiumcodereview.appspot.com/10383153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136812
Review URL: https://chromiumcodereview.appspot.com/10378009
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136812
Review URL: https://chromiumcodereview.appspot.com/10378009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Review URL: https://chromiumcodereview.appspot.com/10378009
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=124566
Test=Compiles on CrOS,Mac
Review URL: https://chromiumcodereview.appspot.com/10378009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=124508
TEST=existing tests suffice
Review URL: https://chromiumcodereview.appspot.com/10380015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code added a new search term.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10381042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=103734
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10382032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When duplicating the IMUI private data, must also duplicate the wordstarts.
BUG=126299
TEST=Updated the unit test.
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10377021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=126182
R=ben@chromium.org
TBR=sky@chromium.org,thestig@chromium.org,mirandac@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10377015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unit-tests should compile on Android.
Review URL: http://codereview.chromium.org/10378020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Passed the existing tests.
Review URL: http://codereview.chromium.org/10209031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
added testing methods to fake input events that don't depend on the OS and being at the front.
BUG=121574
Review URL: https://chromiumcodereview.appspot.com/10368010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added AndroidProviderService.
- Added methods in HistoryService and HistoryBackend to support Android
content provider.
- Also fixed a issue in testing_profile.cc.
BUG=
TEST=Added the new tests
Review URL: http://codereview.chromium.org/10217010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
OWNERS:
brettw: chrome/browser/history/download_database.cc
jhawkins: chrome/browser/ui/webui/downloads_dom_handler.cc
James, feel free to redirect to arv/estade/csilv.
Review URL: http://codereview.chromium.org/10243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles chrome, browser_tests and ui_tests
Review URL: http://codereview.chromium.org/10272004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=103930
R=brettw@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10306011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98716
R=jam@chromium.org
TBR=willchan@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10261003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/10115001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unit_tests should compile on Android
Review URL: http://codereview.chromium.org/10206032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134402 0039d316-1c4b-4281-b951-d872f2087c98
|