summaryrefslogtreecommitdiffstats
path: root/chrome/browser/history
Commit message (Collapse)AuthorAgeFilesLines
* Reverting 27389.darin@chromium.org2009-09-301-2/+2
| | | | | | Review URL: http://codereview.chromium.org/246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize got_thumbnail_callback_, query_url_success_, and ↵jhawkins@chromium.org2009-09-291-2/+7
| | | | | | | | | | | redirect_query_success_ in the constructor. CID=1653 BUG=none TEST=none Review URL: http://codereview.chromium.org/251031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27525 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize all member variables in the default constructor.jhawkins@chromium.org2009-09-281-4/+16
| | | | | | | | | CID=1423 BUG=none TEST=none Review URL: http://codereview.chromium.org/249024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27418 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27379, in hopes of fixing browser_tests.senorblanco@chromium.org2009-09-281-2/+2
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that thread-safe reference counting is used withdarin@chromium.org2009-09-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits<T> to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted<T> and RefCountedThreadSafe<T>. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
* Re-ban chrome:// URLs from being added to history until I can craft a more ↵pkasting@chromium.org2009-09-251-2/+4
| | | | | | | | | | fine-grained solution. BUG=23076 TEST=Hit ctrl-t, then ctrl-h, and verify you didn't just add "New Tab" to your history. Review URL: http://codereview.chromium.org/248005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27253 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize statement_cache_ in the constructor.jhawkins@chromium.org2009-09-241-2/+4
| | | | | | | | | CID=1640 BUG=none TEST=none Review URL: http://codereview.chromium.org/225020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27140 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize statement_cache_ in the constructor.jhawkins@chromium.org2009-09-241-1/+5
| | | | | | | | | CID=1608 BUG=none TEST=none Review URL: http://codereview.chromium.org/222024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27136 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize statement_cache_ in the constructor.jhawkins@chromium.org2009-09-241-1/+4
| | | | | | | | | CID=1602 BUG=none TEST=none Review URL: http://codereview.chromium.org/223026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27135 0039d316-1c4b-4281-b951-d872f2087c98
* Add about: and chrome:* to history. Patch by Pierre-Antoine LaFayette (see ↵pkasting@chromium.org2009-09-241-3/+3
| | | | | | | | | http://codereview.chromium.org/193071 ), r=me,brettw. BUG=2958 TEST=Visit "about:", then hit ctrl-h and make sure it's in your history. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27131 0039d316-1c4b-4281-b951-d872f2087c98
* Add some new histograms for history, and UMA-enable a few others.brettw@chromium.org2009-09-233-9/+36
| | | | | | | | BUG=19773 TEST=none Review URL: http://codereview.chromium.org/212014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26939 0039d316-1c4b-4281-b951-d872f2087c98
* Switch history thread back to base::Thread. Sync unit tests require more ↵chron@chromium.org2009-09-211-2/+7
| | | | | | | | | | than one history thread. We hope to have a hard unit test dependency on buildbot soon, but we need to fix our tests again now. BUG=22056 Review URL: http://codereview.chromium.org/215023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26709 0039d316-1c4b-4281-b951-d872f2087c98
* Some history backend fixes for database corruption.shess@chromium.org2009-09-172-0/+20
| | | | | | | | | | | | | | | Don't enter an infinite loop in GetLastSegmentID() when traversing the referring_visit list. Don't return rows from visits table where a specific visit_id was passed but some other visit_id was returned. Don't update visits table with rows who's referring_visit refers to the visit itself. BUGS=20321 TEST=Don't hang with Kelly's profile. I guess Kelly could test? Review URL: http://codereview.chromium.org/206041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26513 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a few data races on reference counters.timurrrr@chromium.org2009-09-171-1/+2
| | | | | | | BUG=18488 Review URL: http://codereview.chromium.org/215011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26476 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a bunch of hardcoded URLs with constants from url_constants.hbrettw@chromium.org2009-09-151-1/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/193092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new wrapper for sqlite. This is mostly a large cleanup of the existingbrettw@chromium.org2009-09-112-134/+100
| | | | | | | | | | | | | | | one, combined with the statement cache in a nice way. It is designed to entirely wrap sqlite so that we can catch corrupt errors in the future and "do something" when we get them without having to change all the calling code. There is also a new meta_table file which is almost exactly like the old one but which uses the new sql interface. This patch changes Chrome's history TextDatabase to use this new wrapper as a proof of concept, because this usage is relatively well-confined. Review URL: http://codereview.chromium.org/199047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26022 0039d316-1c4b-4281-b951-d872f2087c98
* While importing favicon, make sure there is an entry in the history db.kuchhal@chromium.org2009-09-113-7/+87
| | | | | | | | | | This will match with what history db does for regular bookmarked URLs with favicons - when history db is cleaned, we keep an entry in the db with 0 visits as long as that url is bookmarked. BUG=13338 Review URL: http://codereview.chromium.org/193053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26014 0039d316-1c4b-4281-b951-d872f2087c98
* Metrics for the in-memory DB size to see if we spend too much time loading it,brettw@chromium.org2009-09-111-0/+7
| | | | | | | | | | and how big it ends up being. BUG=none TEST=none Review URL: http://codereview.chromium.org/193061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25957 0039d316-1c4b-4281-b951-d872f2087c98
* Use Scoped[Bstr,ComPtr,Variant] instead of their ATL equivalents to reduce ↵jhawkins@chromium.org2009-09-101-14/+16
| | | | | | | | | | dependencies on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/200045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25879 0039d316-1c4b-4281-b951-d872f2087c98
* Retry 25770 after fixing Valgrind issue.huanr@chromium.org2009-09-103-3/+33
| | | | | | | | | | | | | Enable database logging on history thread. Original review: http://codereview.chromium.org/198011 BUG=16591 TEST=History UI test Review URL: http://codereview.chromium.org/194067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25842 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r25770 due to valgrind failures on Linux.huanr@chromium.org2009-09-091-23/+3
| | | | | | | | | TEST=none. BUG=none. Review URL: http://codereview.chromium.org/199065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25781 0039d316-1c4b-4281-b951-d872f2087c98
* Enable database logging on history thread.huanr@chromium.org2009-09-091-3/+23
| | | | | | | | | BUG=16591 TEST=History UI test Review URL: http://codereview.chromium.org/198011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25770 0039d316-1c4b-4281-b951-d872f2087c98
* Move the "history is too new" dialog out oftony@chromium.org2009-09-051-17/+3
| | | | | | | | | | | | | chrome/browser/history/history.cc. Instead use a notification that Browser picks up and delegates to BrowserWindow. Include implementations for Windows, Linux GTK+, and Linux Views (sorry, no mac impl). Review URL: http://codereview.chromium.org/200023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25556 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in memory log of history visit database. Thishuanr@chromium.org2009-09-024-0/+178
| | | | | | | | | | | | log will be saved in crash dump (to be done in next CL) to help debug the corruption in history thread. TEST=Added unit test. BUG=16591 Review URL: http://codereview.chromium.org/187004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25276 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most Sleeps from RedirectTest and wait properly.phajdan.jr@chromium.org2009-09-021-30/+14
| | | | | | | | | | | | Not fixing any Top15 flakiness, but removes the ugly polling pattern and prevents it from being copy-pasted into new tests. TEST=Covered by ui_tests. BUG=none Review URL: http://codereview.chromium.org/183037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25176 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the RenderProcessHost.PID function that returns the OS-generatedbrettw@chromium.org2009-08-311-2/+2
| | | | | | | | | | | | | | | | | | | | process ID with an internally-generated id() function. This allows us the guarantee that the IDs are unique over the entire run of the application. This also cleans up some code associated with managing the PID. The main potentially interesting change is now the PID is set uniquely for every creation of RenderProcessHost. It used to be set cleared if the process went away, and re-set if the process was re-created. The ID generation is in ChildProcesInfo so it is also unique between workers and plugins. I had to change some significant things in resource_dispatcher_host_unittest to take into account this new generation of IDs. BUG=17828 TEST=none Review URL: http://codereview.chromium.org/160203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-283-90/+71
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-284-19/+15
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-284-15/+19
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Do at least some rudimentary sorting of bookmarked URLs in the omnibox ↵pkasting@chromium.org2009-08-281-2/+12
| | | | | | | | | dropdown (existing sort was effectively random). Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/165455 ), r=sky,me, tweaked. BUG=16230 TEST=In the omnibox dropdown, bookmarked URLs that have been typed more often should be ranked above those that have been typed less often. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24704 0039d316-1c4b-4281-b951-d872f2087c98
* Convert internal time format to Windows 1601 epoch on Linux & Mac.brettw@chromium.org2009-08-263-3/+82
| | | | | | | | | | | Although we represent time internally starting from 1601, there are still things like time explosion that will not work before the year 1900. This limitation is the same as it was previously. BUG=14734 Review URL: http://codereview.chromium.org/173296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24417 0039d316-1c4b-4281-b951-d872f2087c98
* Use 'icu::' namespace explicitly throughout Chrome tree instead of relying ↵jshin@chromium.org2009-08-181-5/+5
| | | | | | | | | | | | | | | | | | | on 'using namespace icu'. This is Chrome's counterpart to the ICU header change that disables 'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece. The webkit change (which is minor) will be dealt with in the webkit bugzilla. This can go in before the ICU change/upgrade without affecting anything. BUG=8198 TEST=All the targets are built without an error on all platforms. Review URL: http://codereview.chromium.org/171012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add CHECKs to track down source of history std::string out of range ↵willchan@chromium.org2009-08-111-0/+14
| | | | | | | | | | exceptions. BUG=http://crbug.com/15261 Review URL: http://codereview.chromium.org/164191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23086 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r22559.aa@chromium.org2009-08-062-4/+4
| | | | | | | | | | | | | | | | | | This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-062-4/+4
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Safari Import - Home Page & History Only.jeremy@chromium.org2009-07-311-0/+2
| | | | | | Review URL: http://codereview.chromium.org/159668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22179 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted fixes for 64-bit.deanm@chromium.org2009-07-281-2/+3
| | | | | | | Review URL: http://codereview.chromium.org/160288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21891 0039d316-1c4b-4281-b951-d872f2087c98
* Make ThumbnailStore broadcast a notification when it has finished reading ↵meelapshah@chromium.org2009-07-282-6/+9
| | | | | | | | | | | thumbnails from disk. Make DOMUIThumbnailSource wait for this notification if ThumbnailStore isn't ready yet. Also clean up some of the code. Review URL: http://codereview.chromium.org/155911 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21785 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in VisitSegmentDatabase::QuerySegmentUsage and ↵meelapshah@chromium.org2009-07-232-3/+8
| | | | | | | | | | | HistoryBackend::QueryTopURLsAndRedirects. BUG=16104 TEST=sh tools/valgrind/chrome_test.sh -t ui --gtest_filter=TabRestoreUITest.RestoreIntoSameWindow Review URL: http://codereview.chromium.org/160060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21472 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/historyphajdan.jr@chromium.org2009-07-1328-79/+97
| | | | | | Review URL: http://codereview.chromium.org/140047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20488 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Acid3 Test 48: LINKTEST, Chromium side....dglazkov@chromium.org2009-07-039-39/+288
| | | | | | | | | | | | | | | | | R=brettw BUG=http://crbug.com/231 BUG=http://crubg.com/5160 TEST=ExpireHistoryTest.ArchiveSomeOldHistory TEST=ExpireHistoryTest.ExpiringVisitsReader TEST=VisitedLinkTest.Listener TEST=VisitedLinkTest.Resizing TEST=VisitedLinkRelayTest.* TEST=VisitedLinkEventsTest.* Review URL: http://codereview.chromium.org/113591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19910 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for Print Preview and Setupmhm@chromium.org2009-07-031-1/+2
| | | | | | | | | | | | | Create the foundations of implementing a tab for printing should be in the form of: print:http://www.google.com I have followed similar approach as what has been done with view-source: and chrome-extension: BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/150207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19906 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Spurious SQL error message is logged in priming SQLite database cache.yuzo@chromium.org2009-07-022-21/+2
| | | | | | | | | | | | | | | | | | | | This patch depends on the MetaTableHelper refactoring in: http://codereview.chromium.org/150094 Currently, a spurious SQL error message is logged every time a unit test that access SQLite database runs. Example: [----------] 6 tests from HistoryBackendTest [ RUN ] HistoryBackendTest.Loaded [5660:5304:0630/150705:414864129:ERROR:sqlite_utils.cc(204)] SQLStatement.prepare_v2 failed: no such table: meta BUG=none TEST=n/a Review URL: http://codereview.chromium.org/150095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19803 0039d316-1c4b-4281-b951-d872f2087c98
* Moved typedef of RedirectList from HistoryService class to history namespace.meelapshah@chromium.org2009-07-0110-49/+51
| | | | | | Review URL: http://codereview.chromium.org/151168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19766 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix for page_cycler perf regression.meelapshah@chromium.org2009-07-011-1/+3
| | | | | | Review URL: http://codereview.chromium.org/151159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19745 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function to the History to return a list of the top n visited URLs ↵meelapshah@chromium.org2009-07-016-0/+68
| | | | | | | | where and the list of most recent redirects for each of those URLs. Review URL: http://codereview.chromium.org/151057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19743 0039d316-1c4b-4281-b951-d872f2087c98
* Whoops, accidentally committed a debug linepinkerton@chromium.org2009-07-011-1/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19728 0039d316-1c4b-4281-b951-d872f2087c98
* Added unit tests for ClearBrowsingDataController.pinkerton@chromium.org2009-07-011-0/+1
| | | | | | | | | Fixed a bug in ClearBrowsingDataController: checking Delete Form Data would end up deleting passwords instead. Patch from Jens Alfke (snej@google.com). BUG=12902 TEST=deleting form data should actually delete the form data. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19727 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Certain redirections remove sites from the historyyuzo@chromium.org2009-07-017-30/+107
| | | | | | | | | | | | | | | | | | | Currently, PageTransition::CHAIN_END flag is removed from a History database entry for a redirect source, even when the redirect is user initiated. This change prevents the flag removal for user-initiated redirects. TEST=Open http://www.google.com/ig and click on tabs multiple times. Without this change, only the last tab clicked appears in the History page (CTRL+H). With this change, all the tabs should appear. TESTED=gcl try, manually BUG=11355 Review URL: http://codereview.chromium.org/147145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19708 0039d316-1c4b-4281-b951-d872f2087c98
* Disables unit test as starting failing due to close to end of month.sky@chromium.org2009-07-012-2/+3
| | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/150147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19690 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-10 05:49:42 +0000