summaryrefslogtreecommitdiffstats
path: root/chrome/browser/importer/toolbar_importer.h
Commit message (Collapse)AuthorAgeFilesLines
* (please review thoroughly since this touches many moving parts).jeremy@chromium.org2009-10-061-3/+2
| | | | | | | | | | | | | | | | | | | | | | | Refactor ImporterHost as preparation for OOPprofile import. ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process. This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc. ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world. ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface. There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can. BUG=14458 TEST=Profile import should continue to work on Windows/Linux & Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27996 Review URL: http://codereview.chromium.org/242091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28117 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor ImporterHost as preparation for OOP switch", which caused ↵mattm@chromium.org2009-10-051-2/+3
| | | | | | | | | | | | | | | | | | | purify XP leak: std::_W::_Allocate(unsigned int,wchar_t *) [unit_tests.exe] Alloc Location ... chrome/browser/importer/ie_importer.cc IEImporter::StartImport(ProfileInfo,WORD,ImporterBridge *) base/tuple.h ?DispatchToMethod@VImporter@@P81@AEXUProfileInfo@@GPAVImporterBridge@@@ZU2@GV?$scoped_refptr@VImporterBridge@@@@@@YAXPAVImporter@@P80@AEXUProfileInfo@@GPAVImporterBridge@@@ZABU?$Tuple3@UProfileInfo@@GV?$scoped_refptr@VImporterBridge@@@@@@@Z ^^^ This reverts commit r28007 and r27996. TBR=jeremy Review URL: http://codereview.chromium.org/260011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28019 0039d316-1c4b-4281-b951-d872f2087c98
* (please review thoroughly since this touches many moving parts).jeremy@chromium.org2009-10-051-3/+2
| | | | | | | | | | | | | | | | | | | | | Refactor ImporterHost as preparation for OOPprofile import. ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process. This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc. ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world. ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface. There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can. BUG=14458 TEST=Profile import should continue to work on Windows/Linux & Mac. Review URL: http://codereview.chromium.org/242091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27996 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable test after fix for valgrind/purify error. brg@chromium.com2009-05-121-1/+1
| | | | | | | | | The fix was submitted in issue 79049. http://crbug.com/10679 Review URL: http://codereview.chromium.org/115202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15889 0039d316-1c4b-4281-b951-d872f2087c98
* Fix break due to disabling Toolbar5Importer test.scherkus@chromium.org2009-04-171-1/+1
| | | | | | Review URL: http://codereview.chromium.org/69044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13956 0039d316-1c4b-4281-b951-d872f2087c98
* Re-introducing the toolbar importer code.This is the same code that was ↵brg@chromium.com2009-04-161-0/+169
| | | | | | | | removed in CL http://codereview.chromium.org/18550.The UI will be reworked in a CL immediately following review/submission of this code.Please contact Nick Baum for information regarding this change. Review URL: http://codereview.chromium.org/66065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13895 0039d316-1c4b-4281-b951-d872f2087c98
* Pull toolbar importer from trunk.brg@chromium.com2009-01-231-169/+0
| | | | | | | This change was requested by personalization. Review URL: http://codereview.chromium.org/18550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8598 0039d316-1c4b-4281-b951-d872f2087c98
* Move url_* to net subdirben@chromium.org2009-01-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8224 0039d316-1c4b-4281-b951-d872f2087c98
* Regression for importer. Updated the code to reflect the coding standards ↵brg@chromium.com2009-01-131-56/+66
| | | | | | | | of the chrome team. Review URL: http://codereview.chromium.org/10272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7909 0039d316-1c4b-4281-b951-d872f2087c98
* Removed lint problems. NO funcationality changes.brg@chromium.com2008-11-071-12/+10
| | | | | | Review URL: http://codereview.chromium.org/10219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5031 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar Importer Pass2brg@chromium.com2008-11-061-54/+51
| | | | | | | | | | | | | Implements the following features 1. Toolbar import always available after first run 2. Deduping of imported favorites 3. Removes attempt to import favicons (not supported through Toolbar UI atm) 4. Always the user to cancel from the UI safely 5. Unittests for parsing (TODO Better UI for login) Review URL: http://codereview.chromium.org/9414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4867 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar Import - Issue 8801, migrated from public tree to svn enlistment.brg@chromium.com2008-11-041-0/+164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4633 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 22:05:21 +0000