summaryrefslogtreecommitdiffstats
path: root/chrome/browser/importer
Commit message (Collapse)AuthorAgeFilesLines
* Revert one more piece of ie_importer.cc I left out in the last revert.jhawkins@chromium.org2009-09-041-1/+1
| | | | | | TBR=tommi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25502 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes to ie_importer.cc from r25498. The builder doesn't like ↵jhawkins@chromium.org2009-09-041-15/+15
| | | | | | | | something; investigating. TBR=tommi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25500 0039d316-1c4b-4281-b951-d872f2087c98
* Use ScopedComPtr instead of CComPtr to reduce a dependency on ATL.jhawkins@chromium.org2009-09-042-29/+28
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/201012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25498 0039d316-1c4b-4281-b951-d872f2087c98
* * Spin a modal loop so that messages that cause Chrome UI to be shown don't ↵jeremy@chromium.org2009-09-021-0/+4
| | | | | | | | | | | | | come through, this fixes a crash in the first run import dialog. * Fail early if NSSDecryptor detects that the environment isn't set up write to load NSS libraries. BUG=19169 TEST=See repro instructions in bug. Review URL: http://codereview.chromium.org/179073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25174 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-281-1/+2
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-2/+2
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-2/+2
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leaks in Firefox impoter unittest.kuchhal@chromium.org2009-08-261-7/+11
| | | | | | | | | BUG=19820 TBR=erikkay Review URL: http://codereview.chromium.org/173546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24564 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable importer unit tests one more time to debug on buildbot.kuchhal@chromium.org2009-08-261-2/+5
| | | | | | | | BUG=19820 Review URL: http://codereview.chromium.org/174561 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24529 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Firefox Importer tests again due to Purify report of leaks.kuchhal@chromium.org2009-08-251-2/+2
| | | | | | Review URL: http://codereview.chromium.org/174414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24356 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable importer unit tests since they do not seem to generate Purify ↵kuchhal@chromium.org2009-08-251-2/+2
| | | | | | | | errors locally. Review URL: http://codereview.chromium.org/174414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24269 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit "Bring up Firefox Password Import Unittest on OS X."jeremy@chromium.org2009-08-219-28/+495
| | | | | | | | This recommits r23971 Review URL: http://codereview.chromium.org/174259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24024 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Bring up Firefox Password Import Unittest on OS X."jeremy@chromium.org2009-08-219-495/+28
| | | | | | This reverts commit 63381b4554b1190c8a87583a5c5f403815e44e83. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23979 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up Firefox Password Import Unittest on OS X.jeremy@chromium.org2009-08-219-28/+495
| | | | | | | | | | | | The NSSDecrptor class needs to be run in a child process on OS X, so we need to do some fancy footwork in the form of a bridge class. Also a few small fixes for surrounding code. BUG=18775 TEST=none Review URL: http://codereview.chromium.org/174206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23971 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two tests while I investigate why Purify doesnt like them.kuchhal@chromium.org2009-08-201-2/+2
| | | | | | | | BUG=19820 Review URL: http://codereview.chromium.org/174153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23844 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-172-9/+12
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Import passwords from Firefox 3.1 and above.kuchhal@chromium.org2009-08-156-55/+169
| | | | | | | | BUG=9103 Review URL: http://codereview.chromium.org/165352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix early return/DCHECK importing Safari bookmarks.jeremy@chromium.org2009-08-121-6/+9
| | | | | | | | BUG=19167 Review URL: http://codereview.chromium.org/164442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23250 0039d316-1c4b-4281-b951-d872f2087c98
* First Run Import Progress UI.jeremy@chromium.org2009-08-112-6/+1
| | | | | | | | | | | First run code needed some reworking in order to get things in order for progress notification. BUG=18773 TEST=When importing another browser's settings, a progress dialog should be displayed. Review URL: http://codereview.chromium.org/164290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23080 0039d316-1c4b-4281-b951-d872f2087c98
* Use real creator code for Keychain items. Instead of hard-coding 'rimZ', usemark@chromium.org2009-08-111-13/+10
| | | | | | | | | | | the correct creator code for the application. This is 'rimZ' for branded Google Chrome, and 'Cr24' for Chromium. BUG=19000 TEST=No functional change in Google Chrome-branded builds Review URL: http://codereview.chromium.org/164332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23074 0039d316-1c4b-4281-b951-d872f2087c98
* When importing bookmarks from Firefox, filter out the default bookmarks.evan@chromium.org2009-08-091-6/+3
| | | | | | | | | | | The existing code attempted to do this but it had a bug. BUG=18530 Review URL: http://codereview.chromium.org/165094 Patch from Doug Muir <dmuir@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22884 0039d316-1c4b-4281-b951-d872f2087c98
* Safari Bookmark/Favicon import.jeremy@chromium.org2009-08-054-82/+335
| | | | | | Review URL: http://codereview.chromium.org/159750 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22556 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Safari Import - Home Page & History Only.jeremy@chromium.org2009-07-314-3/+354
| | | | | | Review URL: http://codereview.chromium.org/159668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22179 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Firefox import on OSX + stubs for Safari import.jeremy@chromium.org2009-07-297-29/+93
| | | | | | | | | | | | | | Known limitations: * Runs in browser process, should run in a separate process. * No UI. * No FF password import. BUG=15455 TEST=Check that firefox settings are correctly imported on first run, firefox password importing and Safari importing still don't work. Review URL: http://codereview.chromium.org/160341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21995 0039d316-1c4b-4281-b951-d872f2087c98
* Navigation and cookies for Automationamit@chromium.org2009-07-281-2/+2
| | | | | | | | | | | | | Give Automation better visibility and control over navigations. Also, make it possible for automation to implement a dummy cookie store to go with dummy request serving over automation. BUG=none TEST=none Review URL: http://codereview.chromium.org/159189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21836 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix NSSDecryptor to decrypt Firefox passwords using correct user ↵willchan@chromium.org2009-07-288-90/+317
| | | | | | | | | | | | | | database. Note that we're deliberately leaving NSS user databases open until NSS shutdown since closing and reopening it does not work correctly (NSS bug). Also, enable the firefox_importer_unittest.cc for linux. Move out some tests to firefox_profile_unittest.cc. Fix lock file deletion in the posix implementation of FirefoxProfileLock. BUG=http://crbug.com/17490 TEST=Import bookmark and settings, verify that passwords are indeed imported. Review URL: http://codereview.chromium.org/160077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21792 0039d316-1c4b-4281-b951-d872f2087c98
* Split NSSDecryptor out into platform specific files.willchan@chromium.org2009-07-2215-574/+810
| | | | | | | | | | This lets Linux not bother to initialize NSS in the same way as the rest, but instead use the NSS symbols linked into the library, thereby preventing the NSS_Shutdown related bugs. BUG=http://crbug.com/13929 TEST=Case 1: Start chrome. Use firefox import utility. Browse to some https site. Shouldn't crash. Case 2: Start chrome. Browse to some https site. Use firefox import utility. Continue browsing https sites. Shouldn't crash. Review URL: http://codereview.chromium.org/159165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21251 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing TemplateURL include.phajdan.jr@chromium.org2009-07-201-0/+1
| | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/159102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21119 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully fix Windows release compile.phajdan.jr@chromium.org2009-07-201-0/+3
| | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/155813 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21118 0039d316-1c4b-4281-b951-d872f2087c98
* Header cleanup in browser/importerphajdan.jr@chromium.org2009-07-2013-38/+83
| | | | | | | | | | - forward declare more things - move bits from header to implementation files to cut includes - extract bookmark_model_observer.h out of bookmark_model.h to reduce includes Review URL: http://codereview.chromium.org/159097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21116 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155428 for Thiago, which changessky@chromium.org2009-07-151-1/+2
| | | | | | | | | | | | | | from me to get the thing to work. Merging two versions of BookmarkNodeRemoved into one. BUG=None TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure everything works ok. Review URL: http://codereview.chromium.org/155572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155128 for Thiago.sky@chromium.org2009-07-081-3/+4
| | | | | | | | | | | | | Description from Thiago: Converting the history::StarredEntry::Type to a type defined in BookmarkNode. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/155165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20195 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/126036 for Thiago.sky@chromium.org2009-06-302-4/+29
| | | | | | | | | | | | | | | | | From Thiago: This patch is to solve the problem in import/export bookmarks. They aren't exported correctly and also not imported correctly. Now when the bookmarks are exported the character " are escaped to &quot; and when they are imported, they are unescaped. BUG=7505 TEST=Try importing/exporting bookmarks, make sure nothing is broken. Review URL: http://codereview.chromium.org/126222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19654 0039d316-1c4b-4281-b951-d872f2087c98
* Move render_view_host_manager* and site_instance* from tab_contents to ↵brettw@chromium.org2009-06-291-1/+1
| | | | | | | | renderer_host. Review URL: http://codereview.chromium.org/150011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19481 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-262-18/+19
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* fix windows build break.kuchhal@chromium.org2009-06-261-0/+2
| | | | | | Review URL: http://codereview.chromium.org/147222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19385 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Firefox import on OS X. No UI yet.kuchhal@chromium.org2009-06-2610-201/+348
| | | | | | Review URL: http://codereview.chromium.org/143001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19381 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathComponents from file_util to FilePath, add FilePath::IsParent()rafaelw@chromium.org2009-06-241-1/+2
| | | | | | | | r=erikkay,mark Review URL: http://codereview.chromium.org/145026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19174 0039d316-1c4b-4281-b951-d872f2087c98
* Import search engines even if they are not in sqlite3 db.kuchhal@chromium.org2009-06-241-23/+21
| | | | | | | | BUG=14123 Review URL: http://codereview.chromium.org/146045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19121 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make import warning dialog modal.kuchhal@chromium.org2009-06-192-3/+12
| | | | | | | | | | | | Make ImporterHost aware of the current parent window and use that as parent for the warning dialog. BUG=13481 TEST=Start Firefox, try to import profile in Chrome and make sure the warning dialog is modal. Review URL: http://codereview.chromium.org/131080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18816 0039d316-1c4b-4281-b951-d872f2087c98
* Import bookmarks to bookmark bar if user has not bookmarked anything yet.kuchhal@chromium.org2009-06-187-41/+52
| | | | | | | | BUG=9000 Review URL: http://codereview.chromium.org/131004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18751 0039d316-1c4b-4281-b951-d872f2087c98
* Extract load times from WebDataSource. Move them to NavigationState.darin@chromium.org2009-06-168-2/+10
| | | | | | | | | | | | Move PasswordForm into the webkit_glue namespace. TEST=none BUG=10041 R=brettw Review URL: http://codereview.chromium.org/126190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18515 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where keyword editor would end up prefixing all keyword urlssky@chromium.org2009-06-151-2/+2
| | | | | | | | | | | | | | | | with "http://" if they didn't have one. This proves problematic as for the google search url we don't have http:// and don't want it. The fix is to only add http:// if the url field is editable. If the url field isn't editable, we know the user hasn't editted it and don't need to try and fix it up. BUG=13282 TEST=see bug, but also make sure you don't run into any other problems with the keyword editor. Review URL: http://codereview.chromium.org/126052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18410 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix Firefox profile path for import.kuchhal@chromium.org2009-06-101-0/+2
| | | | | | | | BUG=13270 Review URL: http://codereview.chromium.org/118526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18094 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Import passwords from Firefox.kuchhal@chromium.org2009-06-092-48/+56
| | | | | | | | | | BUG=11191 TEST=Try importing password from Firefox on Linux and it should work (though they are not accessible in UI yet). Review URL: http://codereview.chromium.org/118443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17955 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: Import passwords from Firefox."kuchhal@chromium.org2009-06-092-55/+48
| | | | | | | | This reverts commit a45f7c83ced4af4ded3fcbd3608a1fe50a2c9f08. Review URL: http://codereview.chromium.org/118435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17946 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Import passwords from Firefox.kuchhal@chromium.org2009-06-092-48/+55
| | | | | | | | | BUG=11191 TEST=Try importing password from Firefox on Linux and it should work (though they are not accessible in UI yet). Review URL: http://codereview.chromium.org/119267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17943 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the following deprecated functions:ojan@chromium.org2009-06-031-13/+21
| | | | | | | | | | | | | | | | file_util::InsertBeforeExtension(wstring*, wstring&) file_util::PathComponents(wstring&, vector<wstring>*) file_util::ReplaceExtension(wstring*, wstring&) BUG=none TEST=manual test for importing IE bookmarks with some sub-directories. Original patch by tkent@google.com. See http://codereview.chromium.org/118109 r=ojan,estade git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17469 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up temporary files/folders in firefox importer tests.munjal@chromium.org2009-05-291-0/+4
| | | | | | Review URL: http://codereview.chromium.org/115930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17238 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that Firefox search engines are imported correctly.mirandac@chromium.org2009-05-291-25/+46
| | | | | | | | | | | | | | | It also makes sure that engines which have been removed from Firefox are not imported into Chrome. BUG= http://crbug.com/12245 TEST= Install firefox, and do not change the default search engines. Start Chrome, and import search engines from Firefox. Default Firefox engines should now be part of Chrome. Review URL: http://codereview.chromium.org/115895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17207 0039d316-1c4b-4281-b951-d872f2087c98