summaryrefslogtreecommitdiffstats
path: root/chrome/browser/importer
Commit message (Collapse)AuthorAgeFilesLines
* Change a bunch of string types.estade@chromium.org2010-06-295-48/+49
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at Moving Browser::AddTypes to TabStripModel. The firstsky@chromium.org2010-06-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | attempt caused some flakiness on the new tab warm startup test. The only difference between this and the last is that I'm leaving some suspcious code in TabStripModel::InsertTabContents and Browser::AddTabWithURL. I'll try to isolate why those changes caused flakiness after I land the rest. Here's the description: Moves Browser::AddTypes to TabStripModel. This patch is primarily cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2866024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50752 - Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2849025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
* Make import from the options menu OOP on Mac OS X.mirandac@chromium.org2010-06-241-1/+2
| | | | | | | | BUG=46701 TEST=import Firefox passwords from the menu once the browser is running. Because import is OOP, FF passwords should be imported. All other import processes should still work as advertised. Review URL: http://codereview.chromium.org/2800026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50753 0039d316-1c4b-4281-b951-d872f2087c98
* Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-2/+2
| | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
* Broken by http://codereview.chromium.org/2403001/show, which eliminated a ↵mirandac@google.com2010-06-231-1/+1
| | | | | | | | "!" that reversed the logic of the code. Review URL: http://codereview.chromium.org/2825017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50616 0039d316-1c4b-4281-b951-d872f2087c98
* Replace wstring with string16 in history. The only time wstring is used now ↵brettw@chromium.org2010-06-235-12/+12
| | | | | | | | | | | | in history is for bookmark-related stuff (the bookmarks system is still wstring-based). The substantial change here is in RTL to make a string16 variant of the functions and in changing the WordIterator to use string16 (this cleaned up some weird utf-32 code). TEST=none BUG=none Review URL: http://codereview.chromium.org/2808017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50597 0039d316-1c4b-4281-b951-d872f2087c98
* Fix password import for OS X Firefox.mirandac@chromium.org2010-06-092-2/+3
| | | | | | | | BUG=18775 TEST=import passwords from Firefox on OS X. Review URL: http://codereview.chromium.org/2725005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49336 0039d316-1c4b-4281-b951-d872f2087c98
* Fix import crash in Mac 10.6 only.mirandac@chromium.org2010-06-092-6/+10
| | | | | | | | | | A DictionaryValue we need to keep was being autoreleased in the Mac message loop. The import process uses only C++ code, so we just make a deep copy of the (very small, 5 strings) Dictionary when it's passed into the bridge. BUG=46003 TEST=import works on Mac OS 10.6 and 10.5 Review URL: http://codereview.chromium.org/2715006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49284 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome ↵tfarina@chromium.org2010-06-062-3/+3
| | | | | | | | | | | directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
* Move import in Mac OS X into its own process.mirandac@chromium.org2010-06-0414-192/+1309
| | | | | | | | BUG=18774 TEST=import still works. Review URL: http://codereview.chromium.org/502045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48928 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap Sqlite utils functions into a sqlite_utils namespace.tfarina@chromium.org2010-06-031-2/+2
| | | | | | | | | | | Note: this was a TODO. BUG=None TEST=compiles Review URL: http://codereview.chromium.org/2410002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48883 0039d316-1c4b-4281-b951-d872f2087c98
* Reusing the RegKey used to get the CurrentVersion to also get the Install ↵mirandac@google.com2010-06-031-3/+3
| | | | | | | | | | | Directory was causing an InvalidHandle exception, and causing FF import to fail. BUG=45730 TEST= FF import should work. Review URL: http://codereview.chromium.org/2581002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48852 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacementphajdan.jr@chromium.org2010-06-015-14/+14
| | | | | | | | | | | that works with all test prefixes (DISABLED, FLAKY, FAILS). TEST=none BUG=44549 Review URL: http://codereview.chromium.org/2439001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated versions of Registry functions.tfarina@chromium.org2010-05-312-15/+18
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2403001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48581 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will make mbelshe@chromium.org2010-05-271-2/+2
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
* Update UI, sync and importer to properly handle managed homepage prefsmnissler@chromium.org2010-05-271-2/+5
| | | | | | | | | | | The change in Preferences.xib binds the homepage options container's enabled state to the new property PreferencesWindowController.IsHomepageManaged BUG=43423 TEST=Manual, especially homepage options on general page of options dialog Review URL: http://codereview.chromium.org/2059001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48371 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-261-2/+2
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will makembelshe@chromium.org2010-05-251-2/+2
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47675.mirandac@chromium.org2010-05-2010-9/+67
| | | | | | | | | | Instead of moving data types into common/, create a special class of IPC messages that live in the browser directory, specifically for importing browser-related data. BUG=18774 TEST=none Review URL: http://codereview.chromium.org/2095020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47827 0039d316-1c4b-4281-b951-d872f2087c98
* Move data types used in the importer process to common/, in preparation for ↵mirandac@chromium.org2010-05-1910-68/+11
| | | | | | | | | | | import to run out of process. BUG= 18774 TEST= none. Review URL: http://codereview.chromium.org/2106015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47675 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath in ProfileInfo struct.tfarina@chromium.org2010-05-159-61/+63
| | | | | | | | | BUG=24672 TEST=out/Debug/unit_tests Review URL: http://codereview.chromium.org/1741012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47370 0039d316-1c4b-4281-b951-d872f2087c98
* Move the profile_writer out of importer in preparation for OOP import on Mac.mirandac@chromium.org2010-05-144-429/+479
| | | | | | | | BUG=18774 TEST=import works exactly the same as before. Review URL: http://codereview.chromium.org/2136002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix retrieval of Firefox proxy settings when it is using an autoconfig URL.eroman@chromium.org2010-05-132-1/+47
| | | | | | | | | BUG=44119,44005 TEST=FirefoxProxySettingsTest.TestParseAutoConfigUrl Review URL: http://codereview.chromium.org/2089004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47207 0039d316-1c4b-4281-b951-d872f2087c98
* Replace #if 0 used to disable test, the DISABLED_ and FLAKY_phajdan.jr@chromium.org2010-05-081-1/+1
| | | | | | | | | | | prefixes, so the code doesn't rot. TEST=none BUG=none Review URL: http://codereview.chromium.org/2035009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46782 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLFetcher and related classes to chrome/common/net.sanjeevr@chromium.org2010-05-072-2/+2
| | | | | | | | BUG=None TEST=Build and Unittests Review URL: http://codereview.chromium.org/1995008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
* The Firefox pref file may contain some non properly UTF-8jcivelli@google.com2010-05-042-1/+9
| | | | | | | | | | | | encoded values. For now we simply ignore them to prevent a DCHECK. BUG=None TEST=Run the FirefoxProxySettingsTest.TestParse unit-test Review URL: http://codereview.chromium.org/1938002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46408 0039d316-1c4b-4281-b951-d872f2087c98
* Add a tool for testing your network setup.eroman@chromium.org2010-05-043-2/+109
| | | | | | | | | | | | It runs a series of experiments using alternate network settings, to try and discover what the misconfiguration is. DESIGN=http://docs.google.com/Doc?id=dfhcnb2v_22cjtdznvg TEST=ConnectionTesterTest.* Review URL: http://codereview.chromium.org/1937001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46387 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes one of the AddTabWithURL variants.sky@chromium.org2010-04-291-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1736022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a way to retrieve Firefox proxy settings.jcivelli@google.com2010-04-276-58/+440
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1703010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45748 0039d316-1c4b-4281-b951-d872f2087c98
* Make it clear what last_sync_timestamp actually tracks. Updatenick@chromium.org2010-03-241-1/+1
| | | | | | | | | | | | | | | | last_sync_timestamp from the new_timestamp only, never from per-entry timestamps. Use what the server sends us to know whether or not there are more updates to fetch. Eliminate some unnecessarily complicated logic having to do with the # of updates returned -- that's always a red herring; with server-side filtering, it is indeed possible for 0 updates to be returned along with a new timestamp. BUG=37373 TEST=manual testing of 2 browser sync; unit tests. Review URL: http://codereview.chromium.org/1161006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer data types into a separate file to prepare for moving importermirandac@chromium.org2010-03-2218-122/+197
| | | | | | | | | | into its own process. BUG= 18774 TEST= none Review URL: http://codereview.chromium.org/1110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42224 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-191-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Move image codec stuff to toplevel gfx.ben@chromium.org2010-03-181-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-171-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* BSD ifdefs, etc. necessary for chrome/pvalchev@google.com2010-03-092-8/+8
| | | | | | Review URL: http://codereview.chromium.org/656009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41067 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 2: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-085-2/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/672007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40945 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/common: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-0/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/668244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40927 0039d316-1c4b-4281-b951-d872f2087c98
* - USE_NSS instead of LINUX where applicablepvalchev@google.com2010-02-244-11/+11
| | | | | | | - Rename nss_decryptor_linux to nss_decryptor_posix as it's more appropriate Review URL: http://codereview.chromium.org/656012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39949 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch more of importer into FilePath.evan@chromium.org2010-02-228-106/+98
| | | | | | | | | | | I thought this would be a small job but I pulled the thread and it kept coming. :( BUG=24672 Review URL: http://codereview.chromium.org/650034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39610 0039d316-1c4b-4281-b951-d872f2087c98
* importer: use FilePath instead of wstring in some placesevan@chromium.org2010-02-193-28/+32
| | | | | | | | | | | Added API to DictionaryValue to use ASCII where appropriate. BUG=24672 TEST=profile import still got my bookmarks Review URL: http://codereview.chromium.org/647016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39441 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-191-1/+1
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Add import/export extension apisfeldstein@chromium.org2010-01-281-0/+9
| | | | | | | | | | | This is a duplicate of 543094. That code review seems to have gotten corrupted as i can no longer publish anything from their web UI. It was LGTM'd+nits by arv, which i've fixed here. BUG=32194 TEST=Import and export bookmarks from the extension Review URL: http://codereview.chromium.org/548167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37351 0039d316-1c4b-4281-b951-d872f2087c98
* Moved GetUserDirectory() into mac_util.mm.akalin@chromium.org2010-01-271-18/+9
| | | | | | | | | | | | | | | Made mac_util.mm and chrome_paths_mac.mm use GetUserDirectory(). Made firefox_importer_utils_mac.mm use PathService. Added unittests for GetUserDirectory(). BUG=22045 TEST=trybots Review URL: http://codereview.chromium.org/548123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37206 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add Certificate Info dialog (part 1)mattm@chromium.org2010-01-141-1/+1
| | | | | | | | | | | Rename base/nss_init.{h,cc} to base/nss_util.{h,cc}, move PRTimeToBaseTime there. BUG=18119 TEST=Load https://www.google.com, compare to firefox cert dialog. Review URL: http://codereview.chromium.org/500141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36291 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected d'tors instead of ↵jamesr@chromium.org2009-12-161-2/+2
| | | | | | | | | | | | | | | | | | | | | non-virtual public implicit d'tors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (chrome/browser/[a-m]* only) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/201100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34634 0039d316-1c4b-4281-b951-d872f2087c98
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-111-1/+1
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows build by #including needed header.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33563 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-028-2/+14
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-308-1/+12
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-16 11:00:58 +0000