summaryrefslogtreecommitdiffstats
path: root/chrome/browser/importer
Commit message (Collapse)AuthorAgeFilesLines
* Make it clear what last_sync_timestamp actually tracks. Updatenick@chromium.org2010-03-241-1/+1
| | | | | | | | | | | | | | | | last_sync_timestamp from the new_timestamp only, never from per-entry timestamps. Use what the server sends us to know whether or not there are more updates to fetch. Eliminate some unnecessarily complicated logic having to do with the # of updates returned -- that's always a red herring; with server-side filtering, it is indeed possible for 0 updates to be returned along with a new timestamp. BUG=37373 TEST=manual testing of 2 browser sync; unit tests. Review URL: http://codereview.chromium.org/1161006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer data types into a separate file to prepare for moving importermirandac@chromium.org2010-03-2218-122/+197
| | | | | | | | | | into its own process. BUG= 18774 TEST= none Review URL: http://codereview.chromium.org/1110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42224 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-191-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Move image codec stuff to toplevel gfx.ben@chromium.org2010-03-181-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-171-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* BSD ifdefs, etc. necessary for chrome/pvalchev@google.com2010-03-092-8/+8
| | | | | | Review URL: http://codereview.chromium.org/656009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41067 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 2: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-085-2/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/672007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40945 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/common: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-0/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/668244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40927 0039d316-1c4b-4281-b951-d872f2087c98
* - USE_NSS instead of LINUX where applicablepvalchev@google.com2010-02-244-11/+11
| | | | | | | - Rename nss_decryptor_linux to nss_decryptor_posix as it's more appropriate Review URL: http://codereview.chromium.org/656012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39949 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch more of importer into FilePath.evan@chromium.org2010-02-228-106/+98
| | | | | | | | | | | I thought this would be a small job but I pulled the thread and it kept coming. :( BUG=24672 Review URL: http://codereview.chromium.org/650034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39610 0039d316-1c4b-4281-b951-d872f2087c98
* importer: use FilePath instead of wstring in some placesevan@chromium.org2010-02-193-28/+32
| | | | | | | | | | | Added API to DictionaryValue to use ASCII where appropriate. BUG=24672 TEST=profile import still got my bookmarks Review URL: http://codereview.chromium.org/647016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39441 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-191-1/+1
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Add import/export extension apisfeldstein@chromium.org2010-01-281-0/+9
| | | | | | | | | | | This is a duplicate of 543094. That code review seems to have gotten corrupted as i can no longer publish anything from their web UI. It was LGTM'd+nits by arv, which i've fixed here. BUG=32194 TEST=Import and export bookmarks from the extension Review URL: http://codereview.chromium.org/548167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37351 0039d316-1c4b-4281-b951-d872f2087c98
* Moved GetUserDirectory() into mac_util.mm.akalin@chromium.org2010-01-271-18/+9
| | | | | | | | | | | | | | | Made mac_util.mm and chrome_paths_mac.mm use GetUserDirectory(). Made firefox_importer_utils_mac.mm use PathService. Added unittests for GetUserDirectory(). BUG=22045 TEST=trybots Review URL: http://codereview.chromium.org/548123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37206 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add Certificate Info dialog (part 1)mattm@chromium.org2010-01-141-1/+1
| | | | | | | | | | | Rename base/nss_init.{h,cc} to base/nss_util.{h,cc}, move PRTimeToBaseTime there. BUG=18119 TEST=Load https://www.google.com, compare to firefox cert dialog. Review URL: http://codereview.chromium.org/500141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36291 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected d'tors instead of ↵jamesr@chromium.org2009-12-161-2/+2
| | | | | | | | | | | | | | | | | | | | | non-virtual public implicit d'tors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (chrome/browser/[a-m]* only) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/201100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34634 0039d316-1c4b-4281-b951-d872f2087c98
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-111-1/+1
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows build by #including needed header.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33563 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-028-2/+14
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-308-1/+12
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-308-12/+1
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-308-1/+12
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable Toolbar5ImporterTestjorlow@chromium.org2009-11-261-35/+38
| | | | | | | | | | | | | * Fix disabled code to make it compile again. * The test doesn't pass if the importer thinks this is the first run of the browser, so call CreateSentinel() to mark this as a subsequent run. BUG=11838 TEST=none Review URL: http://codereview.chromium.org/437083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33177 0039d316-1c4b-4281-b951-d872f2087c98
* Move base64 from 'net/base' into 'base'.hayato@chromium.org2009-11-241-3/+3
| | | | | | | | | BUG=13572 TEST=none Review URL: http://codereview.chromium.org/399068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
* Fix environment variables not being used after switching to ↵jam@chromium.org2009-11-231-4/+3
| | | | | | | | | | ChildProcessLauncher. BUG=28602 TEST=verified flash works on Mac Review URL: http://codereview.chromium.org/439005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32854 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: Fix some callers of CreateNewTempDirectory to remove the ↵evan@chromium.org2009-11-191-11/+11
| | | | | | | | | | | | | deprecated version. BUG=None TEST=unit_tests Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/385112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32487 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-2/+2
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't get an outside array element.jeremy@chromium.org2009-11-083-7/+7
| | | | | | | | | BUG=None TEST=covered by unit_tests. Review URL: http://codereview.chromium.org/343076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31401 0039d316-1c4b-4281-b951-d872f2087c98
* Seventh patch in making destructors of refcounted objects private.jam@chromium.org2009-11-069-12/+36
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/371006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-036-71/+58
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove some now-dead code and add a comment.viettrungluu@chromium.org2009-10-243-41/+7
| | | | | | | | | | | I slightly jumped the gun on committing CL 328010, and this patch does some things requested in a review. BUG=23825 TEST=none Review URL: http://codereview.chromium.org/326024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29979 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: don't import Safari's home page setting.viettrungluu@chromium.org2009-10-231-2/+2
| | | | | | | | | | | Apparently it often leads to a useless home page. I kept the ImportHomepage() method in case we ever change our minds. BUG=25603 TEST=Set the home page in Safari to something interesting; run Chromium with --first-run to bring up import dialog; select Safari and continue; make sure home page isn't imported. Review URL: http://codereview.chromium.org/328010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29954 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some #includes where possible.pkasting@chromium.org2009-10-231-12/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/335002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29915 0039d316-1c4b-4281-b951-d872f2087c98
* Move initialization of ChromeURLRequestContexts to the IO thread.eroman@chromium.org2009-10-231-2/+3
| | | | | | | | | | | | | | | | | | | | | | | Before, these URLRequestContexts were lazily created from the UI thread. Unfortunately that model made it easy for consumers on the UI thread to poke at stuff which was being used from the IO thread, and introduce races. So instead of providing a URLRequestContext*, the Profile now vends a URLRequestContextGetter*. The consequence of this is: * Consumers on the UI thread can no longer get access to a URLRequestContext. * Consumers on the IO thread need to call URLRequestContextGetter::GetURLRequestContext() to get at the context. This uses the same style lazy-creation of URLRequestContexts, albeit from the IO thread. OK, so now the smelly part: There were a couple of consumers of URLRequestContext on the UI thread that can't easily be moved to the IO thread -- these are the consumers of the cookie store. Before they could happily mess with the cookie store from the UI thread, and this was fine since CookieStore is threadsafe. However under the new model, they have no way to get at the URLRequestContext from the UI thread, hence can't get a pointer to the cookie store. To support that use-cases, I bastardized the API some by adding a URLRequestContextGetter::GetCookieStore() method that lets UI thread consumers get a pointer to the cookie store, since we know this particular cross-thread usage is safe. BUG=http://crbug.com/22294 Review URL: http://codereview.chromium.org/258008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29880 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some structures in webkit/glue to string16.darin@chromium.org2009-10-207-26/+30
| | | | | | | | | | R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/305002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
* Add dialog to tell user to close Firefox during import, if it's open and ↵mirandac@chromium.org2009-10-201-1/+1
| | | | | | | | | | | | | blocking. OS-Mac only. BUG= http://crbug.com/20899 TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29481 Review URL: http://codereview.chromium.org/283023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29527 0039d316-1c4b-4281-b951-d872f2087c98
* Add dialog to tell user to close Firefox during import, if it's open and ↵mirandac@chromium.org2009-10-201-2/+3
| | | | | | | | | | | blocking. OS-Mac only. BUG= http://crbug.com/20899 TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox. Review URL: http://codereview.chromium.org/283023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29481 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate PathService::Get(..., wstring*) and use FilePath instead.evan@chromium.org2009-10-193-17/+19
| | | | | | | | | | | | I tried fixing all the Windows code but there's a *ton* of it. This change will at least prevent people from adding new code that uses the deprecated version (as that won't compile on Lin/Mac). BUG=24672 Review URL: http://codereview.chromium.org/293013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29472 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/272036 for Thiago:sky@chromium.org2009-10-191-2/+2
| | | | | | | | | | | | | | Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode. GetType -> type SetType -> set_type BUG=None TEST=None Review URL: http://codereview.chromium.org/297005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29443 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-153-7/+7
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-153-7/+7
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-153-7/+7
| | | | | | | | | | | death to the wstring TEST=trybots BUG=none Review URL: http://codereview.chromium.org/276016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASCII strings for switch names.evan@chromium.org2009-10-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/270062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency cleanup in chrome/phajdan.jr@chromium.org2009-10-121-0/+1
| | | | | | | | | | | | - reduce header dependencies - remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h! TEST=none BUG=none Review URL: http://codereview.chromium.org/245011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-111-1/+1
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dependency on i18n/icu_string_conversions from base/string_util.h.brettw@chromium.org2009-10-102-14/+16
| | | | | | | | | | | | Fix up all files requireing this header to include it directly. Split out the ICU-dependent string util unit tests into a new file base/i18n/icu_string_util_unittest.cc TEST=none BUG=none Review URL: http://codereview.chromium.org/269034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28674 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass file parameter by reference.jhawkins@chromium.org2009-10-082-2/+4
| | | | | | | | | CID=6423 BUG=none TEST=none Review URL: http://codereview.chromium.org/265046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28458 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: remove unused writer_ member from importer classes.mattm@chromium.org2009-10-086-11/+2
| | | | | | | | | | CID=6427 BUG=none TEST=none Review URL: http://codereview.chromium.org/267020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28368 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash during importing. As far as I can tell fromsky@chromium.org2009-10-072-2/+27
| | | | | | | | | | | | | | | | | the crash the BookmarkModel is trying to notifying observers it's going away and one of those observers has been deleted. This is during first run import, so the only observer should be the importer. This may be possible if someone prematurely exits the nested loop started during first run so that the importerhost isn't done when the profile is deleted. BUG=16143 TEST=none Review URL: http://codereview.chromium.org/242119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28227 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 19:42:12 +0000