summaryrefslogtreecommitdiffstats
path: root/chrome/browser/importer
Commit message (Collapse)AuthorAgeFilesLines
* Functions that decoded ie7 structures to extract per-URL username and ↵mpawlowski@opera.com2013-10-112-2/+2
| | | | | | | | | | | password assumed there will only be one such pair for a URL. Changed to work with URLs for which there are several sets of credentials stored. BUG=305241 TEST=IE7PasswordTest.* Review URL: https://codereview.chromium.org/26465006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228180 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED to CallbackList.caitkp@chromium.org2013-10-082-26/+19
| | | | | | | | | BUG=268984 TEST= no functional change Review URL: https://codereview.chromium.org/23710022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227534 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Bookmarks File" to ImporterList interactively.tfarina@chromium.org2013-10-032-15/+26
| | | | | | | | | | | | | | | Otherwise it becomes an option on first run AutoImport and that is not desired. Instead we force the clients to make the decision on whether they want or not to add the "interactive profile", aka "Bookmarks HTML File" to the ImporterList, which can make it available in the "Import Bookmarks and Settings" dialog. BUG=295755 TEST=launch chrome, go to chrome://settings/importData, verifies that "Bookmarks HTML file" option is present in the "From:" combobox and still works. R=gab@chromium.org Review URL: https://codereview.chromium.org/24345002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226694 0039d316-1c4b-4281-b951-d872f2087c98
* Remove mirandac from OWNERS since she no longer works on chrome.erg@chromium.org2013-10-011-1/+0
| | | | | | | | | BUG=none R=mirandac@chromium.org Review URL: https://codereview.chromium.org/25612003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226342 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up remaining unused globals (on mac).thakis@chromium.org2013-09-261-2/+0
| | | | | | | | | | | | Found by clang's new -Wunused-const-variable. BUG=290204 R=akalin@chromium.org, jamesr@chromium.org, koz@chromium.org, piman@chromium.org, sergeyu@chromium.org, thestig@chromium.org, vitalybuka@chromium.org TBR=cpu, dmichael, joi, xhwang Review URL: https://codereview.chromium.org/24579003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225281 0039d316-1c4b-4281-b951-d872f2087c98
* Remove palmer from many (not all) OWNERS files for IPC.palmer@chromium.org2013-09-251-1/+0
| | | | | | Review URL: https://codereview.chromium.org/24476004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225240 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of ui_test_utils.h entry from the exception list.tfarina@chromium.org2013-09-111-5/+7
| | | | | | | | | | | | | | In order to do this we move the WaitForBookmarkModelToLoad() function into a new helper file called bookmark_test_helpers.h. Eventually all the functions from bookmark_model_test_utils.h could be moved over there too. BUG=144783 TEST=unit_tests, browser_tests, interactive_ui_tests R=sky@chromium.org Review URL: https://codereview.chromium.org/23903027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222644 0039d316-1c4b-4281-b951-d872f2087c98
* Move PasswordForm from //content to //autofill.blundell@chromium.org2013-09-098-14/+17
| | | | | | | | | | | | | | The primary goal of this change is to allow PasswordForm to depend on // autofill code for password generation. A side benefit is that this change will allow iOS to cleanly use PasswordForm. To accommodate the fact that multiple message files need to know about PasswordForm, it is put into a newly-created autofill_param_traits_macros.h rather than autofill_messages.h. BUG=263121 Review URL: https://chromiumcodereview.appspot.com/23742004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221991 0039d316-1c4b-4281-b951-d872f2087c98
* Move AlterEnvironment to base/environment.h, implement on Windows. This ↵brettw@chromium.org2013-08-301-2/+2
| | | | | | | | | | | | | re-implements the Posix version to be more like the Windows version and to share some parsing code. The new version will be somewhat slower due to some extra mallocs, but is shorter and more clear. I didn't want to implement a super optimized version on Windows, and the alternative would be to keep the new Windows version and the old Posix version in parallel which seemed less desirable. This changes the input from a vector to a map and just adds the map on the LaunchOptions rather than requiring the caller to set a pointer. This cleans up the callsites somewhat. BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/22750002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220608 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Add option to import from bookmarks html file to ...""tfarina@chromium.org2013-08-121-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | This patch relands crrev.com/216860 with the fix for the first run tests. To test this new feature one can do the following: On chrome, open the "Import Bookmarks and Settings..." dialog, you can do this by three ways, one is to navigate to chrome://settings/importData, another is to open chrome://settings (either through wrench menu or navigating to it through omnibox) and then under the Users category click on "Import Bookmarks..." button to open the dialog. The third way to open this dialog is Wrench->Bookmarks->Import Bookmarks and Settings...". Once the dialog is opened, open the "From" combobox and select "Bookmarks HTML File" item. That should show only the "Favorites/Bookmarks" checkbox checked and enabled and present a "Choose file" button in the place where "Import" button was. Click on that new button and select your bookmarks html file, once you do that the import process should start, and if you file is ok, chrome should import and present you with a success message. BUG=80685 TBR=dbeam@chromium.org, isherman@chromium.org, cpu@chromium.org Review URL: https://chromiumcodereview.appspot.com/22560003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216947 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 216860 "Add option to import from bookmarks html file to ..."tfarina@chromium.org2013-08-101-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Add option to import from bookmarks html file to "Import Bookmarks..." dialog. > > To test this new feature one can do the following: > > On chrome, open the "Import Bookmarks and Settings..." dialog, you can do this > by three ways, one is to navigate to chrome://settings/importData, another is > to open chrome://settings (either through wrench menu or navigating to it through > omnibox) and then under the Users category click on "Import Bookmarks..." button > to open the dialog. The third way to open this dialog > is Wrench->Bookmarks->Import Bookmarks and Settings...". > > Once the dialog is opened, open the "From" combobox and select "Bookmarks HTML File" item. > That should uncheck and disable all the checkboxes but "Favorites/Bookmarks" and present a > "Choose file" button in the place where "Import" button was. Click on that new button and select > your bookmarks html file, once you do that the import process should start, and if you file is > ok, chrome should import and present you with a success message. > > BUG=80685 > R=dbeam@chromium.org, isherman@chromium.org > > Review URL: https://codereview.chromium.org/22332003 It broke some Linux Tests of first run: FirstRunMasterPrefsImportBookmarksFile.ImportBookmarksFile: [4452:4452:0810/092454:2260755831:ERROR:audio_manager_pulse.cc(234)] Failed to connect to the context. Error: Connection refused ../../chrome/browser/first_run/first_run_browsertest.cc:186: Failure Value of: auto_import_state Actual: 5 Expected: MaskExpectedImportState(first_run::AUTO_IMPORT_CALLED | first_run::AUTO_IMPORT_PROFILE_IMPORTED | first_run::AUTO_IMPORT_BOOKMARKS_FILE_IMPORTED) Which is: 7 FirstRunMasterPrefsImportDefault.ImportDefault: [4405:4405:0810/092452:2258318309:ERROR:audio_manager_pulse.cc(234)] Failed to connect to the context. Error: Connection refused ../../chrome/browser/first_run/first_run_browsertest.cc:166: Failure Value of: auto_import_state Actual: 1 Expected: MaskExpectedImportState(first_run::AUTO_IMPORT_CALLED | first_run::AUTO_IMPORT_PROFILE_IMPORTED) Which is: 3 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/22671003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216878 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to import from bookmarks html file to "Import Bookmarks..." dialog.tfarina@chromium.org2013-08-101-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | To test this new feature one can do the following: On chrome, open the "Import Bookmarks and Settings..." dialog, you can do this by three ways, one is to navigate to chrome://settings/importData, another is to open chrome://settings (either through wrench menu or navigating to it through omnibox) and then under the Users category click on "Import Bookmarks..." button to open the dialog. The third way to open this dialog is Wrench->Bookmarks->Import Bookmarks and Settings...". Once the dialog is opened, open the "From" combobox and select "Bookmarks HTML File" item. That should uncheck and disable all the checkboxes but "Favorites/Bookmarks" and present a "Choose file" button in the place where "Import" button was. Click on that new button and select your bookmarks html file, once you do that the import process should start, and if you file is ok, chrome should import and present you with a success message. BUG=80685 R=dbeam@chromium.org, isherman@chromium.org Review URL: https://codereview.chromium.org/22332003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216860 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused variable declaration.etienneb@chromium.org2013-08-091-1/+0
| | | | | | | | | | | | This issue was found by a linter. R=ananta@chromium.org, isherman@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/22476002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216510 0039d316-1c4b-4281-b951-d872f2087c98
* Fix import crash when StartImportSettings is called before ↵gab@chromium.org2013-07-312-4/+3
| | | | | | | | | | | | | | | TemplateURLService is loaded. The SourceProfile has been passed around by pointer ever since http://crrev.com/48928 (then known as ProfileInfo); perhaps callers have changed since then, but it is now the case that callers pass a SourceProfile allocated on the stack to this method. So if the TemplateURLService is not ready, the stack unwinds while the import is waiting. When the notification comes in, the ExternalProcessImporterHost is holding a pointer to a freed SourceProfile... Simply copy the SourceProfile which is a simple data holder, this is better and much safer than trying to keep a pointer around assuming the caller will keep it around for us... BUG=264666 TEST=I can't reproduce the crash in my debug build (something else initializes TemplateURLService early on profile creation...) but I can repro on 30.0.1581.2 canary, so I'll try again on Canary after this lands... Review URL: https://chromiumcodereview.appspot.com/21133008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214711 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in chrome/browser/ for base/process changes.rsesek@chromium.org2013-07-241-1/+0
| | | | | | | | | BUG=242290 R=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/19631004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213461 0039d316-1c4b-4281-b951-d872f2087c98
* Add asserts to TestingProfile::CreateHistoryService to ensure files are deletedrmcilroy@chromium.org2013-07-241-1/+1
| | | | | | | | | | BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213148 Review URL: https://chromiumcodereview.appspot.com/19616004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213413 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 213148 "Add asserts to TestingProfile::CreateHistoryServi..."rlarocque@chromium.org2013-07-231-1/+1
| | | | | | | | | | | | | | | | | Failed on the build bot: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/48941 > Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted > > BUG= > > Review URL: https://chromiumcodereview.appspot.com/19616004 TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/19714004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213151 0039d316-1c4b-4281-b951-d872f2087c98
* Add asserts to TestingProfile::CreateHistoryService to ensure files are deletedrmcilroy@chromium.org2013-07-231-1/+1
| | | | | | | | BUG= Review URL: https://chromiumcodereview.appspot.com/19616004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213148 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Move firefox_proxy_settings* out of importer."tfarina@chromium.org2013-07-233-439/+0
| | | | | | | | | | | | | | | | | | Apparently FirefoxProxySettings has nothing to do with importer/, it's use only by c/b/net. So per request we move it there. This relands the commit at revision r212579. It was reverted because it broke Android build given that it before it was being excluded but after not. This fixes this issue, excluding the build of those files from Android build again. BUG=258876 TEST=unit_tests R=gab@chromium.org,eroman@chromium.org,yfriedman@chromium.org Review URL: https://chromiumcodereview.appspot.com/19905003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213132 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 212579 "Move firefox_proxy_settings* out of importer."peter@chromium.org2013-07-193-0/+439
| | | | | | | | | | | | | | | | | | | > Move firefox_proxy_settings* out of importer. > > Apparently FirefoxProxySettings has nothing to do with importer/, it's use only > by c/b/net. So per request we move it there. > > BUG=258876 > TEST=unit_tests > TBR=eroman@chromium.org, gab@chromium.org, thestig@chromium.org > > Review URL: https://codereview.chromium.org/18612016 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/19786003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212589 0039d316-1c4b-4281-b951-d872f2087c98
* Move firefox_proxy_settings* out of importer.tfarina@chromium.org2013-07-193-439/+0
| | | | | | | | | | | | | Apparently FirefoxProxySettings has nothing to do with importer/, it's use only by c/b/net. So per request we move it there. BUG=258876 TEST=unit_tests TBR=eroman@chromium.org, gab@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/18612016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212579 0039d316-1c4b-4281-b951-d872f2087c98
* Display "Imported" folder name again.tfarina@chromium.org2013-07-181-0/+6
| | | | | | | | | | | | | | | | During the conversion to out of process this seems to have popped out. See https://chromiumcodereview.appspot.com/17379006. BUG=256162 TEST=open chrome, bookmark some pages, go to Bookmark Manager, export the bookmarks to HTML file. Then, import it, there should be a folder named "Imported" again. R=gab@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/19435002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212409 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in chrome/browser/, part 7.avi@chromium.org2013-07-183-3/+3
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19602003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212332 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Firefox3Importer to FirefoxImporterisherman@chromium.org2013-07-184-27/+26
| | | | | | | | | | | | | | | The "3" in this class name was previously used to distinguish the importer from the Firefox 2 and under importer. Now that that code is gone, the 3 is just confusing, since the importer really works for all versions of Firefox 3+. BUG=238229 TEST=none R=avi@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/19670009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212313 0039d316-1c4b-4281-b951-d872f2087c98
* move SafariImporter::CanImport to commonscottmg@chromium.org2013-07-171-2/+2
| | | | | | | | | | | | | Split out from https://codereview.chromium.org/18501013/ and that must be landed first. TBR=gab@chromium.org BUG=254672, 237249 Review URL: https://codereview.chromium.org/19251002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211881 0039d316-1c4b-4281-b951-d872f2087c98
* Move most importer code to chrome/utility/importerscottmg@chromium.org2013-07-1655-6972/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | Moves the out-of-process parts from chrome/browser/importer into chrome/utility/importer. The majority here are simple moves, mostly into chrome/utility/importer and a few into chrome/common/importer. A few places required splitting files up to put some in different parts of browser|common|utility. These were: - chrome/browser/favicon ReencodeFavicon -> utility (it depends on Blink, so should only be in child processes) - history::VisitSource as used by ImporterBridge -> new similar enum in importer_data_types that's remapped once it's in the browser process - LogImporterUseToMetrics split out to importer_uma in browser. Adds chrome/utility/importer/OWNERS identical to chrome/browser/importer. Existing DEPS disallows both utility->browser and browser->utility. TBR=gab@chromium.org, jam@chromium.org, joth@chromium.org, jschuh@chromium.org, thestig@chromium.org BUG=254672,237249 Review URL: https://codereview.chromium.org/18501013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211858 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base::Delete to base::DeleteFilebrettw@chromium.org2013-07-162-2/+2
| | | | | | | | | | | Also renames DeleteAfterReboot to DeleteFileAfterReboot, and removes FileUtilProxy::RecursiveDelete which was never called. BUG= R=shess@chromium.org Review URL: https://codereview.chromium.org/18584011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211822 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual ↵brettw@chromium.org2013-07-151-2/+2
| | | | | | | | | | to the base namespace. TBR=sky Review URL: https://codereview.chromium.org/19052005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211675 0039d316-1c4b-4281-b951-d872f2087c98
* Move favicon decoding code used only by importers into chrome/browser/importerjamesr@chromium.org2013-07-136-12/+66
| | | | | | | | | | | | This code depends on the WebKit image decoders and really should only run in child processes. This moves the code into chrome/browser/importer in anticipation of the importer code migrating out-of-process. BUG=237267 Review URL: https://chromiumcodereview.appspot.com/18977003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211545 0039d316-1c4b-4281-b951-d872f2087c98
* Update some includes of chrome_notification_types.hjam@chromium.org2013-07-122-2/+2
| | | | | | | | TBR=brettw Review URL: https://codereview.chromium.org/19074002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211285 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathExists to base namespace.brettw@chromium.org2013-07-119-19/+19
| | | | | | | | | BUG= TBR=jam@chromium.org Review URL: https://codereview.chromium.org/18286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
* Move Copy* into the base namespace.brettw@chromium.org2013-07-091-4/+3
| | | | | | | | | | | This also creates a new base::internal namespace in file_util and I moved some of the internal functions in file_util to there. BUG= TBR=jam Review URL: https://codereview.chromium.org/18332014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210600 0039d316-1c4b-4281-b951-d872f2087c98
* Make importer bridge use a common VisitSource enumscottmg@chromium.org2013-07-099-15/+35
| | | | | | | | | | | | Factored out of https://codereview.chromium.org/18501013/ in preparation for moving the importer code to utility. R=gab@chromium.org BUG=254672 Review URL: https://chromiumcodereview.appspot.com/18859002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210488 0039d316-1c4b-4281-b951-d872f2087c98
* Provide implementations for the following ↵ananta@chromium.org2013-07-0412-41/+202
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ExternalProcessImporterBridge::AddIE7PasswordInfo and ExternalProcessImporterBridge::AddHomePage functions. The ExternalProcessImporterBridge::AddIE7PasswordInfo function sends the ProfileImportProcessHostMsg_NotifyIE7PasswordInfo IPC to the browser. The ExternalProcessImporterBridge::AddHomePage function sends the ProfileImportProcessHostMsg_NotifyHomePageImportReady IPC to the browser. Added helper functions to return the IE settings and passwords keys to the ie_importer_utils_win.h/.cc files. This is to be able to override these values in the browser tests. This is continuation of the ongoing work for bug https://code.google.com/p/chromium/issues/detail?can=2&q=237249 which is to split chrome.dll into a browser and a renderer/child component due to build issues on Windows. To achieve this we need to ensure that the browser code does not depend on webkit/child. Added a new type ImporterIE7PasswordInfo which mirrors the existing IE7PasswordInfo structure. This is needed to avoid dependency on src/components in the importer code which runs in the utility process. BUG=237249 TBR=gab@chromium.org, jschuh@chromium.org TEST=Covered by new browser tests IEImporterHomePageTest and IEImporterPasswordsTest Review URL: https://codereview.chromium.org/18173007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210214 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the in-process import code (ImporterHost), porting its shared ↵gab@chromium.org2013-07-0311-426/+286
| | | | | | | | | | | | | functionality over to ExternalProcessImporterHost which is finally the only host for import! Goes on top of https://codereview.chromium.org/18120005/ and https://codereview.chromium.org/18556002/. BUG=243423, 254672 TEST=Compile + browser_tests --gtest_filter=*Importer* Review URL: https://chromiumcodereview.appspot.com/18052010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210004 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer messages to commonscottmg@chromium.org2013-07-0320-462/+44
| | | | | | | | | | | | | | | | | Goal is moving profile_import_process_messages to chrome/common so they can be used to communicate between the utility and browser. This also requires moving some of the simple structs/enums that are used in messages. (a few gypi updates that got missed in previous CLs too) TBR=jschuh@chromium.org R=sky@chromium.org BUG=254672 Review URL: https://chromiumcodereview.appspot.com/18555005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209828 0039d316-1c4b-4281-b951-d872f2087c98
* Move some importer-related functionality to chrome/browser/importerscottmg@chromium.org2013-07-0218-29/+1116
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moves bookmark_html_reader*, bookmark_html_writer_unittest, c/b/favicon/imported_favicon_usage.* and c/b/bookmarks/imported_bookmark_entry.*. This is not a perfect solution. There's a regression in the componentization of c/b/favicon and c/b/history. I don't see any great way of avoiding this. Other things I tried: - making bookmark_html_writer_unittest output a static bookmarks.html file. This didn't work well because there's a lot of calls to Time::Now in the bookmarks model. - Making a new browser component containing some of the bookmarks/importer-related functionality. This didn't work because both c/b/importer/firefox* and bookmark_html_writer_unittest depend on bookmark_html_reader, and it in turn uses FaviconUtil::ReencodeFavicon which uses WebKit. So, regressing the componentization seems like the most reasonable path as this issue is similar to the others that are currently causing componentization to not be viable for these components (i.e. their current exceptions). TBR=sky@chromium.org BUG=254672 Review URL: https://codereview.chromium.org/18441002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209716 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/browser: Migrate from googleurl/ includes to url/ ones. Part 1tfarina@chromium.org2013-07-026-6/+6
| | | | | | | | | BUG=229660 TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/18054023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209705 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Google Toolbar importer (aka google.com/bookmarks importer).gab@chromium.org2013-07-0215-1494/+6
| | | | | | | | | | | | (see bug for details on decision) A follow-up CL will get rid of the in-process import code (ImporterHost). BUG=243423, 254672 Review URL: https://chromiumcodereview.appspot.com/18120005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209610 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_util::Delete to the base namespacebrettw@chromium.org2013-07-012-2/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/16950028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209475 0039d316-1c4b-4281-b951-d872f2087c98
* Make importers read urls to private type and convert to history type in browserscottmg@chromium.org2013-06-2913-83/+110
| | | | | | | | | | | | | | | | That parts that will live in utility (the actual importers) work on ImporterURLRow instead of history::URLRow, and once it's in-process in in_process_importer_bridge, they're converted to history::URLRow to be passed on to the profile code. In preference to https://codereview.chromium.org/17956003/. R=sky@chromium.org BUG=254672 Review URL: https://codereview.chromium.org/18080009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209239 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome/browser/, part 1.avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18083008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209145 0039d316-1c4b-4281-b951-d872f2087c98
* The browser importer code which runs in the utility process should not ↵ananta@chromium.org2013-06-2814-238/+250
| | | | | | | | | | | | | | | | | | | | | | | | | depend on chrome\browser data types like TemplateURL, etc. This CL removes the usage of chrome\browser\search_engines\template_url** from the ExternalProcessImporterBridge class. To achieve this, a structure URLKeywordInfo has been added to the importer_data_types.h file. The ImporterBridge::SetKeywords virtual function has been changed to accept a vector of the URLKeywordInfo structures. This is converted to TempateURL instances in the InProcessImporterBridge class which lives in the browser process. The other change is in the Firefox3 importer where in we pass the Firefox profile XML data in a vector to the browser via the newly added virtual function ImporterBridge::SetFirefoxSearchEnginesXMLData. The ExternalProcessImporterBridge implementation of this function sends over the XML data via an IPC to the browser. The InProcessImporterBridge implementation parses this data to retrieve the search engine information which is then imported. This is continuation of the ongoing work for bug https://code.google.com/p/chromium/issues/detail?can=2&q=237249 which is to split chrome.dll into a browser and a renderer/child component due to build issues on Windows. To achieve this we need to ensure that the browser code does not depend on webkit/child. BUG=237249 R=gab@chromium.org, jschuh@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/18064002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209072 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome/browser/, part 5.avi@chromium.org2013-06-282-2/+2
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/18127003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209061 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Remove unused includes of scoped_nsobject.h.thakis@chromium.org2013-06-251-1/+0
| | | | | | | | | | | Manual follow-up to mechanical https://codereview.chromium.org/17593006/ BUG=251957 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/17627005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208410 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Update clients of scoped_nsobject.h.thakis@chromium.org2013-06-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | 1.) The header is now in base/mac instead of base/memory 2.) The class is now in namespace base. This CL was created programmatically by running: 1.) git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g' for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done git commit -a -m headers # manually undo changes to gypi file git cl upload # patch set 1 2.) git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g' # manually undo comment changes in scoped_nsobject.h, tracking_area.h git commit -a -m format git cl upload # patch set 2 # Manually audit all files, file bugs and clean up bad clang-format decisions git cl upload # patch set 3 BUG=251957 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/17593006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208283 0039d316-1c4b-4281-b951-d872f2087c98
* OOP import on Linux (i.e., on all platforms since Linux is the only one left!).gab@chromium.org2013-06-222-7/+2
| | | | | | | | | | | After this CL the only blocker to completely remove the in-process import code will be the toolbar importer on Windows (http://crbug.com/243423). BUG=56816 TEST=Manually verify that first run import works (i.e. imports FF history when FF is default) on Linux. Review URL: https://chromiumcodereview.appspot.com/17379006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208054 0039d316-1c4b-4281-b951-d872f2087c98
* Copy SourceProfile into ExternalProcessImporterClient instead of using a ↵gab@chromium.org2013-06-211-1/+1
| | | | | | | | | | const& since the original SourceProfile might be deleted before ExternalProcessImporterClient uses it on the IO thread in StartProcessOnIOThread(). BUG=248642, 181499 Review URL: https://chromiumcodereview.appspot.com/17245003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207721 0039d316-1c4b-4281-b951-d872f2087c98
* Add the application's locale to SourceProfile as it is required by the ↵gab@chromium.org2013-06-207-26/+47
| | | | | | | | | | | | | | Firefox importer and only available on the browser process' UI thread. Some plumbing is required to get the locale into the SourceProfile (as it is created on the FILE thread); and some more IPC changes are required to make sure it makes it's way into the import utility process. This is a prerequisite for OOP import on Linux (https://codereview.chromium.org/17379006/)! BUG=56816 Review URL: https://chromiumcodereview.appspot.com/17318002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207488 0039d316-1c4b-4281-b951-d872f2087c98
* Move Firefox importer's INI parser to c/browser/common.tommycli@chromium.org2013-06-181-47/+6
| | | | | | | | | | Media Galleries API Picasa Import will require reading some INI files. Rather than re-invent the wheel and duplicate code, we are moving the INI parser used by Firefox import into chrome/browser/common. BUG=151701 Review URL: https://chromiumcodereview.appspot.com/16982004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207111 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 04:25:27 +0000