| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tree directly rather than relying on webkit/data/layout_tests for the
baselines. This requires us to change a few spots in the source code
because the directory naming conventions for platform-specific baselines
is different upstream (it's platform/chromium-win/foo rather than
platform/chromium-win/LayoutTests/foo).
Once this test lands we can (in theory) remove the downstream layout test baselines.
BUG=none
TEST=none
R=dimich@chromium.org
Review URL: http://codereview.chromium.org/1547009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
functions to use FilePaths.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1567009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the UI test framework:
- WaitUntilCookieValue
- WaitUntilCookieNonEmpty
- WaitUntilJavaScriptCondition
This helps reduce number of arbitrary "magic timeouts" which are different
in each test.
We don't remove the test timeout parameter, because it varies depending on test case,
and for now we don't have a better solution. Trying a "naive" way leads to hangs
on flaky tests.
TEST=UI-based tests
BUG=none
Review URL: http://codereview.chromium.org/1557001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test timeout.
Layout tests run in ui_tests can now have their timeout set via the cmd line,
and a longer timeout is passed in when valgrind is run.
BUG=39570
TEST=existing tests suffice
Review URL: http://codereview.chromium.org/1518001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gets uninstalled.
BUG=27938,39177
TEST=Unittest in extension_service_unitttest.cc
Review URL: http://codereview.chromium.org/1257005
Patch from Mattias Nissler.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=valgrind test: unit should turn green
BUG=38398
BUG=39177
Review URL: http://codereview.chromium.org/1313003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"Clear cookies, local storage and databases when an extension gets uninstalled."
BUG=39177
BUG=38398
Review URL: http://codereview.chromium.org/1210004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gets uninstalled."
It introduced a memory leak, causing a regression on valgrind test: unit.
TBR=jochen
Review URL: http://codereview.chromium.org/1295001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=27938
TEST=Unittest in extension_service_unitttest.cc
Review URL: http://codereview.chromium.org/1095003
Patch from Mattias Nissler.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
aren't checked out on the bots. We need to figure out how to deal with this
since we don't want to keep expectations downstream if we can avoid it.
BUG=none
R=none
TEST=bots stay green
Review URL: http://codereview.chromium.org/1253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=bots stay green
R=eroman@chromium.org
Review URL: http://codereview.chromium.org/1214001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
important return values are not ignored.
The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC,
but that's enough since we have bots for all platforms.
Adding these warnings already detected some cases where a return value
was ignored. In some of them the test was trying to get the information
about success "some other way", in some it could sometimes confuse test
failure with test success.
TEST=ui_tests
BUG=none
Review URL: http://codereview.chromium.org/948002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderThread::RoutingIDForCurrentContext() whenever possible. In addition,
call OnContentBlocked directly from within the browser instead of sending
another IPC message. Lastly, make sure that we don't crash in the event
that we can't determine the routing id.
WebKit side: https://bugs.webkit.org/show_bug.cgi?id=35758
(Landing again after reverting in 40922)
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/671001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of using
RenderThread::RoutingIDForCurrentContext() whenever possible. In addition,
call OnContentBlocked directly from within the browser instead of sending
another IPC message. Lastly, make sure that we don't crash in the event
that we can't determine the routing id.
WebKit side: https://bugs.webkit.org/show_bug.cgi?id=35758
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/669084
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/669293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderThread::RoutingIDForCurrentContext() whenever possible. In addition,
call OnContentBlocked directly from within the browser instead of sending
another IPC message. Lastly, make sure that we don't crash in the event
that we can't determine the routing id.
WebKit side: https://bugs.webkit.org/show_bug.cgi?id=35758
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/669084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/669184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
StorageArea::setItem.
TEST=none
BUG=37350
Review URL: http://codereview.chromium.org/669072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=4360
Review URL: http://codereview.chromium.org/551098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34894,35178
Review URL: http://codereview.chromium.org/650204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Added a tab view with all the UI, set up bindings for radio groups and checkboxes. Hooked up buttons.
Missing for now:
* "Exception" dialogs ("exception" buttons are disabled until then)
* Some polish
* The cookie "ask" dialog
BUG=34894
TEST=Open content settings dialog. Set different things, click various things, and make sure they all have the expected effect.
Review URL: http://codereview.chromium.org/652037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make its decision. Before, it used the TabContents to get the profile to get the map, but this was incorrect because the current tab isn't necessarily from the same profile as the original request.
As long as we have the HostContentSettingsMap, we might as well handle "remember" in CookieModalDialog.
This bug exists in 4.1.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/651023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for local storage.
BUG=34628
TEST=none
Review URL: http://codereview.chromium.org/605028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add some plumbing for popping up an icon when it's blocked.
TEST=Turn on the ask content setting for a domain and set local storage and then clear it. Only the set should prompt you.
BUG=34668
Review URL: http://codereview.chromium.org/600078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actual key and value. Unfortunately, we're going to have to abuse cookie strings for 4.1 Once this goes in, I'll add new strings for the actual fields.
This also cleans up the code some.
TEST=Instead of size/modified information you'll see "name" and "content" in the dialog that comes up when asking whether to allow local storage.
BUG=none
Review URL: http://codereview.chromium.org/597061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jorlow
BUG=24607
TEST=none
Review URL: http://codereview.chromium.org/601029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34805
TEST=New Tab page should still work if you disable script + images
Review URL: http://codereview.chromium.org/588011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hooks up the dialog for cookies and localstorage. It also includes
support for remembering the decision, and in the case of cookies, support is
added for forcing a cookie to be a stored as a session cookie.
BUG=34625,34572
Review URL: http://codereview.chromium.org/583004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension data.
You can use the cookie tree model to really delete all data.
BUG=34598
TEST=install an extension that uses local storage, delete browsing data, check that the extension data still exist.
Review URL: http://codereview.chromium.org/573030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/560024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/564012
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/564023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/564012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/565004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2 of the comented out ones crash and need investigation.
The rest have output that are too big for a cookie. It's a low-priority todo to find a better solution for these since there's a decent amount of coverage provided by the tests that do run and the runs in test shell.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/548174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=compiles
Review URL: http://codereview.chromium.org/557001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=33108
Review URL: http://codereview.chromium.org/543168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=The show cookie dialog box should have a new node "local storage" when appropriate. When selected, it should display details of local storage (name, size on disk, last modified) in the details frame.
Review URL: http://codereview.chromium.org/523139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=The show cookie dialog box should have a new node "local storage" when appropriate. When selected, it should display details of local storage (name, size on disk, last modified) in the details frame.
Landing for Marcus
Original CL: http://codereview.chromium.org/523139/show
Review URL: http://codereview.chromium.org/546081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and do a bit of refactoring. Use the recently added session_storage_namespace_id_.
Next steps: a bit more testing then I think we're ready to take it out from behind its flag!
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/523117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
creating and tracking namespace ids in conjunction with the tabs. This is essentially just a bunch of dead code at the moment, but the next patch will get rid of the old way of generating/cloning IDs (initiated by the renderer) and instead use these IDs.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/550017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27618
TEST=none
Review URL: http://codereview.chromium.org/460106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DOMStorageArea.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/488014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you have any suggestions for other unit tests I can write for this, please
suggest them!
TEST=none
BUG=16155
Review URL: http://codereview.chromium.org/491035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28788
TEST="Clear private data..." from the menu, check cookies, and tell it ok. Data in "Local Storage" inside the profile's data dir should be deleted and any open websites that were using that data should no longer be able to see it.
Review URL: http://codereview.chromium.org/441012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start the WebKit thread when we initialize the resource
dispatcher host.
NOTE: It's very possible this will have a startup
performance impact. I'm going to watch the bots after
committing.
TODO: Clean up shutdown logic that exists simply
because we don't know whether or not we'll ever start
the WebKit thread.
Originally landed in r33063, reverted in r33101 due to
coincidence with Modules Linux startup test failures.
TBR=jorlow, darin
TEST=The WebKit thread gets spun up early in the
initialization process.
BUG=24144,28364
Review URL: http://codereview.chromium.org/441025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a flaky failure in Linux startup tests that
started appearing after r33063 landed. Try backing
out r33063 to see if this CL is the cause.
BUG=24144
TEST=linux startup tests pass
TBR=jorlow
Review URL: http://codereview.chromium.org/441020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start the WebKit thread when we initialize the resource dispatcher host.
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TBR=darin
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144,28364
Review URL: http://codereview.chromium.org/432007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=32319 with unit test fixes.
Reverting this as this caused a number of valgrind test failures.
Make the WebKitThread object start the WebKit thread on construction (not lazily).
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144
Review URL: http://codereview.chromium.org/404025
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/427001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with unit test fixes.
Make the WebKitThread object start the WebKit thread on construction (not lazily).
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144
Review URL: http://codereview.chromium.org/404025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=abarth
BUG=25133
TEST=none. A cosmetic change.
Review URL: http://codereview.chromium.org/403011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32373 0039d316-1c4b-4281-b951-d872f2087c98
|