| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5046002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Makes the code for running the promo more real. We're not ready to
flip it on yet, so it isn't enabled.
. Nukes verbatim from about:flags and instead randomly chooses
verbatim/predictive when the user opts in. We're doing this to try
and see if we get feedback as to which one folks like more. Windows
preferences shows you which one you get (by way of an obscure
label). I'll change gtk do to that shortly too.
. Adds metrics.
And a couple of random style issues I encountered in some files.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/5023001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4932001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=tonyg
BUG=62940
TEST=interactive_ui_tests
Review URL: http://codereview.chromium.org/4889001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61991
TEST=Enable Instant. Load extension at chrome/common/extensions/docs/examples/extensions/chrome_search. Type "src foo" into the omnibox. You should not see Instant displaying an error page.
Review URL: http://codereview.chromium.org/4782001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4678003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58937
TEST=manual
Review URL: http://codereview.chromium.org/4427001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add some tests.
BUG=none
TEST=interactive_ui_tests --gtest_filter=InstantTest.*
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
predictive results. More work is needed if we decide this is the direction to go, but it's good enough for us to play with.
BUG=61378
TEST=none
Review URL: http://codereview.chromium.org/4196009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This way Linux and Windows can share.
BUG=58937
TEST=manual
Review URL: http://codereview.chromium.org/4157004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=55418
TEST=unit_tests --gtest_filter=AutocompletePopupViewGtkTest.\* should
run tests on GTK but not Windows or Mac.
Review URL: http://codereview.chromium.org/4082002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to be registered at onload time, then check again for the actual
functions after a delay. We need to do this as functions aren't
registered until after onload time.
BUG=59216
TEST=none
Review URL: http://codereview.chromium.org/4183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59679
TEST=see bug
Review URL: http://codereview.chromium.org/4206001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
right time.
BUG=56259
TEST=none
Review URL: http://codereview.chromium.org/3969004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it on.
BUG=58917
TEST=none
Review URL: http://codereview.chromium.org/3961003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
InstantLoader::DestroyPreviewContents()
AutocompleteEditView::GetMaxYCoordinate()
BUG=None
TEST=Everything should still compile.
Review URL: http://codereview.chromium.org/3772008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ok.
BUG=59148
TEST=none
Review URL: http://codereview.chromium.org/3803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm TBRing this since it's mostly a revert.
TBR=ben@chromium.org
BUG=59298
TEST=make sure instant isn't in preferences anymore.
Review URL: http://codereview.chromium.org/3809005
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/3777009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm TBRing this since it's mostly a revert.
TBR=ben@chromium.org
BUG=59298
TEST=make sure instant isn't in preferences anymore.
Review URL: http://codereview.chromium.org/3809005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
url.
BUG=58756
TEST=none
Review URL: http://codereview.chromium.org/3754004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed around BlockedPopupContainer so that it can handle any types
and made TabContents offer a mode to block all child content.
BUG=58927
TEST=enable instant, go to a site that would normally show a popup on
entering (or explicitly enable all popups). While typing in
the omnibox the popup shouldn't appear, but as soon as you
commit the instant result it should appear.
Review URL: http://codereview.chromium.org/3694005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=58772
TEST=make sure that there is an entry in prefs for instant. See that
it works.
Review URL: http://codereview.chromium.org/3726002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only on a mouse down event. This will allow us to click on instant results without dismissing the omnibox popup.
BUG=56385
TEST=No visible impact, yet.
TEST=Should still be able to tab from the omnibox into webpages.
TEST=Clicking on a webpage should transfer focus to the page.
Review URL: http://codereview.chromium.org/3535015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58567
TEST=none
Review URL: http://codereview.chromium.org/3710002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is done as it's quite expensive to have the page shift around, and the
omnibox can dance around a bit before settling down at a particular
size.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3555023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also had to make it so you can turn off animations in CustomButton.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3544015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FrameLoaderObserver's lifetime is tied to that of InstantLoader.
BUG=58411
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3536017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instant.
BUG=55342
TEST=none
Review URL: http://codereview.chromium.org/3613014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
before sending down the instant script. If the page doesn't support
instant we fallback to reloading urls.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3608009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
popup.
BUG=57361
TEST=see bug
Review URL: http://codereview.chromium.org/3536012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
contain any changes other than renaming/moving, as such I'm TBRing.
BUG=54833
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3602015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61553 0039d316-1c4b-4281-b951-d872f2087c98
|