| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only thing left is the code in SpdyFramer, which will be taken care
of in a separate CL.
Credential frames will never be turned on, so this is all dead code.
Unhide a non-credentials-related test inadvertently put behind a
USE_OPENSSL check.
BUG=311852
R=darin@chromium.org, rch@chromium.org
Review URL: https://codereview.chromium.org/46373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a switch to re-enable advertising SPDY/2.
Use SPDY/3 instead of SPDY/2 for cases where SPDY is forced on. Also use SPDY/3 instead of SPDY/2 in tests.
Add "deprecated" to all enum constants involving SPDY/2.
Remove unused --enable-npn switch.
BUG=303957
R=darin@chromium.org, rtenneti@chromium.org
Review URL: https://codereview.chromium.org/25977005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client Hints can be used as input to proactive content negotiation;
just as the Accept header allowed clients to indicate what formats
they prefer, Client Hints allow clients to indicate a list of device
and agent specific preferences.
See:
https://github.com/igrigorik/http-client-hints/blob/draft2/draft-grigorik-http-client-hints-01.txt
Patched from https://codereview.chromium.org/23654014/, which was
patched from https://codereview.chromium.org/11970002
BUG=170388
CONTRIBUTOR=yoav@yoav.ws
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225425
Review URL: https://codereview.chromium.org/24451003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297361, 299956
R=rch@chromium.org, asvitkine@chromium.org
Review URL: https://codereview.chromium.org/25087007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Client Hints
>
> Client Hints can be used as input to proactive content negotiation;
> just as the Accept header allowed clients to indicate what formats
> they prefer, Client Hints allow clients to indicate a list of device
> and agent specific preferences.
>
> See:
> https://github.com/igrigorik/http-client-hints/blob/draft2/draft-grigorik-http-client-hints-01.txt
>
> Patched from https://codereview.chromium.org/23654014/, which was
> patched from https://codereview.chromium.org/11970002
>
> BUG=170388
> CONTRIBUTOR=yoav@yoav.ws
>
> Review URL: https://codereview.chromium.org/24451003
TBR=bengr@chromium.org
Review URL: https://codereview.chromium.org/24824003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client Hints can be used as input to proactive content negotiation;
just as the Accept header allowed clients to indicate what formats
they prefer, Client Hints allow clients to indicate a list of device
and agent specific preferences.
See:
https://github.com/igrigorik/http-client-hints/blob/draft2/draft-grigorik-http-client-hints-01.txt
Patched from https://codereview.chromium.org/23654014/, which was
patched from https://codereview.chromium.org/11970002
BUG=170388
CONTRIBUTOR=yoav@yoav.ws
Review URL: https://codereview.chromium.org/24451003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be reused by iOS.
Added/Refined UMA metrics for daily data reduction.
Added unit tests for old and new data saving prefs.
Functional change of this CL:
The daily data saving metrics are now in three pairs, total, with data reduction proxy enabled, and via data reduction proxy.
The UMA metric names are adjusted to be shorter and more accurate. I summarize the status of UMA metrics with this CL in the table here: https://docs.google.com/a/google.com/document/d/1C7K2ZEqklr5nRRqsLGaIkuRZvTWWzZMag-TD7mONb7k/
The previous related review URL: https://chromiumcodereview.appspot.com/19656006
BUG=226138
Review URL: https://chromiumcodereview.appspot.com/23011049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverted due to crashes under memory tools.
BUG=280138
> Remove the Extensions URLRequestContext.
>
> Though chrome-extension: scheme URLs support cookies, they do not share
> a namespace with http: and https:. In particular, chrome-extension://a and
> http://a should not have the same set of cookies.
>
> To enforce this, previously the code created a completely separate
> URLRequestContext for servicing chrome-extension: schemes. However,
> the code really only used this object as a method for conveying the
> correct cookie jar from Profile creation to a few spots where cookies
> were accessed; the rest of the URLRequestContext functionality was unused.
>
> This CL removes the Extensions URLRequestContext code and replaces it
> with APIs that directly expose the needed net::CookieStore.
>
> Lastly, CookieMonster::EnableFileScheme() is removed and
> CookieMonster::Delegate is renamed CookieMonsterDelegate.
>
> EnableFileScheme is an inherently racy API because
> CookieMonsters are creatable on all threads and this
> function sets an unprotected global flag. CookieMonsterDelegate
> is preferable to the nested interface because it can now be
> forward declared.
>
> TBRing darin and sky to cover the rest of the mechanical unittest changes.
>
> TBR=darin,sky
> BUG=158386,159193,57884
>
> Review URL: https://chromiumcodereview.appspot.com/12546016
TBR=ajwong@chromium.org
Review URL: https://codereview.chromium.org/23551005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Though chrome-extension: scheme URLs support cookies, they do not share
a namespace with http: and https:. In particular, chrome-extension://a and
http://a should not have the same set of cookies.
To enforce this, previously the code created a completely separate
URLRequestContext for servicing chrome-extension: schemes. However,
the code really only used this object as a method for conveying the
correct cookie jar from Profile creation to a few spots where cookies
were accessed; the rest of the URLRequestContext functionality was unused.
This CL removes the Extensions URLRequestContext code and replaces it
with APIs that directly expose the needed net::CookieStore.
Lastly, CookieMonster::EnableFileScheme() is removed and
CookieMonster::Delegate is renamed CookieMonsterDelegate.
EnableFileScheme is an inherently racy API because
CookieMonsters are creatable on all threads and this
function sets an unprotected global flag. CookieMonsterDelegate
is preferable to the nested interface because it can now be
forward declared.
TBRing darin and sky to cover the rest of the mechanical unittest changes.
TBR=darin,sky
BUG=158386,159193,57884
Review URL: https://chromiumcodereview.appspot.com/12546016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make net::URLRequestFileJob pass a TaskRunner to FileStream, instead of using a deprecated FileStream constructor that depends on WorkerPool. This TaskRunner is obtained from the blocking pool where possible. Also, remove two explicit uses of WorkerPool in net/url_request/ and chrome/browser/.
Removes dependency on deprecated code. Also fixes memory leaks in unit tests caused by FileStream destruction tasks not running to completion in WorkerPool.
BUG=248513, 251774
Review URL: https://chromiumcodereview.appspot.com/22795006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=226138
isherman: for histogram.xml.
Review URL: https://chromiumcodereview.appspot.com/19656006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The V8 proxy resolver depends on using the default isolate which is
created on the main thread.
BUG=259218
R=cpu@chromium.org, eroman@chromium.org
Review URL: https://codereview.chromium.org/21084006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are still differences between SPDY/4 and HTTP/2 draft 04; those
will be ironed out in upcoming CLs.
Add kProtoHTTP2Draft04 to SPDY NextProto-parametrized tests.
Move NextProto -> SpdyMajorVersion conversion to buffered_spdy_framer.h.
Remove unused SpdyMajorVersion -> NextProto conversion.
Clean up HttpResponseInfo::ConnectionInfo a bit and add a TODO to
remove it.
Parametrize SSLClientSocketPoolTest on NextProto.
BUG=265615
R=darin@chromium.org, rch@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214289
Review URL: https://codereview.chromium.org/21131002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [SPDY] Add strings and constants for HTTP/2 draft 04
>
> There are still differences between SPDY/4 and HTTP/2 draft 04; those
> will be ironed out in upcoming CLs.
>
> Add kProtoHTTP2Draft04 to SPDY NextProto-parametrized tests.
>
> Move NextProto -> SpdyMajorVersion conversion to buffered_spdy_framer.h.
>
> Remove unused SpdyMajorVersion -> NextProto conversion.
>
> Clean up HttpResponseInfo::ConnectionInfo a bit and add a TODO to
> remove it.
>
> Parametrize SSLClientSocketPoolTest on NextProto.
>
> BUG=265615
> R=darin@chromium.org, rch@chromium.org
>
> Review URL: https://codereview.chromium.org/21131002
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/21202002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are still differences between SPDY/4 and HTTP/2 draft 04; those
will be ironed out in upcoming CLs.
Add kProtoHTTP2Draft04 to SPDY NextProto-parametrized tests.
Move NextProto -> SpdyMajorVersion conversion to buffered_spdy_framer.h.
Remove unused SpdyMajorVersion -> NextProto conversion.
Clean up HttpResponseInfo::ConnectionInfo a bit and add a TODO to
remove it.
Parametrize SSLClientSocketPoolTest on NextProto.
BUG=265615
R=darin@chromium.org, rch@chromium.org
Review URL: https://codereview.chromium.org/21131002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org, jochen@chromium.org, rkaplow@chromium.org
Review URL: https://codereview.chromium.org/19538005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until this CL, TestingProfile had 3 distinct URLRequestContexts it would return to the user: one via profile->GetDefaultStoragePartition()->GetRequestContext(), one via profile->GetRequestContext(), and one via profile->GetResourceContext->GetRequestContext(). All of these had different cookie stores. This CL unified them so they all return the one from profile->GetDefaultStoragePartition()->GetRequestContext(). This correctly mimics how production code works.
Doing this had a bunch of implications:
(1) Removes TestingProfile::CreateRequestContext()/ResetRequestContext()
(2) Changes MockRequestContext to share the URLRequestContext with TestingProfile.
(3) TestingProfile now requires all BrowserThreads.
Point (3) effectively adds TestBrowserThreadBundle into a bunch more spots. Because of that, we also have the following changes:
(a) AshTestBase now has a TestBrowserThreadBundle
(b) Removed a bunch of real threads from tests.
(c) TemplateUrlService has reworked synchronization semantics.
(d) Removed MultiThreadTestHelper.
(e) Added TestingIOThread class + testing API in IOThread to mock out various IO thread tasks which enervated with the new TestBrowserThreadBundle.
TBR=bauerb,brettw,isherman,joth,jyasskin,mattm,mmenke,mnissler,pkasting,rkc,rlp,satorux,tim,xians,joth
BUG=159193
Review URL: https://chromiumcodereview.appspot.com/17127002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- removes the PrefProxyConfigTracker typedef which depended on compile time flags.
- PrefProxyConfigTracker is now a proper pure interface.
- removes unnecessary exposure of ChromeProxyConfigService; which is now only used in PrefProxyConfigTrackerImpl
- fixes includes where required
BUG=258835
TBR=sky@chromium.org (API usages, fixed includes)
Review URL: https://chromiumcodereview.appspot.com/18259025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix for RetransmitUnackedPackets going in an infinite loop.
- Fix for AddFrame failing after packet_creator_->HasRoomForStreamFrame
success.
- Enable quic_https only if quic_http is enabled (implemented rch's comments).
TODO: Add a flag that sets No QUIC, QUIC+HTTP, QUIC+HTTP+HTTPS
BUG=261475, 261465
TBR=jar@chromium.org, rch@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/19547010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will let us better track down what is causing SpdySessions to be
accessing them after they're destroyed, since we'll have crash reports
instead of just the SyzyASAN reports.
Also use scoped_ptr<HttpServerProperties> when appropriate.
BUG=236451
TBR=ajwong@chromium.org, rtenneti@chromium.org, simonjam@chromium.org, wez@chromium.org
Review URL: https://codereview.chromium.org/19731002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since r195406 the probe is not used. It is now safe to remove this code completely.
BUG=260750
Review URL: https://chromiumcodereview.appspot.com/19286002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Cleaning up TODO(joi) entries in //net.
>
> The two TODOs related to threading are apparently gone so I'm removing
> the TODOs and associated code.
>
> I no longer think it's worth pursuing the idea of separating
> throttling and the sliding window concept, so transforming a TODO
> related to that to just an observation.
>
> TBR=darin@chromium.org
> BUG=none
>
> Review URL: https://chromiumcodereview.appspot.com/18261003
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/19674007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The two TODOs related to threading are apparently gone so I'm removing
the TODOs and associated code.
I no longer think it's worth pursuing the idea of separating
throttling and the sliding window concept, so transforming a TODO
related to that to just an observation.
TBR=darin@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/18261003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this change Init() method will be run as the first task
on the thread asynchronously from the UI thread initialization.
This allows us to speed up the startup by making IOThread Init()
a non-blocking task for the UI.
Changes AwUrlRequestContextGetter to create a CookieMonster on
UI thread since it needs to happen synchonously.
BUG=258231
Review URL: https://chromiumcodereview.appspot.com/18618004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove the UserSharedProxies pref from local state
- fix the default value of the pref in the profile pref service
- make the conditionals, when to use or ignore proxy settings, more explicit and clearer.
BUG=258835
TEST=Manually checked all combinations of {DevicePolicy, UserPolicy, SharedNetwork, NotSharedNetwork} x {before, after login} x {enabled, disabled UseSharedProxies} for proxies of the system context, signin profile and user's profile. I checked the proxies by looking at the vlogs and the UI (like net-internals and settings page). I did not test the actual network connectivity of each context.
TBR=battre@chromium.org, nkostylev@chromium.org
Review URL: https://codereview.chromium.org/18112018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
if SPDY is disabled by policy.
BUG=259021
Review URL: https://chromiumcodereview.appspot.com/18859009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org, rch@chromium.org, thestig@
thestig@: could you please take a look at changes to chrome area (added the flags ala enabling QUIC). thanks
Review URL: https://chromiumcodereview.appspot.com/18961005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace the map of keys to lists of sessions to a map
of keys to sessions, since we were already limiting
the lists to be of size 1 anyway.
Remove the functions from SpdySessionPool that were
used mostly by tests. Replace them with functions
in spdy_test_util_common.{h,cc}. Make a bunch of
tests use these functions.
Make the Close*Sessions() behave consistently.
Make SpdySession::CloseSessionOnError() always remove
the session from its pool.
Move the SpdySessionPool tests for spdy_session_unittest.cc
to a new file spdy_session_pool_unittest.cc. Add
a few more for the Close*Sessions() tests.
Remove --max-spdy-sessions-per-domain switch.
Parametrize HttpStreamFactoryTest on NextProto.
Misc. cleanup here and there.
BUG=255701
TBR=rch@chromium.org
Review URL: https://codereview.chromium.org/18226004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=230124
R=darin@chromium.org, rch@chromium.org
Review URL: https://codereview.chromium.org/17764006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This switch was added in:
https://codereview.chromium.org/9475037
and given to the network stack via chrome_browser_main. At
some point, that plumbing was removed. This restores it.
BUG=249105
Review URL: https://chromiumcodereview.appspot.com/16836006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=222350
Review URL: https://chromiumcodereview.appspot.com/15769006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15798020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Instead of forcing QUIC on for all origins with the specified port, this will allow QUIC to be forced for a particular origin. The old flag made it challenging to test QUIC to servers on non-unique ports (like 80 or 443).
Review URL: https://chromiumcodereview.appspot.com/15896025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux fixes, Part 3 of N
BUG=110610
TBR=darin
Review URL: https://chromiumcodereview.appspot.com/16296002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=230028
Review URL: https://chromiumcodereview.appspot.com/15736025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
addresses a regression from r198915.
BUG=243974
Review URL: https://chromiumcodereview.appspot.com/15665006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of issue 14299011, which broke GLSurfaceGLX, in turn breaking Chrome Linux/Aura.
This CL changes WeakPtr in the following ways:
* Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them.
* Removes WeakPtrFactory::DetachFromThread.
* Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack.
Calling code changes to allow this:
* Unnecessary use of SupportsWeakPtr removed from SGIVideoSyncProviderThreadShim.
* Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
* DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx.
WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use.
TBR=darin,awong
BUG=232143, 234964, 243914
Review URL: https://chromiumcodereview.appspot.com/16007009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused local failures in linux_aura builds. Unsure why this isn't showing
up on the bots.
> Remove all but one use of WeakPtrFactory::DetachFromThread.
>
> This CL changes WeakPtr in the following ways:
> * Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them.
> * Removes WeakPtrFactory::DetachFromThread.
> * Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack.
>
> Calling code changes to allow this:
> * Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
> * DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx.
>
> WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use.
>
> Review URL: https://chromiumcodereview.appspot.com/14299011
BUG=232143, 234964, 243914
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/15819004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes WeakPtr in the following ways:
* Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them.
* Removes WeakPtrFactory::DetachFromThread.
* Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack.
Calling code changes to allow this:
* Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
* DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx.
WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use.
BUG=232143, 234964
Review URL: https://chromiumcodereview.appspot.com/14299011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added enum PrivacyMode (Enabled/Disabled) to mark connections which should not use ChannelID even if it is globally enabled.
PrivacyMode is enabled if user blocks sending or saving cookies to/from particular server, taking in account third party cookie settings as well. See crbug.com/223191 for design doc.
Segmented client socket pools according to privacy mode setting used for particular connection (added 'pm/' prefix to pool key. Introduced SpdySessionKey structure and added PrivacyMode to the key of SpdySessionPool.
Added propagation of Privacy Mode setting from Web Sockets. Added check of Privacy Mode to predictor and pre-connect logic.
BUG=223191
TEST=unit_tests gtest_filter=ChromeNetworkDelegatePrivacyModeTest*
Review URL: https://chromiumcodereview.appspot.com/13008028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes support for SPDY 4a1.
Remove --enable-spdy4 flag for now (until we get test
coverage).
This lands server change 45362310.
BUG=230124
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14189003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead add corresponding ProtocolHandlers as needed.
Remove URLRequestContext members used by these static
factories. Bake FtpAuthCache into FtpProtocolHandler as it
was already unique per FtpProtocolHandler.
This is a revived version of http://crrev.com/10836206
BUG=142945
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188912
Review URL: https://chromiumcodereview.appspot.com/11931024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's no longer providing value as the MSVC warning is disabled during
compilation. Refer to bug for details.
BUG=234765
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/14712004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The service will now get time updates from sync's http bridge (with
time data from the sync server).
Original codereview by haitaol@chromium.org at
https://codereview.chromium.org/12211117/
BUG=177072
TBR=akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12833011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change --enable-spdy31 flag to --disable-spdy31 flag and remove the
experiment in about:flags.
BUG=176592,232201
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/14335002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=230124
Review URL: https://codereview.chromium.org/13845012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=70818
Review URL: https://chromiumcodereview.appspot.com/13818025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=rch@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12770035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|