summaryrefslogtreecommitdiffstats
path: root/chrome/browser/js_modal_dialog.h
Commit message (Collapse)AuthorAgeFilesLines
* Suppress additional JS alerts on Cancel as well as on Accept.pam@chromium.org2010-10-141-1/+1
| | | | | | | | | | BUG=26450 TEST=Load webpage with three JS alerts. Check "Prevent this page from creating additional dialogs" on the second, and Cancel that alert. Ensure that the third alert is not shown. Review URL: http://codereview.chromium.org/3792001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62543 0039d316-1c4b-4281-b951-d872f2087c98
* Fix probably a lot of crash bugs. There was a member variable in ↵ben@chromium.org2010-10-021-2/+0
| | | | | | | | | | | JSModalDialog that was masking the one in AppModalDialog that really mattered. This was preventing proper cleanup of the alert window under certain circumstances. http://crbug.com/57368 TEST=none Review URL: http://codereview.chromium.org/3543008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61315 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Delegate to JavaScriptAppModalDialog.tfarina@chromium.org2010-10-021-15/+36
| | | | | | | | | | | | | | | | | Done a couples of things here: - Renamed JavaScriptMessageBoxClient to JavaScriptMessageBoxDelegate (since this is a common pattern in chrome and helps the reader to find out where the message box goes). - Moved that class into js_modal_dialog.h file. - Deleted jsmessage_box_client.h It is a following to http://codereview.chromium.org/3384036. BUG=54988 TEST=trybots Review URL: http://codereview.chromium.org/3576003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61309 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialog to more clearly isolate platform specific UI pieces ↵ben@chromium.org2010-09-281-34/+11
| | | | | | | | | | | and eliminate the dependency on individual frontends from cross platform code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3398015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60785 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 2)thestig@chromium.org2010-08-061-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3010052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55191 0039d316-1c4b-4281-b951-d872f2087c98
* Delete obviously unneeded forward declarations in chrome/browser/*.h.viettrungluu@chromium.org2010-08-051-0/+4
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3080031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55037 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r44125aa@chromium.org2010-04-091-0/+2
| | | | | | | | BUG=40439 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44132 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt fix for crash bug when alert closes while owning hostaa@chromium.org2010-04-091-2/+0
| | | | | | | | | | | | is invalid. I can't actually repro this bug, but I think this should fix it. BUG=40439 Review URL: http://codereview.chromium.org/1540024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44125 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] augment modal cookie prompt on mac to include details panedanno@chromium.org2010-03-121-0/+16
| | | | | | | | | | | | | | | | Added two new xibs. The first is a cookie info view that is shared between the tree that shows browser data and the cookie modal prompt to block accepting cookies. The second is a window to replace the NSAlert modal dialog for the cookie prompt. Modified cookie tree code and added cookie prompt code to use new xibs. Changed "hidden" handling of cookie detail view to use bindings rather than explicit code. TODOs for http://crbug.com/36948 not in this CL: - changing the expiration for cookies isn't implemented TEST=manually testing of modal cookie prompt, new unit tests BUG=http://crbug.com/36948 Review URL: http://codereview.chromium.org/669127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41408 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: Another chunk of chrome/ ifdef changespvalchev@google.com2010-03-091-3/+2
| | | | | | Review URL: http://codereview.chromium.org/652186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40974 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored out JS specific part of modal dialog stack into its own class, ↵zelidrag@chromium.org2010-02-051-0/+102
exposed cookie/storage prompt as a modal dialog. BUG=32719 TEST=none, requires Darin to hook this with his code. Review URL: http://codereview.chromium.org/560030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38268 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-03 03:18:41 +0000