| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27933 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original issue: http://codereview.chromium.org/115212/show
The favicons service is the entry point to getting favicons.
Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages
are never added to the history.
BUG=5840
TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in
this window. Then close the window and open the NTP. The recently closed
windows/tabs should show the favicons for the hsitroy and downloads page.
Review URL: http://codereview.chromium.org/178001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
track down all callers, also removes the
deprecated function that uses std::wstring.
BUG=3078 (http://crbug.com/3078)
TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests.
Review URL: http://codereview.chromium.org/164537
Patch from Thiago Farina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
To read this crash dump, this issue is caused by my mistake that this jumplist.cc calls "icon_urls_.front()" for an empty list.
This change added some checks that verifies a std::list has one or more items.
This change also fixes linker errors because of conflicted symbols: CLSID_DestinationList and CLSID_EnumerableObjectCollection, which is caused by my mistake that I forgot removing "EXTERN_C" keywords when I moved them into an anonymous namespace. This change removes the "EXTERN_C" keywords for VS2008.
BUG=18837 "Crash - JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned char> >,bool,GURL)"
TEST=Show JumpList on Windows 7.
TEST=Build Chromium with VS2008.
Review URL: http://codereview.chromium.org/159853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22907 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This caused an easily reproducible crash:
1. Start with a fresh profile
2. Navigate to google.com
3. Restart
4. Navigate to google.com
5. crash
The change from pass-by-value to pass-by-ref in
fav_icon_helper.* seems to be to blame, but I can't see it
right off.
TBR=phajdan.jr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
This change enables our custom JumpList by default, i.e. enables our custom JumpList when Chromium is launched without a "--disable-custom-jumplist" option.
BUG=8037
TEST=Right-click the taskbar icon of Chromium on Windows 7.
Review URL: http://codereview.chromium.org/159398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
This change adds an option "--enable-custom-jumplist" that uses the ICustomDestinationList interface to add "Most Visited" pages, "Recently Closed" pages, and "Tasks" to the JumpList of Chromium.
This change registers the CustomJumpList class into an observer of TabRestoreService so it can update the JumpList when a user adds/removes a tab.
This change stores icon files used by a custom JumpList under "$(User Data Dir)/JumpListIcons" so Taskbar can show JumpList icons even when Chromium is not running.
BUG=8037
TEST=Right-click the taskbar icon of Chromium on Windows 7.
Review URL: http://codereview.chromium.org/56175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21522 0039d316-1c4b-4281-b951-d872f2087c98
|
