summaryrefslogtreecommitdiffstats
path: root/chrome/browser/location_bar.h
Commit message (Collapse)AuthorAgeFilesLines
* Add a rudamentary feed preview to the RSS extension. Itfinnur@chromium.org2009-07-091-0/+10
| | | | | | | | | | | | | | | | | | | | | doesn't handle inline HTML in the item description (it just dumps it as text) and the feed needs to be valid XML for it to show any preview, but it is better than nothing. We can easily change it to display the HTML but we want to (at some point) try to use a separate origin so that we can render the HTML code from untrusted sources safely. Also fix a bug in the image tracker. It should not try to communicate with the view if the view has gone away (which was the whole point of the image tracker...) BUG=None TEST=Install the extension, browse to a page with a feed and click onthe rss icon in the Omnibox. An interstitial page should appear with a preview of the feed. Review URL: http://codereview.chromium.org/155180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20316 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for Miranda. glen@chromium.org2009-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/115265 Original text: """ This addresses 3 of the 4 issues described in Issue 9223: 1) Creates a new streamlined bubble with less text. 2) Incorporates a close [x]. 3) Driven by configuration option in master_preferences file; this alternate bubble will be used only if "oem_bubble": true is set. Requested longer linger time feature will involve mucking with the focus manager; this change will be uploaded separately. BUG=9223 TEST=Add "oem_bubble": true to master_preferences file. Run chrome with --first-run option. Alternate, smaller OEM bubble should appear over the Chrome browser in the place of the standard first-run bubble. """ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16438 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the first run bubble change because of Mac/Linux failures.glen@chromium.org2009-05-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16245 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit for MirandaC of Smaller alternate first run bubble. ↵glen@chromium.org2009-05-161-1/+1
| | | | | | http://codereview.chromium.org/115265 BUG=9223 TBR=mirandac git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16243 0039d316-1c4b-4281-b951-d872f2087c98
* rollback of r 162411glen@chromium.org2009-05-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16242 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for MirandaC of Smaller alternate first run bubble. ↵glen@chromium.org2009-05-161-1/+1
| | | | | | | | | | | http://codereview.chromium.org/115265 BUG=9223 TBR=mirandac Review URL: http://codereview.chromium.org/113504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16241 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: enable omni box ui test and automation proxy ui test.estade@chromium.org2009-05-051-0/+4
| | | | | | | | Enable a lot of (already essentially working) automation code along the way. Review URL: http://codereview.chromium.org/100278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 9812: Remove current RSS code in favor of new more generalizedfinnur@chromium.org2009-05-041-3/+0
| | | | | | | | | | | | PageAction code that serves the same purpose (and more). BUG=9812 TEST=No test needed, this shouldn't result in any noticable difference since the RSS parsing was disabled. Review URL: http://codereview.chromium.org/100356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the omnibox contents when the user reloads the page. Patch by Yusuke ↵pkasting@chromium.org2009-05-041-0/+3
| | | | | | | | Sato (see http://codereview.chromium.org/100198 ), r=me. BUG=2985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15211 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first part of the PageAction implementation. More work is ↵finnur@chromium.org2009-05-011-0/+3
| | | | | | | | | | | | | | | | required, but this is a good checkpoint. Design doc: http://dev.chromium.org/developers/design-documents/extensions/page-actions-api This checkin only covers Tab scoped page actions (not type "permanent"). It works end to end (if you have an extension that supplies the page action info -- I created an RSS page action that links to Google Reader). Please note that TabIndex is hard coded to 0 until the extension system can provide the tab id to the extensions (which I understand is in progress). This means that page action(s) only show up for the first tab in the tabstrip. :) BUG=None TEST=There is a unit test for the API, but apart from that it is not possible to test this manually without writing an extension that adds a PageAction. My RSS page action is not ready to be checked in but I can provide it if there is interest in a sneak preview during review/QA. Review URL: http://codereview.chromium.org/99253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15105 0039d316-1c4b-4281-b951-d872f2087c98
* Redone http://codereview.chromium.org/42571idanan@chromium.org2009-03-241-0/+3
| | | | | | | | | | | Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=maruel Review URL: http://codereview.chromium.org/53020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12403 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r12383, caused a build breakage on all platforms.maruel@chromium.org2009-03-241-3/+0
| | | | | | | TBR=idanan Review URL: http://codereview.chromium.org/42571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12385 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 6477: Support modifier clicks on UI elementsidanan@chromium.org2009-03-241-0/+3
| | | | | | | | | | | | | | | | | | | Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12383 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1), 2nd attempt.finnur@chromium.org2009-03-131-0/+3
| | | | | | | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/46055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11672 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11640.finnur@chromium.org2009-03-131-3/+0
| | | | | | Reverting for now. Will try again later git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1)finnur@chromium.org2009-03-131-0/+3
| | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/43109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few comments / formatting related to the location bar.deanm@chromium.org2009-03-031-10/+15
| | | | | | | | Correct the includes, forward declare TabContents. Review URL: http://codereview.chromium.org/39011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10800 0039d316-1c4b-4281-b951-d872f2087c98
* Create a stub LocationBar object on Mac to communicate between the bar and ↵pinkerton@chromium.org2009-02-061-0/+3
| | | | | | | | the Browser. Review URL: http://codereview.chromium.org/20136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9334 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this from earlier... unit tests no longer crash.ben@chromium.org2009-01-271-0/+44
| | | | | | | | | Extract a cross platform LocationBar interface. Adds a TestLocationBar object that unit tests can use to mock the location bar (fixes NULL deref). Review URL: http://codereview.chromium.org/18851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8745 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 8693 because it breaks the unit_tests.nsylvain@chromium.org2009-01-271-44/+0
| | | | | | | TBR Review URL: http://codereview.chromium.org/19009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8704 0039d316-1c4b-4281-b951-d872f2087c98
* Extract a cross-platform LocationBar interface accessible via the ↵ben@chromium.org2009-01-271-0/+44
BrowserWindow interface that the Browser object can use to do locationbar-ey things without directly depending on Views. Review URL: http://codereview.chromium.org/18826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8693 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 13:34:41 +0000