summaryrefslogtreecommitdiffstats
path: root/chrome/browser/login_prompt.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move:ben@chromium.org2010-12-021-453/+0
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequest URLRequest;tfarina@chromium.org2010-11-301-7/+8
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-181-2/+7
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part20:tfarina@chromium.org2010-10-121-1/+1
| | | | | | | | | | | - Include browser_thread.h instead of chrome_thread.h in more 70 files. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3734002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62276 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part15:tfarina@chromium.org2010-10-111-34/+34
| | | | | | | | | | | - Rename entries in more 40 files under chrome/browser. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3704001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62130 0039d316-1c4b-4281-b951-d872f2087c98
* Save passwords for HTTP+FTP authentication.cbentzel@chromium.org2010-09-221-5/+0
| | | | | | | | | | | | Rather than modifying the PasswordForm to have a username_element and password_element, change the logic in PasswordFormManager::HasValidPasswordForm to only care about empty username_element and password_element for HTML-form based PasswordForms. BUG=5236,49894 TEST=unit_tests --gtest_filter="*TestValidForms*". Manual: Start Chrome with fresh profile, go to a Digest authenticating proxy or server and enter a username+password. After page loads successfully, click "save password" in the infobar. Restart chrome with the same profile, and make sure username+password dialog prompt is filled in. Review URL: http://codereview.chromium.org/3419011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60171 0039d316-1c4b-4281-b951-d872f2087c98
* Username+password weren't being saved for HTTP or FTP authentication.cbentzel@chromium.org2010-09-211-0/+5
| | | | | | | | | | | | | | | | HTTP + FTP authentication reuses the PasswordManager infrastructure for saving and autofilling passwords. When the user needs to be prompted for username + password, a PasswordForm is created. However, a username_element and password_element were never set in the PasswordForm. The PasswordFormManager would then treat this form as invalid, and the values would never be saved even if the page loaded successfully. The UI flow is a bit different from older versions of Chrome, but more consistent with other password saves: the user first presses the OK button to provisionally save and try the new password. When the page loads successfully, an info bar than appears to ask the user whether the password should be saved. BUG=5236 TEST=Go to site (or proxy) which requires Basic or Digest HTTP authentication, enter correct username+password and elect to save the password. Stop Chrome, reopen, and go to site (or through same proxy) and make sure username+password are autofilled in the form. Review URL: http://codereview.chromium.org/3398010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60000 0039d316-1c4b-4281-b951-d872f2087c98
* Return an error code to extensions requesting a resource that requires basicmpcomplete@chromium.org2010-08-021-1/+4
| | | | | | | | | | | HTTP authentication. BUG=31388 TEST=test that basic HTTP authentication still works Review URL: http://codereview.chromium.org/2824063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54622 0039d316-1c4b-4281-b951-d872f2087c98
* Net: Convert username and password to string16.thestig@chromium.org2010-07-291-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3040016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54101 0039d316-1c4b-4281-b951-d872f2087c98
* Make ResourceDispatcherHostRequestInfo own SSLClientAuthHandler and ↵davidben@chromium.org2010-07-201-1/+1
| | | | | | | | | | | | | | | | | | LoginHandler references This avoids problems where the objects disappear while the ResourceDispatcherHostRequestInfo still holds pointers. In particular, SSLClientAuthHandler handler adds and removes a reference to itself when the user dismisses the dialog. ResourceDispatcherHost, however, still holds a pointer and may attempt to notify it of a cancelled request. This stray write may NULL out a useful field and crash. BUG=49352 TEST=steps in bug report Review URL: http://codereview.chromium.org/3043008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix password mgr heuristics for sites that keep the login form around after ↵snej@chromium.org2010-04-281-2/+2
| | | | | | | | | | | | signin The test for whether the login form reappeared on the next page load now ignores invisible forms. BUG=28911 TEST=none (manual testing with reduced web pages) Review URL: http://codereview.chromium.org/1656005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45841 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug which causes proxy authentication requeststonyg@chromium.org2010-04-021-4/+4
| | | | | | | | | | to crash Debug builds. BUG=39329 TEST=Mocking a proxy isn't trivial. Ideas? Review URL: http://codereview.chromium.org/1355001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43483 0039d316-1c4b-4281-b951-d872f2087c98
* Notify all active login prompts when one login prompt is submitted. This allows tonyg@chromium.org2010-04-011-24/+123
| | | | | | | | | | | | | | | | | | | identical login prompts to dismiss themselves. This was originally submitted as r42770 but had to be rolled back because I copied from a FLAKY test. Now that r43266 fixed the flakiness, this should be good to go. The code is exactly the same as r42770 with one exception. I added a WaitForNavigation guard to the tab the other tab in the new test cases. This could have also caused flakiness in the initial revision. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest.* Review URL: http://codereview.chromium.org/1528012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43374 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42770 - Notify all active login prompts when one login prompt is ↵tonyg@chromium.org2010-03-261-123/+24
| | | | | | | | | | | | | | | submitted. This allows identical login prompts to dismiss themselves. BUG=8914 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/1039004 TBR=tonyg@chromium.org Review URL: http://codereview.chromium.org/1410002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42776 0039d316-1c4b-4281-b951-d872f2087c98
* Notify all active login prompts when one login prompt is submitted. This allowstonyg@chromium.org2010-03-261-24/+123
| | | | | | | | | | identical login prompts to dismiss themselves. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/1039004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42770 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a base tonyg@chromium.org2010-03-231-0/+184
| | | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Originally submitted as 41739, however that patch had to be reverted because I had accidentally changed an if (!...) { NOTREACHED(); } into a DCHECK(...) in the LoginHandler ctor. That is fixed now. BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/995004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42368 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41739 - Factoring duplicate code from platformspecific LoginHandlers ↵erg@chromium.org2010-03-161-180/+0
| | | | | | | | | | | | | | | | | | | | into a base LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. TBR=erg@chromium.org Review URL: http://codereview.chromium.org/989004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41746 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a baseerg@chromium.org2010-03-161-0/+180
| | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41739 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 3: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-0/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40959 0039d316-1c4b-4281-b951-d872f2087c98
* fix 32718tim@chromium.org2010-01-221-8/+18
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36829 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-031-6/+5
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the proxy host and port string to start with http:// if it does not already.mdm@chromium.org2009-10-241-1/+5
| | | | | | | | | BUG=21218 TEST=none Review URL: http://codereview.chromium.org/235030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30018 0039d316-1c4b-4281-b951-d872f2087c98
* Split ExtraRequestInfo out of ResourceDispatcherHost so it isn't cluttering upbrettw@chromium.org2009-09-021-4/+5
| | | | | | | | | | | that header file. I added documentation and split out the accessors according to Google-style. BUG=none TEST=none Review URL: http://codereview.chromium.org/179046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25133 0039d316-1c4b-4281-b951-d872f2087c98
* Store the proxy's hostname rather than the first site visited via the proxy ↵mdm@chromium.org2009-08-261-1/+5
| | | | | | | | | | | when storing proxy passwords. BUG=12992 TEST=none Review URL: http://codereview.chromium.org/173438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24519 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from some more files that don't need it.thestig@chromium.org2009-07-101-0/+0
| | | | | | | TBR=evmar Review URL: http://codereview.chromium.org/149471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20406 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the windows specific bits from login_prompt.cc and make ↵erg@chromium.org2009-06-171-287/+14
| | | | | | | | | | LoginPromptWin conform to a general cross platform interface. (Also tightens the interface for ConstrainedWindows a bit more) Review URL: http://codereview.chromium.org/125217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18623 0039d316-1c4b-4281-b951-d872f2087c98
* Extract load times from WebDataSource. Move them to NavigationState.darin@chromium.org2009-06-161-0/+1
| | | | | | | | | | | | Move PasswordForm into the webkit_glue namespace. TEST=none BUG=10041 R=brettw Review URL: http://codereview.chromium.org/126190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18515 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the UI for HTTP/FTP auth challenges to include the server's port. So ↵ericroman@google.com2009-05-211-3/+3
| | | | | | | | | | | instead of "www.foo.com" it will say "www.foo.com:80". We need to include the port number since otherwise it can be ambiguous what the actual target server is. This change also introduces utility function "GetHostAnd[Optional]Port()" to help with forming <host> [":" <port>] strings. BUG=12073 Review URL: http://codereview.chromium.org/112041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16672 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-051-1/+1
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-041-8/+8
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r14146 which refactors DialogButton into cross platformtc@google.com2009-04-211-2/+3
| | | | | | | | | | code. This is the same as the last change except I renamed class MessageBox to class MessageBoxFlags to avoid conflicting with the same name in windows.h. Review URL: http://codereview.chromium.org/87065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14159 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor DialogDelegate so the DialogButton enum is in cross platform"tc@google.com2009-04-211-3/+2
| | | | | | | | | | | | This reverts commit r14146. MessageBox is redefined to MessageBoxW by windows. I need to rename the class. Review URL: http://codereview.chromium.org/87064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DialogDelegate so the DialogButton enum is in cross platformtc@google.com2009-04-211-2/+3
| | | | | | | | | | | | | | | | | code. This is mostly a find & replace in our code to use the new location of the enum. I also deleted some GetDialogButtons methods in child classes because they were identical to the parent version in DialogDelegate. This will allow more code to be enabled on linux/mac in the automation provider. Review URL: http://codereview.chromium.org/88008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land my change to clean up TabContents/WebContents ownership. Thisbrettw@chromium.org2009-04-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | is the same except in tab_strip_model_unittest I fixed a leak by making a WebContents on the stack, I added a factory to the SiteInstance unittest to prevent another leak, and I re-added a NULL set to the external_tab_container. Fix the ownership model of TabContents and NavigationController. Previously the NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Previous review URL: http://codereview.chromium.org/69043 Review URL: http://codereview.chromium.org/67294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14053 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14005.brettw@chromium.org2009-04-181-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ownership model of TabContents and NavigationController. Previously thebrettw@chromium.org2009-04-181-1/+1
| | | | | | | | | | | | | | | | | NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Review URL: http://codereview.chromium.org/69043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14005 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more reliance on tab contents types.brettw@chromium.org2009-04-051-15/+13
| | | | | | Review URL: http://codereview.chromium.org/62041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13135 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix - moved fileben@chromium.org2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11831 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-141-1/+2
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/46079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11699 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new message id IDS_LOGIN_DIALOG_DESCRIPTION_NO_REALM,wtc@chromium.org2009-02-251-3/+6
| | | | | | | | | | | | | | | which is a variant of IDS_LOGIN_DIALOG_DESCRIPTION that doesn't have a realm. Some HTTP authentication schemes such as NTLM don't have a realm. In IDS_LOGIN_DIALOG_DESCRIPTION, changed the placeholder's name from "TITLE" to "REALM". R=eroman,tony BUG=6567,6824 Review URL: http://codereview.chromium.org/27117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10324 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths for grit files. Go ahead and resorttc@google.com2009-02-221-2/+1
| | | | | | | | the headers too. Review URL: http://codereview.chromium.org/21472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10167 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-011-2/+2
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the command updater to not be dependent on views::Button (needed for ↵ben@chromium.org2009-01-201-1/+0
| | | | | | | | | porting). TEST=make sure back/forward buttons still enable/disable correctly depending on the length of the back/forward navigation list. Review URL: http://codereview.chromium.org/18343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8332 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions required by the rest of the browser from RenderProcessHost to ↵brettw@chromium.org2009-01-161-1/+1
| | | | | | | | an interface and move the implementation to BrowserRenderProcessHost. This will allow me to write render view unit tests without using the actual renderer, but there are no tests yet. Review URL: http://codereview.chromium.org/18132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8188 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetSignonRealm a global function as opposed towtc@google.com2009-01-161-8/+3
| | | | | | | | | | | a static method of the LoginHandler class, which should remain an interface with only pure virtual methods. R=eroman Review URL: http://codereview.chromium.org/18106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8183 0039d316-1c4b-4281-b951-d872f2087c98
* post-winhttp cleanup: refactor net/base/auth_cache into net/ftp/ftp_auth_cache.ericroman@google.com2009-01-151-5/+31
| | | | | | | | Also moves AuthCache::HttpKey() --> GetSignonRealmKey(). Review URL: http://codereview.chromium.org/18218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8085 0039d316-1c4b-4281-b951-d872f2087c98
* Move password manager files into a subdirben@chromium.org2009-01-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8066 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 09:30:50 +0000