summaryrefslogtreecommitdiffstats
path: root/chrome/browser/login_prompt.h
Commit message (Collapse)AuthorAgeFilesLines
* Notify all active login prompts when one login prompt is submitted. This allows tonyg@chromium.org2010-04-011-7/+64
| | | | | | | | | | | | | | | | | | | identical login prompts to dismiss themselves. This was originally submitted as r42770 but had to be rolled back because I copied from a FLAKY test. Now that r43266 fixed the flakiness, this should be good to go. The code is exactly the same as r42770 with one exception. I added a WaitForNavigation guard to the tab the other tab in the new test cases. This could have also caused flakiness in the initial revision. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest.* Review URL: http://codereview.chromium.org/1528012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43374 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42770 - Notify all active login prompts when one login prompt is ↵tonyg@chromium.org2010-03-261-64/+7
| | | | | | | | | | | | | | | submitted. This allows identical login prompts to dismiss themselves. BUG=8914 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/1039004 TBR=tonyg@chromium.org Review URL: http://codereview.chromium.org/1410002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42776 0039d316-1c4b-4281-b951-d872f2087c98
* Notify all active login prompts when one login prompt is submitted. This allowstonyg@chromium.org2010-03-261-7/+64
| | | | | | | | | | identical login prompts to dismiss themselves. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/1039004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42770 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a base tonyg@chromium.org2010-03-231-24/+73
| | | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Originally submitted as 41739, however that patch had to be reverted because I had accidentally changed an if (!...) { NOTREACHED(); } into a DCHECK(...) in the LoginHandler ctor. That is fixed now. BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/995004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42368 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41739 - Factoring duplicate code from platformspecific LoginHandlers ↵erg@chromium.org2010-03-161-73/+24
| | | | | | | | | | | | | | | | | | | | into a base LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. TBR=erg@chromium.org Review URL: http://codereview.chromium.org/989004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41746 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a baseerg@chromium.org2010-03-161-24/+73
| | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41739 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected d'tors instead of ↵jamesr@chromium.org2009-12-161-1/+4
| | | | | | | | | | | | | | | | | | | | | non-virtual public implicit d'tors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (chrome/browser/[a-m]* only) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/201100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34634 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-1/+2
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-031-5/+3
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the ability to load lazy URLs from the NavigationController. This is nobrettw@chromium.org2009-09-021-1/+1
| | | | | | | | | | | longer used (except for a test that doens't seem to need it). We used to use this feature for session restore, but it has since changed. TEST=none BUG=none Review URL: http://codereview.chromium.org/191008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-4/+1
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-1/+4
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TODO comment for later when I have more time. (hahaha)erg@google.com2009-06-221-0/+6
| | | | | | Review URL: http://codereview.chromium.org/144005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18960 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the windows specific bits from login_prompt.cc and make ↵erg@chromium.org2009-06-171-3/+28
| | | | | | | | | | LoginPromptWin conform to a general cross platform interface. (Also tightens the interface for ConstrainedWindows a bit more) Review URL: http://codereview.chromium.org/125217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18623 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetSignonRealm a global function as opposed towtc@google.com2009-01-161-7/+8
| | | | | | | | | | | a static method of the LoginHandler class, which should remain an interface with only pure virtual methods. R=eroman Review URL: http://codereview.chromium.org/18106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8183 0039d316-1c4b-4281-b951-d872f2087c98
* post-winhttp cleanup: refactor net/base/auth_cache into net/ftp/ftp_auth_cache.ericroman@google.com2009-01-151-1/+6
| | | | | | | | Also moves AuthCache::HttpKey() --> GetSignonRealmKey(). Review URL: http://codereview.chromium.org/18218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8085 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more classes from net/base into the net:: namespace.darin@google.com2008-07-301-1/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+90
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 11:52:55 +0000