summaryrefslogtreecommitdiffstats
path: root/chrome/browser/login_prompt_gtk.cc
Commit message (Collapse)AuthorAgeFilesLines
* Factoring duplicate code from platform-specific LoginHandlers into a base tonyg@chromium.org2010-03-231-202/+11
| | | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Originally submitted as 41739, however that patch had to be reverted because I had accidentally changed an if (!...) { NOTREACHED(); } into a DCHECK(...) in the LoginHandler ctor. That is fixed now. BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/995004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42368 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41739 - Factoring duplicate code from platformspecific LoginHandlers ↵erg@chromium.org2010-03-161-11/+202
| | | | | | | | | | | | | | | | | | | | into a base LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. TBR=erg@chromium.org Review URL: http://codereview.chromium.org/989004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41746 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a baseerg@chromium.org2010-03-161-202/+11
| | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41739 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 4: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40960 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of bad dependency removal (chrome/common -> chrome/browser)phajdan.jr@chromium.org2010-03-021-1/+1
| | | | | | | | | | | This change introduces one more dependency on chrome/browser, but it seems simpler to move gtk_util first and then fix it. TEST=none BUG=none Review URL: http://codereview.chromium.org/661271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: remove superflous focus grabbing calls that cause crashes in debug mode.estade@chromium.org2010-01-221-6/+0
| | | | | | | | | | | The body of OnPromptShown handles default focus. BUG=none TEST=middle click on a link that requires http auth in debug mode, the browser shouldn't crash Review URL: http://codereview.chromium.org/554042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36817 0039d316-1c4b-4281-b951-d872f2087c98
* Tab-modal dialog improvements:zelidrag@google.com2010-01-151-6/+24
| | | | | | | | | | | | | | | | - treat constrained dialogs as tab-modal - only one shows at the time - added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog - blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018. BUG=456,27585,27620 TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc. Review URL: http://codereview.chromium.org/541056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36415 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't dereference stale ConstrainedWindow pointer.estade@chromium.org2009-11-231-2/+4
| | | | | | | | BUG=28587 Review URL: http://codereview.chromium.org/436004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32827 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-031-44/+45
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some structures in webkit/glue to string16.darin@chromium.org2009-10-201-2/+2
| | | | | | | | | | R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/305002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't crash when closing tabs that have open login prompts.mdm@chromium.org2009-09-121-0/+4
| | | | | | | | | BUG=21601 TEST=close a tab asking for HTTP authentication, it should not crash Review URL: http://codereview.chromium.org/196104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26066 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-1/+1
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-1/+1
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill http auth dialog on os x and linux.thakis@chromium.org2009-08-251-2/+33
| | | | | | | | | BUG=19801 TEST=See bug (on both mac and linux) Review URL: http://codereview.chromium.org/173341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24241 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Post the SendNotification in a task on the UI thread. In rare ↵jhawkins@chromium.org2009-08-111-1/+2
| | | | | | | | | | instances, SendNotifications was being run before CancelAuthDeferred, so the proper cleanup was not happening before this object was deleted which leads to a crash. BUG=18973 TEST=Instructions in the bug report. Review URL: http://codereview.chromium.org/165268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22984 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: convert classes GtkUtil/GtkTreeUtil back to namespaces ↵mdm@chromium.org2009-07-311-2/+2
| | | | | | | | | | | gtk_util/gtk_tree_util. BUG=none TEST=none Review URL: http://codereview.chromium.org/160417 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: convert namespace gtk_util to class GtkUtil to meet style guidelines.mdm@chromium.org2009-07-301-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22036 0039d316-1c4b-4281-b951-d872f2087c98
* First run bubble polish:estade@chromium.org2009-07-151-1/+1
| | | | | | | | | | | | | | | - improve spacing and and sizing, both internally and externally (using windows as the guide) - make legible for dark themes - make show delay longer because it was too short on my machine (at least when using a Debug build). Also explicitly set bookmark bubble labels black. BUG=16782 TEST=none Review URL: http://codereview.chromium.org/149664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20762 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing include.brettw@chromium.org2009-06-301-0/+1
| | | | | | Review URL: http://codereview.chromium.org/151123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19680 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetTabContentsID out of tab util because it has nothing to do with tabs orbrettw@chromium.org2009-06-301-3/+4
| | | | | | | | | | | | TabContents. I put a more accurately named static function in ResourceDispatcherHost which is what really controls this request data. I also moved a couple of static functions from the header to the cc in resource_dispatcher. Review URL: http://codereview.chromium.org/150124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19675 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Polish HTTP Auth UI. Adds standard border and word wraps the label.erg@google.com2009-06-221-3/+3
| | | | | | | | http://crbug.com/11512 Review URL: http://codereview.chromium.org/140076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18930 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: HTTP Auth dialogs under linux.erg@google.com2009-06-191-0/+312
- Implements a ConstrainedWindowGtk which positions itself in the center of its corresponding TabContentsViewGtk. - Implements LoginPromptGtk. HTTP Auth now works under Linux. - Renames ConstrainedWindowImpl to ConstrainedWindowWin http://crbug.com/11512 Review URL: http://codereview.chromium.org/132047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18864 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 22:04:43 +0000