summaryrefslogtreecommitdiffstats
path: root/chrome/browser/login_prompt_mac.mm
Commit message (Collapse)AuthorAgeFilesLines
* Notify all active login prompts when one login prompt is submitted. This allows tonyg@chromium.org2010-04-011-5/+6
| | | | | | | | | | | | | | | | | | | identical login prompts to dismiss themselves. This was originally submitted as r42770 but had to be rolled back because I copied from a FLAKY test. Now that r43266 fixed the flakiness, this should be good to go. The code is exactly the same as r42770 with one exception. I added a WaitForNavigation guard to the tab the other tab in the new test cases. This could have also caused flakiness in the initial revision. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest.* Review URL: http://codereview.chromium.org/1528012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43374 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Disconnect buttons from the login sheet when the login sheet goes ↵rohitrao@chromium.org2010-03-261-0/+8
| | | | | | | | | | | | | away, in case they try to call back later. Xib file changes: - Connect the loginButton_ and cancelButton_ IBOutlets. BUG=29462 TEST=See test case in bug. Review URL: http://codereview.chromium.org/1376001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42792 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42770 - Notify all active login prompts when one login prompt is ↵tonyg@chromium.org2010-03-261-6/+5
| | | | | | | | | | | | | | | submitted. This allows identical login prompts to dismiss themselves. BUG=8914 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/1039004 TBR=tonyg@chromium.org Review URL: http://codereview.chromium.org/1410002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42776 0039d316-1c4b-4281-b951-d872f2087c98
* Notify all active login prompts when one login prompt is submitted. This allowstonyg@chromium.org2010-03-261-5/+6
| | | | | | | | | | identical login prompts to dismiss themselves. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/1039004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42770 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a base tonyg@chromium.org2010-03-231-207/+15
| | | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Originally submitted as 41739, however that patch had to be reverted because I had accidentally changed an if (!...) { NOTREACHED(); } into a DCHECK(...) in the LoginHandler ctor. That is fixed now. BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/995004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42368 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41739 - Factoring duplicate code from platformspecific LoginHandlers ↵erg@chromium.org2010-03-161-15/+207
| | | | | | | | | | | | | | | | | | | | into a base LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. TBR=erg@chromium.org Review URL: http://codereview.chromium.org/989004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41746 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a baseerg@chromium.org2010-03-161-207/+15
| | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41739 0039d316-1c4b-4281-b951-d872f2087c98
* mac: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-101-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/745003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41100 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-031-45/+46
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some structures in webkit/glue to string16.darin@chromium.org2009-10-201-2/+2
| | | | | | | | | | R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/305002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up newer GTMthomasvl@chromium.org2009-09-161-6/+4
| | | | | | | | | | Switch a bunch of window sizing over to use the helper so it's completely in all cases. BUG=none TEST=about box, hung renderer, edit search engine, and http auto still size correctly. Review URL: http://codereview.chromium.org/201137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26369 0039d316-1c4b-4281-b951-d872f2087c98
* Load the http auth dialog from the main bundle.thomasvl@chromium.org2009-09-141-2/+26
| | | | | | | | | | | | Localize the http auth dialog. Add the explanation to the http auth dialog. Autosize the http auth dialog after putting in the explanation. TEST=http auto ui should now be localized. BUG=20532 Review URL: http://codereview.chromium.org/196109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26140 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when closing tab with an open http auth sheet.thakis@chromium.org2009-09-141-5/+10
| | | | | | | | | | | Parts of patch by mdm@chromium.org, taken from http://codereview.chromium.org/196104 BUG=19427, 21111, 21304 (not sure about last one) TEST=Open a page with an http auth sheet, open another tab, close tab with the open sheet -- should not crash. Also check that opening a tab with an open sheet, then hitting back, forward, reload still works and doesn't crash. Review URL: http://codereview.chromium.org/194095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26105 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill http auth dialog on os x and linux.thakis@chromium.org2009-08-251-4/+40
| | | | | | | | | BUG=19801 TEST=See bug (on both mac and linux) Review URL: http://codereview.chromium.org/173341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24241 0039d316-1c4b-4281-b951-d872f2087c98
* Implement http auth login dialog for OS X.thakis@chromium.org2009-08-131-0/+308
The login sheet looks very bare-bones…but that's probably ok for now. BUG=12043 TEST=Go to a page that uses http auth, e.g. http://www.pagetutor.com/keeper/mystash/secretstuff.html . A sheet should come up that asks for login and password. Escape should cancel the sheet, return should confirm it. The sheet should be per-tab, e.g. tab switching while the sheet is open should work. Review URL: http://codereview.chromium.org/164391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23276 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 05:55:24 +0000