summaryrefslogtreecommitdiffstats
path: root/chrome/browser/memory_details.cc
Commit message (Collapse)AuthorAgeFilesLines
* Revert 120395 - Merge 120387 - Don't try to collect memory details during ↵mad@chromium.org2012-02-031-7/+0
| | | | | | | | | | | | | | | | | | | | | | | shutdown. There seems to be cases where the asynchronous task of collecting memory details is executed during shutdown. This causes an attempt at using the profile object set in the RenderProcessHost after the profile was destroyed. To avoid the crash, we simply interrupt the memory details collection if we identify that we are trying to shutdown. BUG=112383 TEST=Make sure we still properly collect memory details. Review URL: http://codereview.chromium.org/9317058 TBR=mad@chromium.org Review URL: https://chromiumcodereview.appspot.com/9309091 TBR=mad@chromium.org Review URL: https://chromiumcodereview.appspot.com/9310093 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120399 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 120387 - Don't try to collect memory details during shutdown.mad@chromium.org2012-02-031-0/+7
| | | | | | | | | | | | | | | | | | There seems to be cases where the asynchronous task of collecting memory details is executed during shutdown. This causes an attempt at using the profile object set in the RenderProcessHost after the profile was destroyed. To avoid the crash, we simply interrupt the memory details collection if we identify that we are trying to shutdown. BUG=112383 TEST=Make sure we still properly collect memory details. Review URL: http://codereview.chromium.org/9317058 TBR=mad@chromium.org Review URL: https://chromiumcodereview.appspot.com/9309091 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120395 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Content API around BrowserChildProcessHost, similar to what was done ↵jam@chromium.org2012-01-201-5/+7
| | | | | | | | | | | | with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition. I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118415 Review URL: https://chromiumcodereview.appspot.com/9150017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118516 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of SavePackage usage in Chrome. I've moved IsSavableContents onto ↵jam@chromium.org2012-01-201-0/+1
| | | | | | | | | WebContents itself, IsSavableURL to a file in chrome, and made Chrome's DownloadManagerDelegate give SavePackage the file path through a callback. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9254051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118452 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118415 - Add a Content API around BrowserChildProcessHost, similar to ↵jam@chromium.org2012-01-201-7/+5
| | | | | | | | | | | | | what was done with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition. I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9150017 TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118420 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Content API around BrowserChildProcessHost, similar to what was done ↵jam@chromium.org2012-01-201-5/+7
| | | | | | | | | | | with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition. I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9150017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118415 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderViewHostDelegate to content/public and content namespace.joi@chromium.org2012-01-181-3/+3
| | | | | | | | | | TBR=jam@chromium.org BUG=98716 Review URL: http://codereview.chromium.org/9252010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118162 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of unnecessary accessors in BrowserProcessHost that were ↵jam@chromium.org2012-01-131-3/+3
| | | | | | | | | transitional, in preparetion for turning it into an interface. BUG=98716 Review URL: http://codereview.chromium.org/9211004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117690 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the remaining trivial tab_contents.h includes in chrome to use ↵jam@chromium.org2012-01-051-3/+5
| | | | | | | | | web_contents.h BUG=98716 Review URL: http://codereview.chromium.org/9113020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116548 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NavigationController to NavigationControllerImpl and put it into the ↵jam@chromium.org2011-12-281-2/+3
| | | | | | | | | | content namespace. Also make all users of content::NavigationController interface use the "using" keyword so they don't have to put content:: everywhere (similar to other Content API and WebKit API classes). BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8956059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115916 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the remaining usages of NavigationEntry in chrome by converting a few ↵jam@chromium.org2011-12-281-3/+3
| | | | | | | | | | more NavigationController methods to return the interface. In a followup, I'll rename NavigationEntry to NavigationEntryImpl, then create an interface for NavigationController. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9004045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115900 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a few methods in NavigationController to return a ↵jam@chromium.org2011-12-281-1/+1
| | | | | | | | | | content::NavigationEntry, in preparation for creating an interface around NavigationController. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9008034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115872 0039d316-1c4b-4281-b951-d872f2087c98
* Create a Content API around NavigationEntry that's in ↵jam@chromium.org2011-12-251-2/+2
| | | | | | | | | | content/public/browser. NavigationEntry will be renamed to NavigationEntryImpl in a later change. It now derives from content::NavigationEntry. Most of this change is changing unix_hacker functions to CamelCase and updating callers. BUG=98716 TBR=brettw Review URL: http://codereview.chromium.org/9007043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115766 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115346. The change didn't break anything, the test was faulty. Will ↵jam@chromium.org2011-12-211-2/+2
| | | | | | | | | | | | | | | | | | | | disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_teststhakis@chromium.org2011-12-211-2/+2
| | | | | | | | | | | | | | | | on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::controller() to GetController and put it into the ↵jam@chromium.org2011-12-211-2/+2
| | | | | | | | | | WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
* Move/replace/rename URL-based extension getters from ExtensionService to/in ↵yoz@chromium.org2011-12-131-1/+1
| | | | | | | | | | | | | | | | ExtensionSet. ExtensionService::GetExtensionByURL -> GetByID with the host ExtensionService::GetExtensionByWebExtent -> GetHostedAppByURL GetByURL -> GetExtensionOrAppByURL BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8827013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114148 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetProcessTypeNameInEnglish beside the ProcessType enum where it ↵jam@chromium.org2011-12-011-2/+2
| | | | | | | | | belongs. This also helps reduce the dependencies on child_process_info.h from chrome, in preparation for removing the class altogether. BUG=98716 Review URL: http://codereview.chromium.org/8757014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112408 0039d316-1c4b-4281-b951-d872f2087c98
* Move view_types.h to view_type.h, since that's the standard name for enums.jam@chromium.org2011-12-011-1/+1
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/8760012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112365 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ProcessType enum out to its own file. This is in preparation for ↵jam@chromium.org2011-12-011-18/+19
| | | | | | | | | getting rid of ChildProcessInfo. BUG=98716 Review URL: http://codereview.chromium.org/8760011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112353 0039d316-1c4b-4281-b951-d872f2087c98
* Move the RendererProcessType enum out of ChildProcessInfo. It's actually ↵jam@chromium.org2011-11-291-17/+55
| | | | | | | | | never set on that object, and is only used/set by chrome, so moved it out to memory_details.h:ProcessMemoryInformation. BUG=98716 Review URL: http://codereview.chromium.org/8726022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111957 0039d316-1c4b-4281-b951-d872f2087c98
* Define the public interface for content browser RenderProcessHost. This ↵ananta@chromium.org2011-11-181-10/+12
| | | | | | | | | | | | | | | interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes. The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h. Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now. Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL. BUG=98716 TEST=No change in functionality. Hopefully it all compiles and works. Review URL: http://codereview.chromium.org/8515027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
* Extract a ProcessMap class from ExtensionProcessManager. This is a dumb data ↵aa@chromium.org2011-11-091-7/+18
| | | | | | | | | | | class that can be used on both the IO and UI threads to test extension/process associations. BUG=95111,102617 TEST=Already covered by tests Review URL: http://codereview.chromium.org/8387061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109194 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-021-0/+2
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-281-3/+3
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Cleanup chrome/browser/memory_*.jhawkins@chromium.org2011-10-211-2/+3
| | | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8366018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106743 0039d316-1c4b-4281-b951-d872f2087c98
* Move view_types to content\public\common. Also update the enum values to ↵jam@chromium.org2011-10-121-5/+5
| | | | | | | | | match the convention that we're using for the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8232024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105083 0039d316-1c4b-4281-b951-d872f2087c98
* Move BindingsPolicy enum to content\public\common and put it in the content ↵jam@chromium.org2011-10-111-2/+2
| | | | | | | | | namespace. I've also renamed the value names to match the style that we use in the WebKit API (i.e. all values in an enum start with the enum's name) since it's more readable. As we move other enums to public we should switch them over as well. BUG=98716 Review URL: http://codereview.chromium.org/8220024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104917 0039d316-1c4b-4281-b951-d872f2087c98
* Split ViewType between chrome and contentjochen@chromium.org2011-10-061-5/+6
| | | | | | | | | BUG=89642 TEST=still works Review URL: http://codereview.chromium.org/8135026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104253 0039d316-1c4b-4281-b951-d872f2087c98
* Remove RenderProcessHost::is_extension_processjochen@chromium.org2011-10-051-1/+2
| | | | | | | | | | | | Also move the --process=extension command line flag to --extension-process BUG=89642 TEST=everything still works Review URL: http://codereview.chromium.org/8113035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104173 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of BindingsPolicy::EXTENSIONjochen@chromium.org2011-10-011-1/+5
| | | | | | | | | | BUG=89642 TEST=everything still works Review URL: http://codereview.chromium.org/8052032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103654 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove wstrings from ChildProcessInfoevan@chromium.org2011-08-051-1/+1
| | | | | | | | | Convert MetricsServices' child_process_stats_buffer_ while I'm at it. Review URL: http://codereview.chromium.org/7583016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95680 0039d316-1c4b-4281-b951-d872f2087c98
* Add memory usage info to SyslogsProvider, and clean up bug report screenshot ↵stevenjb@google.com2011-08-031-1/+2
| | | | | | | | | | | data. BUG=chromium-os:18418 TEST=Ensure bug reporting and screenshots work, system info is only provided when option is checked, and system info includes "mem_usage" entry. Review URL: http://codereview.chromium.org/7562001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95327 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA stats for Pepper plugin memory usejamescook@chromium.org2011-08-011-0/+8
| | | | | | | | | | | We currently track plugin memory via Memory.Plugin but that doesn't count Pepper plugins. Since Flash on CrOS runs under Pepper, we need to track this. BUG=chromium-os:18435 TEST=manual, on CrOS open a YouTube page to force Flash to load, then open about:memory to force the stats to be collected, then look at about:histograms and search for Memory.PepperPlugin and Memory.PepperPluginProcessCount. Review URL: http://codereview.chromium.org/7488061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94976 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 2.avi@chromium.org2011-07-271-1/+2
| | | | | | | | | | | BUG=76788 TEST=no change visible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94332 Review URL: http://codereview.chromium.org/7480028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94347 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 94332 - Removal of Profile from content part 2.sergeyu@chromium.org2011-07-271-2/+1
| | | | | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7480028 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/7492051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94335 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of Profile from content part 2.avi@chromium.org2011-07-271-1/+2
| | | | | | | | | BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7480028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94332 0039d316-1c4b-4281-b951-d872f2087c98
* Nix kAboutSyncInternalsURL.msw@chromium.org2011-07-121-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nix kAboutSyncURL. Nix kAboutShorthangURL. Nix kAboutNetInternalsURL. Nix kAboutIPCURL. Nix kAboutHistogramsURL. Nix kAboutHangURL. Nix kAboutGpuHangURL. Nix kAboutGpuCleanURL. Nix kAboutGpuURL. Nix kAboutFlashURL. Nix kAboutFlagsURL. Nix kAboutDNSURL. Nix kAboutCreditsURL. Nix kAboutKillURL. Nix kAboutConflicts. Nix kAboutBrowserCrash. Nix kAboutCacheURL. Nix kAboutAppCacheInternalsURL. Nix kAboutAboutURL. Replace kAboutMemoryURL with kChromeUIMemoryURL. Replace kAboutTermsURL with kChromeUITermsURL. Replace kAboutGpuCrashURL with kChromeUIGpuCrashURL. Unify kChromeUITaskManager* and kChromeUITasks*. Added TODO: Resolve chrome_frame dependency on kAboutPluginsURL & kAboutVersionURL. BUG=55771 TEST=Touched about:foo URLs still work. Review URL: http://codereview.chromium.org/7310020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92109 0039d316-1c4b-4281-b951-d872f2087c98
* Replace many OS_LINUX ifdefs with OS_POSIX & !OS_MACOSX, since most of them ↵chromium@hybridsource.org2011-05-281-3/+3
| | | | | | | | apply to non-linux Unix also. Non-linux Unices tested are the BSDs and Solaris. Review URL: http://codereview.chromium.org/3556009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87156 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r84928: Move EFD to ExtensionTabHelper.aa@chromium.org2011-05-131-2/+2
| | | | | | | BUG=80308 TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Re-land r84928: Move ExtensionFunctionDispatcher to"aa@chromium.org2011-05-121-2/+2
| | | | | | | | | | Breaks installation on webstore. This reverts commit 73ad030f2c57a444b81351b2a1cd8546a6dbddc8. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85084 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r84928: Move ExtensionFunctionDispatcher toaa@chromium.org2011-05-111-2/+2
| | | | | | | | | | ExtensionTabHelper. This reverts commit 89a6b9d9232949a01b8263779fa819ed4d5b3089. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85076 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Looks like this introduced leaks in sync ui tests. Sigh.""aa@chromium.org2011-05-111-2/+2
| | | | | | | | This reverts commit cb8e078c2e7bebf0604871ec0bda69ceac3734d2. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85058 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Looks like this introduced leaks in sync ui tests. Sigh."aa@chromium.org2011-05-111-2/+2
| | | | | | | | This reverts commit 471e46f5060ce0fd9413b0bc5ffbe78a2e4c7d02. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85032 0039d316-1c4b-4281-b951-d872f2087c98
* Looks like this introduced leaks in sync ui tests. Sigh.aa@chromium.org2011-05-111-2/+2
| | | | | | | | | | | | | | | | | | Revert "Move ExtensionFunctionDispatcher to ExtensionTabHelper. This" This reverts commit 4f08bad13a0cb2e40835869a9a7d9edb16a5be9a. Revert "Fix clang warning." This reverts commit 1663f72a9360677aad91a9417b44afd03a41181f. Revert "Fix chrome os" This reverts commit 1abb1afe1b78de4bc92a82fdd1e266166bc74707. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84941 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionFunctionDispatcher to ExtensionTabHelper. Thisaa@chromium.org2011-05-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | sets the stage for us to expose certain extension functions to content scripts and normal web pages. This required two major structural changes: 1. Made EFD stateless, except for the pointer to its delegate. This is important to gracefully handle the case of a RVH navigating between different extensions or even to normal web content. Especially in the case of TabContents, where the entire RVH can be torn down and replaced during navigation. 2. Centralize all per-(extension, RVH) setup in ChromeContentBrowserClient::RenderViewCreated(). In particular, responsibility for enabling extension bindings was very spread out before, making it hard to follow when exactly they were enabled. BUG=80308 Review URL: http://codereview.chromium.org/6927076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84928 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last Chrome dependencies from renderer, and enforce no more ↵jam@chromium.org2011-04-181-1/+1
| | | | | | | | includes through DEPS. I also added DEPS checking for gpu/plugin/worker directories as well. I moved the Chrome specific browser tests to the chrome directory, and removed render_widget_unittest since it didn't seem to be testing much (there are tests that test it much more fully). I had to move bindings_policy.h, which ideally would be split into separate pieces so that the content layer only has to know about the content bindings. Given that it's basically an enum, I moved the whole file now since it's used in a lot of places, and the value of turning on DEPS checking is really high. Review URL: http://codereview.chromium.org/6874038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81924 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized constructors and reverse NULL checks found by Coveritystuartmorgan@chromium.org2011-03-111-3/+2
| | | | | | | | | | CID=15466,14666,14747,14334,13593,13507,7591 BUG=None TEST=None Review URL: http://codereview.chromium.org/6674007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77739 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temporary headers left behind in chrome\browser. I've left ↵jam@chromium.org2011-03-011-9/+9
| | | | | | | | | browser_thread.h for another change, since 450 files include it. TBR=avi Review URL: http://codereview.chromium.org/6596060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76326 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Get rid of more references to dom_ui and DOM_UI.tfarina@chromium.org2011-02-151-1/+1
| | | | | | | | | | | | | They were found with: $ git gs dom_ui_ $ git gs ::DOM_UI BUG=59945 TEST=trybots Review URL: http://codereview.chromium.org/6520019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74884 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 01:41:23 +0000