summaryrefslogtreecommitdiffstats
path: root/chrome/browser/metrics
Commit message (Collapse)AuthorAgeFilesLines
* Revert 77398 - Remove unused memory usage collection in ↵sail@chromium.org2011-04-192-8/+38
| | | | | | | | | MetricsServiceMetricsService was calling MemoryDetails::StartFetch but wasn't using the result so I'm removing the call entirely.BUG=43207TEST=None TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6880038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82121 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code from MetricsServicestuartmorgan@chromium.org2011-04-152-222/+7
| | | | | | | | | | | Per discussion, this code is essentially all unused (the server never sends the node this looks for at the top level), and we don't expect to need it at this point, so take it out. If we do need some of this capability, we can add pieces back as necessary--with tests! BUG=None TEST=Existing MetricsServer tests, but mostly watching for unexpected changes in dashboards. Review URL: http://codereview.chromium.org/6862001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81745 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of libcros layer for system access code.satorux@chromium.org2011-04-151-4/+3
| | | | | | | | | | | | | | - Remove cros/system_library* as we no longer need this libcros layer. - Add SystemAccess class based on SystemLibraryImpl. - Replace popen() with GetAppOutput() in system_access.cc - Change all call sites to use SystemAccess instead of SystemLibrary TEST=confirmed timezone switching worked. also added --vmodule=system_access=1 to /sbin/session_manager_setup.sh to observe that the machine info was obtained properly in /var/log/chrome/chrome* (there wasn't an handy way to test the machine info code). BUG=chromium-os:13351 Review URL: http://codereview.chromium.org/6804006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81705 0039d316-1c4b-4281-b951-d872f2087c98
* Remove another unnecessary MetricsService API method.stuartmorgan@chromium.org2011-04-132-28/+11
| | | | | | | | | | | In practice, "user allows upload" and "reporting is enabled" are the same, and there's no clear conceptual difference, so remove one to make both the API and the implementation simpler. BUG=None TEST=Existing tests. Review URL: http://codereview.chromium.org/6813096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81443 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-061-1/+1
| | | | | | | | | | | | | 1/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6689029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of PrefService::GetMutableDictionary/GetMutableListbattre@chromium.org2011-04-051-18/+19
| | | | | | | | | BUG=77914 TEST=none, trybots remain green Review URL: http://codereview.chromium.org/6792017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80441 0039d316-1c4b-4281-b951-d872f2087c98
* Use lock-free lazy initialization for static histogram referencesjar@chromium.org2011-04-052-1/+2
| | | | | | | | | | | | | | | | Make all histogram macros thread safe, and fast by again using statics to achieve performance. ...at the cost of: Leak all histograms to avoid races at shutdown. Also included leak suppression for valgrind. r=rtenneti BUG=78207 Review URL: http://codereview.chromium.org/6780035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80412 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-285-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity PASS_BY_VALUE fixesdpapad@chromium.org2011-03-242-2/+2
| | | | | | | | | | CID=2660,2611,2584,2582 BUG=none TEST=none Review URL: http://codereview.chromium.org/6736001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79330 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify MetricsService API for shutting downstuartmorgan@chromium.org2011-03-232-8/+9
| | | | | | | | | | | Infer clean shutdown from the fact that shutdown methods are being called, so clients don't have to make two MetricsService shutdown calls at each stage of shutdown. BUG=None TEST=Existing tests Review URL: http://codereview.chromium.org/6712020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79182 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a confusing obsolete comment from MetricsService's headerstuartmorgan@chromium.org2011-03-173-12/+5
| | | | | | | | | | | | | This comment stopped being true almost two and a half years ago (the function doesn't even *have* a return value any more), but was never removed. Also fixes incorrect use of "setup" as a verb, to make the interface more readable. BUG=None TEST=None Review URL: http://codereview.chromium.org/6712011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78616 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining files in chrome\common to content\common.jam@chromium.org2011-03-171-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6672070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
* WATCHDOG thread and thread_watcher class to monitor thertenneti@chromium.org2011-03-173-70/+55
| | | | | | | | | | | | | | | | | | | | responsiveness of browser threads. WATCHDOG thread sends a ping message to watched thread and watched thread responds back with a pong message. Upload the responsiveness of the watched thread (ping time minus pong time) as a histogram. This change list is for readability. The following is the original code review. http://codereview.chromium.org/6392018/ BUG=71378 TEST=thread_watcher_unittest Review URL: http://codereview.chromium.org/6571001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78472 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TreeNode::GetChildCount to TreeNode::child_count. Part 3.tfarina@chromium.org2011-03-101-1/+1
| | | | | | | | | | | | This is part of a serie of patches to make the TreeNode API more closer to style used in the Views Tree API (see views/view.h for reference). BUG=None TEST=existing unit_tests. Review URL: http://codereview.chromium.org/6639015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77592 0039d316-1c4b-4281-b951-d872f2087c98
* Remove gpu_info() from GpuProcessHostUIShim. GPUInfo should be accessed ↵zmo@google.com2011-03-091-5/+5
| | | | | | | | | | | through GpuDataManager, where it won't potentially bring up GPU process. BUG=none TEST=bots green Review URL: http://codereview.chromium.org/6656003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77528 0039d316-1c4b-4281-b951-d872f2087c98
* Move ChildProcessHost and ChildProcessInfo to content.jam@chromium.org2011-03-091-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6612040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77496 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused memory usage collection in MetricsServicesail@chromium.org2011-03-092-38/+8
| | | | | | | | | | MetricsService was calling MemoryDetails::StartFetch but wasn't using the result so I'm removing the call entirely. BUG=43207 TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77398 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-095-10/+10
| | | | | | | | | | | Second part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6639008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77396 0039d316-1c4b-4281-b951-d872f2087c98
* Removing references to off the record in comments and log messages.akalin@chromium.org2011-03-081-1/+1
| | | | | | | | | | | Original patch by vipul.bhasin@gmail.com. BUG=3333 TEST=None Review URL: http://codereview.chromium.org/6625076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
* Add/improve a bunch of commentsjar@chromium.org2011-03-081-1/+1
| | | | | | | | | | | Also remove mention of about:tasks in release build, where we don't generate any data for that about page. R=eroman Review URL: http://codereview.chromium.org/6626064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77323 0039d316-1c4b-4281-b951-d872f2087c98
* Make GPUInfo a struct, which it should be according to the C++ guidelines. ↵jam@chromium.org2011-03-081-6/+2
| | | | | | | | This makes it easy to write automated serilization code for it. Review URL: http://codereview.chromium.org/6621057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77300 0039d316-1c4b-4281-b951-d872f2087c98
* Wait for just RECEIVED_PONG, which verifies that we havertenneti@chromium.org2011-03-051-2/+0
| | | | | | | | | | | | SENT_PING and got RECIVED_PONG. BUG=74949 TEST=ThreadWatcherTest (unit tests) on Linux R=jar Review URL: http://codereview.chromium.org/6627014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77053 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for mac_valgrind giving an error on condition variable.rtenneti@chromium.org2011-03-041-11/+17
| | | | | | | | | | | | Wait for ALL_DONE state before exiting the test. BUG=74727 TEST=mac_valgrind R=jar Review URL: http://codereview.chromium.org/6588135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76883 0039d316-1c4b-4281-b951-d872f2087c98
* Start Watching threads only if we are running. Activatertenneti@chromium.org2011-03-042-4/+19
| | | | | | | | | | | | | thread watching only if we have registered the Thread Watcher objects. BUG=74855 TEST=thread watcher, run browser with -uninstall option R=jar Review URL: http://codereview.chromium.org/6611031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76871 0039d316-1c4b-4281-b951-d872f2087c98
* Use FRIEND_TEST_ALL_PREFIXES so that disabling tests does not break the build.phajdan.jr@chromium.org2011-03-031-6/+6
| | | | | | | | | | | | Interestingly, gtest_prod_util were #included... TBR=rtenneti TEST=none BUG=none Review URL: http://codereview.chromium.org/6603014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76735 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ThreadWatcherTest.MultipleThreadsNotResponding, flakily triggers ↵phajdan.jr@chromium.org2011-03-031-1/+2
| | | | | | | | | | | | assertion. TBR=rtenneti BUG=74727 TEST=unit_tests Review URL: http://codereview.chromium.org/6613014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76734 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the revert 76468. Removed include for browser_thread.h.rtenneti@chromium.org2011-03-023-120/+245
| | | | | | | | | | | | | | | | Enable the WATCHDOG thread that monitors browser threads for their responsiveness using ping-pong messaging. WACTHDOG thread also collects statistics for response time for each thread via histograms. This CL was approved http://codereview.chromium.org/6588039 BUG=71378, 73915, 73844, 73975 TEST=performance tests TBR=jar Review URL: http://codereview.chromium.org/6591091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76561 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of includes to old locations of headers.jam@chromium.org2011-03-021-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6602061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76470 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76468 - Added back thread watcher changes.rtenneti@chromium.org2011-03-023-244/+119
| | | | | | | | | | | | BUG=71378,73915,73844,73975 TEST=performance tests Review URL: http://codereview.chromium.org/6588039 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/6597088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76469 0039d316-1c4b-4281-b951-d872f2087c98
* Added back thread watcher changes.rtenneti@chromium.org2011-03-023-119/+244
| | | | | | | | | BUG=71378,73915,73844,73975 TEST=performance tests Review URL: http://codereview.chromium.org/6588039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76468 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of browser_thread.h jam@chromium.org2011-03-012-3/+3
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6591065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76387 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76199 - Trying changes to see the perfomance impact on Mac.rtenneti@chromium.org2011-02-283-189/+115
| | | | | | | | | | | | | This change list is same as CL 6588039. BUG=73915 Review URL: http://codereview.chromium.org/6602004 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/6591035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76200 0039d316-1c4b-4281-b951-d872f2087c98
* Trying changes to see the perfomance impact on Mac.rtenneti@chromium.org2011-02-283-115/+189
| | | | | | | | | | | This change list is same as CL 6588039. Will back out immediately. BUG=73915 Review URL: http://codereview.chromium.org/6602004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76199 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76168 - Trying changes to see the perfomance impact on Mac.rtenneti@chromium.org2011-02-263-72/+43
| | | | | | | | | | | | | | This change list is same as CL 6588039. Will back out immediately. http://codereview.chromium.org/6588039/ Review URL: http://codereview.chromium.org/6594032 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/6588041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76170 0039d316-1c4b-4281-b951-d872f2087c98
* Trying changes to see the perfomance impact on Mac.rtenneti@chromium.org2011-02-263-43/+72
| | | | | | | | | | | This change list is same as CL 6588039. Will back out immediately. http://codereview.chromium.org/6588039/ Review URL: http://codereview.chromium.org/6594032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76168 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76156 - Added back thread watcher changes.rtenneti@chromium.org2011-02-263-73/+43
| | | | | | | | | | | | | | | will revert the changes right away. trying to test impact on memory on mac. BUG=73915 TEST=performance tests Review URL: http://codereview.chromium.org/6598021 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/6598022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76157 0039d316-1c4b-4281-b951-d872f2087c98
* Added back thread watcher changes.rtenneti@chromium.org2011-02-263-43/+73
| | | | | | | | | | | | will revert the changes right away. trying to test impact on memory on mac. BUG=73915 TEST=performance tests Review URL: http://codereview.chromium.org/6598021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76156 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76154 - Revert 76015 - Added back thread watcher changes byrtenneti@chromium.org2011-02-263-73/+43
| | | | | | | | | | | | | | | | | reverting the revert. will revert the changes right away. trying to test impact on memory on mac. BUG=73915 TEST=performance tests Review URL: http://codereview.chromium.org/6594011 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/6588038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76155 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76015 - Added back thread watcher changes byrtenneti@chromium.org2011-02-263-43/+73
| | | | | | | | | | | | | | reverting the revert. will revert the changes right away. trying to test impact on memory on mac. BUG=73915 TEST=performance tests Review URL: http://codereview.chromium.org/6594011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76154 0039d316-1c4b-4281-b951-d872f2087c98
* Abstracted out setting up of Notifications. Commonrtenneti@chromium.org2011-02-262-30/+42
| | | | | | | | | | method will be used by thread watcher. BUG=71378 Review URL: http://codereview.chromium.org/6598015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76148 0039d316-1c4b-4281-b951-d872f2087c98
* Back out thread watcher changes.rtenneti@chromium.org2011-02-255-42/+42
| | | | | | | | | BUG=73915 TEST=performance tests Review URL: http://codereview.chromium.org/6578033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76015 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling Crash Renderers test, it fails always on offical trunk builderskerz@chromium.org2011-02-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6578031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75948 0039d316-1c4b-4281-b951-d872f2087c98
* Thread Hang detector - enable it for Windows only and ifdef'edrtenneti@chromium.org2011-02-241-3/+4
| | | | | | | | | | | out for Mac and Linux. BUG=73915 TEST=performance tests Review URL: http://codereview.chromium.org/6576026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75935 0039d316-1c4b-4281-b951-d872f2087c98
* Stop thread watching on Mac to fix memory usagertenneti@chromium.org2011-02-241-0/+6
| | | | | | | | | | | on mac-release-10.5/intl2. TBR=jar@chromium.org BUG=73915 Review URL: http://codereview.chromium.org/6579030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75853 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the memory leak of callback Task in PostPingMessage.rtenneti@chromium.org2011-02-241-12/+16
| | | | | | | | | | | | If PostTask to watched thread fails, we will stop monitoring that thread. BUG=73915,73844 TEST=performance testing Review URL: http://codereview.chromium.org/6575007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix OOL issues for linux from the last few days.erg@google.com2011-02-232-1/+3
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6575004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75798 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at a WATCHDOG thread that monitors threads for theirrtenneti@chromium.org2011-02-235-30/+1109
| | | | | | | | | | | | | | responsiveness by sending a ping message to them. Watched Threads respond by sending a pong message to WATCHDOG thread. WACTHDOG thread collects statistics for response time. BUG=71378 TEST=browser_thread_unit_test and thread_watcher_unittest. Starting and stopping of browser. Review URL: http://codereview.chromium.org/6392018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75723 0039d316-1c4b-4281-b951-d872f2087c98
* Recreate both GpuProcessHost and GpuProcessHostUIShim when a new GPU process ↵apatrick@chromium.org2011-02-221-6/+9
| | | | | | | | | | | | | | | | | is launched. This is so that a renderer that was previously sending messages to the browser regarding a particular GPU process, it can be informed that a new one has been launched and that it has to start over. This part is not done yet. Both GpuProcessHost and GpuProcessHostUIShim are now identified by a common host ID. Neither are singletons. This is also a step towards allowing multiple GPU processes. TEST=trybots, check WebGL and 3D CSS work, check terminating Chrome works while running WebGL, check --single-process works, checking terminated GPU process is relaunched and that 3D CSS restarts automatically BUG=none Review URL: http://codereview.chromium.org/6473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75645 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of browser_prefs::RegisterAllPrefs()mnissler@chromium.org2011-02-211-13/+14
| | | | | | | | | | | | | | Local state and user prefs have always been separate namespaces. We'd like to have proxy configuration in both, so let's stick to the namespace separation and clean up testing code that incorrectly merged the namespaces. BUG=none TEST=compiles and passes tests Review URL: http://codereview.chromium.org/6542013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75536 0039d316-1c4b-4281-b951-d872f2087c98
* metrics: hash the path bytes directly for plugin filenameevan@chromium.org2011-02-071-2/+7
| | | | | | | | | | | | We use the hash of the plugin filename as a unique identifier for the plugin. On Windows, this new code produces the same hashes as before; on Mac/Linux, it saves extra conversions. BUG=69467 Review URL: http://codereview.chromium.org/6368110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74044 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 12:27:01 +0000