summaryrefslogtreecommitdiffstats
path: root/chrome/browser/metrics
Commit message (Collapse)AuthorAgeFilesLines
* This adds some plumbing for propagating the status and error code of a ↵gspencer@chromium.org2010-12-141-3/+5
| | | | | | | | | | | | | | | | | | | | | renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. BUG=http://crosbug.com/8505 TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/5172009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded browser_thread.h usage.thestig@chromium.org2010-12-131-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5676004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69037 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-131-4/+6
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Sanitize PrefStore interface.mnissler@chromium.org2010-12-091-5/+4
| | | | | | | | | | | | | | | | | This reworks the PrefStore interface, specifically: - Split up the interface into PrefStore, which only provides reading functionality, and the derived PersistentPrefStore for the actual user pref store - Remove the hurt-me-plenty prefs() function from PrefStore, instead provide Get/Set/Remove operations - Remove special handling of default and user pref store from PrefValueStore and put it into PrefService - Pref change notification handling now almost exclusively handled through PrefValueStore - Adjust all consumers of these interfaces (but keep ConfigurationPolicyPrefStore untouched, that's up next on the list) BUG=64232 TEST=existing unit tests Review URL: http://codereview.chromium.org/5646003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68736 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-022-2/+2
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* No-op change to trigger another build.finnur@chromium.org2010-11-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67704 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant (and problematic) default initializaitonjar@chromium.org2010-11-221-1/+0
| | | | | | | | | | | gcc 4.5 had problems with a default initalizer, and it was really not needed anyway, so this removes it. bug=62810 tbr=wtc Review URL: http://codereview.chromium.org/5221003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66961 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup histogram synchronizerjar@chromium.org2010-11-202-171/+188
| | | | | | | | | | | | | | | Some of the assertions in histogram synchronizer, specifying thread-to-run-on, were breaking. We used to use a fancy mix of threads and locks to access the data involving which sequence was pending, and this transitions to clean use of locking only for all members of the class. BUG=62810 r=wtc Review URL: http://codereview.chromium.org/5189002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66861 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaned up thread safety for GpuProcessHost and GpuProcessHostUIShim.apatrick@chromium.org2010-11-171-3/+3
| | | | | | | | | | | | | | | | | Guarded static members with an assertion that they are invoked on the right thread. Guarded non-static members with an assertion that NonThreadSafe::CalledOnValidThread() is true. GpuProcessHost automatically routes unhandled control messages to the UI shim. Moved gpu_info to the UI shim, which is the thread it is accessed on. TEST=webgl, CSS 3D locally, try BUG=none Review URL: http://codereview.chromium.org/5130001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66482 0039d316-1c4b-4281-b951-d872f2087c98
* base: Get rid of 'using' declaration of StringAppendF.tfarina@chromium.org2010-11-151-2/+2
| | | | | | | | | | | Update the callers to append base:: in the calls to StringAppendF. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4974001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66116 0039d316-1c4b-4281-b951-d872f2087c98
* Improve quality of DCHECK for IsOnIoThreadjar@chromium.org2010-11-122-33/+17
| | | | | | | | | | | | | | | | The old system was adaptive, and this new system uses centralized constant to perform the assertion. I also edited several comments, and added a cleaner reset to the state of the *_sequence_number_ after we've serviced all requests (resetting them back to -2, which was what we had after we initialized). BUG=62810 r=nkostylev,davemoore Review URL: http://codereview.chromium.org/4688009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65955 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup histogram syncronizer a bitjar@chromium.org2010-11-022-29/+38
| | | | | | | | | | | | | | | | | | | | | I adjusted the code so tha there was no chance for the pending response count to get to zero until all the increments had been applied, and all the rendereres had been notified. Without this change, there was a chance that the tally would hit zero prematurely, triggering a a premature completion. I went through the code clarifying where a lock was needed, and where it wasn't. In all cases, we now either take a lock, or assert we're consistently on a single thread (meaning we don't need a lock). r=davemoore Review URL: http://codereview.chromium.org/4193008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64781 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-011-1/+1
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of FLAKY_ tests to match current realitystuartmorgan@chromium.org2010-10-281-4/+0
| | | | | | | | | | | Mostly this is removing FLAKY_ where the bug was fixed but the label never removed, but also switches some FLAKY_ to platform-specific FAILS_. BUG=28372,32048,32070,35341,45561,48544,48562,52858 TEST=N/A Review URL: http://codereview.chromium.org/4087009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64264 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Added unit tests for omnibox highlightingscr@chromium.org2010-10-271-0/+1
| | | | | | | | | | BUG=55418 TEST=unit_tests --gtest_filter=AutocompletePopupViewGtkTest.\* should run tests on GTK but not Windows or Mac. Review URL: http://codereview.chromium.org/4082002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64169 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race condition in histogram renderingdavemoore@chromium.org2010-10-272-12/+12
| | | | | | | | | | | BUG=None TEST=None - There was a race where if the first host responded too quickly we would fail to count it. This is fixed by incrementing the count of hosts before sending the message. I also allow the number of pending hosts to fall below 0. In addition I lock during the increment (which wasn't being done). Plus I fixed some spelling errors. Review URL: http://codereview.chromium.org/4121007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64106 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - misc. chrome/browser/*/*.pkasting@chromium.org2010-10-211-17/+17
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4009001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63420 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63067 - This adds some plumbing for propagating the status and error ↵gspencer@chromium.org2010-10-191-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | code of a renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added some new enum values to TerminationStatus enum (and named it) in process_util.h, so it can be used as the status returned by WhatHappenedToProcess. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. [This change was previously reviewed and LGTM'd: http://codereview.chromium.org/3386014/show but due to issues with "git cl push" was never committed to the tree.] BUG=none TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/3869001 TBR=gspencer@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63074 0039d316-1c4b-4281-b951-d872f2087c98
* This adds some plumbing for propagating the status and error code of agspencer@chromium.org2010-10-191-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added some new enum values to TerminationStatus enum (and named it) in process_util.h, so it can be used as the status returned by WhatHappenedToProcess. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. [This change was previously reviewed and LGTM'd: http://codereview.chromium.org/3386014/show but due to issues with "git cl push" was never committed to the tree.] BUG=none TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/3869001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63067 0039d316-1c4b-4281-b951-d872f2087c98
* o Update the mapping of action hashes to their appropriate identifiers.andybons@chromium.org2010-10-181-2/+6
| | | | | | | | | | | | o Update user_metrics.h to be more explicit about how to add metrics. o Update the some BookmarkBar metrics to fit on one line as is required by the script. BUG=59606 TEST=none Review URL: http://codereview.chromium.org/3815011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62982 0039d316-1c4b-4281-b951-d872f2087c98
* Moving GUID generation from base to chrome/browser/guid*dhollowa@chromium.org2010-10-141-2/+2
| | | | | | | | | | | Moves GUID generation into chrome/browser/guid*. GUID generation is used only within chrome/browser. So am moving it there. BUG=58813 TEST=GUIDTest.GUIDGeneratesAllZeroes, GUIDTest.GUIDGeneratesCorrectly, GUIDTest.GUIDCorrectlyFormatted, MetricsServiceTest.ClientIdCorrectlyFormatted Review URL: http://codereview.chromium.org/3800003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62639 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-142-3/+3
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring GUID generation from metrics to basedhollowa@chromium.org2010-10-133-62/+7
| | | | | | | | | | | Factors GUID generation into base/rand_util. The Autofill feature is in need of this utility so am factoring GUID generation out of metrics and moving to the commons. BUG=58813 TEST=RandUtilTest.GUIDGeneratesAllZeroes, RandUtilTest.GUIDGeneratesCorrectly, RandUtilTest.GUIDCorrectlyFormatted, MetricsServiceTest.ClientIdCorrectlyFormatted Review URL: http://codereview.chromium.org/3800001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62480 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part21:tfarina@chromium.org2010-10-122-2/+2
| | | | | | | | | | | - Include browser_thread.h instead of chrome_thread.h in more 100 files. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3691006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62286 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part13:tfarina@chromium.org2010-10-101-4/+4
| | | | | | | | | | | | | - Rename entries under appcache, automation, chromeos, cocoa, file_system, metrics, policy, prefs, remoting, search_engines and tab_contents. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3660002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62120 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move virtual methods to implementation files.erg@google.com2010-09-232-3/+5
| | | | | | | | | | | Remove logging.h and other headers where possible. BUG=none TEST=none Review URL: http://codereview.chromium.org/3461019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
* Add a pointer to chrome/tools/extract_actions.py in user_metrics.h.satorux@chromium.org2010-09-141-1/+2
| | | | | | | | | | | | | Having the pointer would be useful for those who want to use RecordComputedAction(). For instance, I spent some to find out the script. BUG=none TEST=compiled. Review URL: http://codereview.chromium.org/3364020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59331 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the expected number of crashes in a metrics test.nirnimesh@chromium.org2010-09-071-3/+4
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/3295015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58728 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58663 - Revert 58641 - Add user metrics for nonsandboxed plugin infobar.nsylvain@chromium.org2010-09-071-3/+2
| | | | | | | | | | | | | | | BUG=52341 TEST=none Review URL: http://codereview.chromium.org/3303003 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/3300015 TBR=mal@chromium.org Review URL: http://codereview.chromium.org/3303011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58666 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58641 - Add user metrics for nonsandboxed plugin infobar.mal@chromium.org2010-09-071-2/+3
| | | | | | | | | | | | BUG=52341 TEST=none Review URL: http://codereview.chromium.org/3303003 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/3300015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58663 0039d316-1c4b-4281-b951-d872f2087c98
* Add user metrics for nonsandboxed plugin infobar.bauerb@chromium.org2010-09-061-3/+2
| | | | | | | | | BUG=52341 TEST=none Review URL: http://codereview.chromium.org/3303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58641 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the wstring TreeModelNode::GetTitle() and rename GetTitleAsString16() ↵viettrungluu@chromium.org2010-08-301-0/+1
| | | | | | | | | | | to GetTitle(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57834 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor version-getting info into a chrome::VersionInfo object.evan@chromium.org2010-08-271-13/+10
| | | | | | | | | | | | | | | I was trying to replace wstring usage in base::FileVersionInfo, but that class is rather Windows-specific with strange fields like "private_build()" where the value and encoding aren't clear. 95% of the users of FileVersionInfo actually just care about the current Chrome version, so we can provide a much simpler interface for them. We still use FileVersionInfo for retrieving information from e.g. plugin DLLs, but in those cases the usage is clearer. Review URL: http://codereview.chromium.org/3135028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-263-4/+4
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Header cleanup in chrome/common part 2. The majority of the changed filesjhawkins@chromium.org2010-08-201-0/+1
| | | | | | | | | | | just added notification_observer.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/3120021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56824 0039d316-1c4b-4281-b951-d872f2087c98
* * Add rmdir, mkdir -p and umask to d8 on Unix.evan@chromium.org2010-08-171-2/+2
| | | | | | | | | | | | | * Remove the non-working methods from the os object on d8 on Windows so you can test for their presence with if (os.system). * Add a test (not run by default since it only works on d8). * Fix incorrect use of wait that left defunct processes (zombies). Committed: http://code.google.com/p/v8/source/detail?r=1650 Review URL: http://codereview.chromium.org/56107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56276 0039d316-1c4b-4281-b951-d872f2087c98
* Make prefs use std::string for keys rather than wstrings.viettrungluu@chromium.org2010-08-113-18/+21
| | | | | | | | | | | Much remains to be converted. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3076037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55660 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetMachineStatistic to SystemLibrary.stevenjb@chromium.org2010-08-092-28/+5
| | | | | | | | | | | BUG=chromeos:3949 (http://code.google.com/p/chromium-os/issues/detail?id=3949) TEST=Run a version of chrome with the corresponding changes. Ensure that reporting is enabled. Check that the report "hardware_class" value is valid. See also: http://codereview.chromium.org/3067003/show Review URL: http://codereview.chromium.org/3069002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55471 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 5)thestig@chromium.org2010-08-071-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3041049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55349 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 4)thestig@chromium.org2010-08-071-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 1)thestig@chromium.org2010-08-051-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3071012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
* Convert DictionaryValue's keys to std::string (from wstring).viettrungluu@chromium.org2010-07-302-9/+9
| | | | | | | | | | | | Everything now needs to be changed to avoid the deprecated wstring methods; this includes the unit tests. BUG=23581 TEST=all our tests still pass Review URL: http://codereview.chromium.org/3075010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54359 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-1/+2
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-266-0/+6
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Use FRIEND_TEST_ALL_PREFIXES some more.phajdan.jr@chromium.org2010-07-261-7/+7
| | | | | | | | | TEST=compile BUG=44549 Review URL: http://codereview.chromium.org/3032025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53706 0039d316-1c4b-4281-b951-d872f2087c98
* LogStoreStatus histogram modification.ziadh@chromium.org2010-07-242-1/+3
| | | | | | | | | Added a STORE_SUCCESS element to the LogStoreSatus histogram in order to keep track of the number of time the preferences files was successfully written to disk. r=jar Review URL: http://codereview.chromium.org/3026023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53563 0039d316-1c4b-4281-b951-d872f2087c98
* Change to (quieter) NOTREACHED() rather than (noisy) LOG(DFATAL)jar@chromium.org2010-07-221-9/+9
| | | | | | | | bug=46576 r=thestig Review URL: http://codereview.chromium.org/2884033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53402 0039d316-1c4b-4281-b951-d872f2087c98
* Start trimming headers included in the slowest to compile files.erg@google.com2010-07-214-40/+45
| | | | | | | | | | | Big chunk in the automation code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3056007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53246 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Break another common->app dependency.thestig@chromium.org2010-07-201-4/+7
| | | | | | | | BUG=46666 TEST=none Review URL: http://codereview.chromium.org/3007008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53113 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 19:14:47 +0000