| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7482017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17897
TEST=Crash is gone on Chrome OS.
Review URL: http://codereview.chromium.org/7465020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it private and establish a friend whitelist for existing users.
BUG=64339
TEST=none
Review URL: http://codereview.chromium.org/7438002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=89274
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7395021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
watched browser thread.
Store away thread_id using Debug::Alias so that optimizer doesn't
optimize away the code so that we can see the thread_id that is
hung from the crash dumps in windbg.
Stop the WatchDog thread before stopping other threads to see if
it fixes the racy condition duriong shutdown.
BUG=83564, 86818, 89141, 83343, 83430
TEST=ThreadWatcher unit tests
R=jar
Review URL: http://codereview.chromium.org/7218030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73195
TEST=none
Review URL: http://codereview.chromium.org/7342024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with a minor change to that code since libcros also uses base/values.h.
BUG=88666
TEST=none
Review URL: http://codereview.chromium.org/7259019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_notification_types.h.
This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END
which defines the end of the enum used by content to define notification types. The notificaton_type.h file
in content\common has been renamed to content_notification_types.h
BUG=76698
Review URL: http://codereview.chromium.org/7327007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyslogsProvider.
SystemAccess contained three separate things: timezone settings,
statistics provider, and syslogs provider. We should have them
in separate classes.
This patch touches many files but changes are mechanical. No logic
changes introduced.
BUG=none
TEST=chrome builds and try bots pass
Review URL: http://codereview.chromium.org/7324017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to fix the crash because CoInitialize() call failed.
BUG=85589
TEST=thread_watcher unit tests
R=willchan
Review URL: http://codereview.chromium.org/7301009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents a pending log from being duplicated if it is pending during shutdown (because of the code that saves the currently pending log to the unsent list). Since the write of the trimmed list back to the prefs system is still only done post-upload, it won't be lost during a crash.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7248048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7243011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And check if a node is not an url by using is_folder() method.
Unrelated change:
- Move the friend declaration of BookmarkModel to private section below.
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7260004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and"crash-on-hang-seconds" for crashing the browser whenthreads specified in "crash-on-hang-threads" don't respondfor "crash-on-hang-seconds".TEST=thread watcher unit testsBUG=85282R=jar
Review URL: http://codereview.chromium.org/7134007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves GetPrimaryDisplayDimensions() and DisplayCount()
out of base and into a new DisplayUtils class (currently
alongside the metrics code, since that's the only place that
they're called). These methods add a GDK dependency that
prevents Chrome OS from including process_util (which
depends on SysInfo) in its libchrome library.
BUG=chromium-os:16153
TEST=moved existing unit tests
Review URL: http://codereview.chromium.org/7128001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
connectivity from the browser (first cut). Collect
stats for TCP connectivity also.
- What percentage of users can get a message end-to-end
to an TCP and UDP server.
- What is the latency for TCP and UDP messages.
Added TCP and UDP echo servers to testserver.py
for unittests.
BUG=82565
TEST=udp tests
Review URL: http://codereview.chromium.org/7056031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to go through the newly made ProfileKeyedServiceFactory subclass.
In addition, makes further modifications to the unit testing stuff because the TemplateURL tests change the active TemplateURLService on a profile during the test.
BUG=77155
TEST=unit tests
R=mirandac
Review URL: http://codereview.chromium.org/7056056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome code, but turns out there are legitimate content uses for HTML5 features like speech/geolocation which need to go to the web.
BUG=76697
Review URL: http://codereview.chromium.org/7006005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3 to 6, unresponsive count from 3 to 6.
Changed how often we send a ping from 2 secs to 1 sec. Changed check
for unresponsiveness time from 4 secs to 2 secs.
From jar: this change is to make it harder for scheduler to
a) grant time slices coursely; and
b) favor the watchdog and disfavor the IO thread.
BUG=84145
TEST=thread watcher unit tests
TBR=jar
Original approved CL is http://codereview.chromium.org/6962033/
Review URL: http://codereview.chromium.org/7076042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to 6.
Changed how often we send a ping from 2 secs to 1 sec. Changed check
for unresponsiveness time from 4 secs to 2 secs.
From jar: this change is to make it harder for scheduler to
a) grant time slices coursely; and
b) favor the watchdog and disfavor the IO thread.
BUG=84145
TEST=thread watcher unit tests
R=jar
Review URL: http://codereview.chromium.org/6962033
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/6962036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed how often we send a ping from 2 secs to 1 sec. Changed check
for unresponsiveness time from 4 secs to 2 secs.
From jar: this change is to make it harder for scheduler to
a) grant time slices coursely; and
b) favor the watchdog and disfavor the IO thread.
BUG=84145
TEST=thread watcher unit tests
R=jar
Review URL: http://codereview.chromium.org/6962033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is always called with the same argument, and all the other helpers are member-based rather than param-based, so StopRecording should just use pending_log_directly.
BUG=None
TEST=Metrics continue to work.
Review URL: http://codereview.chromium.org/7077017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=MetricsServiceTest.CloseRenderersNormally passes on touchui
Review URL: http://codereview.chromium.org/6987032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
string_util.h is recursively included by one of the other includes in this file,
which is why we don't get a compile error, but it's best to always include what
you use.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7065044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
3 times for the ping message and if only one other threads
has responded for a ping message.
BUG=82336
TEST=thread watcher unit tests
R=jar
Review URL: http://codereview.chromium.org/6990061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7066036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=still builds
Review URL: http://codereview.chromium.org/6966037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collect stats when a thread hasn't responded 3 times
(12 secs) and all other threads were also not responding
for 3 ping messages (120 secs).
Because we are collecting new stats, disabled crashing
of browser.
BUG=82336
TEST=thread watcher unit tests
R=jar
Review URL: http://codereview.chromium.org/7040011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6969070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3 times for the ping message and if only one other thread
is responding.
Collect stats when it is the first time we have detected
that the watched thread has not responded atleast 3 times
(that is when we haven't done any thread hang processing).
BUG=82336
TEST=thread watcher unit tests
R=jar
Review URL: http://codereview.chromium.org/7030020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't get response atleast 3 times.
BUG=82336
TEST=thread watcher unit tests
R=jar
Review URL: http://codereview.chromium.org/6969049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=82098
TEST=none
R=thakis@chromium.org
Review URL: http://codereview.chromium.org/7004007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disable field trials. I am going to have a need for both soon.
Update some documentation about empty trial names, add TrialExists() method and update many call-sites to use this (it simplifies the previous logic which checked for existence and then for non-empty name, which can no longer happen).
Refactor a bit in browser_main.
While I'm in there and needing base/OWNERS approval, add an OWNERS
file for base/metrics that adds jar@chromium.org as an owner for that
directory.
Initially committed as r84197.
Rolled back due to DCHECK in official builds, r84373.
Will re-submit with fix.
BUG=81750
TEST=base_unittests
Review URL: http://codereview.chromium.org/6883102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also added an OWNERS file with myself and kbr.
TEST=build locally, try
BUG=none
Review URL: http://codereview.chromium.org/6931017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=81612
TEST=None
R=wtc@chromium.org,willchan@chromium.org
Review URL: http://codereview.chromium.org/6932025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ability to
disable field trials. I am going to have a need for both soon.
Cleaning up some comments about empty trial names, adding static
method TrialExists() and simplifying many call sites by using this
method.
While I'm in there and needing base/OWNERS approval, add an OWNERS
file for base/metrics that adds jar@chromium.org as an owner for that
directory.
BUG=none
TEST=base_unittests
TBR=jam@chromium.org
R=jar@chromium.org,phajdan.jr@chromium.org,mark@chromium.org,wtc@chromium.org
Reason for revert: See http://crbug.com/81750
BUG=81750
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/6931048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disable field trials. I am going to have a need for both soon.
Cleaning up some comments about empty trial names, adding static
method TrialExists() and simplifying many call sites by using this
method.
While I'm in there and needing base/OWNERS approval, add an OWNERS
file for base/metrics that adds jar@chromium.org as an owner for that
directory.
BUG=none
TEST=base_unittests
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that is set
once, the first time it is necessary to decide if there is an experiment by a given
name active.
With this change the field-test system can "push" a group that is selected for
the given field trial (field test) if/when an experiment does arrive.
This change implements a simple IPC notification of the result of a FieldTrial
setting being sent to any previously started renderers.
BUG=16494
TEST=field trial tests
R=jar
Review URL: http://codereview.chromium.org/6883029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
record how many other threads are responding and how many
are not responding. This is to get more data before we crash
the browser when we detect threads are not responding (which
could help us to detect the dead locks or hung threads.
BUG=80751
Test=thread watcher unit tests
R=jar
Review URL: http://codereview.chromium.org/6905084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just the class that provides the action logging API which is used all over the place
is being moved. The UserMetrics class uses the notification system to inform the core
of the user metrics system of each event, that core part is not being moved.
Also take care of a TODO to remove the class methods that take a Profile*
as a paramter (since Profile is verbotten in /content).
BUG=78499
Review URL: http://codereview.chromium.org/6883021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
grit (which would have caused a circular dependency in gyp).
Review URL: http://codereview.chromium.org/6903026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not responding but all other watched threads are responding.
Each watched thread maintains unresponsive_count_ which is
set to zero when watched thread has responded with a pong
message. It is incremented by 1 whenever OnCheckResponsiveness
determines that the watched thread is not responding.
When unresponsive_count_ goes over kUnresponsiveCount, WatchDog
thread checks if all other threads are responding or not. If the
watched thread is the only thread that hasn't been responding and
all other threads are responding, then it records in histgorams
unresponsive_count_ for the watched thread.
WatchDog asks ThreadWatcherList (which has a list of all watched
threads) to see if all watched threads are responding or not.
BUG=79511
TEST=thread watcher unit tests
R=jar
Review URL: http://codereview.chromium.org/6857006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic for when to upload is now separate from the core of MetricsService. For now the object is internally constructed so that the MetricsService interface doesn't change, but it could easily be pulled out later if we need DI-style construction.
Fixes a bug where backoff for server errors would be bypassed if the logs were large.
Also removes a bit of dead code I missed when removing the server response parsing in the last CL.
BUG=None
TEST=Metrics continue to show up on the dashboards unchanged.
Review URL: http://codereview.chromium.org/6869034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
MetricsServiceMetricsService was calling MemoryDetails::StartFetch but wasn't using the result so I'm removing the call entirely.BUG=43207TEST=None
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6880038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Per discussion, this code is essentially all unused (the server never sends the node this looks for at the top level), and we don't expect to need it at this point, so take it out. If we do need some of this capability, we can add pieces back as necessary--with tests!
BUG=None
TEST=Existing MetricsServer tests, but mostly watching for unexpected changes in dashboards.
Review URL: http://codereview.chromium.org/6862001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove cros/system_library* as we no longer need this libcros layer.
- Add SystemAccess class based on SystemLibraryImpl.
- Replace popen() with GetAppOutput() in system_access.cc
- Change all call sites to use SystemAccess instead of SystemLibrary
TEST=confirmed timezone switching worked. also added --vmodule=system_access=1 to /sbin/session_manager_setup.sh to observe that the machine info was obtained properly in /var/log/chrome/chrome* (there wasn't an handy way to test the machine info code).
BUG=chromium-os:13351
Review URL: http://codereview.chromium.org/6804006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In practice, "user allows upload" and "reporting is enabled" are the same, and there's no clear conceptual difference, so remove one to make both the API and the implementation simpler.
BUG=None
TEST=Existing tests.
Review URL: http://codereview.chromium.org/6813096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1/3.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6689029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77914
TEST=none, trybots remain green
Review URL: http://codereview.chromium.org/6792017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make all histogram macros thread safe, and fast by again
using statics to achieve performance.
...at the cost of:
Leak all histograms to avoid races at shutdown.
Also included leak suppression for valgrind.
r=rtenneti
BUG=78207
Review URL: http://codereview.chromium.org/6780035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80412 0039d316-1c4b-4281-b951-d872f2087c98
|