summaryrefslogtreecommitdiffstats
path: root/chrome/browser/metrics
Commit message (Collapse)AuthorAgeFilesLines
* Mark the following tests FLAKY on Windows.tkent@chromium.org2010-01-121-0/+4
| | | | | | | | | | | | | | - NPAPITester.NoHangIfInitCrashes - MetricsServiceTest.CrashRenderers - ResourceDispatcherTest.CrossSiteAfterCrash - RendererCrashTest.Crash BUG=32048 TEST=none TBR=jar, nsylvain Review URL: http://codereview.chromium.org/548009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36004 0039d316-1c4b-4281-b951-d872f2087c98
* Add buildtime to UMA upload datajar@chromium.org2010-01-062-14/+54
| | | | | | | r=tigerf Review URL: http://codereview.chromium.org/519017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35629 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup histogram classes mixing SetFlags into FactoryGet argumentsjar@chromium.org2009-12-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Generic cleanup of histogram class, renaming *FactoryGet to FactoryGet, along with reformatting. The macros were cleaned up to use common sub-macros rather than repeating code as much. Removed ThreadSafeHistogram (and associated ASSET_HISTOGRAM macros) since this class was not getting used. I introduced UMA_HISTOGRAM_ENUMERATION to support the common use of LinearHistograms to count various enumerated values. I added a Flags argument to all the FactoryGet routines to help avoid needing to call SetFlags each time a new sample is Add()ed. This also simplifies the code. This will all help prepare for a "don't histogram at all" macro setting so that I can test the impact of the histogram macro calls on performance (since there are now so many active histograms). BUG=31206 r=raman.tenneti Review URL: http://codereview.chromium.org/515033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35295 0039d316-1c4b-4281-b951-d872f2087c98
* Enable UMA data upload in ChromeFramejar@chromium.org2009-12-232-3/+16
| | | | | | | | BUG=30508 r=ananta Review URL: http://codereview.chromium.org/502019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35223 0039d316-1c4b-4281-b951-d872f2087c98
* Improve reporting of subprocess crashes.asargent@chromium.org2009-12-043-3/+38
| | | | | | | | | | | | | | | | | -Split extension renderer crashes out of the existing UMA renderer crash metric into its own metric. -Add a new metric for the sum of all ChildProcessHost crashes. -Add histograms for each crash type. BUG=28022 TEST=We should start getting more crash reports in UMA and histograms. Review URL: http://codereview.chromium.org/468005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33794 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK that was firing in metrics service in debug builds. This ↵jam@chromium.org2009-12-011-1/+1
| | | | | | | | | particular case was harmless with no underlying bugs. BUG=29085 Review URL: http://codereview.chromium.org/449068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33489 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33344 - Relocate plugin list fetching to PluginServicejamesr@chromium.org2009-11-302-33/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We fetch the plugin list from three places. Previously, each location had custom code to proxy the query to the file thread. This change moves the query to the PluginService, which then internally manages posting to the file thread and calling back. I experimented with some different approaches to handling the lifetimes of the requests and responses. The approach now is simple: The PluginService plugin methods are called and respond on the IO thread. Two of the three consumers of the plugin lists are already on the IO thread, so they don't need any complicated thread handling. None of the callers ever need to cancel their requests: one is a singleton, and the other two always wait (in terms of holding a ref on the object) for the requests to complete. This makes lifetime management a lot simpler than it would otherwise be. With this change in place, I can then look at refactoring the PluginService implementation on Linux to do more complicated plugin loading as needed in bug 17863. BUG=17863 Review URL: http://codereview.chromium.org/437069 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/456012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33369 0039d316-1c4b-4281-b951-d872f2087c98
* Remove another instance of using the transient pref service. This preftony@chromium.org2009-11-301-2/+3
| | | | | | | | | | | | is only read from the options dialog, the windows installer (a separate process) and a spot in safe browsing. The only one that matters is the safe browsing case. BUG=28992 Review URL: http://codereview.chromium.org/456004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33348 0039d316-1c4b-4281-b951-d872f2087c98
* Relocate plugin list fetching to PluginServiceevan@chromium.org2009-11-302-29/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | We fetch the plugin list from three places. Previously, each location had custom code to proxy the query to the file thread. This change moves the query to the PluginService, which then internally manages posting to the file thread and calling back. I experimented with some different approaches to handling the lifetimes of the requests and responses. The approach now is simple: - The PluginService plugin methods are called and respond on the IO thread. Two of the three consumers of the plugin lists are already on the IO thread, so they don't need any complicated thread handling. - None of the callers ever need to cancel their requests: one is a singleton, and the other two always wait (in terms of holding a ref on the object) for the requests to complete. This makes lifetime management a lot simpler than it would otherwise be. With this change in place, I can then look at refactoring the PluginService implementation on Linux to do more complicated plugin loading as needed in bug 17863. BUG=17863 Review URL: http://codereview.chromium.org/437069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33344 0039d316-1c4b-4281-b951-d872f2087c98
* Add -profile command line switchdavemoore@chromium.org2009-11-302-29/+0
| | | | | | Review URL: http://codereview.chromium.org/384062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
* Many changes to DictionaryValues:pkasting@chromium.org2009-11-251-3/+4
| | | | | | | | | | | | | | | | | * Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs. * Use these APIs with all key iterator usage. * SetXXX() calls cannot fail, so change them from bool to void. * Change GetSize() to size() since it's cheap, and add empty(). Other: * Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop). * Shorten a few bits of code. BUG=567 TEST=none Review URL: http://codereview.chromium.org/441008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
* Move base64 from 'net/base' into 'base'.hayato@chromium.org2009-11-241-2/+2
| | | | | | | | | BUG=13572 TEST=none Review URL: http://codereview.chromium.org/399068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
* Add compiler-specific "examine printf format" attributes to printfs.evan@chromium.org2009-11-201-5/+5
| | | | | | | | | | | | Functions that take a printf-style format get a new annotation, which produces a bunch of compiler warnings when you use printf impoperly. This change adds the annotations and fixes the warnings. We now must use PRId64 for 64-bit numbers and the PRIsz for size_t. Review URL: http://codereview.chromium.org/339059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32600 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-175-10/+10
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* Use Chrome to transport Chrome OS metrics. rvargas@google.com2009-11-135-103/+26
| | | | | | | | | | | | | | | | | | | | | | | Chrome periodically reads the content of a well-know file, and parses it into name-value pairs, each representing a Chrome OS metrics event. The events are then logged using the normal UMA mechanism. The file is then truncated to zero size. Chrome uses flock() to synchronize accesses to the file. BUG=none TEST=compiled and run Linux and Chrome OS versions. Verified that uploaded Chrome OS events appear in about:histograms. Also external_metrics_unittest.cc tests the collection of metrics messages from the well-known file. patch written by semenzato_google.com original code review: http://codereview.chromium.org/378013 (plus http://codereview.chromium.org/346041) Review URL: http://codereview.chromium.org/394010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31952 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-134-16/+16
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the UMA stats for whether the renderer was in a new desktop or not.jam@chromium.org2009-11-133-35/+0
| | | | | | Review URL: http://codereview.chromium.org/391045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31921 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-071-0/+2
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Change id that identifies client in crash reports. Whenever metrics service ↵kuchhal@chromium.org2009-11-051-0/+2
| | | | | | | | | | | | | | | recording is enabled, it sets the client id for crash reporting. - On Windows this id gets stored in the registry so that we can read it pretty early regardless of the process type. If the id has not been generated (like in the case of first run) we initialize with empty string but the real id gets inserted once metrics service gets initialized. - On Linux we were creating a hash and storing it in 'Consent to Send Stats'. This change replaces that hash with the metrics id. Unlike before calling SetConsentToSendStats doesn't generate a new id, if an id already exists. - On Mac there was no id set. Now we use metrics id as guid for the browser process. For other process types a change is still required to pass that id as command line param to renderers/plugins (like Linux). BUG=23658 TEST=Cause a deliberate crash in Chrome renderer/browser/plugin and make sure the clientID reported to the crash server is the right GUID. Review URL: http://codereview.chromium.org/346007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31143 0039d316-1c4b-4281-b951-d872f2087c98
* Third patch in getting rid of caching MessageLoop pointers and always using ↵jam@chromium.org2009-11-021-2/+1
| | | | | | | | | | ChromeThread instead. BUG=25354 Review URL: http://codereview.chromium.org/342068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some #includes where possible.pkasting@chromium.org2009-10-231-15/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/335002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29915 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/272036 for Thiago:sky@chromium.org2009-10-191-1/+1
| | | | | | | | | | | | | | Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode. GetType -> type SetType -> set_type BUG=None TEST=None Review URL: http://codereview.chromium.org/297005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29443 0039d316-1c4b-4281-b951-d872f2087c98
* Bug fix: MetricsService::RecordPluginChanges should handle only pluginsgregoryd@google.com2009-10-092-5/+28
| | | | | | Review URL: http://codereview.chromium.org/264020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28502 0039d316-1c4b-4281-b951-d872f2087c98
* Use the lite runtime for system_metrics.proto.nick@chromium.org2009-10-081-0/+2
| | | | | | | | Have the system_metrics generated code depend on 'protobuf_lite'. Review URL: http://codereview.chromium.org/242117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28367 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Add startup tests that log start script, domcontentloaded, ↵tony@chromium.org2009-10-071-0/+20
| | | | | | | | | | | | | | | and onload."" This reverts commit r28209 and relands r28199. The failure seems to have been flaky (it passed on the other bots and on the following run). I want to try to land again. If it fails again, I'll disable the test. TBR=mattm Review URL: http://codereview.chromium.org/268003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28268 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add startup tests that log start script, domcontentloaded, and onload."mattm@chromium.org2009-10-071-20/+0
| | | | | | | | | | | | which failed on XP Perf (single). This reverts commit r28199. TBR=tony Review URL: http://codereview.chromium.org/265002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28209 0039d316-1c4b-4281-b951-d872f2087c98
* Add startup tests that log start script, domcontentloaded, and onload.tony@chromium.org2009-10-071-0/+20
| | | | | | | | | | | | | | | | TabContents sends a notification which is picked up by the browser automation controller which keeps a map of events and times. Add an automation IPC so that tests can get these values from the browser automation controller. Finally, add a feature startup test to collect these values. This is just to get some consistent timings from the buildbot. BUG=23120 Review URL: http://codereview.chromium.org/246105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28199 0039d316-1c4b-4281-b951-d872f2087c98
* Convert users of RenderProcessHost iterator to all use same style. The key ↵pkasting@chromium.org2009-10-021-6/+4
| | | | | | | | | | | | | | motivator for this is that at least one old place actually did the wrong thing in its loop and failed to call functions on anything but the first host. This also makes many places slightly shorter. Remove an unneeded #include in web_cache_manager.h by converting it to a forward declaration. Update copyrights on touched files. BUG=none TEST=none Review URL: http://codereview.chromium.org/242104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27890 0039d316-1c4b-4281-b951-d872f2087c98
* Size the buffer used for the metrics log text properly.mark@chromium.org2009-09-151-4/+6
| | | | | | | | | | | | | | | | The existing code was abusing the WriteInto interface (base/string_util.h). The size passed to WriteInto should be the size of the string plus one for a terminating NUL byte. This bug caused the final newline in the log to be clipped. c_str users (there probably weren't any) would see the final newline which wouldn't be wouldn't be followed by a NUL byte. TEST=not really any BUG=21733 Review URL: http://codereview.chromium.org/194099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26280 0039d316-1c4b-4281-b951-d872f2087c98
* Convert std::wstring encoding names to std::string in a bunch of files.tony@chromium.org2009-09-041-2/+2
| | | | | | | | | | | | | | | BUG=8647 (http://crbug.com/8647) TEST=run unit_tests.exe and ui_tests.exe Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/179057/show Some linux related fixes by me. Review URL: http://codereview.chromium.org/192017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25529 0039d316-1c4b-4281-b951-d872f2087c98
* Try to shutdown the browser more peacefully before using more brutal methods.phajdan.jr@chromium.org2009-08-191-17/+17
| | | | | | | | | | | | | Also, do proper cleanup before browser shutdown in MetricsService UI test. I hope this will reduce the flakiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/173023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23780 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor IDMap to support safe removing of elements during iteration.phajdan.jr@chromium.org2009-08-171-3/+4
| | | | | | | | | TEST=Covered by unit_tests and other automated tests. http://crbug.com/19202 Review URL: http://codereview.chromium.org/164518 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23572 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't load plugins on the IO thread.jam@chromium.org2009-08-152-10/+20
| | | | | | | | | | I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins. BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23501 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23420. It caused a reliability regression.maruel@chromium.org2009-08-142-20/+10
| | | | | | | | | TBR=jam BUG=none TEST=reliability Review URL: http://codereview.chromium.org/165532 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23437 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't load plugins on the IO thread.jam@chromium.org2009-08-142-10/+20
| | | | | | | | | | I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins. BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23420 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP flag to build with system libbz2.agl@chromium.org2009-08-061-1/+6
| | | | | | | | | | | | | This follows the general style of r21663, which we agreed was the way to do this. Note that, currently, one cannot build with system libbz2 on a 64-bit system since it's not part of the ia32-compat package. http://codereview.chromium.org/165016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22640 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Client ID generation on Linux/OS X. Enables UMA logging.evan@chromium.org2009-07-281-6/+1
| | | | | | | | | BUG=15418 Review URL: http://codereview.chromium.org/149758 Patch from Chris Masone <cmasone@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21846 0039d316-1c4b-4281-b951-d872f2087c98
* Clear yet another few stats when a new chrome version is installedjar@chromium.org2009-07-181-2/+5
| | | | | | | | | | | | | | | Re-review with Laforge found that three stats were registered, but not cleared when we create a new version. This CL clears those stats. I also cleaned a tiny fragment that relates to one stat (moving the setting of the stat into a conditional... which may make code more readable). r=huanr Review URL: http://codereview.chromium.org/155722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21047 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/149404 for cmasone:sky@chromium.org2009-07-134-0/+117
| | | | | | | | | | | | | | | Adding a protobuf-based metrics communication scheme between Chrome OS and Chrome. Essentially, Chrome is used as a metrics upload service, and this hacks in a simple IPC mechanism for Chrome OS to use to communicate metrics info to Chrome for upload. We eventually want to do this using protobuffers over DBus, but this protobuffers-over-X-properties mechanism will work for now. TEST=none BUG=none Review URL: http://codereview.chromium.org/149459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20539 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155128 for Thiago.sky@chromium.org2009-07-081-1/+1
| | | | | | | | | | | | | Description from Thiago: Converting the history::StarredEntry::Type to a type defined in BookmarkNode. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/155165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20195 0039d316-1c4b-4281-b951-d872f2087c98
* http://codereview.chromium.org/147084sky@chromium.org2009-07-083-4/+63
| | | | | | | | | | | | | | | | | | Implements unique client ID generation for Posix. Client ID generation happens once-per-install of Chromium (...well, this is mostly true, at least). On Windows, the code currently uses some system library code that generates a GUID. We don't ACTUALLY need a GUID, something that's quite random and in the same format will work. Since we don't want to add a dependency on libuuid for POSIX, I created a less-random-but-still-good-enough version. BUG=15418 TEST=none Review URL: http://codereview.chromium.org/149343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20184 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-262-3/+5
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* When we upgrade, discard all uploadable stats, including old logsjar@chromium.org2009-06-191-0/+8
| | | | | | | | | | | | | | We already discard all stability info when we do an upgrade to a new version, as there is less concern about stats from old versions. This change just adds the list of "old logs" (gathered in previous sessions, presumably with an old version) to the list of data that is discarded. BUG=14657 r=evanm Review URL: http://codereview.chromium.org/131089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18794 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc. Take 2.willchan@chromium.org2009-06-181-9/+7
| | | | | | | | | | Relands r18641, original code review: http://codereview.chromium.org/125268 Expect a crash on Windows. The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1. Review URL: http://codereview.chromium.org/131007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18680 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18641: "Linux: Enable metrics_service_uitest.cc."willchan@chromium.org2009-06-171-3/+9
| | | | | | | | Broke ui_tests. Review URL: http://codereview.chromium.org/125268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18646 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc.willchan@chromium.org2009-06-171-9/+3
| | | | | | | | | Add support for zygotes to call DidProcessCrash on renderers. TEST=metrics_server_uitest.cc Review URL: http://codereview.chromium.org/126264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18641 0039d316-1c4b-4281-b951-d872f2087c98
* Consistently use int64 for integers holding number of milliseconds.phajdan.jr@chromium.org2009-06-171-1/+1
| | | | | | | | | | This applies only to things which use TimeDelta::InMilliseconds, because it returns int64. Before this patch callers static_casted that to int, and after this patch they use the returned value as int64. Review URL: http://codereview.chromium.org/126279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18626 0039d316-1c4b-4281-b951-d872f2087c98
* Solve a strict-aliasing issue in metrics_log.cc to appease gcc 4.4 on Linux.craig.schlenter@chromium.org2009-06-161-5/+9
| | | | | | Review URL: http://codereview.chromium.org/126104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18487 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram count of number of command line argumentsjar@chromium.org2009-06-121-1/+20
| | | | | | | | | | This should help us evaluate which users are manually switching on non-standard options, which in turn may impact stability. r=huanr Review URL: http://codereview.chromium.org/126024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18281 0039d316-1c4b-4281-b951-d872f2087c98
* Add back in log info about histogram hashesjar@chromium.org2009-06-121-0/+8
| | | | | | | | | | | | | | | This was seemingly inadvertently deleted in a CL http://src.chromium.org/viewvc/chrome?view=rev&revision=16023 The change should have no semantic impact on the running of the program (unless the user enables logging), and it helps me isolate actual names of histograms for unknown hashes that appear on the histogram dashboard. r=evanm,dpranke Review URL: http://codereview.chromium.org/125011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18280 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 16:04:23 +0000