| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
set the execution_phase.
Minor cleanup: Added SHUTDOWN_COMPLETE to the execution_phase.
Renamed CLEAN_SHUTDOWN to UNINITIALIZED_PHASE.
Added Chrome.Browser.CrashedExecutionPhase histogram to
reflect changes to execution phase enums.
Retired Chrome.Browser.ExecutionPhase histogram.
R=jar@chromium.org,
Review URL: https://codereview.chromium.org/69953008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=isherman@chromium.org
BUG=162530
Review URL: https://codereview.chromium.org/68113008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[MetricsServiceTest.RegisterSyntheticTrial fails under ASAN.]
> MetricsService API to support synthetic field trials
>
> Extend the MetricsService API to register synthetic field trials, where trial groups map to Chrome configuration states, e.g., values of a preference. These trials are included in UMA reports.
>
> BUG=270275
>
> Review URL: https://codereview.chromium.org/22340005
TBR=bengr@chromium.org
Review URL: https://codereview.chromium.org/61453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Extend the MetricsService API to register synthetic field trials, where trial groups map to Chrome configuration states, e.g., values of a preference. These trials are included in UMA reports.
BUG=270275
Review URL: https://codereview.chromium.org/22340005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The from factor API under /ui/base/form_factor.h is used to obtained the current device form factor.
BUG=312920
Review URL: https://codereview.chromium.org/37243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=315884, 78045
TBR=owners
Review URL: https://codereview.chromium.org/67923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Extends FakeDBusThreadManager about DBusClient setters.
- Removes default initialization of DBusClients from FakeDBusThreadManager.
- Replaces all occurrences of MockDBusThreadManager in tests by FakeDBusThreadManager.
- Every test now creates exactly the DBusClients that are required.
- Removes all references to Fake/Stub implementations from the DBusThreadManagerImpl used for production.
Depends on:
https://codereview.chromium.org/50243005/
BUG=275286
TBR=miket@chromium.org,mkwst@chromium.org,rtenneti@chromium.org
Review URL: https://codereview.chromium.org/49773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTIFICATION_RENDER_WIDGET_HOST_HANG as it is being sent out by the RenderWidgetHost.
BUG=none
TEST=no change
Review URL: https://codereview.chromium.org/64683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS, NEW_TAB_PAGE, and OBSOLETE_INSTANT_NEW_TAB_PAGE enums.
This is based the suggestion at https://codereview.chromium.org/23621037/diff/972001/chrome/browser/autocomplete/search_provider.cc#newcode941
BUG=
Review URL: https://codereview.chromium.org/65373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly involves deleting hundreds of lines of unused code.
BUG=315884
R=akalin@chromium.org, brettw@chromium.org, fischman@chromium.org, jamesr@chromium.org, sky@chromium.org, thestig@chromium.org
TBR=piman, youngki
Review URL: https://codereview.chromium.org/63153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
them.
As described on http://crbug.com/266955#c7
Also adding AtExitManager to gcapi_test.exe; this is required to support MasterPreferences's LazyInstance used by BrowserDistribution, used by google_update's ReadExperimentLabels().
Introducing GCAPITestRegistryOverrider as a class to be added as a member to GCAPI test fixtures that require registry overriding; extracted from the existing GCAPIReactivationTest fixture.
Move Windows-specific variations_util.cc code to experiment_labels_win.cc
BUG=266955
TEST=gcapi_test.exe
Review URL: https://codereview.chromium.org/23579003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents an issue where the variations seed not changing
in a while will result in studies not actually expiring.
Also, removes an unused header include.
BUG=315177
TEST=New unit test.
Review URL: https://codereview.chromium.org/59953005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is renamed because we're going to add new "services" directory which holds all google services related codes, like sync, invalidation and signin. We do not want to have both "service" and "services" to cause the confusion. Since all codes under "service" deal purely with service process, we would like to rename it to "service_process".
BUG=none
TEST=none due to that this is just a dir renaming
R=thakis@chromium.org, vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/57383010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move this outside of Chrome to enable moving ExtensionPrefs
to the top-level extensions/ directory.
BUG=313284
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/46073004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a UMA histogram.
As a first attempt, tracked the following
- Before starting metrics service,
- Before creating profile
- Before starting startup time bomb
- Before starting thread watcher
- Before starting main message loop
- Before starting shutdown time bomb
- clean shutdown.
R=jar@chromium.org
Review URL: https://codereview.chromium.org/28283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
MetricsService in browser process sends request for histograms to service process if service is running. Request is called in parallel with requests to other browser child processes.
Service process still loses all data collected after browser process is gone.
BUG=305019
Review URL: https://codereview.chromium.org/26779002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original name was a misnomer as the class behaves like a fake
and hosts fake D-Bus client classes. No semantic changes.
BUG=223061
TEST=none
R=hashimoto@chromium.org, miket@chromium.org, nona@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/31793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
by making these counters into Atomic32 and using atomic operations to access them.
BUG=308590
R=rtenneti@chromium.org
Review URL: https://codereview.chromium.org/29063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new X-Chrome-UMA-Log-SHA1 header that is transmitted
along with each UMA log upload. The header contains the SHA1
(as hex) of the payload prior to compression.
The hash is computed at the time that the log is closed, rather than
just before being transmitted - to minimize the chance of hashing
an already corrupted log.
Does not store the hash with logs when they are persisted temporarily
to local state for later upload, since log are already hashed when stored
(and discarded on load if the hash does not match). The SHA1 hash is
re-computed when logs are loaded from local state.
BUG=308066
Review URL: https://codereview.chromium.org/26646003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=307668
R=hans@chromium.org
TBR=oshima
Review URL: https://codereview.chromium.org/29263007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces crashes on the mac tests: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/34018/steps/unit_tests/logs/stdio
Specifically, these tests now crash:
TabStripControllerTest.TabCloseDuringDrag
TabposeWindowTest.TestModelObserver
TabposeWindowTest.TestShow
And this test suite is referenced in this patch.
> Update defaults for InstantExtended.
>
> Flip the InstantExtended New Tab page to on by default and remove the flags.
> Add a separate flag to control query in the omnibox (which is still off by
> default).
>
> Also fixes a ton of tests that needed adjusting for Instant Extended. Mostly
> the changes stem from the fact that we're prerendering the Instant Extended
> New Tab page which changes assumptions in a bunch of tests.
>
> BUG=297915
>
> Review URL: https://codereview.chromium.org/24733003
TBR=samarth@chromium.org
Review URL: https://codereview.chromium.org/27235010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the InstantExtended New Tab page to on by default and remove the flags.
Add a separate flag to control query in the omnibox (which is still off by
default).
Also fixes a ton of tests that needed adjusting for Instant Extended. Mostly
the changes stem from the fact that we're prerendering the Instant Extended
New Tab page which changes assumptions in a bunch of tests.
BUG=297915
Review URL: https://codereview.chromium.org/24733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ThreadWatcher.
Get a crash dump if UI thread doesn't respond for 60 pings
(or 120 secs). Picked a very high number to catch the worst
hangs/janks and to have fewer crash dumps due to ThreadWatcher.
R=jar@chromium.org
Review URL: https://codereview.chromium.org/27261002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds a new flag --force-variation-ids
- Accepts a comma-separated list of numeric experiment ids.
- Strictly meant for dev use.
- Basic error checking for invalid flags based on StringToInt behavior.
BUG=305882
Review URL: https://codereview.chromium.org/26565007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=297184
Review URL: https://codereview.chromium.org/25364002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I need to merge this into m30 or even m29 so trying to find a happy place to gather this.
It can be found as Platform.LogicalCpuCount
BUG=none
TBR=sky
TEST=none
Review URL: https://codereview.chromium.org/25647002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MetricsService::InitializeMetricsState() has a DCHECK
that MetricsLog::GetIncrementalUptime() would always
return 0, which isn't the case for unit tests. (This is
because MetricsService may be created and destroyed
multiple times.)
This CL de-flakes the tests by moving the static
MetricsLog::GetIncrementalUptime to be a non-static
MetricsService::GetIncrementalUptime function (with
the last time stored as an instance variable).
BUG=290326
TEST=Tests still pass even if you add a sleep() call
to MetricsServiceTest() constructor.
NOTRY=true
Review URL: https://codereview.chromium.org/25559009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=270135
For sync/util/get_session_name.cc (comment change only):
TBR=tim@chromium.org
Review URL: https://codereview.chromium.org/25112004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=299180
Review URL: https://codereview.chromium.org/25675012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77656
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/23602009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: PerfTimer is used by production code, so it doesn't make sense to have
it as test only.
- Rename it to ElapsedTimer.
- Move into base namespace.
- Move into timer/ directory.
BUG=None
TEST=None, no functional change
R=brettw@chromium.org
TBR=grt@chromium.org # for chrome_frame
Review URL: https://codereview.chromium.org/24265005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to catch hangs in issue like 288265.
R=jar@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/24945002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Guarded by command switch. When enabled, NetworkTimeService converts local navigation time to network time, which is used to timestamp history entry and session sync entry.
BUG=265523
NOTRY=true
TBR=asvitkine@chromium.org
Review URL: https://codereview.chromium.org/23876007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes:
* Move TouchFactory from ui/base/ into ui/events/x/.
* Split out some switches from ui/base/ into ui/events/.
* Move SequentialIDGenerator from ui/base/ into ui/gfx/.
BUG=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/24692003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
At scale factors above 125%, we are over-scaling up the dpi calculation.
BUG=292607
Review URL: https://chromiumcodereview.appspot.com/23851034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
same browser process.
This CL fixes a bug wherein a non-fatal crash report would prevent subsequent (fatal or non-fatal) crash reports in the same browser process from being counted in the histograms.
It has been further expanded to define separate histograms for crashing, non-crashing and total-number-of attenoted crash reports.
R= cpu, jar, rvargas, grt
BUG= 290196
Review URL: https://chromiumcodereview.appspot.com/23453032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes compressing metrics protobufs before uploading the default.
From our field trial we noticed that compressed protobufs are on average 44% the
size of the uncompressed protobufs.
BUG=245300
TEST=Built chrome browser. Ensure it can send UMA data.
Review URL: https://chromiumcodereview.appspot.com/23684053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=103304
Review URL: https://codereview.chromium.org/23769011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves hidpi switch to gfx/switches.h
R=sky@chromium.org
http://crbug.com/103304
Review URL: https://codereview.chromium.org/23451036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 17114003 and 22410004 added a way for Mac and views to hide the top
omnibox match when it is a verbatim match we do not want to show. This
implements that for GTK too so it'll work on all desktop platforms.
BUG=252823
TEST=Manually. Run with no flags and verify that when you type 'faceb'
in the omnibox, the popup shows a search suggestion for 'faceb'. Run
again with the flags
--enable-instant-extended-api
--force-fieldtrials='InstantExtended/Group1 hide_verbatim:1/'
and verify that you do not see this suggestion. Also check that with the
flags set, hovering on the top suggestion works and that there are no
off-by-one problems when clicking on suggestions.
Review URL: https://chromiumcodereview.appspot.com/22679003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=285440
Review URL: https://chromiumcodereview.appspot.com/23534051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=rsesek@chromium.org
Review URL: https://codereview.chromium.org/23726019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches to how most of the code / documentation
was referring to it already and remains compatible
with the existing payload.
BUG=none
TEST=Existing unit tests. Also, verified manually that a seed received
from the server is still accepted and works correctly.
R=jwd@chromium.org
Review URL: https://codereview.chromium.org/23568004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving this code out of chrome/ paves the way for server-controlled system
field trials on ChromeOS. This allows building a new ChromeOS daemon binary
that depends on the new variations target, without needing to depend on all of
chrome/.
This CL moves several files from chrome/common/metrics and
chrome/browser/metrics into a separate component/variations target and
updates all the include paths referencing these. It does not do additional
cleanup, such as changing namespaces - this is left for a follow-up cleanup
CL.
BUG=266007
TEST=Existing unit tests.
R=joi@chromium.org, jwd@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/23097007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Followed up previous code review; see linked bug.
Once you approve of these comments, I'll revise them in the other
two places (google-internal protocol file and autocomplete_input.h).
BUG=264938
Review URL: https://chromiumcodereview.appspot.com/22912009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should address the TODO from tools/gn/secondary/base/BUILD.gn
BUG=None
TEST=test_support_perf
R=brettw@chromium.org
TBR=cpu, dalecurtis, akalin, thestig
Review URL: https://chromiumcodereview.appspot.com/22887041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=274679
TEST=N/A
TBR=cbentzel, jamesr, simonjam, tzik, stevet, mpcomplete
Review URL: https://chromiumcodereview.appspot.com/23064011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hack Alert!
This CL attempts to count the number of times the browser process generates a crash dump. It does so by sending up a smoke signal (creating a file in a smoke-signal subdirectory of the crash-dump directory) just after generating a minidump for the crash server. On browser startup, these files are scavenged and a crash dump counter is incremented for each.
R= mad@chromium.org, cpu@chromium.org
TBR= isherman@chromium.org
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/22493007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
than 5 minutes.
R=jar@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/22816009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way, variation_ids.h can stay under chrome/ when a subset of this
code will move to a new target that will also be used by the ChromeOS
daemon process.
BUG=266007
TEST=Existing unit tests.
Review URL: https://chromiumcodereview.appspot.com/22980009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218102 0039d316-1c4b-4281-b951-d872f2087c98
|