summaryrefslogtreecommitdiffstats
path: root/chrome/browser/metrics
Commit message (Collapse)AuthorAgeFilesLines
* Try to shutdown the browser more peacefully before using more brutal methods.phajdan.jr@chromium.org2009-08-191-17/+17
| | | | | | | | | | | | | Also, do proper cleanup before browser shutdown in MetricsService UI test. I hope this will reduce the flakiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/173023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23780 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor IDMap to support safe removing of elements during iteration.phajdan.jr@chromium.org2009-08-171-3/+4
| | | | | | | | | TEST=Covered by unit_tests and other automated tests. http://crbug.com/19202 Review URL: http://codereview.chromium.org/164518 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23572 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't load plugins on the IO thread.jam@chromium.org2009-08-152-10/+20
| | | | | | | | | | I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins. BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23501 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23420. It caused a reliability regression.maruel@chromium.org2009-08-142-20/+10
| | | | | | | | | TBR=jam BUG=none TEST=reliability Review URL: http://codereview.chromium.org/165532 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23437 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't load plugins on the IO thread.jam@chromium.org2009-08-142-10/+20
| | | | | | | | | | I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins. BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23420 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP flag to build with system libbz2.agl@chromium.org2009-08-061-1/+6
| | | | | | | | | | | | | This follows the general style of r21663, which we agreed was the way to do this. Note that, currently, one cannot build with system libbz2 on a 64-bit system since it's not part of the ia32-compat package. http://codereview.chromium.org/165016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22640 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Client ID generation on Linux/OS X. Enables UMA logging.evan@chromium.org2009-07-281-6/+1
| | | | | | | | | BUG=15418 Review URL: http://codereview.chromium.org/149758 Patch from Chris Masone <cmasone@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21846 0039d316-1c4b-4281-b951-d872f2087c98
* Clear yet another few stats when a new chrome version is installedjar@chromium.org2009-07-181-2/+5
| | | | | | | | | | | | | | | Re-review with Laforge found that three stats were registered, but not cleared when we create a new version. This CL clears those stats. I also cleaned a tiny fragment that relates to one stat (moving the setting of the stat into a conditional... which may make code more readable). r=huanr Review URL: http://codereview.chromium.org/155722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21047 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/149404 for cmasone:sky@chromium.org2009-07-134-0/+117
| | | | | | | | | | | | | | | Adding a protobuf-based metrics communication scheme between Chrome OS and Chrome. Essentially, Chrome is used as a metrics upload service, and this hacks in a simple IPC mechanism for Chrome OS to use to communicate metrics info to Chrome for upload. We eventually want to do this using protobuffers over DBus, but this protobuffers-over-X-properties mechanism will work for now. TEST=none BUG=none Review URL: http://codereview.chromium.org/149459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20539 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155128 for Thiago.sky@chromium.org2009-07-081-1/+1
| | | | | | | | | | | | | Description from Thiago: Converting the history::StarredEntry::Type to a type defined in BookmarkNode. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/155165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20195 0039d316-1c4b-4281-b951-d872f2087c98
* http://codereview.chromium.org/147084sky@chromium.org2009-07-083-4/+63
| | | | | | | | | | | | | | | | | | Implements unique client ID generation for Posix. Client ID generation happens once-per-install of Chromium (...well, this is mostly true, at least). On Windows, the code currently uses some system library code that generates a GUID. We don't ACTUALLY need a GUID, something that's quite random and in the same format will work. Since we don't want to add a dependency on libuuid for POSIX, I created a less-random-but-still-good-enough version. BUG=15418 TEST=none Review URL: http://codereview.chromium.org/149343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20184 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-262-3/+5
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* When we upgrade, discard all uploadable stats, including old logsjar@chromium.org2009-06-191-0/+8
| | | | | | | | | | | | | | We already discard all stability info when we do an upgrade to a new version, as there is less concern about stats from old versions. This change just adds the list of "old logs" (gathered in previous sessions, presumably with an old version) to the list of data that is discarded. BUG=14657 r=evanm Review URL: http://codereview.chromium.org/131089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18794 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc. Take 2.willchan@chromium.org2009-06-181-9/+7
| | | | | | | | | | Relands r18641, original code review: http://codereview.chromium.org/125268 Expect a crash on Windows. The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1. Review URL: http://codereview.chromium.org/131007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18680 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18641: "Linux: Enable metrics_service_uitest.cc."willchan@chromium.org2009-06-171-3/+9
| | | | | | | | Broke ui_tests. Review URL: http://codereview.chromium.org/125268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18646 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc.willchan@chromium.org2009-06-171-9/+3
| | | | | | | | | Add support for zygotes to call DidProcessCrash on renderers. TEST=metrics_server_uitest.cc Review URL: http://codereview.chromium.org/126264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18641 0039d316-1c4b-4281-b951-d872f2087c98
* Consistently use int64 for integers holding number of milliseconds.phajdan.jr@chromium.org2009-06-171-1/+1
| | | | | | | | | | This applies only to things which use TimeDelta::InMilliseconds, because it returns int64. Before this patch callers static_casted that to int, and after this patch they use the returned value as int64. Review URL: http://codereview.chromium.org/126279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18626 0039d316-1c4b-4281-b951-d872f2087c98
* Solve a strict-aliasing issue in metrics_log.cc to appease gcc 4.4 on Linux.craig.schlenter@chromium.org2009-06-161-5/+9
| | | | | | Review URL: http://codereview.chromium.org/126104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18487 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram count of number of command line argumentsjar@chromium.org2009-06-121-1/+20
| | | | | | | | | | This should help us evaluate which users are manually switching on non-standard options, which in turn may impact stability. r=huanr Review URL: http://codereview.chromium.org/126024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18281 0039d316-1c4b-4281-b951-d872f2087c98
* Add back in log info about histogram hashesjar@chromium.org2009-06-121-0/+8
| | | | | | | | | | | | | | | This was seemingly inadvertently deleted in a CL http://src.chromium.org/viewvc/chrome?view=rev&revision=16023 The change should have no semantic impact on the running of the program (unless the user enables logging), and it helps me isolate actual names of histograms for unknown hashes that appear on the histogram dashboard. r=evanm,dpranke Review URL: http://codereview.chromium.org/125011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18280 0039d316-1c4b-4281-b951-d872f2087c98
* Automatically adapt to faster/slower uploads of renderer histogramsjar@chromium.org2009-05-282-34/+54
| | | | | | | | | | | | | | | | | | | | | This replaces the current time based approach (chrome is given N seconds to upload all renederer histograms) with an asynch callback approach that waits until all renderers have responded (with their updates). It uses a fall-back timer to ensure that a hung renderer won't delay things forever as well. This causes faster (and complete) updates in about:histograms as well as generally assuring complete updates during UMA gatherings. This code was contributed by Raman Tenneti in CL 42496 http://codereview.chromium.org/42496 bug=12850 r=raman Review URL: http://codereview.chromium.org/113473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
* Make automation proxy objects to ref_counted. That allows to process async ↵stoyan@chromium.org2009-05-281-5/+5
| | | | | | | | | | | notifications directly in channel background thread. Add support for listener-less ChannelProxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/113722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-222-52/+37
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/114040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16792 0039d316-1c4b-4281-b951-d872f2087c98
* Add GTK options window (no options actually configurable yet.)evan@chromium.org2009-05-141-2/+0
| | | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/113377 Patch from Matt Mueller <mattm@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16023 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RENDERER_PROCESS_CLOSED notification that gets sent when we close thempcomplete@google.com2009-05-051-3/+4
| | | | | | | | | | RenderProcessHost's process_. This is similar to RENDER_PROCESS_TERMINATED, but the latter is not always sent since the process could get reused. It also takes the place of RENDERER_PROCESS_CRASHED, where this one contains a boolean Details indicating whether the process crashed (true) or just exited (false). Review URL: http://codereview.chromium.org/100277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15261 0039d316-1c4b-4281-b951-d872f2087c98
* ImportantFileWriterphajdan.jr@chromium.org2009-04-282-4/+3
| | | | | | | | | | | | | | Introducing a class for writing important files, preventing their corruption during writing. Switched PrefService to use it. Other classes will be switched in future changesets. TEST=This may affect things using preferences. Make sure that changes in preferences don't get lost, and that you don't get excessive disk activity when changing preferences. http://crbug.com/10618 Review URL: http://codereview.chromium.org/83001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14717 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send stats from Chromium builds.kuchhal@chromium.org2009-04-272-6/+15
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14665 0039d316-1c4b-4281-b951-d872f2087c98
* Searching by keyword now generates a visit against the site with asky@chromium.org2009-04-271-0/+1
| | | | | | | | | | | | | | | | transition type of TAB_TO_SEARCH. This visit increments the typed count and ensures if you use TAB_TO_SEARCH you still get autocompleted to the site. I'll add some tests for this, but want to make sure we're ok with it before I do that. BUG=3633 TEST=will be covered by unit tests. Review URL: http://codereview.chromium.org/93087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14609 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Do not send stats from Chromium builds."kuchhal@chromium.org2009-04-242-11/+6
| | | | | | | | | | | | This reverts commit 4a0189db765fe94f5df360c0907a585e26c9f681. Revert "Fix build break." This reverts commit eada493cf28975e56395aa3e2d3a0dc267a7f2c7. Review URL: http://codereview.chromium.org/92162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.kuchhal@chromium.org2009-04-241-1/+1
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14478 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send stats from Chromium builds.kuchhal@chromium.org2009-04-242-6/+11
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14474 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of using WebPluginListBuilder.darin@chromium.org2009-04-241-1/+1
| | | | | | | | | | | | | | I also broke glue/webplugininfo.h out of glue/webplugin.h as part of this change. Eventually, glue/webplugin.h will go away and be moved into the WebKit API, but the structures left in glue/webplugininfo.h need to remain since they are used extensively throughout Chrome. BUG=10922 R=dglazkov Review URL: http://codereview.chromium.org/93116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14438 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated version of UITest::DieFileDie().thestig@chromium.org2009-04-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/75008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13852 0039d316-1c4b-4281-b951-d872f2087c98
* Don't overload the meaning of the RENDERER_PROCESS_TERMINATED notification, ↵jam@chromium.org2009-04-131-4/+3
| | | | | | | | | | | | instead create a new one for crashing. The old way of using notifications was incorrect since a RenderProcessHost might have sent only one notification even though a new renderer might have been created after a crash. BUG=9379 Review URL: http://codereview.chromium.org/66069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13629 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/62160robertshield@google.com2009-04-131-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13600 0039d316-1c4b-4281-b951-d872f2087c98
* The profile Source parameter of a BookmarkModelLoaded event can be null ↵tim@chromium.org2009-04-091-3/+5
| | | | | | | | | | during testing. MetricsService and WebContents weren't handling this case properly. Review URL: http://codereview.chromium.org/66007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13475 0039d316-1c4b-4281-b951-d872f2087c98
* Switching things to FilePath:phajdan.jr@chromium.org2009-04-071-4/+5
| | | | | | | | | | | | | | | | Remove following deprecated wstring-using functions: net/net_util: FilePathToFileURL net/net_util: FileURLToFilePath Switch net/base/upload_data to FilePath. Switch upload-related parts of net/url_request/url_request to FilePath. Made necessary adjustments in rest of code (a lot). Review URL: http://codereview.chromium.org/63011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13242 0039d316-1c4b-4281-b951-d872f2087c98
* Make OpenProcessHandle report an error when it couldn't open the handle.phajdan.jr@chromium.org2009-04-031-1/+2
| | | | | | | | One more step to land http://codereview.chromium.org/54003 (chrome_process_util). Review URL: http://codereview.chromium.org/62004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13086 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in chrome UI tests.phajdan.jr@chromium.org2009-03-301-2/+5
| | | | | | | | | Can't include them in the Linux build yet because they wouldn't pass. Review URL: http://codereview.chromium.org/57010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12780 0039d316-1c4b-4281-b951-d872f2087c98
* Fix underflow that would cause either an access violation or an infinite ↵robertshield@google.com2009-03-181-2/+3
| | | | | | | | loop if we were ever to get a "chrome_config" node back in metrics response data. Review URL: http://codereview.chromium.org/42335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11983 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-108-10/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* The MetricsService are not initialized unless the user have opted injar@chromium.org2009-03-081-9/+13
| | | | | | | | | See contributed CL 28315 by Xharze BUG=2278 Review URL: http://codereview.chromium.org/40274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11219 0039d316-1c4b-4281-b951-d872f2087c98
* Add a set of long-running metrics to Chrome that are sent up only at ↵robertshield@google.com2009-03-042-18/+43
| | | | | | | | uninstall time via the uninstall survey page.These uninstall metrics are collected according to the same opt-in policy as the existing UMA code. They are stored along with other prefs in the browser's Local State file. At uninstall time, the Local State file is copied to a temporary location during the file deletion stage and then read to extract the uninstall metrics. If the user selected to have metrics reported, the uninstall metrics are then sent up to the uninstall survey page that is currently opened. Review URL: http://codereview.chromium.org/27092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10859 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath setter/getter to pref service. Change callers to use it rather ↵estade@chromium.org2009-03-041-2/+2
| | | | | | | | | | | | | than the string methods. Update the pref service unit test and enable it on linux. Also switch over some wstrings to filepaths where appropriate. BUG=8154 Review URL: http://codereview.chromium.org/27354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10844 0039d316-1c4b-4281-b951-d872f2087c98
* revert broken change 10833nsylvain@chromium.org2009-03-032-42/+28
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10837 0039d316-1c4b-4281-b951-d872f2087c98
* Port DictionaryValue to use string16 instead of wstring.dsh@google.com2009-03-032-28/+42
| | | | | | | Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10818 Review URL: http://codereview.chromium.org/31014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10833 0039d316-1c4b-4281-b951-d872f2087c98
* Revert dsh's change 10818nsylvain@chromium.org2009-03-032-36/+26
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10821 0039d316-1c4b-4281-b951-d872f2087c98
* Port DictionaryValue to use string16 instead of wstring.dsh@google.com2009-03-032-26/+36
| | | | | | Review URL: http://codereview.chromium.org/31014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10818 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilations errors introduced by revision 10712.maruel@chromium.org2009-03-021-4/+5
| | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/27347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10721 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of wstring variants of StringToFoo.dsh@google.com2009-02-281-6/+6
| | | | | | Review URL: http://codereview.chromium.org/28281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10664 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 16:04:07 +0000