| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
it doesn't have to be. The delegates don't need to be strictly gears either, but for now they are only used by gears and this simple change allows re-use of HtmlDialogView + HtmlDialogContents + HtmlDialogContentsDelegate.
Review URL: http://codereview.chromium.org/17441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
possible to get more than one NOTIFY_WEB_CONTENTS_DISCONNECTED. The
first time ModalHTMLDialogDelegate gets a
NOTIFY_WEB_CONTENTS_DISCONNECTED it sets the contents_ to NULL. This
is problematic because the destructor than removes the observer using
a source of NULL. Instead we should remove the observer immediately,
then NULL out the contents_.
BUG=4129
TEST=covered by QEMU
Review URL: http://codereview.chromium.org/11413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://crbug.com/2188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
|