summaryrefslogtreecommitdiffstats
path: root/chrome/browser/modal_html_dialog_delegate.h
Commit message (Collapse)AuthorAgeFilesLines
* Split the IPC code into ipc/agl@chromium.org2009-07-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This splits the ipc code from the common project. The 'common' project pulls in all of webkit, the v8 bindings, skia, googleurl, and a number of other projects which makes it very difficult to deal with especially for external projects wanting just to use some of Chromium's infrastructure. This puts the ipc code into its top-level ipc/ directory with a dependency only on base. The common project depends on the new ipc/ipc.gyp:ipc target so that all projects currently pulling common in to get the IPC code still have it available. This mostly follows agl's pre-gyp attempt to do this which was r13062. Known issues: - Currently a number of projects depend on chrome/chrome.gyp:common in order to use the IPC infrastructure. Rather than fixing all of these dependencies I have made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules section of DEPS so that checkdeps.py doesn't complain. Over time projects that need IPC should depend on the IPC project themselves and dependencies on common removed, although I don't think many projects that need IPC will be able to get away without common currently. - ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve this since it's really an IDE bug - the named pipe name (windows+linux) and the logging event name (all) + env variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion of ipc/ being an independent library. I think this should be examined in a subsequent, much smaller patch. - I've eliminated the IPC.SendMsgCount counter since it was implemented in a way to create a dependency from ipc/ to chrome/common/chrome_counters. This is the same approach that r13062 took. http://codereview.chromium.org/155905 (Patch from James Robinson) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
* Take two for http://codereview.chromium.org/131094tim@chromium.org2009-06-291-0/+2
| | | | | | | | This time without browser_tests timeout that caused the revert. The problem was BrowsingHistoryHandler trying to use a dom_ui_ before being attached. Review URL: http://codereview.chromium.org/149117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19359 due to browser_tests timeout.tim@chromium.org2009-06-261-2/+0
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/147206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to ↵tim@chromium.org2009-06-261-0/+2
| | | | | | | | | | | | | | construct these objects by deferring the DOMUI dependency to the init / "Attach" step. Add GetMessageHandlers to HtmlDialogUIDelegate to allow sending/receiving messages to the page hosted in the dialog as opposed to only on open/close. BUG=none TEST=none Review URL: http://codereview.chromium.org/131094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
* Google Gears should be renamed to Gearsmhm@chromium.org2009-06-121-1/+1
| | | | | | | | | | | BUG=6234 (http://crbug.com/6234) TEST=Checked the Google Gears screen to see if they got changed. Wrench > Options > Under the Hood > Web Content Review URL: http://codereview.chromium.org/125037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18326 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.BUG=2381pkasting@chromium.org2009-05-221-5/+2
| | | | | | Review URL: http://codereview.chromium.org/113743 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16767 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-041-4/+4
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Move HTML dialogs out of their own tab contents type. Moved functions to newbrettw@chromium.org2009-04-031-4/+5
| | | | | | | | | | | | | file html_dialog_ui.* Move WebContents view creation into the constructor, which makes a bunch of extra calls to CreateView unnecessary. Remove unused CallJavascriptFunction() functions in DOMUI. Review URL: http://codereview.chromium.org/56065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13065 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome_plugin_host.cc and chrome_plugin_util.cc compile on Posix.jhawkins@chromium.org2009-02-261-1/+2
| | | | | | Review URL: http://codereview.chromium.org/27150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10436 0039d316-1c4b-4281-b951-d872f2087c98
* HtmlDialogContentsDelegate should not subclass views::WindowDelegate, for ↵ben@chromium.org2009-02-241-5/+3
| | | | | | | | | | | portability reasons (views isn't used on Mac or Linux). Instead, add modal/title getting methods to HtmlDialogContentsDelegate directly, and have the UI (HtmlDialogView) call to these in the Modal/ModelessHtmlDialogDelegate in its implementation of views::WindowDelegate instead. TEST=open any page and test that Page->Create application shortcuts still works. visit any site that uses Gears and make sure the Gears Allow/Deny dialog still comes up. Review URL: http://codereview.chromium.org/27074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10236 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-011-1/+1
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* HtmlDialogView is hard-wired to the gears application shortcut dialogs but ↵tim@chromium.org2009-01-091-0/+1
| | | | | | | | it doesn't have to be. The delegates don't need to be strictly gears either, but for now they are only used by gears and this simple change allows re-use of HtmlDialogView + HtmlDialogContents + HtmlDialogContentsDelegate. Review URL: http://codereview.chromium.org/17441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7804 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing possible crash in ModalHTMLDialogDelegate. It'ssky@google.com2008-11-171-5/+9
| | | | | | | | | | | | | | | | possible to get more than one NOTIFY_WEB_CONTENTS_DISCONNECTED. The first time ModalHTMLDialogDelegate gets a NOTIFY_WEB_CONTENTS_DISCONNECTED it sets the contents_ to NULL. This is problematic because the destructor than removes the observer using a source of NULL. Instead we should remove the observer immediately, then NULL out the contents_. BUG=4129 TEST=covered by QEMU Review URL: http://codereview.chromium.org/11413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5575 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-161-1/+1
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+78
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-12-26 04:20:10 +0000