summaryrefslogtreecommitdiffstats
path: root/chrome/browser/net
Commit message (Collapse)AuthorAgeFilesLines
* Coverity: Fix various NULL_RETURNS defects.csilv@chromium.org2011-03-111-1/+3
| | | | | | | | CID=8699, 13592, 14444, 14510, 14658, 14805, 14897 BUG=none Review URL: http://codereview.chromium.org/6672016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77845 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass values by reference.jhawkins@chromium.org2011-03-112-6/+6
| | | | | | | | | | CID=8402,8494,8641,8716,8717,8740,9100 BUG=none TEST=none Review URL: http://codereview.chromium.org/6676015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77788 0039d316-1c4b-4281-b951-d872f2087c98
* connection_tester.cc doesn't need to includewtc@chromium.org2011-03-101-1/+0
| | | | | | | | | | | | net/disk_cache/disk_cache.h. R=rvargas BUG=none TEST=no compilation errors Review URL: http://codereview.chromium.org/6657014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77717 0039d316-1c4b-4281-b951-d872f2087c98
* Define a new CertDatabase::Observer abstract class which can be implemented ↵rch@chromium.org2011-03-101-7/+11
| | | | | | | | | | | | | | by classes which wish to be notified when a new ssl client cert is added. Register SpdySessionPool, SocketPoolManager and SSLClientAuthCache as observers. Notify observers in CertDatabase::AddUserCert(); BUG=75326 Review URL: http://codereview.chromium.org/6588014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77599 0039d316-1c4b-4281-b951-d872f2087c98
* Extends NetworkDelegate to avoid use of static_cast<> when handling ↵tony@chromium.org2011-03-103-12/+19
| | | | | | | | | | | | | | | | | | | | | RegisterProtocolHandler URLs. Currently we use a static_cast<> to convert a URLRequestContext into a ChromeURLRequestContext in a ProtocolFactory. However, ProtocolFactory is global and not all URLRequestContexts are instances of ChromeURLRequestContext, so this will always crash in certain circumstances (such as the one described in the TEST field). This change solves the problem by providing a MaybeCreateURLRequestJob() method in NetworkDelegate and then having the ProtocolHandlerRegistry::Factory() call it instead of casting. BUG=74063 TEST=Requesting a URL that has a registerProtocolHandler() from chrome://net-internals/#tests doesn't crash. Review URL: http://codereview.chromium.org/6592060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77559 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-0910-26/+26
| | | | | | | | | | | Second part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6639008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77396 0039d316-1c4b-4281-b951-d872f2087c98
* Implement blocking for webRequest.onBeforeRequest extension event.mpcomplete@chromium.org2011-03-082-6/+8
| | | | | | | | | | | | | I did some measurements with a Release build of chrome, both manually and via the page cycler tests. It seems that a simple empty blocking event listener can add anywhere from a 1 to 30ms delay to request times, largely depending on how many requests are in the queue (when many requests come at once, the last ones to be processed by the extension are delayed the longest). From page cycler data (on my local machine), the average increase in page load time seems to be around 6ms. This is independent of total page load time (which makes sense). BUG=60101 TEST=covered by apitests Review URL: http://codereview.chromium.org/6574049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77339 0039d316-1c4b-4281-b951-d872f2087c98
* Move resource related IPCs to their own file in content. I added a ↵jam@chromium.org2011-03-051-1/+1
| | | | | | | | | IPC_STRUCT_TRAITS_PARENT macro to allow the automatic serializing macros to add a parent struct. TBR=tsepez Review URL: http://codereview.chromium.org/6628035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77048 0039d316-1c4b-4281-b951-d872f2087c98
* mock url tests: be more careful about string handling in URLsevan@chromium.org2011-03-032-8/+13
| | | | | | | | BUG=69467 Review URL: http://codereview.chromium.org/6612018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76794 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of browser_thread.h jam@chromium.org2011-03-014-4/+4
| | | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6594084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76411 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of browser_thread.h jam@chromium.org2011-03-0114-14/+14
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6591065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76387 0039d316-1c4b-4281-b951-d872f2087c98
* Make the ChromeNetworkDelegate use the ExtensionEventRouterForwarderjochen@chromium.org2011-03-012-13/+21
| | | | | | | | | BUG=73903 TEST=tests for proxy and webrequest API should still work Review URL: http://codereview.chromium.org/6598002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76372 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temporary headers left behind in chrome\browser. I've left ↵jam@chromium.org2011-03-012-5/+5
| | | | | | | | | browser_thread.h for another change, since 450 files include it. TBR=avi Review URL: http://codereview.chromium.org/6596060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76326 0039d316-1c4b-4281-b951-d872f2087c98
* Update NetLog in preparation for late binding of HttpStream jobs to requests.willchan@chromium.org2011-02-283-99/+139
| | | | | | | | | BUG=54371,42669 TEST=Open up about:net-internals#Events and make sure HTTP_STREAM_JOBs appear and are tied together to URL_REQUESTs. Review URL: http://codereview.chromium.org/6592027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76287 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a way to encode/decode quoted-printable strings.jcivelli@chromium.org2011-02-283-0/+373
| | | | | | | | | | | This is going to be used for MHTML support. BUG=30863 TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/6542069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76273 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Move the remaining files from chrome/browser/webui to ↵tfarina@chromium.org2011-02-271-1/+1
| | | | | | | | | | | chrome/browser/ui/webui. Final Part. BUG=59946 TEST=trybots Review URL: http://codereview.chromium.org/6594035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76191 0039d316-1c4b-4281-b951-d872f2087c98
* Move appcache/file_sytem/device_orientation subdirectories of chrome\browser ↵jam@chromium.org2011-02-241-3/+3
| | | | | | | | | to content\browser. TBR=avi Review URL: http://codereview.chromium.org/6586001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75990 0039d316-1c4b-4281-b951-d872f2087c98
* Show the origin of the site setting the cookie instead of the domain of therogerta@chromium.org2011-02-242-4/+8
| | | | | | | | | | | cookie. BUG=63662 TEST=see repro steps in bug report, including expected result Review URL: http://codereview.chromium.org/6524024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75890 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor of NetworkDelegate.willchan@chromium.org2011-02-243-35/+21
| | | | | | | | | | | | | | * Renames HttpNetworkDelegate to NetworkDelegate, moves to net/base/network_delegate.h. NOTE: this is a layering violation. wtc/eroman/willchan have agreed to this exception because the other solutions are less palatable. * Move the virtuals in NetworkDelegate to the private section. Use non-virtual public interface as the network stack's interface for notifying the delegate. Add sanity checking to the implmentation in NetworkDelegate. The private virtual interface is for consumers to receive notifications. * Remove ExtensionIOEventRouter from ChromeURLRequestContext, it is only used by the ChromeNetworkDelegate. Pass it directly to the ChromeNetworkDelegate's constructor. * Introduce a SystemNetworkDelegate. It does nothing right now. BUG=67232 TEST=none Review URL: http://codereview.chromium.org/6580002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75822 0039d316-1c4b-4281-b951-d872f2087c98
* Send fatal proxy errors to the network delegate.jochen@chromium.org2011-02-232-1/+29
| | | | | | | | | BUG=60099 TEST=browser test Review URL: http://codereview.chromium.org/6541021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75726 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpStreamFactory.willchan@chromium.org2011-02-233-112/+49
| | | | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75668 Review URL: http://codereview.chromium.org/6543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75688 0039d316-1c4b-4281-b951-d872f2087c98
* Adds navigator.registerProtocolHandler.tony@chromium.org2011-02-231-0/+9
| | | | | | | | | BUG=11359 TEST=None at the moment Review URL: http://codereview.chromium.org/6410115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75681 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75668 for breaking ChromeOS build - Refactor HttpStreamFactory.willchan@chromium.org2011-02-233-49/+112
| | | | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Review URL: http://codereview.chromium.org/6543004 TBR=willchan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75670 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpStreamFactory.willchan@chromium.org2011-02-223-112/+49
| | | | | | | | | | | | | | | | | Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest. Rename HttpStreamFactory to HttpStreamFactoryImpl. Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here). Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist. Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness. I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup. BUG=54371,42669 TEST=unit tests Review URL: http://codereview.chromium.org/6543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75668 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of browser_prefs::RegisterAllPrefs()mnissler@chromium.org2011-02-213-7/+6
| | | | | | | | | | | | | | Local state and user prefs have always been separate namespaces. We'd like to have proxy configuration in both, so let's stick to the namespace separation and clean up testing code that incorrectly merged the namespaces. BUG=none TEST=compiles and passes tests Review URL: http://codereview.chromium.org/6542013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75536 0039d316-1c4b-4281-b951-d872f2087c98
* When user "discards history," discard speculative data as welljar@chromium.org2011-02-202-0/+10
| | | | | | | | | | | | | | | The speculative system record the first 10 connections that are made (at startup), and also learns about subresource connections made when the user visits sites. This information implies visitation history, and needs to be discarded when the user BUG=62891 r=eroman,sky Review URL: http://codereview.chromium.org/6538007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75525 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "WebUI: Move more files from chrome/browser/dom_ui to ↵tfarina@chromium.org2011-02-191-1/+1
| | | | | | | | | | | | | | | | chrome/browser/webui. Part 5." This reverts commit 1088003ee7026f2b830d2451f79ce772c44a7cea. BUG=59945, 59946 TEST=trybots TBR=avi@chromium.org Original Review: http://codereview.chromium.org/6538053/ Review URL: http://codereview.chromium.org/6532069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75478 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75453 - WebUI: Move more files from chrome/browser/dom_ui to ↵scherkus@chromium.org2011-02-181-1/+1
| | | | | | | | | | | | | chrome/browser/webui. Part 5. BUG=59945, 59946 TEST=trybots Review URL: http://codereview.chromium.org/6538053 TBR=tfarina@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75456 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI: Move more files from chrome/browser/dom_ui to chrome/browser/webui. ↵tfarina@chromium.org2011-02-181-1/+1
| | | | | | | | | | | Part 5. BUG=59945, 59946 TEST=trybots Review URL: http://codereview.chromium.org/6538053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75453 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74842willchan@chromium.org2011-02-163-682/+102
| | | | | | | | | | | Merged correctly this time. BUG=none TEST=none Review URL: http://codereview.chromium.org/6523067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75165 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75143 - Reland r74842willchan@chromium.org2011-02-163-102/+682
| | | | | | | | | | | | | | The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6526029 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6480120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75152 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74842willchan@chromium.org2011-02-163-682/+102
| | | | | | | | | | | The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6526029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75143 0039d316-1c4b-4281-b951-d872f2087c98
* Even more test cleanup. Some fixes to non-test code that's regressed.erg@google.com2011-02-152-14/+36
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6523032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75014 0039d316-1c4b-4281-b951-d872f2087c98
* Move FinalStatus out of PrerenderContents, and add prerender namespace.cbentzel@chromium.org2011-02-151-4/+4
| | | | | | | | | | | I had a separate CL which wanted to record cancellations of prerenders which happened prior to a PrerenderContents object being created [in the PrerenderResourceHandler]. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6503008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74937 0039d316-1c4b-4281-b951-d872f2087c98
* More test out-of-lining.erg@google.com2011-02-142-1/+3
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6484043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74879 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74842 - It seems to have broken the ChromeOS "PFQ bot"?willchan@chromium.org2011-02-143-102/+682
| | | | | | | | | | | | | | | | r74561 added a DCHECK to make sure users didn't try to access the ChromeURLRequestContextGetter from the Profile, since the Profile should only be read on the UI thread. ChromeOS apparently tried to access it from another thread, and therefore hit the new DCHECK. I'm relanding without the DCHECK. I'm also eagerly initializing the off the record context getter to prevent the ChromeOS race. ChromeOS should fix that code so the eager initialization isn't necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/6484041 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6517021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74848 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r74728 which reverted r74561 for exposing a ChromeOS bug.willchan@chromium.org2011-02-143-682/+102
| | | | | | | | | | | | | r74561 added a DCHECK to make sure users didn't try to access the ChromeURLRequestContextGetter from the Profile, since the Profile should only be read on the UI thread. ChromeOS apparently tried to access it from another thread, and therefore hit the new DCHECK. I'm relanding without the DCHECK. I'm also eagerly initializing the off the record context getter to prevent the ChromeOS race. ChromeOS should fix that code so the eager initialization isn't necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/6484041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74842 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused ChromeURLRequestContextFactory member.finnur@chromium.org2011-02-141-1/+0
| | | | | | | | | | BUG=None TEST=None CID=14593 Review URL: http://codereview.chromium.org/6476030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74803 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup SandboxedFileSystem* and merge them into FileSystem* for simplicity.kinuko@chromium.org2011-02-141-5/+5
| | | | | | | | | | | Based on our rough discussion over emails, I just went ahead and did the cleanup. BUG=none TEST=none Review URL: http://codereview.chromium.org/6471018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74786 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r74632 "Reland r74561 after fixing ChromeOS build breakage."oshima@google.com2011-02-123-102/+683
| | | | | | | | | | | | This reverts commit f19e6d524e086ed8182a475680e931a9a870d2a8. TBR=willchan@chromium.org BUG=none TEST=chromeos pfq bot should cycle green Review URL: http://codereview.chromium.org/6512009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74728 0039d316-1c4b-4281-b951-d872f2087c98
* Support predictive redundant preconnection jar@chromium.org2011-02-112-10/+7
| | | | | | | | | | | | | When a page loads additional content via secondary connections from its own domain, this CL should learn from those connections, and reserve additional connections during the primary connection. r=mbelshe@chromium.org bug=72666 Review URL: http://codereview.chromium.org/6487019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74679 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing with the out-of-lining of test code.erg@google.com2011-02-112-51/+62
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6485015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74660 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74561 after fixing ChromeOS build breakage.willchan@chromium.org2011-02-113-683/+102
| | | | | | | | | | | | | | | | | Introduce OffTheRecordProfileIOData and ProfileImplIOData. They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6500002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74632 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74561 for breaking the ChromeOS buildwillchan@chromium.org2011-02-113-102/+683
| | | | | | | | | | | | | | | | | | | | Introduce OffTheRecordProfileIOData and ProfileImplIOData. They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6286133 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6489020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74564 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce OffTheRecordProfileIOData and ProfileImplIOData.willchan@chromium.org2011-02-113-683/+102
| | | | | | | | | | | | | | | They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6286133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74561 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 3 at: Splits ChromeURLDataManager into 2 chunks:sky@chromium.org2011-02-102-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. This differs from the last version in that DataSource::SendResponse does nothing if the DataSource is schedule for deletion. This is necessary otherwise SendResponse will up the ref count and by the time the request is processed on the IO thread chances are the DataSource will have been deleted. And if it wasn't deleted, it'll get scheduled for deletion again. <insert comment here about the perils of using delayed deletion> This has always been possible, it just appears to be more likely with my patch. BUG=52022 71868 TEST=none Review URL: http://codereview.chromium.org/6479007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74432 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74340 - Attempt 2 at: Splits ChromeURLDataManager into 2 chunks:sky@chromium.org2011-02-102-12/+0
| | | | | | | | | | | | | | | | | | | | | | | | | . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. This differs from the version I landed in that there is now a NULL check in ChromeURLDataManager::DeleteDataSources. BUG=52022 71868 TEST=none TBR=willchan, evan, ahendrickson Review URL: http://codereview.chromium.org/6462036 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/6478010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74384 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at: Splits ChromeURLDataManager into 2 chunks:sky@chromium.org2011-02-092-0/+12
| | | | | | | | | | | | | | | | | | | | | | . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. This differs from the version I landed in that there is now a NULL check in ChromeURLDataManager::DeleteDataSources. BUG=52022 71868 TEST=none TBR=willchan, evan, ahendrickson Review URL: http://codereview.chromium.org/6462036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74340 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74292 - Splits ChromeURLDataManager into 2 chunks:sky@chromium.org2011-02-092-12/+0
| | | | | | | | | | | | | | | | | | | | | | . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. BUG=52022 71868 TEST=none Review URL: http://codereview.chromium.org/6286131 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/6461024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74294 0039d316-1c4b-4281-b951-d872f2087c98
* Splits ChromeURLDataManager into 2 chunks:sky@chromium.org2011-02-092-0/+12
| | | | | | | | | | | | | | | | | | | . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. BUG=52022 71868 TEST=none Review URL: http://codereview.chromium.org/6286131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74292 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 22:27:49 +0000