| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of events.
The sequence of events needed to trigger the assertion is a little complicated (see unittest for specifics).
The general pattern goes something like this:
(1) Add a dependency between two sources of different types. (This increments the refcount on the dependency.)
(2) Saturate the "graveyard" containing the dependency causing it to be nuked.
(3) Add a new entry to the original dependency, causing it to re-create the source (but now with 0 refcount).
(4) Force the buffer containing the source in step (1) to be nuked
(5) In releasing the dependencies, it will now try to release reference on non-existent source.
While this was crashing debug mode, I don't believe there would have been an impact on release builds (since DeleteSourceInfo() early returns if it can't find the source).
BUG=58847
TEST=PassiveLogCollectorTest.ReleaseDependencyToUnreferencedSource
Review URL: http://codereview.chromium.org/4960001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the callers to append base:: in the calls to StringAppendF.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4974001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This was a TODO for chron).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4155010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/4651005/
BUG=None
TEST=ConnectionTesterTest* should no longer exhibit memory leaks
Review URL: http://codereview.chromium.org/4723004
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Group Policy support for HTTP authentication, already had LGTM from http://codereview.chromium.org/3517018.
BUG=53625
TEST=ConfigurationPolicyPrefStore*
Review URL: http://codereview.chromium.org/4733003
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=53625
TEST=ConfigurationPolicyPrefStore*
Review URL: http://codereview.chromium.org/3517018
Patch from Jakob Kummerow <jkummerow@google.com>.
TBR=danno@chromium.org
Review URL: http://codereview.chromium.org/4643004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=53625
TEST=ConfigurationPolicyPrefStore*
Review URL: http://codereview.chromium.org/3517018
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed FileSystemQuota to FileSystemQuotaManager.
Removed PlatFormErrorToFileError in simple_file_system.cc (in favor of webkit_flue::PlatformErrorToFileError)
BUG=60243
TEST=none
Review URL: http://codereview.chromium.org/4017007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread shutdown."
Should be safe to reland after r65479.
BUG=58859
TEST=none
Review URL: http://codereview.chromium.org/4672005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=2620,2654,2656,2657,2694,2701,2718,8074,8075,8076,8077,8078,
8079,8080,8082,8083,8406,8407,8408,8730,9160,11282,11897,12722,
12724
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4623001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only apply preference-set values if the values are set in the user preferences or forced by some higher-priority source. This is so we use the system settings as a default instead of stuff defined in recommended policy (which we should just ignore).
BUG=49540
TEST=Configure recommended proxy policy and observe that the system defaults are in effect.
Review URL: http://codereview.chromium.org/4439003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
http://codereview.chromium.org/4448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed methods for querying and enabling media cache as the cache has been stable enough we shouldn't have to worry about checking anymore.
BUG=None.
TEST=No specific test as this flag hasn't been used.
Review URL: http://codereview.chromium.org/4266001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
load. The performance optimization of doing EV verification
for only main frames is incorrect with HTTP keep-alive connections.
R=eroman
BUG=41267
TEST=Visit https://www.paypal.com/. Hit the Reload button
repeatedly. The EV status should not disappear.
Review URL: http://codereview.chromium.org/3938001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
token-based authentication, not the chromiumsync token.
BUG=61490
TEST=webstore integration
Review URL: http://codereview.chromium.org/4106016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
First step in mechanism for fetching cloud-based policy for CrOS.
BUG=none
TEST=DeviceTokenFetcher*
Review URL: http://codereview.chromium.org/4121003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A/B tests suggest that large numbers of parallel
resolutions may cause the DNS failure rate
(re: ratio of "host not found" to "found") to
rise. To stay safely away from that threshold,
this change lowers the maximum parallel resolutions
to 8, and restricts the speculative resolutions
to 3.
We are also running A/B tests which will look at the
impact of modulating either of these values.
BUG=3041
r=eroman
Review URL: http://codereview.chromium.org/4111004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread shutdown.
We register all ChromeURLRequestContextGetters that have a reference to a ChromeURLRequestContext with the IOThread. We unregister them when they go away. In IOThread::CleanUp(), we tell the known ChromeURLRequestContextGetters to release their references to ChromeURLRequestContexts.
BUG=58859
TEST=none
Review URL: http://codereview.chromium.org/3686003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/4014010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211,60394
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from doing IO
Reverting because this breaks the ChromiumOS (dbg) builder.
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/3983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r63580, build breakage.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We register all ChromeURLRequestContextGetters that have a reference to a ChromeURLRequestContext with the IOThread. We unregister them when they go away. In IOThread::CleanUp(), we tell the known ChromeURLRequestContextGetters to release their references to ChromeURLRequestContexts.
BUG=58859
TEST=none
Review URL: http://codereview.chromium.org/3686003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome_frame failed to compile last time. I needed to add a "mutable" to a
member variable in chrome_frame/metrics_service.cc.
Review URL: http://codereview.chromium.org/3971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4007001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Pages with "chrome" scheme have very narrow permissions (e.g. no access to localStorage). We want inspector page to have the same permissions as usual page.
Review URL: http://codereview.chromium.org/3838005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit b7ce919957536ceb0cfac1709bc779fd086b6ce8.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3869003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3879002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Only 424k off Linux debug .a files).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Was reverted in r62922 due to a change landing between the try run and the
commit.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3803011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create an SSLHostInfoFactory interface and plumb it from the HttpCache
to the SSLConnectJob. Also, move the SSLHostInfo reference from the
ssl_config to being passed to the SSLClientSocket.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/3747003
TBR=agl@chromium.org
Review URL: http://codereview.chromium.org/3846005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create an SSLHostInfoFactory interface and plumb it from the HttpCache
to the SSLConnectJob. Also, move the SSLHostInfo reference from the
ssl_config to being passed to the SSLClientSocket.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/3747003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
living in IOThread.
I had to make some other changes to make this fit well: moved ProxyScriptFetcherImpl to its own set of files, and added a IOThread::Get() accessor to avoid plumbing through several layers in connection_tester.
I find the registry living in IOThread is preferable, as globals in net/ limit the ability to run on safely on multiple threads, and also leads to confusion on what needs to be called at shutdown.
Review URL: http://codereview.chromium.org/3823001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59105
TEST=Configuration*
Review URL: http://codereview.chromium.org/3782007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm doing tests to see what the impact of changing the
speculative resolution system parameters is on
resolution time. By default, the speculative system
limits itself to no more than 8 pending resolutions
at any time, and this test looks at 6, 4, and 2
as limits.
It also modulates the speculative congestion avoidance
system, which purges the speculative queue when there is
too much resolution latency, and tries various durations
of time. (the latter was less important... but was already
part of this existing A/B test.)
I also pushed the test rates up to 10% for each case, so
that we'd get data from the canary and/or dev builds.
r=eroman
Review URL: http://codereview.chromium.org/3762006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shouldn't be shown
Removed the logic from the ConfigurationPolicyPrefStore that sets managed preferences, it's now completely handled by CommandLinePrefStore. Moved the detection of conflicting proxy settings between the managed and other stores into the PrefValueStore. Implemented a sentinel value that can be used by stores to signal that they are returning the default value. Changed managed store to use this sentinel to hide non-managed proxy settings proxy settings when proxy policy is specified.
BUG=54792
TEST=manual
Review URL: http://codereview.chromium.org/3367021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(3.5 megs off debug linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3806005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54745
TEST=manual
Review URL: http://codereview.chromium.org/3582007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop refcounting StreamRequest. Establish a clear ownership of the StreamRequest. Deletion implies cancellation. Use ScopedRunnableMethodFactory::NewRunnableMethod() instead of NewRunnableMethod().
Remove Start() from StreamRequest. This is an implementation detail of HttpStreamRequest, so it only exists there now.
BUG=59103
TEST=existing, this is a pure refactor.
Review URL: http://codereview.chromium.org/3746002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58192
TEST=Start chrome with --auth-schemes=NTLM and --proxy-server pointing to a Microsoft Forefront Threat Management Gateway proxy configurated for Integrated Authentication. Assuming the user is part of the same domain as the proxy, authentication should work transparently, and the user should not be presented with auth prompts. Also, net_unittests should pass.
Review URL: http://codereview.chromium.org/3676004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=40797
Review URL: http://codereview.chromium.org/3646004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename chrome_thread.cc to browser_thread.cc
- Rename chrome_thread_unittest.cc to browser_thread_unittest.cc
- Include browser_thread.h instead of chrome_thread.h where needed.
- Fix gyp files according.
BUG=56926
TEST=trybots and compiled locally
Review URL: http://codereview.chromium.org/3643005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Include browser_thread.h instead of chrome_thread.h in more 100 files.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3691006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a revert of r62107 which is a revert of r62105 which is a revert of r60753 which is a revert of r60739 which is a revert of r60025 which is a revert of r59972 which is a revert of r59570 which is a revert of r59511 which is a revert of r59299 which is a revert of r59289.
The most recent reverts have all been due to ChromiumOS leaks which I believe to be fixed after fixing bug 58572, since I tested the combined fix in r62105 which was green on all ChromiumOS valgrind bots.
BUG=55940
TEST=Run a debug build on Linux. 10% or so of startups used to crash on startup. Shouldn't happen anymore.
Review URL: http://codereview.chromium.org/3660010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
run on ChromiumOS valgrind bots.
Revert "Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the IO loop used for OCSP."
Review URL: http://codereview.chromium.org/3681003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3669003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62107 0039d316-1c4b-4281-b951-d872f2087c98
|