summaryrefslogtreecommitdiffstats
path: root/chrome/browser/net
Commit message (Collapse)AuthorAgeFilesLines
* Do not roll back to SSL 3.0 for Google properties.thaidn@google.com2013-04-192-2/+30
| | | | | | | | | | | | SSL 3.0 fallback for Google properties can be enabled again with --enable-unrestricted-ssl3-fallback. Delete the obsolete SSL 3.0 fallback on TLS decompression failure. BUG=230171 Review URL: https://chromiumcodereview.appspot.com/14125003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195335 0039d316-1c4b-4281-b951-d872f2087c98
* UDP Network Connectivity - Perform 6 packet and FEC connectivityrtenneti@chromium.org2013-04-192-7/+7
| | | | | | | | | | tests for port 443. R=jar@chromium.org Review URL: https://chromiumcodereview.appspot.com/14247008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195277 0039d316-1c4b-4281-b951-d872f2087c98
* Move path functions from file_util to FilePath object.brettw@chromium.org2013-04-122-4/+6
| | | | | | | | | | | | | | EnsureEndsWithSeparator used to check whether the file existed. This seems bad and unnecessary so I removed it. I removed file_util::ContainsPath and used the existing file_util::IsParent instead. The functions descriptions are the same but the implementations do slightly different things, which is worrying. The only non-test use of this function to worry about is content/browser/storage_partition_impl_map.cc. As far as I see, the requirements for this seem OK, but I'm not very familiar with this. After some discussion with akalin, I changed sync/internal_api/sync_manager_impl.cc to be a DCHECK that the path is absolute rather than make it absolute. The old code relied on the behavior of the old function that the argument would be unchanged if the file didn't exist, and this (possibly relative) path would be used later. This behavior doesn't make a lot of sense, and it looks like now that the path is always absolute, so I replaced this call with a DCHECK. BUG= Review URL: https://codereview.chromium.org/13196006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193855 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_array<T> to scoped_ptr<T[]> in chrome.dcheng@chromium.org2013-04-111-2/+2
| | | | | | | | | | | | This is a manual cleanup pass using sed for files which are not built on Linux. BUG=171111 Review URL: https://chromiumcodereview.appspot.com/14114006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193728 0039d316-1c4b-4281-b951-d872f2087c98
* Remove URL fragment from referrer HTTP header (to comply with rfc2616) when ↵mef@chromium.org2013-04-101-1/+1
| | | | | | | | | | | | | | opening link using "Open Link in New Tab" option. Change URLRequest::set_referrer to URLRequest::SetReferrer which sanitizes referrer by removing URL fragment, user name and password. Remove URLRequest::GetSanitizedReferrer as URLRequest::referrer is now sanitized during set. BUG=168213 TEST=net_unittests, browser_tests Review URL: https://chromiumcodereview.appspot.com/12569007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193482 0039d316-1c4b-4281-b951-d872f2087c98
* Move SQLitePersistentCookieStore to contentsky@chromium.org2013-04-1010-1867/+26
| | | | | | | | | BUG=none TEST=none Review URL: https://codereview.chromium.org/13427006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193454 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-096-12/+13
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-096-13/+12
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-096-12/+13
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing EvictedDomainCookieCounter to keep statistics on cookie ↵huangs@chromium.org2013-04-083-0/+737
| | | | | | | | | | eviction and reinstatement. BUG=225765 Review URL: https://chromiumcodereview.appspot.com/12805010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192866 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ChromeNetLog when there are no observers.mmenke@chromium.org2013-03-302-6/+6
| | | | | | | | Performance gains are probably neglible, though it does prevent locking. Review URL: https://codereview.chromium.org/12209100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191485 0039d316-1c4b-4281-b951-d872f2087c98
* net: extract net/cert out of net/basephajdan.jr@chromium.org2013-03-298-9/+9
| | | | | | | | | | | | This introduces the following dependency of net/base on things outside: net/base/openssl_client_key_store.cc:#include "net/cert/x509_certificate.h" BUG=70818 Review URL: https://codereview.chromium.org/13006020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191450 0039d316-1c4b-4281-b951-d872f2087c98
* NetLogLogger no longer falls back to logging to LOG when itmmenke@chromium.org2013-03-285-59/+83
| | | | | | | | | | | | | | fails to open a file. This fairly useless behavior. Also make NetLogLogger take a FILE on creation, so the caller is responsible for handling the fail-to-open case gracefully. BUG=none Review URL: https://chromiumcodereview.appspot.com/12975004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191145 0039d316-1c4b-4281-b951-d872f2087c98
* LoadTiming in net part 7: Hooking it all upmmenke@chromium.org2013-03-277-971/+599
| | | | | | | | | | | | | Use the new load timing implementation in net/ to replace LoadTimingObserver. This should fix reported times when using a SPDY proxy, and results in more heavily tested and (hopefully) less regression-prone code. BUG=77446 Review URL: https://chromiumcodereview.appspot.com/12094085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190955 0039d316-1c4b-4281-b951-d872f2087c98
* base/prefs: Remove the public/ directory and move the files to //base/prefs.tfarina@chromium.org2013-03-218-9/+9
| | | | | | | | | | BUG=155525 R=joi@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/12789006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189513 0039d316-1c4b-4281-b951-d872f2087c98
* net: move host_resolver files from net/base to net/dnsphajdan.jr@chromium.org2013-03-218-11/+11
| | | | | | | | BUG=70818 Review URL: https://codereview.chromium.org/12518036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189485 0039d316-1c4b-4281-b951-d872f2087c98
* Convert http; into http: (and other valid schemes).grt@chromium.org2013-03-202-73/+107
| | | | | | | | | | | | Also: * Use the unnamed namespace instead of static functions. * Make ordering of functions in .cc file match that in .h file. BUG=176106 Review URL: https://chromiumcodereview.appspot.com/12393047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189213 0039d316-1c4b-4281-b951-d872f2087c98
* Tracking received data amounts on a daily basisbengr@chromium.org2013-03-191-0/+88
| | | | | | | | | | | | Maintain a window of the last 60 days of the amount of HTTP data received. BUG=174531 Review URL: https://chromiumcodereview.appspot.com/12664006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189127 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Separate out priority field from HttpRequestInfoakalin@chromium.org2013-03-191-3/+3
| | | | | | | | | | | | | | This is in preparation for supporting reprioritization; HttpRequestInfo is assumed to be an unchanging struct, so priority can't live in it if it is something that can change. Also add DEFAULT_PRIORITY value and replace some uses of LOWEST with it. BUG=166689 Review URL: https://codereview.chromium.org/12833008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189099 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 188912 "Removed static factories for data, ftp, file, and..."kbr@chromium.org2013-03-193-5/+5
| | | | | | | | | | | | | | | | | | | | | Broke layout tests userscripts/user-script-plugin-document.html and plugins/plugin-document-back-forward.html on all platforms. > Removed static factories for data, ftp, file, and about jobs. > Instead add corresponding ProtocolHandlers as needed. > Remove URLRequestContext members used by these static > factories. Bake FtpAuthCache into FtpProtocolHandler as it > was already unique per FtpProtocolHandler. > This is a revived version of http://crrev.com/10836206 > > BUG=142945 > > > Review URL: https://chromiumcodereview.appspot.com/11931024 TBR=pauljensen@chromium.org Review URL: https://codereview.chromium.org/12605011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188927 0039d316-1c4b-4281-b951-d872f2087c98
* Removed static factories for data, ftp, file, and about jobs.pauljensen@chromium.org2013-03-193-5/+5
| | | | | | | | | | | | | | | Instead add corresponding ProtocolHandlers as needed. Remove URLRequestContext members used by these static factories. Bake FtpAuthCache into FtpProtocolHandler as it was already unique per FtpProtocolHandler. This is a revived version of http://crrev.com/10836206 BUG=142945 Review URL: https://chromiumcodereview.appspot.com/11931024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188912 0039d316-1c4b-4281-b951-d872f2087c98
* Change ProxyRules to handle ProxyLists rather than just single ProxyServer ↵marq@google.com2013-03-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | instances. - All of the ProxyRules members that used to just be ProxyServers are now ProxyLists. - ParseFromString will now accept multiple proxy specifications per scheme. - ProxyRules::Apply now sets the ProxyInfo result to use a PAC string if any proxying will be done. - ProxyList now has an AddProxyServer method. - In general, beacuse ProxyList checks for the validity of its contents before adding new entries, IsEmpty() is used as a validity test where is_valid() used to be. - Writing ProxyRules into a dictionary will write out each constituent ProxyList as a PAC string. - Slight functional change to proxy_info: Calling UsePacString() now invokes Reset(), in line with the other Use* methods. - Updated proxy_config_unittest to compare PAC strings of proxy rules components. BUG= Review URL: https://chromiumcodereview.appspot.com/12315019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188604 0039d316-1c4b-4281-b951-d872f2087c98
* Stop sending Accept-Charset HTTP header as its not relevant anymore. Remove ↵pauljensen@chromium.org2013-03-154-39/+8
| | | | | | | | | | it from HttpUserAgentSettings as well as this is no longer needed. BUG=112804 Review URL: https://chromiumcodereview.appspot.com/12463021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188237 0039d316-1c4b-4281-b951-d872f2087c98
* net: split net/ssl out of net/basephajdan.jr@chromium.org2013-03-1413-16/+16
| | | | | | | | | | | | | | | Also moves transport_security_state files to net/http. This change also updates the callers. R=wtc TBR=rsleevi,lambroslambrou,tony BUG=70818 Review URL: https://codereview.chromium.org/12680003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188119 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused ServerBoundCertStore::FlushStore.mattm@chromium.org2013-03-133-94/+0
| | | | | | | | | BUG=169644 Review URL: https://chromiumcodereview.appspot.com/12755023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187718 0039d316-1c4b-4281-b951-d872f2087c98
* Don't apply the URL blacklist to page resources nor to background downloaders.joaodasilva@chromium.org2013-03-121-1/+1
| | | | | | | | | | | | | | | | | The URL blacklist is expected to apply to user navigations; if a page passes the filter then all its subresources should be loaded (except inner frames, which must be filtered too). In particular, the blacklist shouldn't filter background fetchers such as sync or extension updates. There are other policies to control those features. TBR=battre@chromium.org BUG=180905 Review URL: https://chromiumcodereview.appspot.com/12701006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187631 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes NetLogLogger to generate valid JSON.rohitrao@chromium.org2013-03-113-2/+102
| | | | | | | | | | BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/12731004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187339 0039d316-1c4b-4281-b951-d872f2087c98
* Remove calls to URLRequestContext::network_delegate() in chrome browser code.tedv@chromium.org2013-03-113-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | These changes are motivated by a desire to remove external accesses to a request context's delegate. (If a block of code needs to use a NetworkDelegate, it should not query the URLRequestContext for it, but instead should already have access to whatever delegate the context uses.) Two interfaces changed to support this: ProxyServiceFactory::CreateProxyService() now accepts separate arguments for URLRequestContext* and NetworkDelegate*, and its call locations (most notably from chrome/browser/io_thread.cc) specify the network delegate the context used. Note that this means that if someone gets a non-const URLRequestContext pointer and later calls set_network_delegate() on it, the ProxyServiceFactory would not match the context's delegate. This doesn't happen now, and I can't even think of why we might want to do that, but it's worth noting for the record that this would be a Bad Thing(tm). The constructor of TestURLRequest also accepts a separate argument for the network delegate (as an alternative to using the context's delegate). Several tests were updated to clarify their url requests have no network delegate. BUG=146587 Review URL: https://chromiumcodereview.appspot.com/12313094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187336 0039d316-1c4b-4281-b951-d872f2087c98
* Removing base::DictionaryValue::key_iterator which was displaced by ↵pneubeck@chromium.org2013-03-102-22/+17
| | | | | | | | | | | DictionaryValue::Iterator. BUG=162611 TBR=kkania@chromium.org (for webdriver), kalman@chromium.org (for extensions) Review URL: https://chromiumcodereview.appspot.com/12601006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187203 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome-search: access from Instant overlaydhollowa@chromium.org2013-03-072-162/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enables the Instant NTP page access to: chrome-search://theme/*, chrome-search://favicon/*, and chrome-search://thumb/*. This CL has a number of aspects to make the installed theme background image available to the Instant overlay: 1. Utilizes the new chrome-search: scheme that is accessible only to the Instant overlay's render process. This is enforced on the renderer side by WebKit::WebSecurityPolicy facilities. This is enforced on the browser side by the InstantIOContext::ShouldServiceRequest and URLDataSource::ShouldServiceRequest facilities. 2. Whitelists the chrome-search://theme origin to be made available to the specific Instant overlay's origin/url. 3. Backend CSS that sets the appropriate background image that resides in the chrome-search://theme origin. 4. A small refactoring of the Instant tests to support mix-in usage of InstantTestBase. BUG=172408, 134937 TEST=InstantPolicyTest.SearchSchemePolicy R=sreeram@chromium.org, creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186347 Review URL: https://chromiumcodereview.appspot.com/11896113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186680 0039d316-1c4b-4281-b951-d872f2087c98
* Added ERR_BLOCKED_BY_ADMINISTRATOR and a custom error page.joaodasilva@chromium.org2013-03-061-2/+2
| | | | | | | | | | | | | This distinguishes navigations blocked by administrator policy from other ERR_NETWORK_ACCESS_DENIED sources. The custom error page can then inform the user that a policy configured by the administrator prevents access to the site. BUG=88702 Review URL: https://chromiumcodereview.appspot.com/12226113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186455 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 186347jochen@chromium.org2013-03-062-30/+162
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke MalwareDetailsTest: [ RUN ] MalwareDetailsTest.HTTPCache Received signal 11 SEGV_MAPERR 00010000001e [0x00000285f2ee] base::debug::StackTrace::StackTrace() [0x00000285f3f6] base::debug::(anonymous namespace)::StackDumpSignalHandler() [0x7f5274c148f0] <unknown> [0x0000028a82f7] base::SupportsUserData::GetUserData() [0x00000215307f] (anonymous namespace)::GetDataForResourceContext() [0x00000215315c] InstantIOContext::RemoveInstantProcessOnIO() [0x000002881dd9] MessageLoop::RunTask() [0x00000288261b] MessageLoop::DeferOrRunPendingTask() [0x000002882c28] MessageLoop::DoWork() [0x000002853f4a] base::MessagePumpLibevent::Run() [0x00000287d8f2] MessageLoop::RunInternal() [0x00000289966d] base::RunLoop::Run() [0x00000287cca5] MessageLoop::Run() [0x0000042ee488] content::BrowserThreadImpl::IOThreadRun() [0x0000042ef28b] content::BrowserThreadImpl::Run() [0x0000028b4d88] base::Thread::ThreadMain() [0x0000028afc01] base::(anonymous namespace)::ThreadFunc() [0x7f5274c0b9ca] start_thread [0x7f5272728cdd] clone > Add chrome-search: access from Instant overlay > > Enables the Instant NTP page access to: > chrome-search://theme/*, > chrome-search://favicon/*, and > chrome-search://thumb/*. > > This CL has a number of aspects to make the installed theme > background image available to the Instant overlay: > 1. Utilizes the new chrome-search: scheme that is accessible only > to the Instant overlay's render process. This is enforced > on the renderer side by WebKit::WebSecurityPolicy > facilities. This is enforced on the browser side by the > InstantIOContext::ShouldServiceRequest and URLDataSource::ShouldServiceRequest facilities. > 2. Whitelists the chrome-search://theme origin to be made > available to the specific Instant overlay's origin/url. > 3. Backend CSS that sets the appropriate background image > that resides in the chrome-search://theme origin. > 4. A small refactoring of the Instant tests to support mix-in > usage of InstantTestBase. > > BUG=172408, 134937 > TEST=InstantPolicyTest.SearchSchemePolicy > R=sreeram@chromium.org, creis@chromium.org > > > Review URL: https://chromiumcodereview.appspot.com/11896113 TBR=dhollowa@chromium.org Review URL: https://codereview.chromium.org/12521005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186371 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome-search: access from Instant overlaydhollowa@chromium.org2013-03-062-162/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enables the Instant NTP page access to: chrome-search://theme/*, chrome-search://favicon/*, and chrome-search://thumb/*. This CL has a number of aspects to make the installed theme background image available to the Instant overlay: 1. Utilizes the new chrome-search: scheme that is accessible only to the Instant overlay's render process. This is enforced on the renderer side by WebKit::WebSecurityPolicy facilities. This is enforced on the browser side by the InstantIOContext::ShouldServiceRequest and URLDataSource::ShouldServiceRequest facilities. 2. Whitelists the chrome-search://theme origin to be made available to the specific Instant overlay's origin/url. 3. Backend CSS that sets the appropriate background image that resides in the chrome-search://theme origin. 4. A small refactoring of the Instant tests to support mix-in usage of InstantTestBase. BUG=172408, 134937 TEST=InstantPolicyTest.SearchSchemePolicy R=sreeram@chromium.org, creis@chromium.org Review URL: https://chromiumcodereview.appspot.com/11896113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186347 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce //components/user_prefs.joi@chromium.org2013-03-064-4/+4
| | | | | | | | | | | | | | | | | | The user_prefs component provides: a) The UserPrefs class, used to map PrefService objects to BrowserContext. This addresses a TODO to get rid of PrefServiceFromBrowserContext from base/prefs/pref_service.h, where clearly a mention of a content class did not belong. b) A place for PrefRegistrySyncable to live, where it can be used by components that need to register prefs. We also use (b) in this change to eliminate Autofill's dependency on chrome/browser/prefs. Work is ongoing to move Autofill to //components/autofill. TBR=ben@chromium.org BUG=155525,140037 Review URL: https://chromiumcodereview.appspot.com/12340111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186301 0039d316-1c4b-4281-b951-d872f2087c98
* Add AddHSTS() and AddHPKP() to replace EnableHost(DomainState), asunsafe@trevp.net2013-03-022-27/+26
| | | | | | | | | | | | DomainStates are being turned into "results" objects only. Rename the Delete functions to make clear they operate on Dynamic Data. Also, move some TransportSecurityStates functions into private. BUG=156152 Review URL: https://chromiumcodereview.appspot.com/12093038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185757 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 185068mal@chromium.org2013-03-026-19/+29
| | | | | | | | | | > Minor typos and style fixes. > TBR=cmp@chromium.org Review URL: https://codereview.chromium.org/12393027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185671 0039d316-1c4b-4281-b951-d872f2087c98
* Dereference io_thread in browser thread, not IO thread.ttuttle@chromium.org2013-03-021-3/+7
| | | | | | | | | | | | https://chromiumcodereview.appspot.com/12223080/ changed NetErrorTabHelper so it dereferences g_browser_process->io_thread() on the IO thread, but that's not allowed (g_browser_thread can only be accessed on the browser process), so we crashed when BrowserProcess DCHECKed to see if it was called on the right thread. This change restores the original arrangement, where we grabbed the IOThread and passed it to StartDnsProbeOnIOThread. BUG=178802 Review URL: https://chromiumcodereview.appspot.com/12335143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185658 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 185602wez@chromium.org2013-03-016-29/+19
| | | | | | | | | | | This broke the FixupFile and FixupRelativeFile unit_tests on Linux Tests. > Minor typos and style fixes (2). TBR=aa@chromium.org Review URL: https://codereview.chromium.org/12388054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185606 0039d316-1c4b-4281-b951-d872f2087c98
* Minor typos and style fixes (2).aa@chromium.org2013-03-016-19/+29
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185602 0039d316-1c4b-4281-b951-d872f2087c98
* Connect SparseHistogram with the rest of stats systemkaiwang@chromium.org2013-03-011-5/+5
| | | | | | | | | | | | | With this CL, SparseHistogram is usable with SparseHistogram::FactoryGet. Next step is to implement a Histogram like macro and implement WriteHTMLGraph and WriteAscii to have a nice output. BUG=139612 Review URL: https://chromiumcodereview.appspot.com/12207058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185451 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Update include paths of string_split.h to its new location.tfarina@chromium.org2013-02-284-4/+4
| | | | | | | | | | BUG=175186 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12378016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185315 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last traces of experimental support for MAC cookiesrsleevi@chromium.org2013-02-283-17/+8
| | | | | | | | | | | | | | | | Support for MAC cookies was mostly removed in r126928. However, changes to the cookie store were not fully reverted, and new callsites were introduced due to the interface changes. This fully removes the interfaces introduced for MAC cookies, including the CookieMonster::CookieInfo class. BUG=none TBR=willchan Review URL: https://chromiumcodereview.appspot.com/12326056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185160 0039d316-1c4b-4281-b951-d872f2087c98
* Remove invalid reinterpret_cast<>. Use covariant return type instead.ajwong@chromium.org2013-02-282-15/+9
| | | | | | | | | | | | | | | Up/down casting in a class hierarchy should be done with static_cast<>. Using reinterpret_cast<> may forget to correctly offset the this pointer and in general causes undefined behavior. In this case though, a covariant return is an even cleaner solution. BUG=none Review URL: https://chromiumcodereview.appspot.com/12321150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185096 0039d316-1c4b-4281-b951-d872f2087c98
* Minor typos and style fixes.aa@chromium.org2013-02-276-29/+19
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185068 0039d316-1c4b-4281-b951-d872f2087c98
* Make SQLitePersistentCookieStore run on injected SequencedTaskRunners vs ↵erikwright@chromium.org2013-02-274-199/+217
| | | | | | | | | | | | | | | | | named BrowserThreads. In a follow-up, I will make the production code run on the worker pool, which will hopefully speed up browser startup by eliminating delays due to other long-running DB thread tasks. R=rdsmith@chromium.org TBR=jar@chromium.org,mmenke@chromium.org BUG=175415 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184868 Review URL: https://chromiumcodereview.appspot.com/12314015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184879 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 184868mpearson@chromium.org2013-02-274-217/+199
| | | | | | | | | | | | | | | | | | | | | | | | | | Seems to cause timeout in MultiThreadedCookieMonsterTest.ThreadCheckDeleteCanonicalCookie http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%281%29/builds/6970 I often chalk timeouts up to flakes and reopen the tree and wait but this failure (threading + cookies) seems to directly relevant to this changelist I'm just going ahead to revert. > Make SQLitePersistentCookieStore run on injected SequencedTaskRunners vs named BrowserThreads. > > In a follow-up, I will make the production code run on the worker pool, which will hopefully speed up browser startup by eliminating delays due to other long-running DB thread tasks. > > R=rdsmith@chromium.org > TBR=jar@chromium.org,mmenke@chromium.org > BUG=175415 > > > Review URL: https://chromiumcodereview.appspot.com/12314015 TBR=erikwright@chromium.org Review URL: https://codereview.chromium.org/12342030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184874 0039d316-1c4b-4281-b951-d872f2087c98
* Make SQLitePersistentCookieStore run on injected SequencedTaskRunners vs ↵erikwright@chromium.org2013-02-274-199/+217
| | | | | | | | | | | | | | | named BrowserThreads. In a follow-up, I will make the production code run on the worker pool, which will hopefully speed up browser startup by eliminating delays due to other long-running DB thread tasks. R=rdsmith@chromium.org TBR=jar@chromium.org,mmenke@chromium.org BUG=175415 Review URL: https://chromiumcodereview.appspot.com/12314015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184868 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 184352brettw@chromium.org2013-02-242-7/+7
| | | | | | | | | | | | | | | | | > Add utf_string_conversions to base namespace. > > This adds "using"s for all functions so those can be fixed in a separate pass. > > This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover. > > BUG= > > Review URL: https://codereview.chromium.org/12314090 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/12315071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184355 0039d316-1c4b-4281-b951-d872f2087c98
* Add utf_string_conversions to base namespace.brettw@chromium.org2013-02-242-7/+7
| | | | | | | | | | | | This adds "using"s for all functions so those can be fixed in a separate pass. This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover. BUG= Review URL: https://codereview.chromium.org/12314090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184352 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-249-9/+9
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 00:46:44 +0000