summaryrefslogtreecommitdiffstats
path: root/chrome/browser/notifications
Commit message (Collapse)AuthorAgeFilesLines
* Add calling frame's source_url to extension and dom ui requests.rafaelw@chromium.org2010-04-022-1/+3
| | | | | | | | Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url. Review URL: http://codereview.chromium.org/1605005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43523 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/gfx/.estade@chromium.org2010-04-011-1/+1
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/1570005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43362 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up extension apps notification permission, take tworafaelw@chromium.org2010-03-312-40/+1
| | | | | | | | | | | | | | | This is the chromium side of a change which will wait to land on the webkit side landing. (https://bugs.webkit.org/show_bug.cgi?id=36625) It changes the NotificationPresenter to pass the sourceURL, rather than the SecurityOrigin in checking permission. The full URL is required to match the app extent. BUG=32361, 31024 TEST=NONE Review URL: http://codereview.chromium.org/1383001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43162 0039d316-1c4b-4281-b951-d872f2087c98
* Add two Extension view types: Notification and Infobars.finnur@chromium.org2010-03-261-1/+3
| | | | | | | | | | | | | Also hooked them up to GetExtensionViews and consolidated various methods of getting views into one (getViews, which now takes an optional param type). BUG=26463 TEST=None Review URL: http://codereview.chromium.org/1397002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42828 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 42631: The problem was that notifications aren't implemented on ↵aa@chromium.org2010-03-252-11/+40
| | | | | | | | linux/views yet. TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42671 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42631 as it seems to have broken browser tests on linux_views.aa@chromium.org2010-03-252-40/+11
| | | | | | TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42644 0039d316-1c4b-4281-b951-d872f2087c98
* Finish wiring up notifications in extensions.aa@chromium.org2010-03-252-11/+40
| | | | | | Review URL: http://codereview.chromium.org/1076004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42631 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BalloonViewHost, removing a lot of duplicate code that crept into ↵johnnyg@chromium.org2010-03-232-0/+247
| | | | | | | | | | | notifications during the port to mac & linux and making behavior more consistent. BUG=34826 TEST=notifications on each platform. Review URL: http://codereview.chromium.org/1055005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42404 0039d316-1c4b-4281-b951-d872f2087c98
* * Moved sticky/controls frag to chromeos::BalloonViewImploshima@chromium.org2010-03-1711-106/+114
| | | | | | | | | | | | | | * Added AddSystemNotification to add system notification and UpdateNotification to update a notification. * refactored NotificationObjectProxy and added NotificationDelegate class. * Added notification_browser.cc. BUG=33306 TEST=added notification_browser.cc with minimal test. I'll add more in next step. Review URL: http://codereview.chromium.org/1013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41801 0039d316-1c4b-4281-b951-d872f2087c98
* Factored out common classes used in notification tests.oshima@chromium.org2010-03-163-50/+58
| | | | | | | | | | | Replaced TestQueueing with one that makes more sense on ChromeOS. BUG=33306 TEST=Replaced TestQueueing with TestManyNotifications. Review URL: http://codereview.chromium.org/791004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41699 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-146-10/+10
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* This DCHECK occurs when an installed extension that declares the ↵aa@chromium.org2010-03-123-7/+28
| | | | | | | | notification permission is loaded. Review URL: http://codereview.chromium.org/842002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41368 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add more NULL-checks to UI tests that were lacking them to avoid ↵phajdan.jr@chromium.org2010-03-111-0/+4
| | | | | | | | | | | crashiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
* svn prop fixes. Applied to all files not in third_party.pkasting@chromium.org2010-03-091-0/+0
| | | | | | | | | | | | * Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type. * Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF. TBR=evanm BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r40855 with chromeos fix.jhawkins@chromium.org2010-03-071-0/+3
| | | | | | | | | | | webkit/glue: string_util.h -> utf_string_conversions.h fix. TBR=bradnelson BUG=none TEST=none Review URL: http://codereview.chromium.org/668242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40872 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 40855 - webkit/glue: string_util.h > utf_string_conversions.h fix.bradnelson@google.com2010-03-071-3/+0
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/668229 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/669251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40856 0039d316-1c4b-4281-b951-d872f2087c98
* webkit/glue: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-071-0/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/668229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40855 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, detect the WM_DISPLAYCHANGE message which indicates the desktop ↵johnnyg@chromium.org2010-03-046-2/+12
| | | | | | | | | | | size is changing. Pass this event using the NotificationService, and listen for it in desktop notification code in order to adjust metrics properly for the corner of the screen. BUG=35464 TEST=resize desktop after starting chrome; create notifications. Review URL: http://codereview.chromium.org/606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40670 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring balloon collection and added chromeos's BalloonCollection.oshima@chromium.org2010-03-0210-132/+171
| | | | | | | | | | | | | | * Separated BalloonCollection and BalloonCollectionImpl * Moved BalloonSpaceChangeListener to BalloonCollection from BalloonCollectionImpl as this listener is used by NotificationUIManager. * Added BalloonCollectionImpl for chromeos. (chromeos/notifications/balloon_collectino_impl.{h,cc}) * Changed NotificationPanel to use ScrollView to show all notifications in the panel. BUG=none TEST=none Review URL: http://codereview.chromium.org/660111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40460 0039d316-1c4b-4281-b951-d872f2087c98
* Change some desktop notifications layout parameters to be per-platform ↵johnnyg@chromium.org2010-03-025-25/+55
| | | | | | | | | | | rather than universal, and put mac notifications in the upper right as requested. BUG=34826 TEST=create notifications on all platforms Review URL: http://codereview.chromium.org/661333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40343 0039d316-1c4b-4281-b951-d872f2087c98
* Adding sticky field to Notificationoshima@chromium.org2010-02-264-23/+64
| | | | | | | | | BUG=33306 TEST=modified and added new test (TestSticky) to DesktopNotificationsTest Review URL: http://codereview.chromium.org/661155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40139 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files from chrome/common to chrome/browserphajdan.jr@chromium.org2010-02-231-1/+1
| | | | | | | | | | to further reduce bad dependencies on chrome/browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/652051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39703 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-192-2/+2
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of using a single template file and leaving some parts of it out, ↵johnnyg@chromium.org2010-02-192-18/+31
| | | | | | | | | | | use template files for each configuration. this allows for better presentation of small notifications without a lot of empty space. BUG=36081 TEST=create notification with a short string Review URL: http://codereview.chromium.org/628010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39409 0039d316-1c4b-4281-b951-d872f2087c98
* Desktop Notifications for the macjohnnyg@chromium.org2010-02-093-4/+19
| | | | | | | | | | BUG=23066 TEST=notify_demo.html Review URL: http://codereview.chromium.org/548208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38533 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38469 - Desktop Notifications for the mac!johnnyg@chromium.org2010-02-092-12/+2
| | | | | | | | | | | | BUG=23066 TEST=notify_demo.html Review URL: http://codereview.chromium.org/548208 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/600015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38493 0039d316-1c4b-4281-b951-d872f2087c98
* Desktop Notifications for the mac!johnnyg@chromium.org2010-02-092-2/+12
| | | | | | | | | BUG=23066 TEST=notify_demo.html Review URL: http://codereview.chromium.org/548208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38469 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-052-6/+5
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Enable notification for Chromeos/Linux view build.oshima@chromium.org2010-01-272-8/+1
| | | | | | | | | | | | | The notification behavir is same as one in windows/linux_gtk and no integration with panels yet. BUG=33306 TEST=enabled two tests in desktop_notification_unittests for linux view config. manual test: goto http://www.corp.google.com/~johnnyg/notify_demo.html and confirm text/html notification works. Review URL: http://codereview.chromium.org/552196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37332 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure notifications are only enabled on GTK builds of linux, since ↵johnnyg@chromium.org2010-01-251-2/+14
| | | | | | | | | | | that's what's supported so far. BUG=23954 TEST=none Review URL: http://codereview.chromium.org/552122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37017 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and ↵pkasting@chromium.org2010-01-081-4/+4
| | | | | | | | | | EmptyGURL(), since the code in question can just use the default constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/517054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the calculation of desktop size to use an existing common method ↵johnnyg@chromium.org2010-01-054-45/+17
| | | | | | | | | | | rather than windows-specific logic. Part of notifications port to linux. BUG=23954 TEST=none Review URL: http://codereview.chromium.org/524039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35575 0039d316-1c4b-4281-b951-d872f2087c98
* Add a configurable amount of space between the notification balloons.johnnyg@chromium.org2010-01-051-4/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/521030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35542 0039d316-1c4b-4281-b951-d872f2087c98
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-111-2/+1
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications should resize themselves to the content within min-max bounds, ↵johnnyg@chromium.org2009-12-087-30/+90
| | | | | | | | | | | | | rather than being all the same size. CL hooks into RenderView callbacks to detect the size of the content, and contains some refactoring so that conceptually balloon size = content size + frame, rather than content size = balloon size - frame as it has been. BUG=26691 TEST=included Review URL: http://codereview.chromium.org/460131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34076 0039d316-1c4b-4281-b951-d872f2087c98
* Spruce up the notification UI to much more closely match the mocks, ↵johnnyg@chromium.org2009-12-052-12/+14
| | | | | | | | | | | | | including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons. Part of the CL includes new features for TextButton class to control icon placement and appearance on hover. BUG=none TEST=notifications Review URL: http://codereview.chromium.org/450045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* Keep incognito notification preferences separate from regular ones, and ↵johnnyg@chromium.org2009-12-012-28/+38
| | | | | | | | | | | don't persist them permanently. BUG=none TEST=use notifications in incognito Review URL: http://codereview.chromium.org/455004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33476 0039d316-1c4b-4281-b951-d872f2087c98
* Make notifications permission available in the extension manifest and hook ↵johnnyg@chromium.org2009-11-242-7/+47
| | | | | | | | | | | up to the desktop notification service. BUG=27249 TEST=none Review URL: http://codereview.chromium.org/432005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32979 0039d316-1c4b-4281-b951-d872f2087c98
* Remove (actually, reverse meaning of) command line flag for desktop ↵johnnyg@chromium.org2009-11-141-1/+0
| | | | | | | | | | | | | notifications, so that is is available by default in Windows. Security review at http://b/issue?id=2161143 BUG=25975 TEST=none Review URL: http://codereview.chromium.org/391064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31990 0039d316-1c4b-4281-b951-d872f2087c98
* Escape javascript going into text notifications.johnnyg@chromium.org2009-11-142-2/+22
| | | | | | | | | BUG=27674 TEST=included Review URL: http://codereview.chromium.org/386035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31989 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications permission infobar should only be shown in response to a user ↵johnnyg@chromium.org2009-11-131-0/+65
| | | | | | | | | | | | | | gesture, not arbitrary script. Experimental fix for UI test, so checking in flaky at first to see if I have it... BUG=27215 TEST=included Committed as r31839... and reverted. Review URL: http://codereview.chromium.org/387011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31953 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-134-10/+10
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31839 - Notifications permission infobar should only be shown in ↵scherkus@chromium.org2009-11-121-67/+0
| | | | | | | | | | | | | | | | response to a user gesture, not arbitrary script. Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script. BUG=27215 TEST=included Review URL: http://codereview.chromium.org/387011 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/385080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31857 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications permission infobar should only be shown in response to a user ↵johnnyg@chromium.org2009-11-121-0/+67
| | | | | | | | | | | | | gesture, not arbitrary script. Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script. BUG=27215 TEST=included Review URL: http://codereview.chromium.org/387011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31839 0039d316-1c4b-4281-b951-d872f2087c98
* When extensions use notifications, display the name of the extension in UI ↵johnnyg@chromium.org2009-11-124-6/+50
| | | | | | | | | | | rather than the "origin". BUG=26961 TEST=test extension linked in the bug Review URL: http://codereview.chromium.org/385058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31799 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreaming WebKit.gypyaar@chromium.org2009-11-123-3/+3
| | | | | | | | | | | | This mega patch contains a few simple but tightly dependent changes: 1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org. 2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion. 3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp. 4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch. Review URL: http://codereview.chromium.org/387020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31749 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for desktop notifications.johnnyg@chromium.org2009-11-116-29/+414
| | | | | | | | | | | | | * Allow non-windows BalloonCollections to create non-viewable balloons (so that non-viewing aspects are cross-platform testable) * Makes NotificationObjectProxy overridable by a mock object which logs instead of calls to JS * Move Layout code from private to protected in BalloonCollection to enable verification of position code. BUG=none TEST=these Review URL: http://codereview.chromium.org/371041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31670 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly route the notifications permission-request-complete callback to ↵johnnyg@chromium.org2009-11-062-6/+11
| | | | | | | | | | | the process/route which generated it. It might not be the same tab that's showing the infobar, particularly if it comes from an extension. BUG=26859 TEST=request notifications permission from an extension and allow it. Review URL: http://codereview.chromium.org/378005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31239 0039d316-1c4b-4281-b951-d872f2087c98
* Seventh patch in making destructors of refcounted objects private.jam@chromium.org2009-11-062-0/+8
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/371006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98