summaryrefslogtreecommitdiffstats
path: root/chrome/browser/notifications
Commit message (Collapse)AuthorAgeFilesLines
* The desktop notification service infobar would not display in ChromeFrame ↵ananta@chromium.org2010-05-272-11/+6
| | | | | | | | | | | | | | | | rendered pages as the code assumed the existing of a BrowserList and associated objects like Browser etc. In ChromeFrame the tab contents is owned by the ExternalTabContainer. Fix is to pass the current tab contents from the RenderViewHost to the DesktopNotificationService::RequestPermission function and use that if we don't have a browser list. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44913 Bug=44913 Review URL: http://codereview.chromium.org/2294002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48348 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix renderer idle cpu usage regression.thakis@chromium.org2010-05-241-1/+3
| | | | | | | | | | | | | Since polling is required only for the preferred height and mac only needs preferred width, add a flag that specifies if the client is interested in width and/or height. This is a band-aid, the Real Fix is tracked in 44850. BUG=44494 TEST=Open chrome's task manager. Idle renderer processes should take close to 0 %cpu instead of ~1.5 before. Review URL: http://codereview.chromium.org/2145002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48056 0039d316-1c4b-4281-b951-d872f2087c98
* Update extension functions to always pass a list of arguments, even when one ↵arv@chromium.org2010-05-212-2/+2
| | | | | | | | | | | argument was passed. BUG=36301 TEST=Updated tests and ran all the existing tests. Review URL: http://codereview.chromium.org/2137012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem of displaying title with parenthesis in extension.xji@chromium.org2010-05-211-1/+1
| | | | | | | | | | | | | | | Wrap title with correctly bidi control characters in windows for display purpose. BUG=43485 TEST=1. open RTL chrome. 2. install Google dictionary extension. 3. extension title "Google Dictionary (by Google)" should be displayed as is in chrome://extensions page, 4. right click the extension icon, title "Google Dictionary (by Google)" should be displayed in extension context menu, 5. extension title should be displayed correctly in other places, such as task manager, etc. Review URL: http://codereview.chromium.org/2015004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47937 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when signing in with certain desktop notification settings.zork@chromium.org2010-05-091-4/+8
| | | | | | | | | BUG=42216 TEST=See bug Review URL: http://codereview.chromium.org/2045007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46800 0039d316-1c4b-4281-b951-d872f2087c98
* New visuals for notifications on Windows.johnnyg@chromium.org2010-05-072-4/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1980005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46690 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for web-extent background pages.rafaelw@chromium.org2010-05-062-7/+16
| | | | | | | | | | | | | | | | | | | | This patch adds a new RVH container: BackgroundContents. The idea is that apps can open a live web-page as a "background" page using window.open('<url>', '<name>', 'background'); If 'background' is specified and the opener is within the app's extent, a BackgroundContents will be used. Otherwise, the 'background' feature is ignored and it is treated as a regular popup call. Note that as of this patch the following are explicitly not-yet addressed: 1) Session storage for BackgroundContents 2) SSL (or other failures) requiring UI 3) Javascript messages (alert, etc...) 4) Session restore TEST=All tests should pass BUG=41275 Review URL: http://codereview.chromium.org/1734014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46544 0039d316-1c4b-4281-b951-d872f2087c98
* Make the app launcher bubble fit its contents.jcivelli@google.com2010-05-051-3/+1
| | | | | | | | | | | | | | It remains at least as wide as the browser location bar (that way it can always point at the + button). InfoBubble was modified so it can be resized. BUG=42260 TEST=Open the app launcher multiple-times. The app launcher should fit its contents nicely. Review URL: http://codereview.chromium.org/1739020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46482 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated things from net test suite:phajdan.jr@chromium.org2010-04-301-4/+4
| | | | | | | | | | | | - URLRequestTestContext (from now on use TestURLRequestContext) - TestServerPageW (use TestServerPage). TEST=none BUG=none Review URL: http://codereview.chromium.org/1814002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46044 0039d316-1c4b-4281-b951-d872f2087c98
* This is the second side of a multi-sided webkit patch that will allow ↵rafaelw@chromium.org2010-04-282-3/+8
| | | | | | | | | | | | | | | | | experimental window.open feature strings to be captured and passed to the client. It should wait for: https://bugs.webkit.org/show_bug.cgi?id=38013 to land. This is required because this patch needs to use the WebWindowFeature binding struct in WebKit. Once this is landed, a webkit patch to change the call signature for WebViewClient::createView to include the WebWindowFeatures will be submitted (and after that another chromium patch to remove the old call signature). This patch implements old and new WebViewClient::createView signatures, and additionally passes the vector all the way to RenderViewHostDelegateHelper who will eventually use it to observe the 'background' feature. BUG=41275 TEST=all tests should pass Review URL: http://codereview.chromium.org/1758004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45877 0039d316-1c4b-4281-b951-d872f2087c98
* This test is no longer flaky now that it is run as an interactive UI test. ↵johnnyg@chromium.org2010-04-271-1/+1
| | | | | | | | | | | Changing the name to match. BUG=32807 TEST=none Review URL: http://codereview.chromium.org/1727008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45651 0039d316-1c4b-4281-b951-d872f2087c98
* Run the notifications info bar tests as interactive ui tests rather than ↵johnnyg@chromium.org2010-04-231-9/+10
| | | | | | | | | | | just ui tests. BUG=32807 TEST=included Review URL: http://codereview.chromium.org/1699007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45498 0039d316-1c4b-4281-b951-d872f2087c98
* Implement app process model isolation.mpcomplete@chromium.org2010-04-221-1/+3
| | | | | | | | | | | | | | | The process grouping logic is unfortunately duplicated in SiteInstance and RenderView. URLs that are part of extension X's web extent get converted into a pseudo URL of the form chrome-extension://X/path. This groups pages from an extension app and its offline resources into the same process. The rest is mostly plumbing and passing data around. BUG=41273 Review URL: http://codereview.chromium.org/1735004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45384 0039d316-1c4b-4281-b951-d872f2087c98
* Scroll notification panel so that new/updated notification is visible.oshima@chromium.org2010-04-191-1/+1
| | | | | | | | | | | | | | | | * Updated the test so that the notifications have some text and reasonable size. (Empty string was making them smaller.) * Don't leave KEEPS_SIZE state when new notification is added. (test updated) * A couple of clean ups - const - removed unused code - Added utility function to avoid repeating static_cast. BUG=41011 TEST=new TestScrollBalloonToVisible test is added. updated TestKeepSizeState. Review URL: http://codereview.chromium.org/1638017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44978 0039d316-1c4b-4281-b951-d872f2087c98
* Create a valid RendererPreferences for notification windows.erg@chromium.org2010-04-152-3/+7
| | | | | | | | | | | | On linux, Notifications now have the correct select color, scrollbar properties and font anti-aliasing properties. BUG=41674 TEST=Try to highlight text in a notification. It should be highlighted. Review URL: http://codereview.chromium.org/1613019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44709 0039d316-1c4b-4281-b951-d872f2087c98
* Add ExtensionFunctionDispatcher::Delegate::GetAssociatedTabContents.rafaelw@chromium.org2010-04-151-0/+1
| | | | | | | | | | | Following work from: http://codereview.chromium.org/1521032/show, based on comments from aa here: http://codereview.chromium.org/1521032/diff/4002/9004#newcode639 BUG=40428 TEST=All tests should pass Review URL: http://codereview.chromium.org/1627024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44680 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "r44062 Fix issue where the size of notification onoshima@chromium.org2010-04-141-2/+0
| | | | | | | | | | | | | | | | linux/views gets created bigger than max size." This is not right fix. This reverts commit ef67a340932fffa116b72413c7e5e425019f32a1. BUG=none TEST=none TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/1618016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44489 0039d316-1c4b-4281-b951-d872f2087c98
* On Mac, notifications needs the uninverted coordinate space, because we ↵johnnyg@chromium.org2010-04-133-2/+16
| | | | | | | | | | | invert already within the layout code. This change puts notifications in the correct place regardless of the height of the dock. BUG=40593 TEST=notifications on mac, with dock set to NOT auto-hide Review URL: http://codereview.chromium.org/1593017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44362 0039d316-1c4b-4281-b951-d872f2087c98
* Add notifications to allow desktop notification permissions to be synced.zork@chromium.org2010-04-125-33/+163
| | | | | | | | | | | | | Fix a bug where sites can be added to allow and deny lists multiple times. BUG=none TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44234 Review URL: http://codereview.chromium.org/1578023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44283 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44234 - Add notifications to allow desktop notification permissions ↵zork@chromium.org2010-04-125-152/+29
| | | | | | | | | | | | | | | | to be synced. Fix a bug where sites can be added to allow and deny lists multiple times. BUG=none TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser. Review URL: http://codereview.chromium.org/1578023 TBR=zork@chromium.org Review URL: http://codereview.chromium.org/1607012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44235 0039d316-1c4b-4281-b951-d872f2087c98
* Add notifications to allow desktop notification permissions to be synced.zork@chromium.org2010-04-125-29/+152
| | | | | | | | | | | Fix a bug where sites can be added to allow and deny lists multiple times. BUG=none TEST=Open two browsers with separate profiles. Request permission for notifications on a site on one. Check that the permissions are the same on the other browser. Review URL: http://codereview.chromium.org/1578023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44234 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure small notifications get shown. Previous change to make sure ↵johnnyg@chromium.org2010-04-091-3/+6
| | | | | | | | | | | notifications don't shrink caused a regression when the notification is of minimal size (like the one from html5rocks.com), since this is the same as the pre-show size. BUG=40817 TEST=see bug Review URL: http://codereview.chromium.org/1558031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44148 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where the size of notification on linux/views gets created bigger ↵oshima@chromium.org2010-04-091-0/+2
| | | | | | | | | | | than max size. BUG=none TEST=manual: run linux/view build or chromeos build and create a web notification. The size of balloon should be same as one in Windows. Review URL: http://codereview.chromium.org/1631007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44062 0039d316-1c4b-4281-b951-d872f2087c98
* Add notification processes to the task manager.johnnyg@chromium.org2010-04-088-29/+59
| | | | | | | | | BUG=29332 TEST=notifications in task manager Review URL: http://codereview.chromium.org/1610006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44014 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow notifications to grow in size (as the content size is ↵johnnyg@chromium.org2010-04-071-2/+8
| | | | | | | | | | | determined). Mac OS sometimes rapidly reports two alternating sizes, causing the animations to seize up and flicker. BUG=38083 TEST=visit http://www/~johnnyg/38083.html, or otherwise invoke the javascript in the bug. there should be no animation problems. Review URL: http://codereview.chromium.org/1589020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43857 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the new WebPopupType to the RenderWidget creation.jcivelli@google.com2010-04-071-1/+1
| | | | | | | | | BUG=None TEST=Tests that all popups (select popup, autofill, browser actions, bookmark bubble...) work as expected and get the focus correctly. Review URL: http://codereview.chromium.org/1523013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43845 0039d316-1c4b-4281-b951-d872f2087c98
* Add calling frame's source_url to extension and dom ui requests.rafaelw@chromium.org2010-04-022-1/+3
| | | | | | | | Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url. Review URL: http://codereview.chromium.org/1605005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43523 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/gfx/.estade@chromium.org2010-04-011-1/+1
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/1570005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43362 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up extension apps notification permission, take tworafaelw@chromium.org2010-03-312-40/+1
| | | | | | | | | | | | | | | This is the chromium side of a change which will wait to land on the webkit side landing. (https://bugs.webkit.org/show_bug.cgi?id=36625) It changes the NotificationPresenter to pass the sourceURL, rather than the SecurityOrigin in checking permission. The full URL is required to match the app extent. BUG=32361, 31024 TEST=NONE Review URL: http://codereview.chromium.org/1383001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43162 0039d316-1c4b-4281-b951-d872f2087c98
* Add two Extension view types: Notification and Infobars.finnur@chromium.org2010-03-261-1/+3
| | | | | | | | | | | | | Also hooked them up to GetExtensionViews and consolidated various methods of getting views into one (getViews, which now takes an optional param type). BUG=26463 TEST=None Review URL: http://codereview.chromium.org/1397002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42828 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 42631: The problem was that notifications aren't implemented on ↵aa@chromium.org2010-03-252-11/+40
| | | | | | | | linux/views yet. TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42671 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42631 as it seems to have broken browser tests on linux_views.aa@chromium.org2010-03-252-40/+11
| | | | | | TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42644 0039d316-1c4b-4281-b951-d872f2087c98
* Finish wiring up notifications in extensions.aa@chromium.org2010-03-252-11/+40
| | | | | | Review URL: http://codereview.chromium.org/1076004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42631 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BalloonViewHost, removing a lot of duplicate code that crept into ↵johnnyg@chromium.org2010-03-232-0/+247
| | | | | | | | | | | notifications during the port to mac & linux and making behavior more consistent. BUG=34826 TEST=notifications on each platform. Review URL: http://codereview.chromium.org/1055005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42404 0039d316-1c4b-4281-b951-d872f2087c98
* * Moved sticky/controls frag to chromeos::BalloonViewImploshima@chromium.org2010-03-1711-106/+114
| | | | | | | | | | | | | | * Added AddSystemNotification to add system notification and UpdateNotification to update a notification. * refactored NotificationObjectProxy and added NotificationDelegate class. * Added notification_browser.cc. BUG=33306 TEST=added notification_browser.cc with minimal test. I'll add more in next step. Review URL: http://codereview.chromium.org/1013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41801 0039d316-1c4b-4281-b951-d872f2087c98
* Factored out common classes used in notification tests.oshima@chromium.org2010-03-163-50/+58
| | | | | | | | | | | Replaced TestQueueing with one that makes more sense on ChromeOS. BUG=33306 TEST=Replaced TestQueueing with TestManyNotifications. Review URL: http://codereview.chromium.org/791004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41699 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-146-10/+10
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* This DCHECK occurs when an installed extension that declares the ↵aa@chromium.org2010-03-123-7/+28
| | | | | | | | notification permission is loaded. Review URL: http://codereview.chromium.org/842002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41368 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add more NULL-checks to UI tests that were lacking them to avoid ↵phajdan.jr@chromium.org2010-03-111-0/+4
| | | | | | | | | | | crashiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
* svn prop fixes. Applied to all files not in third_party.pkasting@chromium.org2010-03-091-0/+0
| | | | | | | | | | | | * Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type. * Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF. TBR=evanm BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r40855 with chromeos fix.jhawkins@chromium.org2010-03-071-0/+3
| | | | | | | | | | | webkit/glue: string_util.h -> utf_string_conversions.h fix. TBR=bradnelson BUG=none TEST=none Review URL: http://codereview.chromium.org/668242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40872 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 40855 - webkit/glue: string_util.h > utf_string_conversions.h fix.bradnelson@google.com2010-03-071-3/+0
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/668229 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/669251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40856 0039d316-1c4b-4281-b951-d872f2087c98
* webkit/glue: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-071-0/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/668229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40855 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, detect the WM_DISPLAYCHANGE message which indicates the desktop ↵johnnyg@chromium.org2010-03-046-2/+12
| | | | | | | | | | | size is changing. Pass this event using the NotificationService, and listen for it in desktop notification code in order to adjust metrics properly for the corner of the screen. BUG=35464 TEST=resize desktop after starting chrome; create notifications. Review URL: http://codereview.chromium.org/606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40670 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring balloon collection and added chromeos's BalloonCollection.oshima@chromium.org2010-03-0210-132/+171
| | | | | | | | | | | | | | * Separated BalloonCollection and BalloonCollectionImpl * Moved BalloonSpaceChangeListener to BalloonCollection from BalloonCollectionImpl as this listener is used by NotificationUIManager. * Added BalloonCollectionImpl for chromeos. (chromeos/notifications/balloon_collectino_impl.{h,cc}) * Changed NotificationPanel to use ScrollView to show all notifications in the panel. BUG=none TEST=none Review URL: http://codereview.chromium.org/660111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40460 0039d316-1c4b-4281-b951-d872f2087c98
* Change some desktop notifications layout parameters to be per-platform ↵johnnyg@chromium.org2010-03-025-25/+55
| | | | | | | | | | | rather than universal, and put mac notifications in the upper right as requested. BUG=34826 TEST=create notifications on all platforms Review URL: http://codereview.chromium.org/661333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40343 0039d316-1c4b-4281-b951-d872f2087c98
* Adding sticky field to Notificationoshima@chromium.org2010-02-264-23/+64
| | | | | | | | | BUG=33306 TEST=modified and added new test (TestSticky) to DesktopNotificationsTest Review URL: http://codereview.chromium.org/661155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40139 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files from chrome/common to chrome/browserphajdan.jr@chromium.org2010-02-231-1/+1
| | | | | | | | | | to further reduce bad dependencies on chrome/browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/652051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39703 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-192-2/+2
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of using a single template file and leaving some parts of it out, ↵johnnyg@chromium.org2010-02-192-18/+31
| | | | | | | | | | | use template files for each configuration. this allows for better presentation of small notifications without a lot of empty space. BUG=36081 TEST=create notification with a short string Review URL: http://codereview.chromium.org/628010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39409 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 01:59:11 +0000