summaryrefslogtreecommitdiffstats
path: root/chrome/browser/notifications
Commit message (Collapse)AuthorAgeFilesLines
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-111-2/+1
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications should resize themselves to the content within min-max bounds, ↵johnnyg@chromium.org2009-12-087-30/+90
| | | | | | | | | | | | | rather than being all the same size. CL hooks into RenderView callbacks to detect the size of the content, and contains some refactoring so that conceptually balloon size = content size + frame, rather than content size = balloon size - frame as it has been. BUG=26691 TEST=included Review URL: http://codereview.chromium.org/460131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34076 0039d316-1c4b-4281-b951-d872f2087c98
* Spruce up the notification UI to much more closely match the mocks, ↵johnnyg@chromium.org2009-12-052-12/+14
| | | | | | | | | | | | | including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons. Part of the CL includes new features for TextButton class to control icon placement and appearance on hover. BUG=none TEST=notifications Review URL: http://codereview.chromium.org/450045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* Keep incognito notification preferences separate from regular ones, and ↵johnnyg@chromium.org2009-12-012-28/+38
| | | | | | | | | | | don't persist them permanently. BUG=none TEST=use notifications in incognito Review URL: http://codereview.chromium.org/455004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33476 0039d316-1c4b-4281-b951-d872f2087c98
* Make notifications permission available in the extension manifest and hook ↵johnnyg@chromium.org2009-11-242-7/+47
| | | | | | | | | | | up to the desktop notification service. BUG=27249 TEST=none Review URL: http://codereview.chromium.org/432005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32979 0039d316-1c4b-4281-b951-d872f2087c98
* Remove (actually, reverse meaning of) command line flag for desktop ↵johnnyg@chromium.org2009-11-141-1/+0
| | | | | | | | | | | | | notifications, so that is is available by default in Windows. Security review at http://b/issue?id=2161143 BUG=25975 TEST=none Review URL: http://codereview.chromium.org/391064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31990 0039d316-1c4b-4281-b951-d872f2087c98
* Escape javascript going into text notifications.johnnyg@chromium.org2009-11-142-2/+22
| | | | | | | | | BUG=27674 TEST=included Review URL: http://codereview.chromium.org/386035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31989 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications permission infobar should only be shown in response to a user ↵johnnyg@chromium.org2009-11-131-0/+65
| | | | | | | | | | | | | | gesture, not arbitrary script. Experimental fix for UI test, so checking in flaky at first to see if I have it... BUG=27215 TEST=included Committed as r31839... and reverted. Review URL: http://codereview.chromium.org/387011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31953 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-134-10/+10
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31839 - Notifications permission infobar should only be shown in ↵scherkus@chromium.org2009-11-121-67/+0
| | | | | | | | | | | | | | | | response to a user gesture, not arbitrary script. Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script. BUG=27215 TEST=included Review URL: http://codereview.chromium.org/387011 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/385080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31857 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications permission infobar should only be shown in response to a user ↵johnnyg@chromium.org2009-11-121-0/+67
| | | | | | | | | | | | | gesture, not arbitrary script. Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script. BUG=27215 TEST=included Review URL: http://codereview.chromium.org/387011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31839 0039d316-1c4b-4281-b951-d872f2087c98
* When extensions use notifications, display the name of the extension in UI ↵johnnyg@chromium.org2009-11-124-6/+50
| | | | | | | | | | | rather than the "origin". BUG=26961 TEST=test extension linked in the bug Review URL: http://codereview.chromium.org/385058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31799 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreaming WebKit.gypyaar@chromium.org2009-11-123-3/+3
| | | | | | | | | | | | This mega patch contains a few simple but tightly dependent changes: 1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org. 2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion. 3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp. 4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch. Review URL: http://codereview.chromium.org/387020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31749 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for desktop notifications.johnnyg@chromium.org2009-11-116-29/+414
| | | | | | | | | | | | | * Allow non-windows BalloonCollections to create non-viewable balloons (so that non-viewing aspects are cross-platform testable) * Makes NotificationObjectProxy overridable by a mock object which logs instead of calls to JS * Move Layout code from private to protected in BalloonCollection to enable verification of position code. BUG=none TEST=these Review URL: http://codereview.chromium.org/371041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31670 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly route the notifications permission-request-complete callback to ↵johnnyg@chromium.org2009-11-062-6/+11
| | | | | | | | | | | the process/route which generated it. It might not be the same tab that's showing the infobar, particularly if it comes from an extension. BUG=26859 TEST=request notifications permission from an extension and allow it. Review URL: http://codereview.chromium.org/378005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31239 0039d316-1c4b-4281-b951-d872f2087c98
* Seventh patch in making destructors of refcounted objects private.jam@chromium.org2009-11-062-0/+8
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/371006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98
* Implement cancel() API on a Notification object so that script can cancel or ↵johnnyg@chromium.org2009-11-0410-4/+81
| | | | | | | | | | | tear down a toast. BUG=26360 TEST=cancel a notification Review URL: http://codereview.chromium.org/363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31004 0039d316-1c4b-4281-b951-d872f2087c98
* Third patch in getting rid of caching MessageLoop pointers and always using ↵jam@chromium.org2009-11-021-21/+14
| | | | | | | | | | ChromeThread instead. BUG=25354 Review URL: http://codereview.chromium.org/342068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build by removing some not implemented macros.johnnyg@chromium.org2009-10-312-2/+0
| | | | | | | | | | TBR=atwilson BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30655 0039d316-1c4b-4281-b951-d872f2087c98
* Now that the UI layer is accessible cross-platform, coalesce the ↵johnnyg@chromium.org2009-10-304-155/+75
| | | | | | | | | | | DesktopNotificationService layer into one common module. BUG=none TEST=none Review URL: http://codereview.chromium.org/343066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30652 0039d316-1c4b-4281-b951-d872f2087c98
* Need to load the permissions lists every time at startup for notifications.johnnyg@chromium.org2009-10-303-12/+8
| | | | | | | | | BUG=26274 TEST=grant notifications permissions and restart browser Review URL: http://codereview.chromium.org/339077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30623 0039d316-1c4b-4281-b951-d872f2087c98
* Connect the various pieces for notifications... hook up ↵johnnyg@chromium.org2009-10-304-8/+148
| | | | | | | | | | | NotificationUIManager to BrowserProcess to DesktopNotificationService to RenderView. BUG=none TEST=none Review URL: http://codereview.chromium.org/342043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30557 0039d316-1c4b-4281-b951-d872f2087c98
* Adds UI components for desktop notifications, including balloon view classes ↵johnnyg@chromium.org2009-10-298-200/+554
| | | | | | | | | | | to display toasts on the screen, and manager for controlling the layout of the balloons. BUG=none TEST=none yet (part of larger patch) Review URL: http://codereview.chromium.org/338051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30471 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify threading in browser thread by making only ChromeThread deal with ↵jam@chromium.org2009-10-271-5/+3
| | | | | | | | different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354 Review URL: http://codereview.chromium.org/306032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98
* Browser side support (sans UI) for desktop notifications.johnnyg@chromium.org2009-10-1211-0/+958
BUG=none TEST=none Review URL: http://codereview.chromium.org/194108 Review URL: http://codereview.chromium.org/271052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28696 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 22:15:38 +0000